net: vrf: Fix ping failed when vrf mtu is set to 0
Subsystems (3)
PATCH v3 1/1 net: vrf: Fix ping failed when vrf mtu is set to 0
From: Miaohe Lin <[email protected]>
When the mtu of a vrf device is set to 0, it would cause ping failed. So I think we should limit vrf mtu in a reasonable range to solve this problem. I set dev->min_mtu to IPV6_MIN_MTU, so it will works for both ipv4 and ipv6. And if dev->max_mtu still be 0 can be confusing, so I set dev->max_mtu to ETH_MAX_MTU.
Here is the reproduce step:
1.Config vrf interface and set mtu to 0:
3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel master vrf1 state UP mode DEFAULT group default qlen 1000
link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff
2.Ping peer:
3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel master vrf1 state UP group default qlen 1000
link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff
inet 10.0.0.1/16 scope global enp4s0
valid_lft forever preferred_lft foreverconnect: Network is unreachable
3.Set mtu to default value, ping works:
PING 10.0.0.2 (10.0.0.2) 56(84) bytes of data. 64 bytes from 10.0.0.2: icmp_seq=1 ttl=64 time=1.88 ms
---V2->V3:
- delete VRF specific mtu macros
- set mtu range directly and add a comment
drivers/net/vrf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/vrf.c +6 -2
@@ -1275,8 +1275,12 @@ static void vrf_setup(struct net_device *dev) dev->priv_flags |=IFF_NO_QUEUE ; dev->priv_flags |=IFF_NO_RX_HANDLER ; - dev->min_mtu =0 ; - dev->max_mtu =0 ; +/* VRF devices do not care about MTU, but if the MTU is set +* too low then the ipv4 and ipv6 protocols are disabled +* which breaks networking. +*/ + dev->min_mtu =IPV6_MIN_MTU ; + dev->max_mtu =ETH_MAX_MTU ; } static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],
Signature · 1 line
2.19.1
Quoted 23 lines · linmiaohe
From: Miaohe Lin <[email protected]>
When the mtu of a vrf device is set to 0, it would cause ping failed. So I think we should limit vrf mtu in a reasonable range to solve this problem. I set
dev->min_mtutoIPV6_MIN_MTU, so it will works for both ipv4 and ipv6. And ifdev->max_mtustill be 0 can be confusing, so I setdev->max_mtutoETH_MAX_MTU.Here is the reproduce step:
1.Config vrf interface and set mtu to 0:
3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdiscfq_codelmaster vrf1 state UP mode DEFAULT group default qlen 1000link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff2.Ping peer:
3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdiscfq_codelmaster vrf1 state UP group default qlen 1000link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff inet 10.0.0.1/16 scope global enp4s0 valid_lft forever preferred_lft foreverconnect: Network is unreachable
Quoted 7 lines
3.Set mtu to default value, ping works:
PING 10.0.0.2 (10.0.0.2) 56(84) bytes of data. 64 bytes from 10.0.0.2: icmp_seq=1 ttl=64 time=1.88 msFixes ad49bc6361ca2 ("net: vrf: remove MTU limits for vrf device")Signed-off-by Miaohe Lin <[email protected]>---
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Sun, 7 Apr 2019 20:51:05 -0700
Quoted 10 lines · linmiaohe
Quoted 9 lines
From: Miaohe Lin <[email protected]>
When the mtu of a vrf device is set to 0, it would cause ping failed. So I think we should limit vrf mtu in a reasonable range to solve this problem. I set
dev->min_mtutoIPV6_MIN_MTU, so it will works for both ipv4 and ipv6. And ifdev->max_mtustill be 0 can be confusing, so I setdev->max_mtutoETH_MAX_MTU.Here is the reproduce step:
...
Quoted 5 lines
Quoted 3 lines
Fixes ad49bc6361ca2 ("net: vrf: remove MTU limits for vrf device")Signed-off-by Miaohe Lin <[email protected]>---
Reviewed-by David Ahern <[email protected]>
Applied and queued up for -stable, thanks.