Add support for Baijie Helper A133 board
Subsystems (2)
v2 cover Add support for Baijie Helper A133 board
Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:
- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFi
Add initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet.
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board v1:
- https://lore.kernel.org/all/[email protected]/
Alexander Sverdlin (3):
dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd.
dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
.../devicetree/bindings/arm/sunxi.yaml | 11 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a133-baije-core.dtsi | 162 ++++++++++++++++++ .../allwinner/sun50i-a133-baijie-helper.dts | 94 ++++++++++ 5 files changed, 270 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Signature · 1 line
2.54.0
PATCH v2 1/3 dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd.
Shenzhen Baijie Technology Co., Ltd. focuses on R&D and production of embedded products as well as customization of embedded solutions.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -229,6 +229,8 @@ patternProperties: description: Azoteq (Pty) Ltd "^azw,.*": description: Shenzhen AZW Technology Co., Ltd. + "^baijie,.*": + description: Shenzhen Baijie Technology Co., Ltd. "^baikal,.*": description: BAIKAL ELECTRONICS, JSC "^bananapi,.*":
Signature · 1 line
2.54.0
Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd.
Hi,
Quoted 6 lines · Alexander Sverdlin
Shenzhen Baijie Technology Co., Ltd. focuses on R&D and production of embedded products as well as customization of embedded solutions.
Acked-by Conor Dooley <[email protected]>Signed-off-by Alexander Sverdlin <[email protected]>
All the best,
Paul
Quoted 21 lines
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-0@@ -229,6 +229,8 @@ patternProperties: description: Azoteq (Pty) Ltd "^azw,.*": description: Shenzhen AZW Technology Co., Ltd. + "^baijie,.*": + description: Shenzhen Baijie Technology Co., Ltd. "^baikal,.*": description: BAIKAL ELECTRONICS, JSC "^bananapi,.*":Signature · 1 line
2.54.0
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
PATCH v2 2/3 dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
In reply to Alexander SverdlinBaijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.
---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board
Documentation/devicetree/bindings/arm/sunxi.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +11 -0
@@ -96,6 +96,17 @@ properties: - const: allwinner,ba10-tvbox - const: allwinner,sun4i-a10 + - description: Baijie Helper A133 + items: + - const: baijie,helper-a133 + - const: baijie,helper-a133-core + - const: allwinner,sun50i-a100 + + - description: HelperBoardA133 Core + items: + - const: baijie,helper-a133-core + - const: allwinner,sun50i-a100 + - description: BananaPi items: - const: lemaker,bananapi
Signature · 1 line
2.54.0
Re: [PATCH v2 2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
Quoted 22 lines · Alexander Sverdlin
Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) boardDocumentation/devicetree/bindings/arm/sunxi.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)Documentation/devicetree/bindings/arm/sunxi.yaml +0
-0@@ -96,6 +96,17 @@ properties: - const: allwinner,ba10-tvbox - const: allwinner,sun4i-a10
Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 108
Quoted 10 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +10
-0+ - description: Baijie Helper A133 + items: + - const: baijie,helper-a133 + - const: baijie,helper-a133-core + - const: allwinner,sun50i-a100 + + - description: HelperBoardA133 Core + items: + - const: baijie,helper-a133-core + - const: allwinner,sun50i-a100
Does this make sense? Can the core board be used without a carrier?
Quoted 7 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +1
-0+ - description: BananaPi items: - const: lemaker,bananapiSignature · 1 line
2.54.0
Re: [PATCH v2 2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
Hi Conor,
Quoted 26 lines · Conor Dooley
Quoted 26 lines
Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board
Documentation/devicetree/bindings/arm/sunxi.yaml| 11 +++++++++++1 file changed, 11 insertions(+)Documentation/devicetree/bindings/arm/sunxi.yaml +0
-0@@ -96,6 +96,17 @@ properties:- const: allwinner,ba10-tvbox
- const: allwinner,sun4i-a10
+ - description: Baijie Helper A133
+ items:
+ - const: baijie,helper-a133
+ - const: baijie,helper-a133-core
Quoted 8 lines
Quoted 6 lines
+ - const: allwinner,sun50i-a100
+
+ - description: HelperBoardA133 Core
+ items:
+ - const: baijie,helper-a133-core
+ - const: allwinner,sun50i-a100Does this make sense? Can the core board be used without a carrier?
such operation would be impractical at least, that's why in my v1 Core board didn't have its own compatible. Maybe I didn't understand you correctly.
Shall I drop the above 4 lines, the compatible property from the root in sun50i-a133-baije-core.dtsi and only leave sun50i-a133-baijie-helper.dtb with 3-strings compatible as it is now in v2?
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
Quoted 33 lines · Alexander Sverdlin
Hi Conor,
Quoted 30 lines · Conor Dooley
Quoted 29 lines
Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board
Documentation/devicetree/bindings/arm/sunxi.yaml| 11 +++++++++++1 file changed, 11 insertions(+)Documentation/devicetree/bindings/arm/sunxi.yaml +0
-0@@ -96,6 +96,17 @@ properties:- const: allwinner,ba10-tvbox
- const: allwinner,sun4i-a10+
+ - description: HelperBoardA133 Core
+ items:
+ - const: baijie,helper-a133-core
+ - const: allwinner,sun50i-a100
Quoted 5 lines
Quoted 1 line
Does this make sense? Can the core board be used without a carrier?
such operation would be impractical at least, that's why in my v1 Core board didn't have its own compatible. Maybe I didn't understand you correctly.
I just wanted a comaptible for the SoM, so that there's a common compatible for that if it ends up on another carrier. IIRC these Baijie folks had another one on their site, but may be misremembering.
Quoted 11 lines
Shall I drop the above 4 lines, the compatible property from the root in
sun50i-a133-baije-core.dtsiand only leave sun50i-a133-baijie-helper.dtb with 3-strings compatible as it is now in v2?Quoted 5 lines
Quoted 5 lines
+ - description: Baijie Helper A133
+ items:
+ - const: baijie,helper-a133
+ - const: baijie,helper-a133-core
+ - const: allwinner,sun50i-a100
What I wanted was just this, so trim it down to that and you can add my Acked-by: Conor Dooley <[email protected]>
~heers,
Conor.
Re: [PATCH v2 2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
In reply to Alexander SverdlinHi Alexander,
Quoted 19 lines · Alexander Sverdlin
Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) boardDocumentation/devicetree/bindings/arm/sunxi.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)Documentation/devicetree/bindings/arm/sunxi.yaml +0
-0
Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 99
Quoted 4 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +1
-0@@ -96,6 +96,17 @@ properties: - const: allwinner,ba10-tvbox - const: allwinner,sun4i-a10 + - description: Baijie Helper A133
Please use the correct naming from the vendor, which is: "Baijie A133 HelperBoard"
Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 101
Quoted 2 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +2
-0+ items: + - const: baijie,helper-a133
Please make this: "baijie,helperboard-a133"
Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 102
Quoted 1 line
Documentation/devicetree/bindings/arm/sunxi.yaml +1
-0+ - const: baijie,helper-a133-core
Please make this: "baijie,helperboard-a133-core"
Thanks!
Quoted 14 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +7
-0+ - const: allwinner,sun50i-a100 + + - description: HelperBoardA133 Core + items: + - const: baijie,helper-a133-core + - const: allwinner,sun50i-a100 + - description: BananaPi items: - const: lemaker,bananapiSignature · 1 line
2.54.0
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
PATCH v2 3/3 arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinBaijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:
- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFi
Add initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet.
---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board
arch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a133-baije-core.dtsi | 162 ++++++++++++++++++ .../allwinner/sun50i-a133-baijie-helper.dts | 94 ++++++++++ 3 files changed, 257 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h64-remix-mini-pc.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-baijie-helper.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-liontron-h-a133l.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus-v1.2.dtb
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +162 -0
162 lines not on this page · raw message
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +94 -0
94 lines not on this page · raw message
Signature · 1 line
2.54.0
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Alexander,
thanks for upstreaming the DTs!
Quoted 47 lines · Alexander Sverdlin
Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:
- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFiAdd initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) boardarch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a133-baije-core.dtsi | 162 ++++++++++++++++++ .../allwinner/sun50i-a133-baijie-helper.dts | 94 ++++++++++ 3 files changed, 257 insertions(+)create mode 100644
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsicreate mode 100644arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h64-remix-mini-pc.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-baijie-helper.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-liontron-h-a133l.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus-v1.2.dtbarch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.
Please put your own copyright here, even if that has been largely copied from an existing file.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */
Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 24
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+ }; +}; + +&cpu0 { + cpu-supply = <®_dcdc2>; +}; + +&pio {
The order of those referenced nodes is alphabetically by the label name. So this one goes further down.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 33
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +9
-0+ vcc-pb-supply = <®_dcdc1>; + vcc-pc-supply = <®_eldo1>; + vcc-pd-supply = <®_dcdc1>; + vcc-pe-supply = <®_dldo2>; + vcc-pf-supply = <®_dcdc1>; + vcc-pg-supply = <®_dldo1>; + vcc-ph-supply = <®_dcdc1>; +}; +
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
Quoted 19 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +19
-0+&mmc2 { + vmmc-supply = <®_dcdc1>; + vqmmc-supply = <®_eldo1>; + cap-mmc-hw-reset; + non-removable; + bus-width = <8>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + status = "okay"; +}; + +&r_i2c0 { + status = "okay"; + + axp803: pmic@34 { + compatible = "x-powers,axp803"; + reg = <0x34>; + interrupt-parent = <&r_intc>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 62
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +10
-0+ }; +}; + +#include "axp803.dtsi" + +&ac_power_supply { + status = "okay"; +}; + +®_aldo1 {
What is aldo1 used for, actually? I don't see this referenced anywhere. I guess the kernel turns that off after booting?
If you have access to the schematic, please check that. If that's for some peripheral not yet supported, please note the user anyway, ideally by an explaining regulator-name, or by a comment. Also if it's used for any of the required SoC VDD pins. See the Liontron .dts for comparison.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 65
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0+ regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>;
Please don't provide ranges here (those are in the driver already), the point of this entry is to set the voltage required by the board. (And yes, the vendor DTBs alway get this wrong). Typically there are fixed requirements, so use the same value for min and max. Same for the others below.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 69
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +4
-0+}; + +®_aldo2 { + regulator-always-on;
For always-on regulators we definitely need an explanation. Does the board stop booting if you remove this line? Maybe it's for DRAM? Can you say what voltage it is, either from the reset default, or set by the bootloader?
Quoted 12 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +12
-0+ regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; +}; + +®_aldo3 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>; +}; + +®_dcdc1 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +10
-0+ regulator-always-on; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <3400000>; + regulator-name = "vcc-3v3"; +}; + +®_dcdc2 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;
This one is an exception, because the voltage is to be adjusted at runtime. But the voltage range needs to be tighter, the A133 datasheet puts the valid VDD_CPU range between 810mV and 1200mV. Compare to the Liontron dts file here.
Quoted 77 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +71
-0+ regulator-name = "vdd-cpu"; +}; + +®_dcdc3 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; +}; + +®_dcdc4 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; + regulator-name = "vdd-sys"; +}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram"; +}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>; +}; + +®_dldo2 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3400000>; + regulator-enable-ramp-delay = <1000>; +}; + +®_dldo3 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>; + regulator-name = "avdd-csi"; +}; + +®_dldo4 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>; +}; + +®_eldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1900000>; + regulator-enable-ramp-delay = <1000>; +}; + +®_eldo2 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1900000>; + regulator-enable-ramp-delay = <1000>; + regulator-name = "dvdd-csi"; +}; + +/* ELDO3 unused */ + +®_fldo1 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1450000>; + regulator-name = "vdd-cpus-usb"; +};arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 3
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +3
-0@@ -0,0 +1,94 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.
Your own copyright, please.
Quoted 22 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +22
-0+ */ + +/dts-v1/; + +#include "sun50i-a133-baije-core.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> + +/{ + model = "HelperBoard A133"; + compatible = "baijie,helper-a133", + "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + };
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 35
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0+ + leds { + compatible = "gpio-leds"; + + led { + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>; + gpios = <&pio 7 13 GPIO_ACTIVE_LOW>; /* PH13 */ + }; + };
I see quite some buttons on the board. I guess they are connected to GPIOs? Can you please describe them then, using gpio-keys? Look at sun50i-h5-orangepi-pc2.dts for an example.
And you should provide a top level 5V regulator here, to be the root of the regulator tree. Look at reg_vcc5v in the Liontron .dts.
Quoted 25 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +25
-0+}; + +&mmc0 { + vmmc-supply = <®_dcdc1>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ + bus-width = <4>; + status = "okay"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pb_pins>; + status = "okay"; +}; + +&rgmii0_pins { + drive-strength = <30>; +}; + +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&rgmii0_pins>; + phy-handle = <ð_phy>; + phy-mode = "rgmii-id"; + allwinner,rx-delay-ps = <200>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 70
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0+ allwinner,tx-delay-ps = <200>; + status = "okay"; +}; + +&mdio0 { + reset-gpios = <&pio 7 11 GPIO_ACTIVE_LOW>; /* PH11 */ + reset-delay-us = <10000>; + reset-post-delay-us = <150000>; + + eth_phy: ethernet-phy@1 {
The typical label here would be rgmii_phy. The node name is correct, though.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 75
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +5
-0+ compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; +
So from the pictures I found online it looks like there is an USB-C port labelled "OTG", so can you please add an &usbotg reference here and describe that port.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 76
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +1
-0+&usbphy {
Are the two USB ports always powered?
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 80
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +4
-0+ status = "okay"; +}; + +&ehci0 {
(and again, please order those nodes alphabetically)
Cheers,
Andre.
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +14
-0+ status = "okay"; +}; + +&ohci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay"; +};
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Andre,
thanks for the quick feedback!
Quoted 10 lines · Andre Przywara
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.Please put your own copyright here, even if that has been largely copied from an existing file.
Quoted 16 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
That's the only thing I can do currently regarding BT: stabilize the serial enumeration, because UART1 cannot be used for anything else except BT module, because this is soldered inside "core" module. We can avoid different tty enumeration, should the support for BT be implemented in the future...
Quoted 3 lines
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
So both the above BT and the WiFi is AW869A/AIC8800 combo chip, which has neither upstream driver, nor [upstream] DT bindings. Even github driver for AIC8800 doesn't seem to use DT, therefore it looks quite pointless to me at this point to specify anything in the DT for the chip which doesn't have the bindings idea even theoretically.
Nothing in the current DT shall block any future work on the AW869A support though and the above "aliases" entry shall even guarantee unchanged serial enumeration shall such support arise.
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 62
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+®_aldo1 {What is aldo1 used for, actually? I don't see this referenced anywhere. I guess the kernel turns that off after booting?
If you have access to the schematic, please check that. If that's for some peripheral not yet supported, please note the user anyway, ideally by an explaining regulator-name, or by a comment. Also if it's used for any of the required SoC VDD pins. See the Liontron .dts for comparison.arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 18
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+ regulator-always-on;
^^^^^^^^^^^^^^^^^^^
I suppose it's not being switcdhed of because of the above.
It's used for both PLL supply for the whole SoC + as analog voltage reference for LRADC (the buttons you've noticed on the board are connected to this ADC via a resistor ladder).
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 20
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +2
-0+®_aldo2 { + regulator-always-on;For always-on regulators we definitely need an explanation. Does the board stop booting if you remove this line?
Maybe it's for DRAM? Can you say what voltage it is, either from the reset default, or set by the bootloader?
Thanks for the hint! I'll put proper voltages into all regulators + comment all the always-on regulators.
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0And you should provide a top level 5V regulator here, to be the root of the regulator tree. Look at
reg_vcc5vin the Liontron .dts.
It doesn't look to me as if Liontron had reg_vcc5v as its 5V "root" regulator. It seems to be only used for reg_usb1_vbus, while HelperBoard A133 doesn't have USB power control. The second issue with Helper/Core split is that all PMIC story is inside Core board which has 5V input rail, while HelperBoard around it has indeed 12V->5V DCDC regulator (similar to Liontron), but putting it in the DT would introduce wierd dependency of the core to the HelperBoard which carries it. Do you think it would make sense?
Quoted 3 lines
So from the pictures I found online it looks like there is an USB-C port labelled "OTG", so can you please add an &usbotg reference here and describe that port.
Nice catch! I've missed the fact usbphy 0 has to be in peripheral mode, not host mode. Will rework!
Quoted 8 lines
Quoted 1 line
+&usbphy {
Are the two USB ports always powered?
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
There are two hubs, one on each usbphy. OTG side hub is even bus-powered, two USB-A ports are always powered from the board's 12V->5V DCDC, no USB load switches.
Quoted 1 line
Signature · 1 line
Alexander Sverdlin.
Chen-Yu Tsai
maintainerRe: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Quoted 73 lines · Alexander Sverdlin
Hi Andre,
thanks for the quick feedback!
Quoted 10 lines · Andre Przywara
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.Please put your own copyright here, even if that has been largely copied from an existing file.
Quoted 16 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
That's the only thing I can do currently regarding BT: stabilize the serial enumeration, because UART1 cannot be used for anything else except BT module, because this is soldered inside "core" module. We can avoid different tty enumeration, should the support for BT be implemented in the future...
Quoted 3 lines
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
So both the above BT and the WiFi is AW869A/AIC8800 combo chip, which has neither upstream driver, nor [upstream] DT bindings. Even github driver for AIC8800 doesn't seem to use DT, therefore it looks quite pointless to me at this point to specify anything in the DT for the chip which doesn't have the bindings idea even theoretically.
Nothing in the current DT shall block any future work on the AW869A support though and the above "aliases" entry shall even guarantee unchanged serial enumeration shall such support arise.
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 62
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+®_aldo1 {What is aldo1 used for, actually? I don't see this referenced anywhere. I guess the kernel turns that off after booting?
If you have access to the schematic, please check that. If that's for some peripheral not yet supported, please note the user anyway, ideally by an explaining regulator-name, or by a comment. Also if it's used for any of the required SoC VDD pins. See the Liontron .dts for comparison.Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+ regulator-always-on;^^^^^^^^^^^^^^^^^^^I suppose it's not being switcdhed of because of the above.
It's used for both PLL supply for the whole SoC + as analog voltage reference for LRADC (the buttons you've noticed on the board are connected to this ADC via a resistor ladder).Quoted 4 lines
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +2
-0+®_aldo2 { + regulator-always-on;
Quoted 7 lines
Quoted 4 lines
For always-on regulators we definitely need an explanation. Does the board stop booting if you remove this line?
Maybe it's for DRAM? Can you say what voltage it is, either from the reset default, or set by the bootloader?Thanks for the hint! I'll put proper voltages into all regulators + comment all the always-on regulators.
Please also give them proper names. If you have the schematics, then use the names from that; otherwise just make up names matching their use.
Quoted 10 lines
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0And you should provide a top level 5V regulator here, to be the root of the regulator tree. Look at
reg_vcc5vin the Liontron .dts.
Quoted 7 lines
It doesn't look to me as if Liontron had
reg_vcc5vas its 5V "root" regulator. It seems to be only used forreg_usb1_vbus, while HelperBoard A133 doesn't have USB power control. The second issue with Helper/Core split is that all PMIC story is inside Core board which has 5V input rail, while HelperBoard around it has indeed 12V->5V DCDC regulator (similar to Liontron), but putting it in the DT would introduce wierd dependency of the core to the HelperBoard which carries it. Do you think it would make sense?
In that case I would probably put a 5v "fake root" regulator in the core dtsi. And in combined dts, I'd then add the 12v "real root", and use that as the supply for the 5v fake root.
Does that make sense?
ChenYu
Quoted 23 lines
Quoted 3 lines
So from the pictures I found online it looks like there is an USB-C port labelled "OTG", so can you please add an &usbotg reference here and describe that port.
Nice catch! I've missed the fact usbphy 0 has to be in peripheral mode, not host mode. Will rework!
Quoted 8 lines
Quoted 1 line
+&usbphy {
Are the two USB ports always powered?
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
There are two hubs, one on each usbphy. OTG side hub is even bus-powered, two USB-A ports are always powered from the board's 12V->5V DCDC, no USB load switches.
Quoted 1 line
--
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Checn-Yu,
thanks for the review!
Quoted 11 lines · Chen-Yu Tsai
Quoted 10 lines
Quoted 2 lines
And you should provide a top level 5V regulator here, to be the root of the regulator tree. Look at
reg_vcc5vin the Liontron .dts.It doesn't look to me as if Liontron had
reg_vcc5vas its 5V "root" regulator. It seems to be only used forreg_usb1_vbus, while HelperBoard A133 doesn't have USB power control. The second issue with Helper/Core split is that all PMIC story is inside Core board which has 5V input rail, while HelperBoard around it has indeed 12V->5V DCDC regulator (similar to Liontron), but putting it in the DT would introduce wierd dependency of the core to the HelperBoard which carries it. Do you think it would make sense?
Quoted 5 lines
In that case I would probably put a 5v "fake root" regulator in the core dtsi. And in combined dts, I'd then add the 12v "real root", and use that as the supply for the 5v fake root.
Does that make sense?
"core" board has some battery management schematics, switching the 5V, I'll look into specifying this part in "core" .dtsi, maybe it will result in some kind of regulator in "core" part. I'll send v4.
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinHi Alexander,
Quoted 48 lines · Alexander Sverdlin
Hi Andre,
thanks for the quick feedback!
Quoted 10 lines · Andre Przywara
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.Please put your own copyright here, even if that has been largely copied from an existing file.
Quoted 16 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
That's the only thing I can do currently regarding BT: stabilize the serial enumeration, because UART1 cannot be used for anything else except BT module, because this is soldered inside "core" module. We can avoid different tty enumeration, should the support for BT be implemented in the future...
Quoted 3 lines
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
So both the above BT and the WiFi is AW869A/AIC8800 combo chip, which has neither upstream driver, nor [upstream] DT bindings. Even github driver for AIC8800 doesn't seem to use DT, therefore it looks quite pointless to me at this point to specify anything in the DT for the chip which doesn't have the bindings idea even theoretically.
Quoted 3 lines
Nothing in the current DT shall block any future work on the AW869A support though and the above "aliases" entry shall even guarantee unchanged serial enumeration shall such support arise.
Fair enough for not providing DT nodes for those unsupported chips, but why do we need to force enumeration? For the eventual Bluetooth usage, the driver will find the respective serial interface by just looking at its parent interface. IIUC there is nothing referring to ttyS1 explicitly. So we wouldn't really need an alias, would we? I see that some boards do define an alias, but others with Bluetooth don't, which I think is the right thing to do. Which name the kernel comes up with for UART1 shouldn't matter in any way.
Quoted 9 lines
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 62
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+®_aldo1 {What is aldo1 used for, actually? I don't see this referenced anywhere. I guess the kernel turns that off after booting?
If you have access to the schematic, please check that. If that's for some peripheral not yet supported, please note the user anyway, ideally by an explaining regulator-name, or by a comment. Also if it's used for any of the required SoC VDD pins. See the Liontron .dts for comparison.
Quoted 6 lines
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 18
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+ regulator-always-on;^^^^^^^^^^^^^^^^^^^I suppose it's not being switcdhed of because of the above.
It's used for both PLL supply for the whole SoC + as analog voltage reference for LRADC (the buttons you've noticed on the board are connected to this ADC via a resistor ladder).
Ah, yeah, somehow missed that line. So as stated below, please use a descriptive regulator name. Look at sun55i-a527-cubie-a5e.dts, I think is a more modern example of how to handle regulators best.
Quoted 10 lines
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 20
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +2
-0+®_aldo2 { + regulator-always-on;For always-on regulators we definitely need an explanation. Does the board stop booting if you remove this line?
Maybe it's for DRAM? Can you say what voltage it is, either from the reset default, or set by the bootloader?
Quoted 2 lines
Thanks for the hint! I'll put proper voltages into all regulators + comment all the always-on regulators.
Thanks!
Quoted 11 lines
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0And you should provide a top level 5V regulator here, to be the root of the regulator tree. Look at
reg_vcc5vin the Liontron .dts.
Quoted 7 lines
It doesn't look to me as if Liontron had
reg_vcc5vas its 5V "root" regulator. It seems to be only used forreg_usb1_vbus, while HelperBoard A133 doesn't have USB power control. The second issue with Helper/Core split is that all PMIC story is inside Core board which has 5V input rail, while HelperBoard around it has indeed 12V->5V DCDC regulator (similar to Liontron), but putting it in the DT would introduce wierd dependency of the core to the HelperBoard which carries it. Do you think it would make sense?
Ah yeah, the Liontron is not the best example, we don't have the full description there, because this board misses schematics.
So look at sun55i-a527-cubie-a5e.dts instead, which uses the top level regulator correctly. We didn't traditionally do this with the A64 boards using the AXP803, and just learned to live with those dummy supplies created by the kernel, but for new boards we should do better.
Regarding the board/SoM split: You should have a fixed regulator in the SoM .dtsi reflecting the 5V input pin(s), and then using that as the VIN
supply for the various PMIC rails, as the Cubie A5E does. This would
mimic some barrel connector on a standard board: the voltage is applied "by the user", externally.
So in this SoM .dtsi node, there is no vin-supply property, but you add that in the board .dts:
®_vcc5v {
vin-supply = <®_vcc12v5v>;
};Please come up with some better names than I just did ;-) Maybe something like reg_vcc5v_som to make this clearer.
And then you have that 12V->5V regulator described in the board .dts, along with a parent-less 12V regulator, check sun55i-t527-avaota-a1.dts for an example.
That should work cleanly, I think.
Quoted 6 lines
Quoted 3 lines
So from the pictures I found online it looks like there is an USB-C port labelled "OTG", so can you please add an &usbotg reference here and describe that port.
Nice catch! I've missed the fact usbphy 0 has to be in peripheral mode, not host mode. Will rework!
I guess that's the same situation as in the other recent boards using USB-C: they hardwired it to peripheral mode, although you can use this as a host port with some tricks, check sun50i-h616-orangepi-zero.dtsi, and copy this comment, should it apply.
Quoted 10 lines
Quoted 8 lines
Quoted 1 line
+&usbphy {
Are the two USB ports always powered?
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
There are two hubs, one on each usbphy. OTG side hub is even bus-powered,
What do you mean with OTG side hub, exactly? Is there a hub on USB0? How does this work, then?
Cheers,
Andre
Quoted 4 lines
two USB-A ports are always powered from the board's 12V->5V DCDC, no USB load switches.
Quoted 1 line
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Andre,
Quoted 9 lines · Andre Przywara
Quoted 6 lines
Quoted 4 lines
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
There are two hubs, one on each usbphy. OTG side hub is even bus-powered,
What do you mean with OTG side hub, exactly? Is there a hub on USB0? How does this work, then?
the upstream port of this hub is wired to the USB-C connector, one port has CH340E USB-UART on it for the console, the other port goes to the SoC usbphy 0. So it would be "peripheral" only, I suppose.
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Alexander,
Quoted 8 lines · Alexander Sverdlin
Hi Andre,
Quoted 5 lines · Andre Przywara
Quoted 5 lines
Quoted 4 lines
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
There are two hubs, one on each usbphy. OTG side hub is even bus-powered,
What do you mean with OTG side hub, exactly? Is there a hub on USB0? How does this work, then?
the upstream port of this hub is wired to the USB-C connector, one port has CH340E USB-UART on it for the console, the other port goes to the SoC usbphy 0. So it would be "peripheral" only, I suppose.
Yes like I explained in my other email there used to be a USB0 ID pin in earlier revisions of the board but it was reassigned and USB0 is now sitting behind the hub so it should be peripheral only.
All the best,
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinHi,
Quoted 8 lines · Alexander Sverdlin
Hi Andre,
Quoted 5 lines · Andre Przywara
Quoted 5 lines
Quoted 4 lines
And anyway, I see a *dual* USB-A socket on the pictures online, in addition to the USB-OTG port. So where does the third USB come from? The A133 only supports one host USB port plus the one OTG port. So is there an USB hub chip on the board?
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
There are two hubs, one on each usbphy. OTG side hub is even bus-powered,
What do you mean with OTG side hub, exactly? Is there a hub on USB0? How does this work, then?
the upstream port of this hub is wired to the USB-C connector, one port has CH340E USB-UART on it for the console, the other port goes to the SoC usbphy 0. So it would be "peripheral" only, I suppose.
Ah, that's interesting, I was wondering about this, but don't think we have seen this before.
So yeah, then it's definitely peripheral only. And please state in the comment that it's connected to the downstream port of a hub, so changing it to "host" will not work.
Thanks,
Andre
Chen-Yu Tsai
maintainerRe: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Andre PrzywaraQuoted 56 lines · Andre Przywara
Hi Alexander,
Quoted 48 lines · Alexander Sverdlin
Hi Andre,
thanks for the quick feedback!
Quoted 10 lines · Andre Przywara
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.Please put your own copyright here, even if that has been largely copied from an existing file.
Quoted 16 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
That's the only thing I can do currently regarding BT: stabilize the serial enumeration, because UART1 cannot be used for anything else except BT module, because this is soldered inside "core" module. We can avoid different tty enumeration, should the support for BT be implemented in the future...
Quoted 3 lines
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
So both the above BT and the WiFi is AW869A/AIC8800 combo chip, which has neither upstream driver, nor [upstream] DT bindings. Even github driver for AIC8800 doesn't seem to use DT, therefore it looks quite pointless to me at this point to specify anything in the DT for the chip which doesn't have the bindings idea even theoretically.
Quoted 3 lines
Nothing in the current DT shall block any future work on the AW869A support though and the above "aliases" entry shall even guarantee unchanged serial enumeration shall such support arise.
Quoted 8 lines
Fair enough for not providing DT nodes for those unsupported chips, but why do we need to force enumeration? For the eventual Bluetooth usage, the driver will find the respective serial interface by just looking at its parent interface. IIUC there is nothing referring to ttyS1 explicitly. So we wouldn't really need an alias, would we?
I see that some boards do define an alias, but others with Bluetooth don't, which I think is the right thing to do. Which name the kernel comes up with for UART1 shouldn't matter in any way.
It does provide a hint for any users enabling more UARTs and adding aliases for them that they should number them starting from 2? And just stable numbering overall.
ChenYu
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Chen-Yu,
Quoted 56 lines · Chen-Yu Tsai
Quoted 47 lines
Quoted 43 lines
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 3
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd.Please put your own copyright here, even if that has been largely copied from an existing file.
Quoted 16 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{ + compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */Do we really need an alias for the BT UART? And is the BT module supported already? Then please add a child node to the UART node.
That's the only thing I can do currently regarding BT: stabilize the serial enumeration, because UART1 cannot be used for anything else except BT module, because this is soldered inside "core" module. We can avoid different tty enumeration, should the support for BT be implemented in the future...
Quoted 3 lines
Isn't the WiFi/BT module on the SoM? Then please mention and enable MMC1 here. Provide the child node for the WiFi chip, even if there is no upstream support in the kernel for it yet.
So both the above BT and the WiFi is AW869A/AIC8800 combo chip, which has neither upstream driver, nor [upstream] DT bindings. Even github driver for AIC8800 doesn't seem to use DT, therefore it looks quite pointless to me at this point to specify anything in the DT for the chip which doesn't have the bindings idea even theoretically.
Quoted 3 lines
Nothing in the current DT shall block any future work on the AW869A support though and the above "aliases" entry shall even guarantee unchanged serial enumeration shall such support arise.
Quoted 8 lines
Fair enough for not providing DT nodes for those unsupported chips, but why do we need to force enumeration? For the eventual Bluetooth usage, the driver will find the respective serial interface by just looking at its parent interface. IIUC there is nothing referring to ttyS1 explicitly. So we wouldn't really need an alias, would we?
I see that some boards do define an alias, but others with Bluetooth don't, which I think is the right thing to do. Which name the kernel comes up with for UART1 shouldn't matter in any way.
Quoted 3 lines
It does provide a hint for any users enabling more UARTs and adding aliases for them that they should number them starting from 2? And just stable numbering overall.
that's exactly what I had in mind, as the the status of BT/WiFi might change in future, we might want to make UART1=tty1 and UART2=tty2 today and this will not change with potentially coming AW869A support.
But that's not an essential feature to me, just nice to have.
Signature · 1 line
Alexander Sverdlin.
[email protected]
AI reviewRe: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinThank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: - [High] Board-level regulator constraints are dangerously overly permissive, reflecting PMIC hardware…
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] Board-level regulator constraints are dangerously overly permissive, reflecting PMIC hardware limits instead of the board's electrical design.
- [Medium] Mismatch between the commit message and device tree configuration regarding the PMIC model.
- [Medium] Missing DT bindings for new compatible strings and vendor prefix.
- [Low] Typo in the new device tree include filename.
--
commit 995a0c0548d7cc620abeca1987efff325083911e
Author: Alexander Sverdlin <[email protected]>
arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
This commit adds initial support for the Baijie Helper A133 board and its core SBC. It enables UART, PMU, eMMC, USB, and Ethernet peripherals.
Quoted 6 lines
Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:
- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
The commit message mentions an AXP707 PMIC, but the device tree configures an x-powers,axp803 PMIC. Is AXP707 a typo in the message, or does the hardware actually use an AXP707?
Also, are the new compatible strings baijie,helper-a133 and baijie,helper-a133-core, along with the baijie vendor prefix, included in a separate dt-bindings patch? I don't see them documented here, which might cause schema validation failures.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0
This isn't a bug, but there is a typo in the filename. The vendor prefix is baijie but the file is named baije.
[ ... ]
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 86
Quoted 6 lines
+®_dcdc1 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +5
-0+ regulator-always-on; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <3400000>; + regulator-name = "vcc-3v3"; +};
Does this overly permissive voltage range match the physical board design?
Since this rail is named vcc-3v3 and shared by multiple 3.3V IO banks, allowing the voltage to drop to 1.6V could undervolt other components if a driver dynamically requests a lower voltage.
Could the constraints be tightened to match the safe operating limits of the board layout, rather than the PMIC hardware capabilities?
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinHi Alexander,
Quoted 2 lines · Alexander Sverdlin
Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:
Just in case you missed it, there was a previous submission for this board which wasn't followed up on.
I also have one of this board and wanted to respin support, but it looks like you beat me to it :)
Thanks for working on this!
Please change the naming to "Baijie HelperBoard A133" and "Baijie A133 HelperBoard Core" to align with the vendor terminology and rename the files as:
- sun50i-a133-helperboard.dts
- sun50i-a133-helperboard-core.dtsi
Quoted 45 lines
- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFiAdd initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet.
Signed-off-by Alexander Sverdlin <[email protected]>---
Changelog:
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) boardarch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a133-baije-core.dtsi | 162 ++++++++++++++++++ .../allwinner/sun50i-a133-baijie-helper.dts | 94 ++++++++++ 3 files changed, 257 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h64-remix-mini-pc.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-baijie-helper.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-liontron-h-a133l.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus-v1.2.dtbarch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0@@ -0,0 +1,162 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 11
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +10
-0+/* + * Copyright (c) 2025 Arm Ltd. + */ + +/dts-v1/; + +#include "sun50i-a100.dtsi" +#include "sun50i-a100-cpu-opp.dtsi" + +/{
You could add a model here while at it, even though it would generally be overwritten.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 16
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +5
-0+ compatible = "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial1 = &uart1; /* BT module */
Not sure this is reallyt useful.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 17
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+ };
You should add:
chosen {
stdout-path = "serial0:115200n8";
};As well as the incoming 5v regulator:
reg_vcc5v: vcc5v {
compatible = "regulator-fixed";
regulator-name = "vcc-5v";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
regulator-always-on;
};Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +&cpu0 { + cpu-supply = <®_dcdc2>; +}; + +&pio {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 34
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +10
-0+ vcc-pb-supply = <®_dcdc1>; + vcc-pc-supply = <®_eldo1>; + vcc-pd-supply = <®_dcdc1>; + vcc-pe-supply = <®_dldo2>; + vcc-pf-supply = <®_dcdc1>; + vcc-pg-supply = <®_dldo1>; + vcc-ph-supply = <®_dcdc1>; +}; + +&mmc2 {
mmc2 goes before pio (alphanum sorting).
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 42
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+ vmmc-supply = <®_dcdc1>; + vqmmc-supply = <®_eldo1>; + cap-mmc-hw-reset; + non-removable; + bus-width = <8>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + status = "okay";
You can add:
max-frequency = <100000000>; cap-mmc-highspeed;
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 52
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +10
-0+}; + +&r_i2c0 { + status = "okay"; + + axp803: pmic@34 { + compatible = "x-powers,axp803"; + reg = <0x34>; + interrupt-parent = <&r_intc>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
You can also add:
x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */ aldoin-supply = <®_vcc5v>; dldoin-supply = <®_vcc5v>; eldoin-supply = <®_vcc5v>; fldoin-supply = <®_dcdc5>; vin1-supply = <®_vcc5v>; vin2-supply = <®_vcc5v>; vin3-supply = <®_vcc5v>; vin4-supply = <®_vcc5v>; vin5-supply = <®_vcc5v>; vin6-supply = <®_vcc5v>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 65
Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +13
-0+ }; +}; + +#include "axp803.dtsi" + +&ac_power_supply { + status = "okay"; +}; + +®_aldo1 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pll-avcc";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 71
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +6
-0+}; + +®_aldo2 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-dram-lpddr";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 78
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_aldo3 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pl";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 85
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc1 { + regulator-always-on; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <3400000>; + regulator-name = "vcc-3v3";
Should be:
regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-name = "vcc-io-usb-pd-nand-3v3";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +6
-0+}; + +®_dcdc2 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;
Should be:
regulator-min-microvolt = <900000>; regulator-max-microvolt = <1300000>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 99
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+ regulator-name = "vdd-cpu"; +}; + +®_dcdc3 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; +};
DCDC3 is polyphased with DCDC2, so remove this one and add:
/* DCDC3 is polyphased with DCDC2 */
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 105
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +6
-0+ +®_dcdc4 { + regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; + regulator-name = "vdd-sys";
Should be:
regulator-min-microvolt = <810000>; regulator-max-microvolt = <990000>; regulator-name = "vcc-usb-sys";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 112
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram";
Should be:
regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-name = "vcc-dram-2";
ALDO2 is the main DRAM supply, this is the second one.
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 120
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pg";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 126
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +6
-0+}; + +®_dldo2 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3400000>; + regulator-enable-ramp-delay = <1000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-csi-pe";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 133
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dldo3 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>; + regulator-name = "avdd-csi";
Should be:
regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-name = "ldo-avdd-csi";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 139
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +6
-0+}; + +®_dldo4 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;
Should be:
regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-name = "ldo-avdd-csi";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 140
Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +1
-0+};
You can add:
®_drivevbus {
regulator-name = "usb0-vbus";
status = "okay";
};arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 145
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +5
-0+ +®_eldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1900000>; + regulator-enable-ramp-delay = <1000>;
Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pc-efuse-lvds-cpvin-mcsi";
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 150
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +5
-0+}; + +®_eldo2 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1900000>;
Should be:
regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>;
Quoted 28 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +12
-0+ regulator-enable-ramp-delay = <1000>; + regulator-name = "dvdd-csi"; +}; + +/* ELDO3 unused */ + +®_fldo1 { + regulator-always-on; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1450000>; + regulator-name = "vdd-cpus-usb"; +};arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0@@ -0,0 +1,94 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Arm Ltd. + */ + +/dts-v1/; + +#include "sun50i-a133-baije-core.dtsi" + +#include <dt-bindings/gpio/gpio.h>
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 20
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0+#include <dt-bindings/leds/common.h> + +/{ + model = "HelperBoard A133"; + compatible = "baijie,helper-a133", + "baijie,helper-a133-core", + "allwinner,sun50i-a100"; + + aliases { + serial0 = &uart0;
The is best added to the core dtsi.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 24
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +4
-0+ }; + + chosen { + stdout-path = "serial0:115200n8";
Ditto.
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +8
-0+ }; + + leds { + compatible = "gpio-leds"; + + led { + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 42
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0+ gpios = <&pio 7 13 GPIO_ACTIVE_LOW>; /* PH13 */ + }; + }; +}; + +&mmc0 { + vmmc-supply = <®_dcdc1>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ + bus-width = <4>; + status = "okay";
You can add:
disable-wp;
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 53
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +11
-0+}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pb_pins>; + status = "okay"; +}; + +&rgmii0_pins { + drive-strength = <30>; +};
Sorting is also incorrect throughout the file, please use alphanum sorting for phandle-based overwrites.
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +14
-0+ +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&rgmii0_pins>; + phy-handle = <ð_phy>; + phy-mode = "rgmii-id"; + allwinner,rx-delay-ps = <200>; + allwinner,tx-delay-ps = <200>; + status = "okay"; +}; + +&mdio0 { + reset-gpios = <&pio 7 11 GPIO_ACTIVE_LOW>; /* PH11 */ + reset-delay-us = <10000>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 77
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +10
-0+ reset-post-delay-us = <150000>; + + eth_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + +&usbphy { + status = "okay";
You can add:
usb0_vbus-supply = <®_dcdc1>; usb1_vbus-supply = <®_dcdc4>;
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 82
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +5
-0+}; + +&ehci0 { + status = "okay"; +};
AFAIK there is no ID pin so ehci0/ohci0 will not be used. It seems that version 1.7 of the board used PH0 as USB0 ID pin but version 2.5 has reassigned PH8 to LCD reset.
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +11
-0+&ohci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay"; +};Signature · 1 line
2.54.0
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Paul,
Quoted 5 lines · Paul Kocialkowski
Just in case you missed it, there was a previous submission for this board which wasn't followed up on.
I also have one of this board and wanted to respin support, but it looks like you beat me to it :)
thanks for the hint!
Do you mean this series:
https://lore.kernel.org/all/[email protected]/
?
I've missed it indeed! I'll look into it!
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Alexander,
Quoted 9 lines · Alexander Sverdlin
Hi Paul,
Quoted 5 lines · Paul Kocialkowski
Just in case you missed it, there was a previous submission for this board which wasn't followed up on.
I also have one of this board and wanted to respin support, but it looks like you beat me to it :)
Quoted 6 lines
thanks for the hint!
Do you mean this series:
https://lore.kernel.org/all/[email protected]/
?I've missed it indeed! I'll look into it!
Yes that's the one! But I don't think there are features that your series is missing, as long as you apply the suggestions I made earlier.
I also have a U-Boot config ready for it, which I could send once the device-trees are merged on the kernel side. I could send it to you if you're interested.
I will also get back to you about your TF-A series so we can move all of this forward!
By the way it's good to wait a few days before sending new versions of patch series, to avoid overwhelmind the developers.
All the best,
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Paul,
Quoted 3 lines · Paul Kocialkowski
I also have a U-Boot config ready for it, which I could send once the device-trees are merged on the kernel side. I could send it to you if you're interested.
I do have one as well, I'm testing all open-source ;-) from ATF-upwards, just thought U-Boot would require ATF merged and kernel DT merged because of OF_UPSTREAM in U-Boot. But I'd be happy to sync when we get there.
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Alexander,
Quoted 11 lines · Alexander Sverdlin
Hi Paul,
Quoted 3 lines · Paul Kocialkowski
I also have a U-Boot config ready for it, which I could send once the device-trees are merged on the kernel side. I could send it to you if you're interested.
I do have one as well, I'm testing all open-source ;-) from ATF-upwards, just thought U-Boot would require ATF merged and kernel DT merged because of
OF_UPSTREAMin U-Boot. But I'd be happy to sync when we get there.
Sure, let's keep in touch about this!
I also have the 7" LVDS LCD that goes with it, which was supported by Parthiban's initial series (but needs rework, and it seems that he's unlikely to do it). I also have the 5" MIPI LCD but it's less likely that it will be supported, although I have seen dirty patches to make some other MIPI panel work with A133.
We'll need PWM for it which should be a follow-up to the current H616 PWM series from Richard Genoud.
Other than that there is a PCF8563TS RTC on the board, audio stuff:
speaker (which I have) mic and headphones and a GPIO beeper which could be added.
Do you have other A133 boards that you're interested in? I also have:
- KICKPI K5C
- DshanPi-R818
- Logicom La Tab 129
- Trimui Brick
And have some WIP device-trees and u-boot for most of them.
All the best,
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Paul,
Quoted 8 lines · Paul Kocialkowski
I also have the 7" LVDS LCD that goes with it, which was supported by Parthiban's initial series (but needs rework, and it seems that he's unlikely to do it). I also have the 5" MIPI LCD but it's less likely that it will be supported, although I have seen dirty patches to make some other MIPI panel work with A133.
We'll need PWM for it which should be a follow-up to the current H616 PWM series from Richard Genoud.
I didn't have video in my mind, but...
Quoted 3 lines
Other than that there is a PCF8563TS RTC on the board, audio stuff:
speaker (which I have) mic and headphones and a GPIO beeper which could be added.
... would be happy to work on higher quality audio I/O support after we get the base merged...
Quoted 6 lines
Do you have other A133 boards that you're interested in? I also have:
- KICKPI K5C
- DshanPi-R818
- Logicom La Tab 129
- Trimui Brick
thanks! I'll try to concentrate on the SzBaijie Core/Helper boards I have for now.
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinOn Mon, 18 May 2026 16:40:11 +0200
Alexander Sverdlin <[email protected]> wrote:
Hi Alexander,
Quoted 9 lines · Paul Kocialkowski
Quoted 3 lines
I also have a U-Boot config ready for it, which I could send once the device-trees are merged on the kernel side. I could send it to you if you're interested.
I do have one as well, I'm testing all open-source ;-) from ATF-upwards, just thought U-Boot would require ATF merged and kernel DT merged because of
OF_UPSTREAMin U-Boot. But I'd be happy to sync when we get there.
There is no requirement for upstream TF-A support when adding U-Boot support. All we need is *some* blob to feed to the U-Boot build system. There is one dependency, though: the TF-A load address. Mostly that's some quite obvious SRAM address, but in this case it turned out that the SRAM on the A133 is probably too small, so it looks like we need to move to DRAM. Not sure how we handle the transition, but at the moment there is just one board supported, so it will be slightly painful for a few weeks or months, I am afraid.
And yes, DTs need to be merged into Linus' tree to be considered, so this series of yours is exactly the right thing to do. There are regular syncs between the DT rebasing repo and U-Boot, but we can manually cherry-pick patches once they have reached the mainline tree. But feel free to send U-Boot patches once this series has been ACKed, so the defconfig file can be reviewed and then queued, to wait for the DT to appear in v7.2-rc1, for instance.
Cheers,
Andre
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Paul KocialkowskiHi Paul,
thanks for the review!
Quoted 6 lines · Paul Kocialkowski
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0
[]
Quoted 5 lines
You should add:
chosen { stdout-path = "serial0:115200n8"; };
I actually have it in .dts, but it's theoretically possible to deploy the core board in a way that serial0 is *not* a console, so the above probably will not be valid in all cases in .dtsi.
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 7 lines
+®_dcdc2 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;Should be:
regulator-min-microvolt = <900000>; regulator-max-microvolt = <1300000>;
0.81..1.2v according to A133 Datasheet Revision 1.1 Jul.14, 2020?
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 105
Quoted 6 lines
+®_dcdc4 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +4
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; + regulator-name = "vdd-sys";Should be:
regulator-min-microvolt = <810000>; regulator-max-microvolt = <990000>; regulator-name = "vcc-usb-sys";
I'm a bit puzzled here: datasheet says 0.9..1.0v and it has no "Typ" value, similar to VDD_CPU, but VDD_SYS is not part of OPP tables, so who is going to adjust this? Or shall it be just
regulator-min-microvolt = <950000>;
regulator-max-microvolt = <950000>;
?
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 112
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram";Should be:
Quoted 5 lines
regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-name = "vcc-dram-2";ALDO2 is the main DRAM supply, this is the second one.
Core schematics mentions 1.1V/1.2/1.35/1.5 on this rail... Currently U-Boot has CONFIG_AXP_DCDC5_VOLT=1100, but potentially this is adjustable, right? At some point LPDDR4 chips they are soldering today will be unavailable. And in the current market it will happen rather sooner than later...
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 120
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;Should be:
Quoted 3 lines
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pg";
Do suggest to drop vendor's
regulator-enable-ramp-delay = <1000>;
in all cases?
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0
[]
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 20
Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +2
-0+ aliases { + serial0 = &uart0;The is best added to the core dtsi.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 24
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +4
-0+ }; + + chosen { + stdout-path = "serial0:115200n8";Ditto.
But it only physically materializes in Helperboard, the carrier. Potentially this one can be left floating or used for something else.
Signature · 1 line
Alexander Sverdlin.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Alexander,
Quoted 16 lines · Alexander Sverdlin
Hi Paul,
thanks for the review!
Quoted 6 lines · Paul Kocialkowski
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0[]
Quoted 2 lines
You should add:
Quoted 7 lines
Quoted 3 lines
chosen { stdout-path = "serial0:115200n8"; };I actually have it in .dts, but it's theoretically possible to deploy the core board in a way that serial0 is *not* a console, so the above probably will not be valid in all cases in .dtsi.
Yes I figured out later that it was in the board dts file and I initially assumed it was missing entirely.
In practice both options are fine, although the reference software does hardcode UART0 as debug serial.
Quoted 10 lines
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 4 lines
+®_dcdc2 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;Should be:
regulator-min-microvolt = <900000>; regulator-max-microvolt = <1300000>;0.81..1.2v according to A133 Datasheet Revision 1.1 Jul.14, 2020?
I guess the initial values are taken from the allwinner-perf1 board dts.
The 900 mV-1.3 V range matches the CPU OPPs (although it really only goes up to 1.13 V). Maybe down to 810 mV does work, but we don't have an OPP for it. I think I took these values from the reference BSP for the board.
Also it would be good to add:
regulator-name = "vdd-cpux";
Quoted 17 lines
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 105
Quoted 6 lines
+®_dcdc4 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +4
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; + regulator-name = "vdd-sys";Should be:
regulator-min-microvolt = <810000>; regulator-max-microvolt = <990000>; regulator-name = "vcc-usb-sys";I'm a bit puzzled here: datasheet says 0.9..1.0v and it has no "Typ" value, similar to
VDD_CPU, butVDD_SYSis not part of OPP tables, so who is going to adjust this? Or shall it be just
Quoted 4 lines
regulator-min-microvolt = <950000>;
regulator-max-microvolt = <950000>;?
Yes the reference BSP runs it at 950 mV, LGTM.
Quoted 15 lines
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 112
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram";Should be:
regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-name = "vcc-dram-2";
Quoted 7 lines
Quoted 1 line
ALDO2 is the main DRAM supply, this is the second one.
Core schematics mentions 1.1V/1.2/1.35/1.5 on this rail... Currently U-Boot has
CONFIG_AXP_DCDC5_VOLT=1100, but potentially this is adjustable, right? At some point LPDDR4 chips they are soldering today will be unavailable. And in the current market it will happen rather sooner than later...
It is part of the LPDDR4 spec that the main voltage should be 1.8 V and the second and I/O buffer ones should be 1.1 V. See JESD209-4D Table 180 — Recommended DC Operating Conditions.
Maybe they jsut copied this comment from a reference design that allows for other types of DRAM too. In any case their BSP hardcodes 1.1 V anyway.
Quoted 15 lines
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 120
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;Should be:
Quoted 3 lines
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pg";
Quoted 5 lines
Do suggest to drop vendor's
regulator-enable-ramp-delay = <1000>;
in all cases?
Well we generally don't have the delays in the axp regulator definitions and it works well without them, but I guess they don't hurt either.
In practice many drivers will have a delay after a regulator power on anyway because we generally expect that hardware needs some time to power up, in addition to the regulator. So all in all it's rarely critical.
Quoted 22 lines
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0[]
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 20
Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +2
-0+ aliases { + serial0 = &uart0;The is best added to the core dtsi.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 24
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +4
-0+ }; + + chosen { + stdout-path = "serial0:115200n8";Ditto.
Quoted 2 lines
But it only physically materializes in Helperboard, the carrier. Potentially this one can be left floating or used for something else.
Yes fair enough, I'm happy with having it on the helperboard dts file.
All the best,
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Chen-Yu Tsai
maintainerRe: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Quoted 47 lines · Paul Kocialkowski
Hi Alexander,
Quoted 16 lines · Alexander Sverdlin
Hi Paul,
thanks for the review!
Quoted 6 lines · Paul Kocialkowski
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0[]
Quoted 2 lines
You should add:
Quoted 7 lines
Quoted 3 lines
chosen { stdout-path = "serial0:115200n8"; };I actually have it in .dts, but it's theoretically possible to deploy the core board in a way that serial0 is *not* a console, so the above probably will not be valid in all cases in .dtsi.
Yes I figured out later that it was in the board dts file and I initially assumed it was missing entirely.
In practice both options are fine, although the reference software does hardcode UART0 as debug serial.
Quoted 10 lines
Quoted 8 lines
Quoted 4 lines
+®_dcdc2 {
+ regulator-always-on;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1300000>;Should be:
regulator-min-microvolt = <900000>; regulator-max-microvolt = <1300000>;0.81..1.2v according to A133 Datasheet Revision 1.1 Jul.14, 2020?
I guess the initial values are taken from the allwinner-perf1 board dts.
Quoted 24 lines
The 900 mV-1.3 V range matches the CPU OPPs (although it really only goes up to 1.13 V). Maybe down to 810 mV does work, but we don't have an OPP for it. I think I took these values from the reference BSP for the board.
Also it would be good to add:
regulator-name = "vdd-cpux";Quoted 16 lines
Quoted 11 lines
Quoted 6 lines
+®_dcdc4 {
+ regulator-always-on;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-name = "vdd-sys";Should be:
regulator-min-microvolt = <810000>; regulator-max-microvolt = <990000>; regulator-name = "vcc-usb-sys";I'm a bit puzzled here: datasheet says 0.9..1.0v and it has no "Typ" value, similar to
VDD_CPU, butVDD_SYSis not part of OPP tables, so who is going to adjust this? Or shall it be just
No one really. As long as the current voltage is within the range, the kernel will be happy. But ideally the DT just describes the acceptable range, and the bootloader programs the correct recommended voltage.
Quoted 52 lines
Quoted 4 lines
regulator-min-microvolt = <950000>;
regulator-max-microvolt = <950000>;?
Yes the reference BSP runs it at 950 mV, LGTM.
Quoted 15 lines
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 112
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram";Should be:
regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-name = "vcc-dram-2";Quoted 7 lines
Quoted 1 line
ALDO2 is the main DRAM supply, this is the second one.
Core schematics mentions 1.1V/1.2/1.35/1.5 on this rail... Currently U-Boot has
CONFIG_AXP_DCDC5_VOLT=1100, but potentially this is adjustable, right? At some point LPDDR4 chips they are soldering today will be unavailable. And in the current market it will happen rather sooner than later...It is part of the LPDDR4 spec that the main voltage should be 1.8 V and the second and I/O buffer ones should be 1.1 V. See JESD209-4D Table 180 — Recommended DC Operating Conditions.
Maybe they jsut copied this comment from a reference design that allows for other types of DRAM too. In any case their BSP hardcodes 1.1 V anyway.
Quoted 15 lines
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 120
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;Should be:
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pg";
Quoted 8 lines
Quoted 5 lines
Do suggest to drop vendor's
regulator-enable-ramp-delay = <1000>;
in all cases?
Well we generally don't have the delays in the axp regulator definitions and it works well without them, but I guess they don't hurt either.
We should probably keep them if we know that they are properly measured values, and not just cargo-culted.
Quoted 3 lines
In practice many drivers will have a delay after a regulator power on anyway because we generally expect that hardware needs some time to power up, in addition to the regulator. So all in all it's rarely critical.
Those are two different things. Devices generally say "wait x ms" after power rail is at full voltage. The enable ramp delay is the time it takes the rail to get to full voltage. The latter depends on board design (capacitor rating) and PMIC settings.
ChenYu
Quoted 38 lines
Quoted 20 lines
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0[]
Quoted 10 lines
Quoted 2 lines
+ aliases {
+ serial0 = &uart0;The is best added to the core dtsi.
Quoted 4 lines
+ };
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +3
-0+ + chosen { + stdout-path = "serial0:115200n8";Quoted 4 lines
Quoted 1 line
Ditto.
But it only physically materializes in Helperboard, the carrier. Potentially this one can be left floating or used for something else.
Yes fair enough, I'm happy with having it on the helperboard dts file.
All the best,
Paul
--
Paul Kocialkowski,Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/Expert in multimedia, graphics and embedded hardware support with Linux.
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
In reply to Alexander SverdlinOn Mon, 18 May 2026 22:05:25 +0200
Alexander Sverdlin <[email protected]> wrote:
Hi Paul, Alexander,
Quoted 14 lines
thanks for the review!
Quoted 6 lines · Paul Kocialkowski
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +0
-0[]
Quoted 2 lines
You should add:
Quoted 7 lines
Quoted 3 lines
chosen { stdout-path = "serial0:115200n8"; };I actually have it in .dts, but it's theoretically possible to deploy the core board in a way that serial0 is *not* a console, so the above probably will not be valid in all cases in .dtsi.
I am with Alexander here, to me the serial port belong into the helper board .dts, not the SoM .dtsi.
Quoted 13 lines
Quoted 4 lines
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 4 lines
+®_dcdc2 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;Should be:
regulator-min-microvolt = <900000>; regulator-max-microvolt = <1300000>;
Quoted 1 line
0.81..1.2v according to A133 Datasheet Revision 1.1 Jul.14, 2020?
Do you have the CPU OPPs for this board? Do they slightly overclock/over-volt the core? We have seen this for some other boards. But you could go with the safer 810mV...1200mV range, and we adjust this when needed.
Quoted 13 lines
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 105
Quoted 7 lines
+®_dcdc4 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +4
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>; + regulator-name = "vdd-sys";Should be:
Quoted 3 lines
regulator-min-microvolt = <810000>; regulator-max-microvolt = <990000>; regulator-name = "vcc-usb-sys";
Quoted 7 lines
I'm a bit puzzled here: datasheet says 0.9..1.0v and it has no "Typ" value, similar to
VDD_CPU, butVDD_SYSis not part of OPP tables, so who is going to adjust this? Or shall it be justregulator-min-microvolt = <950000>;
regulator-max-microvolt = <950000>;
There is indeed no exact value to be found. Just go with whatever the BSP used: either it's the PMIC reset value, or it's adjusted by boot0. If you have a BSP kernel booted, check the value of this regulator on the Linux prompt, then use this value. Chances are it's indeed 950mV, as used by the Liontron board.
Quoted 17 lines
?
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 112
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +7
-0+}; + +®_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1840000>; + regulator-name = "vcc-dram";Should be:
regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-name = "vcc-dram-2";
Quoted 7 lines
Quoted 1 line
ALDO2 is the main DRAM supply, this is the second one.
Core schematics mentions 1.1V/1.2/1.35/1.5 on this rail... Currently U-Boot has
CONFIG_AXP_DCDC5_VOLT=1100, but potentially this is adjustable, right? At some point LPDDR4 chips they are soldering today will be unavailable. And in the current market it will happen rather sooner than later...
We don't support multiple DRAM types for one board, really. If they switch to another DRAM type, we will need a new DT or some other way to adjust this (potentially runtime patched by U-Boot). But we can address this when we get there, so just set the 1.1V that LPDDR4 requires for the existing boards right now.
Quoted 16 lines
Quoted 12 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 120
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +8
-0+}; + +/* DCDC6 unused */ + +®_dldo1 { + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <3300000>; + regulator-enable-ramp-delay = <1000>;Should be:
Quoted 3 lines
regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-name = "vcc-pg";
Quoted 6 lines
Do suggest to drop vendor's
regulator-enable-ramp-delay = <1000>;
in all cases?
I don't see this used in many other mainline DTs, mostly it's just for some picky peripherals (PHYs). So if that works stable for you without, I'd drop all of them.
Quoted 21 lines
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +0
-0[]
Quoted 11 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 20
Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +2
-0+ aliases { + serial0 = &uart0;The is best added to the core dtsi.
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts line 24
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +4
-0+ }; + + chosen { + stdout-path = "serial0:115200n8";Ditto.
Quoted 2 lines
But it only physically materializes in Helperboard, the carrier. Potentially this one can be left floating or used for something else.
As mentioned above, I agree on this staying in the helper board .dts, and it not being moved.
Cheers,
Andre
Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Hi Andre,
Quoted 9 lines · Andre Przywara
Quoted 9 lines
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi line 91
Quoted 4 lines
+®_dcdc2 {
arch/arm64/boot/dts/allwinner/sun50i-a133-baije-core.dtsi new file +3
-0+ regulator-always-on; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1300000>;Should be:
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <1300000>;
Quoted 6 lines
Quoted 1 line
0.81..1.2v according to A133 Datasheet Revision 1.1 Jul.14, 2020?
Do you have the CPU OPPs for this board? Do they slightly overclock/over-volt the core? We have seen this for some other boards. But you could go with the safer 810mV...1200mV range, and we adjust this when needed.
I'm not sure how to interpret this, if it helps, vendor BSP has:
root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/opp@1512000000/ clock-latency-ns name opp-hz opp-microvolt-b0 opp-microvolt-b1 opp-microvolt-b2 opp-microvolt-b3 root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/opp@1512000000/opp-microvolt-b0 00000000 00 12 01 60 |...`| root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/opp@1512000000/opp-microvolt-b1 00000000 00 11 3e 10 00 11 3e 10 00 11 65 20 |..>...>...e | root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/opp@1512000000/opp-microvolt-b2 00000000 00 10 c8 e0 |....| root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/opp@1512000000/opp-microvolt-b3 00000000 00 10 7a c0 |..z.| root@HelperA133:~# hexdump -Cv /proc/device-tree/opp_l_table/compatible 00000000 61 6c 6c 77 69 6e 6e 65 72 2c 73 75 6e 35 30 69 |allwinner,sun50i| 00000010 2d 6f 70 65 72 61 74 69 6e 67 2d 70 6f 69 6e 74 |-operating-point| 00000020 73 00 |s.|
At least 1512MHz is possible (but datasheet says 1.6GHz, so probably no overclocking yet).
Signature · 1 line
Alexander Sverdlin.