Skip to contentSkip to conversation

test: fix typo in print statement

PATCH In review David Christensen 2 participants 5 messages May 8, 2019 – May 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/4 test: fix typo in print statement

Change "much" to "match" in a printf.

---
v2:
* None
v3:
* None

 app/test/test_barrier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test/test_barrier.c +1 -1
index 82b572c..c219d56 100644
@@ -252,7 +252,7 @@ struct lcore_plock_test {
 
 		/* race condition occurred, lock doesn't work properly */
 		if (sum[i] != pt[i].val || 2 * iter != pt[i].iter) {
-			printf("error: local and shared sums don't much\n");
+			printf("error: local and shared sums don't match\n");
 			rc = -1;
 		}
 	}
Signature · 1 line
1.8.3.1
#1 lore raw

Hi David,

08/05/2019 23:02, David Christensen:

Quoted 4 lines

v2:
* None
v3:
* None

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread, ideally with a cover letter.
All versions of a patchset must be in the same thread, ideally with the cover letter v1 being the common ancestor. Please check http://core.dpdk.org/contribute/#send

You need also to report the acks you got in previous versions.

Thanks

#2 lore raw
Quoted 10 lines

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread, ideally with a cover letter.
All versions of a patchset must be in the same thread, ideally with the cover letter v1 being the common ancestor. Please check http://core.dpdk.org/contribute/#send

You need also to report the acks you got in previous versions.

I messed up with the first post in the patch series (no 0/4 message). In order to fix the long line problem, which post would you suggest I use as an anchor for my reply-to? The original v1 1/4, the v3 1/4, or some other?

Dave

#3 lore raw

09/05/2019 00:50, David Christensen:

Quoted 9 lines
Quoted 9 lines

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread, ideally with a cover letter.
All versions of a patchset must be in the same thread, ideally with the cover letter v1 being the common ancestor. Please check http://core.dpdk.org/contribute/#send

Quoted 6 lines
Quoted 1 line

You need also to report the acks you got in previous versions.

I messed up with the first post in the patch series (no 0/4 message). In order to fix the long line problem, which post would you suggest I use as an anchor for my reply-to? The original v1 1/4, the v3 1/4, or some other?

The patches of v3 are not threaded together,
so when doing a v4 you can skip --in-reply-to.

#4 lore raw

09/05/2019 09:46, Thomas Monjalon:

Quoted 11 lines

09/05/2019 00:50, David Christensen:

Quoted 10 lines
Quoted 9 lines

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread, ideally with a cover letter.
All versions of a patchset must be in the same thread, ideally with the cover letter v1 being the common ancestor. Please check http://core.dpdk.org/contribute/#send

You need also to report the acks you got in previous versions.

Quoted 7 lines
Quoted 4 lines

I messed up with the first post in the patch series (no 0/4 message). In order to fix the long line problem, which post would you suggest I use as an anchor for my reply-to? The original v1 1/4, the v3 1/4, or some other?

The patches of v3 are not threaded together,
so when doing a v4 you can skip --in-reply-to.

Series applied with added acks, fixes lines, etc, thanks.