net/ena: remove unused macro
PATCH 1/1 net/ena: remove unused macro
This assert macro is not called anymore.
This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not exist.
Fixes 3adcba9a8987 ("net/ena: update HAL to the newer version")
Fixes 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging")
Signed-off-by David Marchand <[email protected]>
--- drivers/net/ena/base/ena_plat_dpdk.h | 13 ------------- 1 file changed, 13 deletions(-)
drivers/net/ena/base/ena_plat_dpdk.h +0 -13
@@ -73,19 +73,6 @@ typedef uint64_t dma_addr_t; (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())extern int ena_logtype_com; -#if RTE_LOG_DP_LEVEL >=RTE_LOG_DEBUG -#define ENA_ASSERT(cond, format, arg...) \ - do { \ - if (unlikely(!(cond))) { \ - rte_log(RTE_LOGTYPE_ERR, ena_logtype_com, \ - format, ##arg); \ - rte_panic("line %d\tassert \"" #cond "\"" \ - "failed\n", __LINE__); \ - } \ - } while (0) -#else -#define ENA_ASSERT(cond, format, arg...) do {} while (0) -#endif #define ENA_MAX_T (type, x, y) RTE_MAX((type)(x), (type)(y))#define ENA_MAX32 (x, y) ENA_MAX_T(uint32_t, (x), (y))
Signature · 1 line
2.23.0
pt., 23 paź 2020 o 10:44 David Marchand <[email protected]> napisał(a):
Quoted 10 lines
This assert macro is not called anymore.
This also fixes an invalid reference toRTE_LOGTYPE_ERRthat does not exist.Fixes 3adcba9a8987 ("net/ena: update HAL to the newer version")Fixes 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging")Signed-off-by David Marchand <[email protected]>
Acked-by Michal Krawczyk <[email protected]>
Quoted 31 lines
--- drivers/net/ena/base/ena_plat_dpdk.h | 13 ------------- 1 file changed, 13 deletions(-)drivers/net/ena/base/ena_plat_dpdk.h +0
-14@@ -73,19 +73,6 @@ typedef uint64_t dma_addr_t; (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())extern int ena_logtype_com; -#if RTE_LOG_DP_LEVEL >=RTE_LOG_DEBUG -#define ENA_ASSERT(cond, format, arg...) \ - do { \ - if (unlikely(!(cond))) { \ - rte_log(RTE_LOGTYPE_ERR, ena_logtype_com, \ - format, ##arg); \ - rte_panic("line %d\tassert \"" #cond "\"" \ - "failed\n", __LINE__); \ - } \ - } while (0) -#else -#define ENA_ASSERT(cond, format, arg...) do {} while (0) -#endif #define ENA_MAX_T (type, x, y) RTE_MAX((type)(x), (type)(y))#define ENA_MAX32 (x, y) ENA_MAX_T(uint32_t, (x), (y)) --2.23.0
Ferruh Yigit
AppliedQuoted 6 lines · Michał Krawczyk
pt., 23 paź 2020 o 10:44 David Marchand <[email protected]> napisał(a):
Quoted 5 lines
This assert macro is not called anymore.
This also fixes an invalid reference toRTE_LOGTYPE_ERRthat does not exist.
Quoted 7 lines
Quoted 5 lines
Fixes 3adcba9a8987 ("net/ena: update HAL to the newer version")Fixes 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging")Signed-off-by David Marchand <[email protected]>Acked-by Michal Krawczyk <[email protected]>
Applied to dpdk-next-net/main, thanks.