Skip to contentSkip to conversation

ata: pata_serverworks: "foo * bar" should be "foo *bar"

PATCH In review [email protected] 2 participants 2 messages Jul 19, 2023 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ata: pata_serverworks: "foo * bar" should be "foo *bar"

This patch fixes the checkpatch.pl error:

./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo *bar"

---
 drivers/ata/pata_serverworks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_serverworks.c +1 -1
index b348784..549ff24 100644
@@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev *pdev)
 
     /* Third Channel Test */
     if (!(PCI_FUNC(pdev->devfn) & 1)) {
-        struct pci_dev *findev = NULL;
+        struct pci_dev * findev = NULL;
         u32 reg4c = 0;
         findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
             PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);
maintainer
#2 lore raw
Quoted 6 lines · On 7/19/23 10:54, [email protected] wrote:

This patch fixes the checkpatch.pl error:

./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo *bar"

Please stop sending patches like this. I will not apply such patch unless you actually fix a bug or a compilation warning.

Quoted 18 lines

---
 drivers/ata/pata_serverworks.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_serverworks.c +1 -1
index b348784..549ff24 100644
@@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev *pdev)
 
      /* Third Channel Test */
      if (!(PCI_FUNC(pdev->devfn) & 1)) {
-        struct pci_dev *findev = NULL;
+        struct pci_dev * findev = NULL;
          u32 reg4c = 0;
          findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
              PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);
Signature · 2 lines
Damien Le Moal
Western Digital Research