Skip to contentSkip to conversation

eal: resort symbols in EXPERIMENTAL section

PATCH In review Stephen Hemminger 4 participants 6 messages Apr 5, 2019 – Jul 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal: resort symbols in EXPERIMENTAL section

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

This has no impact on code, API, ABI or otherwise. Purely for humans.

---
 lib/librte_eal/rte_eal_version.map | 36 +++++++++++++++---------------
 1 file changed, 18 insertions(+), 18 deletions(-)
lib/librte_eal/rte_eal_version.map +18 -18
index d6e375135ad1..33f2c303a361 100644
@@ -277,6 +277,14 @@ EXPERIMENTAL {
 	rte_class_unregister;
 	rte_ctrl_thread_create;
 	rte_delay_us_sleep;
+	rte_devargs_add;
+	rte_devargs_dump;
+	rte_devargs_insert;
+	rte_devargs_next;
+	rte_devargs_parse;
+	rte_devargs_parsef;
+	rte_devargs_remove;
+	rte_devargs_type_count;
 	rte_dev_dma_map;
 	rte_dev_dma_unmap;
 	rte_dev_event_callback_process;
@@ -289,14 +297,6 @@ EXPERIMENTAL {
 	rte_dev_is_probed;
 	rte_dev_iterator_init;
 	rte_dev_iterator_next;
-	rte_devargs_add;
-	rte_devargs_dump;
-	rte_devargs_insert;
-	rte_devargs_next;
-	rte_devargs_parse;
-	rte_devargs_parsef;
-	rte_devargs_remove;
-	rte_devargs_type_count;
 	rte_eal_cleanup;
 	rte_extmem_attach;
 	rte_extmem_detach;
@@ -306,19 +306,19 @@ EXPERIMENTAL {
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
 	rte_fbarray_dump_metadata;
-	rte_fbarray_find_idx;
 	rte_fbarray_find_biggest_free;
 	rte_fbarray_find_biggest_used;
+	rte_fbarray_find_contig_free;
+	rte_fbarray_find_contig_used;
+	rte_fbarray_find_idx;
 	rte_fbarray_find_next_free;
-	rte_fbarray_find_next_used;
 	rte_fbarray_find_next_n_free;
 	rte_fbarray_find_next_n_used;
+	rte_fbarray_find_next_used;
 	rte_fbarray_find_prev_free;
-	rte_fbarray_find_prev_used;
 	rte_fbarray_find_prev_n_free;
 	rte_fbarray_find_prev_n_used;
-	rte_fbarray_find_contig_free;
-	rte_fbarray_find_contig_used;
+	rte_fbarray_find_prev_used;
 	rte_fbarray_find_rev_biggest_free;
 	rte_fbarray_find_rev_biggest_used;
 	rte_fbarray_find_rev_contig_free;
@@ -346,24 +346,24 @@ EXPERIMENTAL {
 	rte_mem_event_callback_register;
 	rte_mem_event_callback_unregister;
 	rte_mem_iova2virt;
-	rte_mem_set_dma_mask;
-	rte_mem_virt2memseg;
-	rte_mem_virt2memseg_list;
 	rte_memseg_contig_walk;
 	rte_memseg_contig_walk_thread_unsafe;
 	rte_memseg_get_fd;
 	rte_memseg_get_fd_offset;
-	rte_memseg_get_fd_thread_unsafe;
 	rte_memseg_get_fd_offset_thread_unsafe;
+	rte_memseg_get_fd_thread_unsafe;
 	rte_memseg_list_walk;
 	rte_memseg_list_walk_thread_unsafe;
 	rte_memseg_walk;
 	rte_memseg_walk_thread_unsafe;
+	rte_mem_set_dma_mask;
+	rte_mem_virt2memseg;
+	rte_mem_virt2memseg_list;
 	rte_mp_action_register;
 	rte_mp_action_unregister;
 	rte_mp_reply;
-	rte_mp_request_sync;
 	rte_mp_request_async;
+	rte_mp_request_sync;
 	rte_mp_sendmsg;
 	rte_option_register;
 	rte_realloc_socket;
Signature · 1 line
2.17.1
#1 lore raw

06/04/2019 05:30, Stephen Hemminger:

Quoted 7 lines

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

This has no impact on code, API, ABI or otherwise. Purely for humans.

I don't think it's worth adding a layer of git history for this sort. I would prefer to leave it as is.

#2 lore raw
Quoted 4 lines · Thomas Monjalon

06/04/2019 05:30, Stephen Hemminger:

Quoted 3 lines

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

Quoted 9 lines
Quoted 4 lines

This has no impact on code, API, ABI or otherwise. Purely for humans.

I don't think it's worth adding a layer of git history for this sort. I would prefer to leave it as is.

If this is about preferrence, I would prefer we have those symbols sorted per versions that introduced them ;-).
Much easier to check and see if they are candidates for entering stable ABI.

Signature · 1 line
David Marchand
#3 lore raw
Quoted 11 lines · David Marchand
Quoted 9 lines · Thomas Monjalon

06/04/2019 05:30, Stephen Hemminger:

Quoted 7 lines

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

This has no impact on code, API, ABI or otherwise. Purely for humans.

Quoted 8 lines
Quoted 4 lines

I don't think it's worth adding a layer of git history for this sort. I would prefer to leave it as is.

If this is about preferrence, I would prefer we have those symbols sorted per versions that introduced them ;-).
Much easier to check and see if they are candidates for entering stable ABI.

Not bad idea, +1 from my side J

#4 lore raw
Quoted 17 lines · Ferruh Yigit
Quoted 1 line · David Marchand

On Fri, Jun 14, 2019 at 9:39 AM Thomas Monjalon <[email protected]>

Quoted 14 lines · wrote:
Quoted 14 lines

06/04/2019 05:30, Stephen Hemminger:

Quoted 7 lines

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

This has no impact on code, API, ABI or otherwise. Purely for humans.

I don't think it's worth adding a layer of git history for this sort. I would prefer to leave it as is.

Quoted 8 lines
Quoted 3 lines

If this is about preferrence, I would prefer we have those symbols sorted per versions that introduced them ;-).
Much easier to check and see if they are candidates for entering stable

ABI.

Quoted 1 line

Not bad idea, +1 from my side J

Here is what it looks like:
https://github.com/david-marchand/dpdk/commit/cab0d75ea6bdc7782566d7aad6718b9f5fa784f7

Comments?

Signature · 1 line
David Marchand
#5 lore raw
Quoted 26 lines · David Marchand
Quoted 22 lines · Ferruh Yigit
Quoted 19 lines · David Marchand
Quoted 4 lines · Thomas Monjalon

06/04/2019 05:30, Stephen Hemminger:

Quoted 3 lines

The symbols in the EXPERIMENTAL were close to alphabetic order but running sort showed several mistakes.

Quoted 9 lines
Quoted 4 lines

This has no impact on code, API, ABI or otherwise. Purely for humans.

I don't think it's worth adding a layer of git history for this sort. I would prefer to leave it as is.

If this is about preferrence, I would prefer we have those symbols sorted per versions that introduced them ;-).
Much easier to check and see if they are candidates for entering stable ABI.

Quoted 5 lines
Quoted 1 line

Not bad idea, +1 from my side J

Here is what it looks like:
https://github.com/david-marchand/dpdk/commit/cab0d75ea6bdc7782566d7aad6718b9f5fa784f7

Sent the patch rebased on master.
https://patchwork.dpdk.org/patch/57172/

Signature · 1 line
David Marchand