Info about emac
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Could someone explain me why
'ppc_4xx_eth_rx()' call 'NetReceive(...length-4)'
Is it FCS, padding, VLAN tag?
Thanks
Salvatore
--- Mar 9/12/08, u-boot-request at lists.denx.de <[email protected]> ha scritto:
Quoted 535 lines
Da: u-boot-request at lists.denx.de <[email protected]>
Oggetto: U-Boot Digest, Vol 7, Issue 67
A: u-boot at lists.denx.de
Data: Marted? 9 dicembre 2008, 01:06
Send U-Boot mailing list submissions to
u-boot at lists.denx.deTo subscribe or unsubscribe via the World Wide Web, visit
http://lists.denx.de/mailman/listinfo/u-boot
or, via email, send a message with subject or body 'help' to
u-boot-request at lists.denx.deYou can reach the person managing the list at
u-boot-owner at lists.denx.deWhen replying, please edit your Subject line so it is more specific
than "Re: Contents of U-Boot digest..."Today's Topics:
1. Re: [PATCH 1/1] Make FAT code comply to coding rules. (Wolfgang Denk)
2. Re: [PATCH] OneNAND: Fix compiler warnings (Kyungmin
Park)
3. Re: [PATCH 3/4]v2: Cleanup bootvx and handle newCONFIG_SYS_VXWORKSparameters (Wolfgang Denk)
4. [PATCH]vxworks.h: Fix build problem introduced by
commits29a4c24d/e9084b23 (Wolfgang Denk)5. [PATCH] MAKEALL: Automatically use parallel builds
(Wolfgang Denk)
6. Re: [PATCH] Section name should be ".data"
not "data"
(Wolfgang Denk)
7. Re: Pull request - net (Wolfgang Denk)
8. Re: AT91 Pull request (Wolfgang Denk)----------------------------------------------------------------------
Message: 1
Date: Mon, 08 Dec 2008 23:40:36 +0100
From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/1] Make FAT code comply to coding
rules.
To: Remy B?hmer <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID:
<[email protected]>
Content-Type: text/plain; charset=ISO-8859-1Dear =?utf-8?q?Remy=20B=C3=B6hmer?=,
In message <[email protected]>
Quoted 1 line · you
Currently the fat code is messy related to Coding
rules.
...but your new code has new issues, too.
Review
Quoted 6 lines
(quoted diff) +2
-4- if (cur_dev->block_read) { - return cur_dev->block_read (cur_dev->dev - , startblock, getsize, (unsigned long *)bufptr); - } + if (cur_dev->block_read) + return cur_dev->block_read(cur_dev->dev,startblock, nofblocks,
Review
Quoted 1 line
(quoted diff) +1
-0+ (unsigned long *)bufptr);Multi-line statements do require the curly braces, and two lines is
multi-line.And this...
Quoted 6 lines
(quoted diff) +3
-3- actsize=bytesperclust; - endclust=curclust; - do { + actsize = bytesperclust; + endclust = curclust; + for (;;) {Review
Quoted 10 lines
(quoted diff) +5
-3/* search for consecutive clusters */ - while(actsize < filesize) { + while (actsize < filesize) { newclust = get_fatent(mydata, endclust); - if((newclust -1)!=endclust) - goto getit; + if ((newclust - 1) != endclust) { + if (get_cluster(mydata, curclust, buffer, + (int)actsize) != 0) { + FAT_ERROR("Error readingcluster\n");
Quoted 6 lines
(quoted diff) +6
-0+ return -1; + } + gotsize += (int)actsize; + filesize -= actsize; + buffer += actsize; + curclust = get_fatent(mydata, endclust);Review
Quoted 10 lines
(quoted diff) +10
-0+ if (CHECK_CLUST(curclust, mydata->fatsize)) { + FAT_DPRINT("curclust: 0x%x\n", + curclust); + FAT_ERROR("Invalid FAT entry\n"); + return gotsize; + } + actsize = bytesperclust; + endclust = curclust; + continue; + }...looks like a massive code change, not only a coding style cleanup.
Please submit as two separate patches.Best regards,
Wolfgang Denk
Signature · 28 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I'm a programmer: I don't buy software, I write it. -- Tom Christiansen ------------------------------ Message: 2 Date: Tue, 9 Dec 2008 08:17:32 +0900 From: "Kyungmin Park" <[email protected]> Subject: Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings To: "Wolfgang Denk" <[email protected]> Cc: scottwood at freescale.com, u-boot at lists.denx.de, Stefan Roese <[email protected]> Message-ID: <[email protected]> Content-Type: text/plain; charset=ISO-8859-1 On Tue, Dec 9, 2008 at 5:44 AM, Wolfgang DenkQuoted 3 lines · <[email protected]> wrote:
Hi all,
In message
<[email protected]> you
Quoted 3 lines · wrote:
Quoted 3 lines
Signed-off-by Stefan Roese <[email protected]>---
This patch has to be applied on top of the patchsubmitted by Kyungmin Park
Quoted 4 lines
Quoted 2 lines
on 2008-11-04:
[PATCH] [OneNAND] Sync with 2.6.27I have to admit that I completely lost track of all
the OneNAND
Quoted 1 line
patches floating around and being sent and resent and
resent again.
Quoted 2 lines
This is especially the case since none of the boards I
am familiar
Quoted 1 line
with uses OneNAND, sso I have zero experience and
little ways to test
Quoted 4 lines
anything.
In short: we need a OneNAND custodian, and we need him
badly.
Quoted 2 lines
Is any of you volunteering, or knows of a potential
candidate?
Quoted 1 line
Stefan,
Even though It's some difficult to access the external server, I can
access http protocol. So I can pull the git. So if you control the git
then I generate and send a patch against the OneNAND tree.Or other ideas?
Thank you,
Kyungmin Park------------------------------
Message: 3
Date: Tue, 09 Dec 2008 00:28:45 +0100
From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [PATCH 3/4]v2: Cleanup bootvx and handle new
CONFIG_SYS_VXWORKSparameters
To: Niklaus Giger <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID:
<[email protected]>
Content-Type: text/plain; charset=ISO-8859-1Dear Niklaus Giger,
In message <[email protected]> you
Quoted 1 line · wrote:
Signed-off-by Niklaus GigerQuoted 2 lines
--- common/cmd_elf.c | 81++++++++++++++++++++----------------------------------
Quoted 1 line
1 files changed, 30 insertions(+), 51 deletions(-)Argh...
This commit breaks building ofr a lot of boards:
-> MAKEALL sequoia
Configuring for sequoia board...cmd_elf.c: In function 'do_bootvx':
cmd_elf.c:170: error: 'srv' undeclared (first use in this function)
cmd_elf.c:170: error: (Each undeclared identifier is reported only once
cmd_elf.c:170: error: for each function it appears in.) make[1]: *** [cmd_elf.o] Error 1Will send a patch soon...
Best regards,
Wolfgang Denk
Signature · 31 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Today's robots are very primitive, capable of understanding only a few simple instructions such as 'go left', 'go right', and 'build car'." - John Sladek ------------------------------ Message: 4 Date: Tue, 9 Dec 2008 00:28:48 +0100 From: Wolfgang Denk <[email protected]> Subject: [U-Boot] [PATCH] vxworks.h: Fix build problem introduced by commits 29a4c24d/e9084b23 To: u-boot at lists.denx.de Cc: niklaus.giger at member.fsf.org Message-ID: <[email protected]> Signed-off-by: Wolfgang Denk <[email protected]> --- include/vxworks.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/vxworks.h +1
-1@@ -47,7 +47,7 @@ int do_bootvx(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);#endif #ifndef CONFIG_SYS_VXWORKS_SERVERNAME -#define CONFIG_SYS_VXWORKS_SERVERNAME srv +#define CONFIG_SYS_VXWORKS_SERVERNAME "srv"#endif #endif
Signature · 29 lines
1.5.6.5 ------------------------------ Message: 5 Date: Tue, 9 Dec 2008 00:41:25 +0100 From: Wolfgang Denk <[email protected]> Subject: [U-Boot] [PATCH] MAKEALL: Automatically use parallel builds To: u-boot at lists.denx.de Message-ID: <[email protected]> Add logic to the MAKEALL script to determine the number of CPU cores on the system, and run a parallel build if there is more than one. Usually this significantrly accelerates builds. Allow to manually adjust the number of parallel make jobs by using the "BUILD_NCPUS" environment variable. Signed-off-by: Wolfgang Denk <[email protected]> --- MAKEALL | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-)MAKEALL +10
-1@@ -1,6 +1,15 @@ #!/bin/sh -: ${JOBS:=} +# Determine number of CPU cores if no default was set +: ${BUILD_NCPUS:="`getconf _NPROCESSORS_ONLN`"} + +if [ "$BUILD_NCPUS" -gt 1 ] +then + JOBS=-j`expr "$BUILD_NCPUS" + 1` +else + JOBS="" +fi + if [ "${CROSS_COMPILE}" ] ; then MAKE="make CROSS_COMPILE=${CROSS_COMPILE}"Signature · 22 lines
1.5.6.5 ------------------------------ Message: 6 Date: Tue, 09 Dec 2008 00:51:04 +0100 From: Wolfgang Denk <[email protected]> Subject: Re: [U-Boot] [PATCH] Section name should be ".data" not "data" To: Trent Piepho <[email protected]> Cc: u-boot at lists.denx.de Message-ID: <[email protected]> Content-Type: text/plain; charset=ISO-8859-1 Dear Trent Piepho, In message <[email protected]>Quoted 1 line · you
Signed-off-by Trent PiephoQuoted 3 lines
--- drivers/i2c/fsl_i2c.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)Ummm...
cpu/mpc8260/i2c.c,cpu/ppc4xx/i2c.c, anddrivers/i2c/soft_i2c.chad the very same problem.I fixed these, too, and merged this into your commit. Hope this is OK
with you.Best regards,
Wolfgang Denk
Signature · 24 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "How to make a million dollars: First, get a million dollars." - Steve Martin ------------------------------ Message: 7 Date: Tue, 09 Dec 2008 01:02:35 +0100 From: Wolfgang Denk <[email protected]> Subject: Re: [U-Boot] Pull request - net To: Ben Warren <[email protected]> Cc: U-Boot <[email protected]> Message-ID: <[email protected]> Content-Type: text/plain; charset=ISO-8859-1 Dear Ben Warren,Quoted 3 lines · In message <[email protected]> you wrote:
Wolfgang,
The following changes since commit
90665e3d97948000f98846ded37c921c7ae67dd7:Quoted 2 lines
Wolfgang Denk (1):
Merge branch 'master' of
git://git.denx.de/u-boot-at91Quoted 14 lines
are available in the git repository at:
git://git.denx.de/u-boot-net.gitmasterAnatolij Gustschin (1):
net: tsec: Fix Marvell 88E1121R phy initPeter Tyser (4):
net: Fix download command parsing
net: Define IP flag field values
net: Add additional IP fragmentation check
net: FixTftpStart()ip:filename bugQuoted 7 lines
common/cmd_net.c | 20 ++++++++++++-------- drivers/net/tsec.c | 3 +++ include/net.h | 6 ++++++ include/tsec.h | 4 ++++ net/net.c | 7 ++++--- net/tftp.c | 3 +-- 6 files changed, 30 insertions(+), 13 deletions(-)Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 27 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There is such a fine line between genius and stupidity." - David St. Hubbins, "Spinal Tap" ------------------------------ Message: 8 Date: Tue, 09 Dec 2008 01:06:27 +0100 From: Wolfgang Denk <[email protected]> Subject: Re: [U-Boot] AT91 Pull request To: Jean-Christophe PLAGNIOL-VILLARD <[email protected]> Cc: U-Boot <[email protected]> Message-ID: <[email protected]> Content-Type: text/plain; charset=ISO-8859-1 Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[email protected]>Quoted 2 lines · you
Hi Wolfgang,
Please pull The following changes since commit
90665e3d97948000f98846ded37c921c7ae67dd7:Quoted 2 lines
Wolfgang Denk (1):
Merge branch 'master' of
git://git.denx.de/u-boot-at91Quoted 7 lines
are available in the git repository at:
git://git.denx.de/u-boot-at91.gitmasterNicolas Ferre (1):
at91: Choose environment variables locationwithin make config target
Quoted 2 lines
Makefile | 60+++++++++++++++++++++++---
Quoted 1 line
doc/README.at91 | 88+++++++++++++++++++++++++++++++++++++++
Quoted 6 lines
include/configs/at91sam9260ek.h | 4 -- include/configs/at91sam9261ek.h | 19 +++++++-- include/configs/at91sam9263ek.h | 3 - include/configs/at91sam9rlek.h | 3 - 6 files changed, 156 insertions(+), 21 deletions(-) create mode 100644 doc/README.at91Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 26 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The management question ... is not _whether_ to build a pilot system and throw it away. You _will_ do that. The only question is whether to plan in advance to build a throwaway, or to promise to deliver the throwaway to customers. - Fred Brooks, "The Mythical Man Month" ------------------------------ _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot End of U-Boot Digest, Vol 7, Issue 67 *************************************