rk3188: don't set same clk rate twice
Subsystems (2)
PATCH 1/1 rk3188: don't set same clk rate twice
Hi,
We found setting a clock rate which has already been set, rk3188 (radxa rock pro) bails out. This is a quick fix only. Underlying situation not (yet)
investigated: why it is even trying to set it to the same rate again. It remains to state that some but not all rrpro boards exhibit this behaviour, no other rk3188 boards have been tested.
--- drivers/clk/rockchip/clk-pll.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/clk/rockchip/clk-pll.c +0 -0
@@ -164,6 +164,11 @@ static int rockchip_rk3066_pll_set_rate(struct clk *hw,
unsigned long drate,
int cur_parent;
int ret;
+ if (old_rate == drate) {
+ pr_debug("%s: not changing rate, old == new rate (clk/old/new/parent):
%s/%lu/%lu/%lu\n", __func__, __clk_get_name(hw), old_rate, drate, prate);
+ return 0;
+ }
+
pr_debug("%s: changing %s from %lu to %lu with a parent rate of %lu\n",
__func__, __clk_get_name(hw), old_rate, drate, prate);
--
2.17.1
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Hi,
Quoted 18 lines · On Thu, Nov 08, 2018 at 03:34:29PM +0100, [email protected] wrote:
Hi,
We found setting a clock rate which has already been set, rk3188 (radxa rock pro) bails out. This is a quick fix only. Underlying situation not (yet)
investigated: why it is even trying to set it to the same rate again. It remains to state that some but not all rrpro boards exhibit this behaviour, no other rk3188 boards have been tested.Signed-off-by P. Rachet <[email protected]>--- drivers/clk/rockchip/clk-pll.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/clk/rockchip/clk-pll.c +0
-0
drivers/clk/rockchip/clk-pll.c static int rockchip_rk3066_pll_set_rate(struct clk *hw, · line 173
Quoted 10 lines
drivers/clk/rockchip/clk-pll.c +5
-0@@ -164,6 +164,11 @@ static int rockchip_rk3066_pll_set_rate(struct clk *hw,unsigned long drate, int cur_parent;int ret; +if (old_rate == drate) { + pr_debug("%s: not changing rate, old == new rate (clk/old/new/parent): %s/%lu/%lu/%lu\n", __func__, __clk_get_name(hw), old_rate, drate, prate); + return 0; + } +
The patch is whitespace damaged. I applied it manually this time, but please consider using git-send-email next time. It just does it right™
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox