sta2x11: use monotonic timestamp

PATCH In review Hans Verkuil 2 participants 4 messages May 7, 2015 Media (V4L/DVB)

lore

Share & tools

lore

Hans Verkuil

author

2015-05-07 06:22 UTC #0 lore raw

PATCH 1/1 sta2x11: use monotonic timestamp

V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time.

drivers/media/pci/sta2x11/sta2x11_vip.c +2 -1

index d384a6b..59b3a36 100644
@@ -813,7 +813,7 @@ static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip)
 		/* Disable acquisition */
 		reg_write(vip, DVP_CTL, reg_read(vip, DVP_CTL) & ~DVP_CTL_ENA);
 		/* Remove the active buffer from the list */
-		do_gettimeofday(&vip->active->vb.v4l2_buf.timestamp);
+		v4l2_get_timestamp(&vip->active->vb.v4l2_buf.timestamp);
 		vip->active->vb.v4l2_buf.sequence = vip->sequence++;
 		vb2_buffer_done(&vip->active->vb, VB2_BUF_STATE_DONE);
 	}

@@ -864,6 +864,7 @@ static int sta2x11_vip_init_buffer(struct sta2x11_vip *vip)
 	vip->vb_vidq.buf_struct_size = sizeof(struct vip_buffer);
 	vip->vb_vidq.ops = &vip_video_qops;
 	vip->vb_vidq.mem_ops = &vb2_dma_contig_memops;
+	vip->vb_vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
 	err = vb2_queue_init(&vip->vb_vidq);
 	if (err)
 		return err;

Hans Verkuil

author

2015-05-07 06:27 UTC #1 lore raw

Added Federico to the CC-list.

Quoted 29 lines · Hans Verkuil

V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time.

drivers/media/pci/sta2x11/sta2x11_vip.c +2 -2

index d384a6b..59b3a36 100644
@@ -813,7 +813,7 @@ static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip)
 		/* Disable acquisition */
 		reg_write(vip, DVP_CTL, reg_read(vip, DVP_CTL) & ~DVP_CTL_ENA);
 		/* Remove the active buffer from the list */
-		do_gettimeofday(&vip->active->vb.v4l2_buf.timestamp);
+		v4l2_get_timestamp(&vip->active->vb.v4l2_buf.timestamp);
 		vip->active->vb.v4l2_buf.sequence = vip->sequence++;
 		vb2_buffer_done(&vip->active->vb, VB2_BUF_STATE_DONE);
 	}

@@ -864,6 +864,7 @@ static int sta2x11_vip_init_buffer(struct sta2x11_vip *vip)
 	vip->vb_vidq.buf_struct_size = sizeof(struct vip_buffer);
 	vip->vb_vidq.ops = &vip_video_qops;
 	vip->vb_vidq.mem_ops = &vb2_dma_contig_memops;
+	vip->vb_vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
 	err = vb2_queue_init(&vip->vb_vidq);
 	if (err)
 		return err;
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Federico Vaga

Acked-by

2015-05-07 12:21 UTC #2 lore raw

Quoted 1 line · On Thursday 07 May 2015 08:27:20 Hans Verkuil wrote:

Added Federico to the CC-list.

Fine for me

Acked-by Federico Vaga <[email protected]>

Quoted 39 lines · Hans Verkuil

Quoted 38 lines
V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time.
(quoted diff) +0 -0
b/drivers/media/pci/sta2x11/sta2x11_vip.c index d384a6b..59b3a36 100644
drivers/media/pci/sta2x11/sta2x11_vip.c +1 -1
@@ -813,7 +813,7 @@ static irqreturn_t vip_irq(int irq, struct sta2x11_vip
 *vip)> 
 		/* Disable acquisition */
 		reg_write(vip, DVP_CTL, reg_read(vip, DVP_CTL) & ~DVP_CTL_ENA);
 		/* Remove the active buffer from the list */
 
-		do_gettimeofday(&vip->active->vb.v4l2_buf.timestamp);
+		v4l2_get_timestamp(&vip->active->vb.v4l2_buf.timestamp);
 
drivers/media/pci/sta2x11/sta2x11_vip.c +1 -0
 		vip->active->vb.v4l2_buf.sequence = vip->sequence++;
 		vb2_buffer_done(&vip->active->vb, VB2_BUF_STATE_DONE);
 
 	}
@@ -864,6 +864,7 @@ static int sta2x11_vip_init_buffer(struct sta2x11_vip
 *vip)> 
 	vip->vb_vidq.buf_struct_size = sizeof(struct vip_buffer);
 	vip->vb_vidq.ops = &vip_video_qops;
 	vip->vb_vidq.mem_ops = &vb2_dma_contig_memops;
 
+	vip->vb_vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
 
drivers/media/pci/sta2x11/sta2x11_vip.c +0 -1
 	err = vb2_queue_init(&vip->vb_vidq);
 	if (err)
 
 		return err;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line

Federico Vaga

Hans Verkuil

author

2015-05-07 06:33 UTC #3 lore raw

In reply to Hans Verkuil

Quoted 3 lines · Hans Verkuil

V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time.

Signed-off-by Hans Verkuil <[email protected]>

Quoted 26 lines

drivers/media/pci/sta2x11/sta2x11_vip.c +2 -2

index d384a6b..59b3a36 100644
@@ -813,7 +813,7 @@ static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip)
 		/* Disable acquisition */
 		reg_write(vip, DVP_CTL, reg_read(vip, DVP_CTL) & ~DVP_CTL_ENA);
 		/* Remove the active buffer from the list */
-		do_gettimeofday(&vip->active->vb.v4l2_buf.timestamp);
+		v4l2_get_timestamp(&vip->active->vb.v4l2_buf.timestamp);
 		vip->active->vb.v4l2_buf.sequence = vip->sequence++;
 		vb2_buffer_done(&vip->active->vb, VB2_BUF_STATE_DONE);
 	}

@@ -864,6 +864,7 @@ static int sta2x11_vip_init_buffer(struct sta2x11_vip *vip)
 	vip->vb_vidq.buf_struct_size = sizeof(struct vip_buffer);
 	vip->vb_vidq.ops = &vip_video_qops;
 	vip->vb_vidq.mem_ops = &vb2_dma_contig_memops;
+	vip->vb_vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
 	err = vb2_queue_init(&vip->vb_vidq);
 	if (err)
 		return err;
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html