sunxi: video: Add support for HDMI output on A64/H3/H5
Subsystems (6)
v2 cover sunxi: video: Add support for HDMI output on A64/H3/H5
This series implements support for HDMI output. This is done using DM video framework and sharing the HDMI controller code with RK3288.
Patch 1 splits out RK3288 HDMI code in a way that it is appropriate for sharing with Allwinner SoCs.
Patch 2 splits out TCON code which is completely reusable on all Allwinner SoCs.
Patch 3 (new) converts commont TCON code to use DM video compatible timing structure.
Patch 4 adds all necessary clocks which are needed for Display Engine 2, TCON and HDMI.
Patch 5 implement actual DE2 and HDMI driver and patch 6 disables HDMI on all boards which don't have it (default is on).
Patch 7 is included here only for testing HDMI output on A64 due to missing power regulator support (AXP803). Another option is to use ATF which powers on HDMI. Such ATF can be found on Andre Przywara's github.
Code was tested on OrangePi 2 & OrangePi Plus 2E (both H3), OrangePi PC 2 (H5) and Pine64 (A64). It was also tested on RK3288 Tinker board. However, it was only compile tested for A10 and A20 targets.
This series was developed on u-boot-sunxi repository with additional, not yet merged, patch: https://patchwork.ozlabs.org/patch/735617/
Because already merged patches are not yet included in u-boot-sunxi repository, they need to be cherry picked from u-boot-rockchip:a0a2774aebdaa039ce787090c903cf47263f04c9 520c174b3564ae183f0e7c118dc8ce3770ae20b0
Best regards,
Jernej Skrabec
Changes in v2:
- patch 1 & 2 were removed because they were merged
- collect reviewed by and tested by tags
- TCON split out patch is splitted in two patches
- fixed lcdc_enable() calls in video driver for old SoCs
- defconfigs should disable video driver, not enable it
- minor constant style fix
Icenowy Zheng (1):
[DO NOT MERGE] sunxi: add AXP803 support
Jernej Skrabec (6):
rockchip: video: Split out HDMI controller code
sunxi: video: Split out TCON code
sunxi: video: Convert lcdc to use struct display_timing
sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
sunxi: video: Add A64/H3/H5 HDMI driver
sunxi: Disable DE2 video driver where not needed
arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h | 456 --------------
arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 54 ++
arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 8 +
arch/arm/include/asm/arch-sunxi/display.h | 103 ---
arch/arm/include/asm/arch-sunxi/display2.h | 124 ++++
arch/arm/include/asm/arch-sunxi/lcdc.h | 128 ++++
arch/arm/mach-sunxi/Makefile | 3 +
arch/arm/mach-sunxi/clock_sun6i.c | 40 +-
arch/arm/mach-sunxi/pmic_bus.c | 6 +-
arch/arm/mach-sunxi/rsb.c | 2 +-
board/sunxi/Kconfig | 10 +
board/sunxi/board.c | 31 +-
configs/nanopi_neo_air_defconfig | 1 +
configs/nanopi_neo_defconfig | 1 +
configs/orangepi_zero_defconfig | 1 +
drivers/power/Kconfig | 87 ++-
drivers/power/Makefile | 1 +
drivers/power/axp803.c | 256 ++++++++
drivers/power/axp818.c | 2 +-
drivers/video/Makefile | 2 +-
drivers/video/dw_hdmi.c | 764 +++++++++++++++++++++++
drivers/video/rockchip/Makefile | 2 +-
drivers/video/rockchip/rk_hdmi.c | 757 +---------------------
drivers/video/rockchip/rk_vop.c | 1 -
drivers/video/sunxi/Makefile | 9 +
drivers/video/sunxi/lcdc.c | 209 +++++++
drivers/video/sunxi/sunxi_de2.c | 258 ++++++++
drivers/video/{ => sunxi}/sunxi_display.c | 220 ++-----
drivers/video/sunxi/sunxi_dw_hdmi.c | 389 ++++++++++++
include/axp803.h | 73 +++
include/axp_pmic.h | 3 +
include/configs/sun50i.h | 2 +
include/configs/sun8i.h | 4 +
include/configs/sunxi-common.h | 5 +
include/dw_hdmi.h | 486 ++++++++++++++
scripts/config_whitelist.txt | 1 +
36 files changed, 2977 insertions(+), 1522 deletions(-)
delete mode 100644 arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h
create mode 100644 arch/arm/include/asm/arch-sunxi/display2.h
create mode 100644 arch/arm/include/asm/arch-sunxi/lcdc.h
create mode 100644 drivers/power/axp803.c
create mode 100644 drivers/video/dw_hdmi.c
create mode 100644 drivers/video/sunxi/Makefile
create mode 100644 drivers/video/sunxi/lcdc.c
create mode 100644 drivers/video/sunxi/sunxi_de2.c
rename drivers/video/{ => sunxi}/sunxi_display.c (87%)
create mode 100644 drivers/video/sunxi/sunxi_dw_hdmi.c
create mode 100644 include/axp803.h
create mode 100644 include/dw_hdmi.hSignature · 1 line
2.12.0
PATCH v2 1/7 rockchip: video: Split out HDMI controller code
Designware HDMI controller and phy are used in other SoCs as well. Split out platform independent code.
DW HDMI has 8 bit registers but they can be represented as 32 bit registers as well. Add support to select access mode.
EDID reading code use reading by blocks which is not supported by other SoCs in general. Make it more general using byte by byte approach, which is also used in Linux driver.
Finally, not all DW HDMI controllers are accompanied with DW HDMI phy. Support custom phys by making controller code independent from phy code.
---
Changes in v2:
- added tested by tag
- added reviewed by tag
arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h | 456 -------------- drivers/video/dw_hdmi.c | 764 +++++++++++++++++++++++ drivers/video/rockchip/Makefile | 2 +- drivers/video/rockchip/rk_hdmi.c | 757 +--------------------- drivers/video/rockchip/rk_vop.c | 1 - include/dw_hdmi.h | 486 ++++++++++++++ 6 files changed, 1275 insertions(+), 1191 deletions(-) delete mode 100644 arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h create mode 100644 drivers/video/dw_hdmi.c create mode 100644 include/dw_hdmi.h
arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h deleted +0 -456
@@ -1,456 +0,0 @@ -/* -* Copyright (c) 2015 Google, Inc -* Copyright 2014 Rockchip Inc. -* Copyright (C) 2011 Freescale Semiconductor, Inc. -* -* SPDX-License-Identifier: GPL-2.0+ -*/ - -#ifndef _ASM_ARCH_HDMI_H -#define _ASM_ARCH_HDMI_H - - -#define HDMI_EDID_BLOCK_SIZE 128 - -struct rk3288_hdmi { -u32 reserved0[0x100 ]; -u32 ih_fc_stat0; -u32 ih_fc_stat1; -u32 ih_fc_stat2; -u32 ih_as_stat0; -u32 ih_phy_stat0; -u32 ih_i2cm_stat0; -u32 ih_cec_stat0; -u32 ih_vp_stat0; -u32 ih_i2cmphy_stat0; -u32 ih_ahbdmaaud_stat0; -u32 reserved1[0x17f -0x109 ]; -u32 ih_mute_fc_stat0; -u32 ih_mute_fc_stat1; -u32 ih_mute_fc_stat2; -u32 ih_mute_as_stat0; -u32 ih_mute_phy_stat0; -u32 ih_mute_i2cm_stat0; -u32 ih_mute_cec_stat0; -u32 ih_mute_vp_stat0; -u32 ih_mute_i2cmphy_stat0; -u32 ih_mute_ahbdmaaud_stat0; -u32 reserved2[0x1fe -0x189 ]; -u32 ih_mute; -u32 tx_invid0; -u32 tx_instuffing; -u32 tx_gydata0; -u32 tx_gydata1; -u32 tx_rcrdata0; -u32 tx_rcrdata1; -u32 tx_bcbdata0; -u32 tx_bcbdata1; -u32 reserved3[0x7ff -0x207 ]; -u32 vp_status; -u32 vp_pr_cd; -u32 vp_stuff; -u32 vp_remap; -u32 vp_conf; -u32 vp_stat; -u32 vp_int; -u32 vp_mask; -u32 vp_pol; -u32 reserved4[0xfff -0x808 ]; -u32 fc_invidconf; -u32 fc_inhactv0; -u32 fc_inhactv1; -u32 fc_inhblank0; -u32 fc_inhblank1; -u32 fc_invactv0; -u32 fc_invactv1; -u32 fc_invblank; -u32 fc_hsyncindelay0; -u32 fc_hsyncindelay1; -u32 fc_hsyncinwidth0; -u32 fc_hsyncinwidth1; -u32 fc_vsyncindelay; -u32 fc_vsyncinwidth; -u32 fc_infreq0; -u32 fc_infreq1; -u32 fc_infreq2; -u32 fc_ctrldur; -u32 fc_exctrldur; -u32 fc_exctrlspac; -u32 fc_ch0pream; -u32 fc_ch1pream; -u32 fc_ch2pream; -u32 fc_aviconf3; -u32 fc_gcp; -u32 fc_aviconf0; -u32 fc_aviconf1; -u32 fc_aviconf2; -u32 fc_avivid; -u32 fc_avietb0; -u32 fc_avietb1; -u32 fc_avisbb0; -u32 fc_avisbb1; -u32 fc_avielb0; -u32 fc_avielb1; -u32 fc_avisrb0; -u32 fc_avisrb1; -u32 fc_audiconf0; -u32 fc_audiconf1; -u32 fc_audiconf2; -u32 fc_audiconf3; -u32 fc_vsdieeeid0; -u32 fc_vsdsize; -u32 reserved7[0x2fff -0x102a ]; -u32 phy_conf0; -u32 phy_tst0; -u32 phy_tst1; -u32 phy_tst2; -u32 phy_stat0; -u32 phy_int0; -u32 phy_mask0; -u32 phy_pol0; -u32 reserved8[0x301f -0x3007 ]; -u32 phy_i2cm_slave_addr; -u32 phy_i2cm_address_addr; -u32 phy_i2cm_datao_1_addr; -u32 phy_i2cm_datao_0_addr; -u32 phy_i2cm_datai_1_addr; -u32 phy_i2cm_datai_0_addr; -u32 phy_i2cm_operation_addr; -u32 phy_i2cm_int_addr; -u32 phy_i2cm_ctlint_addr; -u32 phy_i2cm_div_addr; -u32 phy_i2cm_softrstz_addr; -u32 phy_i2cm_ss_scl_hcnt_1_addr; -u32 phy_i2cm_ss_scl_hcnt_0_addr; -u32 phy_i2cm_ss_scl_lcnt_1_addr; -u32 phy_i2cm_ss_scl_lcnt_0_addr; -u32 phy_i2cm_fs_scl_hcnt_1_addr; -u32 phy_i2cm_fs_scl_hcnt_0_addr; -u32 phy_i2cm_fs_scl_lcnt_1_addr; -u32 phy_i2cm_fs_scl_lcnt_0_addr; -u32 reserved9[0x30ff -0x3032 ]; -u32 aud_conf0; -u32 aud_conf1; -u32 aud_int; -u32 aud_conf2; -u32 aud_int1; -u32 reserved32[0x31ff -0x3104 ]; -u32 aud_n1; -u32 aud_n2; -u32 aud_n3; -u32 aud_cts1; -u32 aud_cts2; -u32 aud_cts3; -u32 aud_inputclkfs; -u32 reserved12[0x3fff -0x3206 ]; -u32 mc_sfrdiv; -u32 mc_clkdis; -u32 mc_swrstz; -u32 mc_opctrl; -u32 mc_flowctrl; -u32 mc_phyrstz; -u32 mc_lockonclock; -u32 mc_heacphy_rst; -u32 reserved13[0x40ff -0x4007 ]; -u32 csc_cfg; -u32 csc_scale; -struct { -u32 msb; -u32 lsb; - } csc_coef[3 ][4 ]; -u32 reserved17[0x7dff -0x4119 ]; -u32 i2cm_slave; -u32 i2c_address; -u32 i2cm_datao; -u32 i2cm_datai; -u32 i2cm_operation; -u32 i2cm_int; -u32 i2cm_ctlint; -u32 i2cm_div; -u32 i2cm_segaddr; -u32 i2cm_softrstz; -u32 i2cm_segptr; -u32 i2cm_ss_scl_hcnt_1_addr; -u32 i2cm_ss_scl_hcnt_0_addr; -u32 i2cm_ss_scl_lcnt_1_addr; -u32 i2cm_ss_scl_lcnt_0_addr; -u32 i2cm_fs_scl_hcnt_1_addr; -u32 i2cm_fs_scl_hcnt_0_addr; -u32 i2cm_fs_scl_lcnt_1_addr; -u32 i2cm_fs_scl_lcnt_0_addr; -u32 reserved18[0x7e1f -0x7e12 ]; -u32 i2cm_buf0; -}; -check_member (rk3288_hdmi, i2cm_buf0,0x1f880 ); - -enum { -/* HDMI PHY registers define */ -PHY_OPMODE_PLLCFG =0x06 , -PHY_CKCALCTRL =0x05 , -PHY_CKSYMTXCTRL =0x09 , -PHY_VLEVCTRL =0x0e , -PHY_PLLCURRCTRL =0x10 , -PHY_PLLPHBYCTRL =0x13 , -PHY_PLLGMPCTRL =0x15 , -PHY_PLLCLKBISTPHASE =0x17 , -PHY_TXTERM =0x19 , - -/* ih_phy_stat0 field values */ -HDMI_IH_PHY_STAT0_HPD =0x1 , - -/* ih_mute field values */ -HDMI_IH_MUTE_MUTE_WAKEUP_INTERRUPT =0x2 , -HDMI_IH_MUTE_MUTE_ALL_INTERRUPT =0x1 , - -/* tx_invid0 field values */ -HDMI_TX_INVID0_INTERNAL_DE_GENERATOR_DISABLE =0x00 , -HDMI_TX_INVID0_VIDEO_MAPPING_MASK =0x1f , -HDMI_TX_INVID0_VIDEO_MAPPING_OFFSET =0 , - -/* tx_instuffing field values */ -HDMI_TX_INSTUFFING_BDBDATA_STUFFING_ENABLE =0x4 , -HDMI_TX_INSTUFFING_RCRDATA_STUFFING_ENABLE =0x2 , -HDMI_TX_INSTUFFING_GYDATA_STUFFING_ENABLE =0x1 , - -/* vp_pr_cd field values */ -HDMI_VP_PR_CD_COLOR_DEPTH_MASK =0xf0 , -HDMI_VP_PR_CD_COLOR_DEPTH_OFFSET =4 , -HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK =0x0f , -HDMI_VP_PR_CD_DESIRED_PR_FACTOR_OFFSET =0 , - -/* vp_stuff field values */ -HDMI_VP_STUFF_IDEFAULT_PHASE_MASK =0x20 , -HDMI_VP_STUFF_IDEFAULT_PHASE_OFFSET =5 , -HDMI_VP_STUFF_YCC422_STUFFING_MASK =0x4 , -HDMI_VP_STUFF_YCC422_STUFFING_STUFFING_MODE =0x4 , -HDMI_VP_STUFF_PP_STUFFING_MASK =0x2 , -HDMI_VP_STUFF_PP_STUFFING_STUFFING_MODE =0x2 , -HDMI_VP_STUFF_PR_STUFFING_MASK =0x1 , -HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE =0x1 , - -/* vp_conf field values */ -HDMI_VP_CONF_BYPASS_EN_MASK =0x40 , -HDMI_VP_CONF_BYPASS_EN_ENABLE =0x40 , -HDMI_VP_CONF_PP_EN_ENMASK =0x20 , -HDMI_VP_CONF_PP_EN_DISABLE =0x00 , -HDMI_VP_CONF_PR_EN_MASK =0x10 , -HDMI_VP_CONF_PR_EN_DISABLE =0x00 , -HDMI_VP_CONF_YCC422_EN_MASK =0x8 , -HDMI_VP_CONF_YCC422_EN_DISABLE =0x0 , -HDMI_VP_CONF_BYPASS_SELECT_MASK =0x4 , -HDMI_VP_CONF_BYPASS_SELECT_VID_PACKETIZER =0x4 , -HDMI_VP_CONF_OUTPUT_SELECTOR_MASK =0x3 , -HDMI_VP_CONF_OUTPUT_SELECTOR_BYPASS =0x3 , - -/* vp_remap field values */ -HDMI_VP_REMAP_YCC422_16BIT =0x0 , - -/* fc_invidconf field values */ -HDMI_FC_INVIDCONF_HDCP_KEEPOUT_MASK =0x80 , -HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE =0x80 , -HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE =0x00 , -HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_MASK =0x40 , -HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH =0x40 , -HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW =0x00 , -HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_MASK =0x20 , -HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH =0x20 , -HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW =0x00 , -HDMI_FC_INVIDCONF_DE_IN_POLARITY_MASK =0x10 , -HDMI_FC_INVIDCONF_DE_IN_POLARITY_ACTIVE_HIGH =0x10 , -HDMI_FC_INVIDCONF_DE_IN_POLARITY_ACTIVE_LOW =0x00 , -HDMI_FC_INVIDCONF_DVI_MODEZ_MASK =0x8 , -HDMI_FC_INVIDCONF_DVI_MODEZ_HDMI_MODE =0x8 , -HDMI_FC_INVIDCONF_DVI_MODEZ_DVI_MODE =0x0 , -HDMI_FC_INVIDCONF_R_V_BLANK_IN_OSC_MASK =0x2 , -HDMI_FC_INVIDCONF_R_V_BLANK_IN_OSC_ACTIVE_HIGH =0x2 , -HDMI_FC_INVIDCONF_R_V_BLANK_IN_OSC_ACTIVE_LOW =0x0 , -HDMI_FC_INVIDCONF_IN_I_P_MASK =0x1 , -HDMI_FC_INVIDCONF_IN_I_P_INTERLACED =0x1 , -HDMI_FC_INVIDCONF_IN_I_P_PROGRESSIVE =0x0 , - - -/* fc_aviconf0-fc_aviconf3 field values */ -HDMI_FC_AVICONF0_PIX_FMT_MASK =0x03 , -HDMI_FC_AVICONF0_PIX_FMT_RGB =0x00 , -HDMI_FC_AVICONF0_PIX_FMT_YCBCR422 =0x01 , -HDMI_FC_AVICONF0_PIX_FMT_YCBCR444 =0x02 , -HDMI_FC_AVICONF0_ACTIVE_FMT_MASK =0x40 , -HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT =0x40 , -HDMI_FC_AVICONF0_ACTIVE_FMT_NO_INFO =0x00 , -HDMI_FC_AVICONF0_BAR_DATA_MASK =0x0c , -HDMI_FC_AVICONF0_BAR_DATA_NO_DATA =0x00 , -HDMI_FC_AVICONF0_BAR_DATA_VERT_BAR =0x04 , -HDMI_FC_AVICONF0_BAR_DATA_HORIZ_BAR =0x08 , -HDMI_FC_AVICONF0_BAR_DATA_VERT_HORIZ_BAR =0x0c , -HDMI_FC_AVICONF0_SCAN_INFO_MASK =0x30 , -HDMI_FC_AVICONF0_SCAN_INFO_OVERSCAN =0x10 , -HDMI_FC_AVICONF0_SCAN_INFO_UNDERSCAN =0x20 , -HDMI_FC_AVICONF0_SCAN_INFO_NODATA =0x00 , - -HDMI_FC_AVICONF1_ACTIVE_ASPECT_RATIO_MASK =0x0f , -HDMI_FC_AVICONF1_ACTIVE_ASPECT_RATIO_USE_CODED =0x08 , -HDMI_FC_AVICONF1_ACTIVE_ASPECT_RATIO_4_3 =0x09 , -HDMI_FC_AVICONF1_ACTIVE_ASPECT_RATIO_16_9 =0x0a , -HDMI_FC_AVICONF1_ACTIVE_ASPECT_RATIO_14_9 =0x0b , -HDMI_FC_AVICONF1_CODED_ASPECT_RATIO_MASK =0x30 , -HDMI_FC_AVICONF1_CODED_ASPECT_RATIO_NO_DATA =0x00 , -HDMI_FC_AVICONF1_CODED_ASPECT_RATIO_4_3 =0x10 , -HDMI_FC_AVICONF1_CODED_ASPECT_RATIO_16_9 =0x20 , -HDMI_FC_AVICONF1_COLORIMETRY_MASK =0xc0 , -HDMI_FC_AVICONF1_COLORIMETRY_NO_DATA =0x00 , -HDMI_FC_AVICONF1_COLORIMETRY_SMPTE =0x40 , -HDMI_FC_AVICONF1_COLORIMETRY_ITUR =0x80 , -HDMI_FC_AVICONF1_COLORIMETRY_EXTENDED_INFO =0xc0 , - -HDMI_FC_AVICONF2_SCALING_MASK =0x03 , -HDMI_FC_AVICONF2_SCALING_NONE =0x00 , -HDMI_FC_AVICONF2_SCALING_HORIZ =0x01 , -HDMI_FC_AVICONF2_SCALING_VERT =0x02 , - HDMI_FC_AVICONF2_SCALING_HORIZ_vert =0x03 , -HDMI_FC_AVICONF2_RGB_QUANT_MASK =0x0c , -HDMI_FC_AVICONF2_RGB_QUANT_DEFAULT =0x00 , -HDMI_FC_AVICONF2_RGB_QUANT_LIMITED_RANGE =0x04 , -HDMI_FC_AVICONF2_RGB_QUANT_FULL_RANGE =0x08 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_MASK =0x70 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_XVYCC601 =0x00 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_XVYCC709 =0x10 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_SYCC601 =0x20 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_ADOBE_YCC601 =0x30 , -HDMI_FC_AVICONF2_EXT_COLORIMETRY_ADOBE_RGB =0x40 , -HDMI_FC_AVICONF2_IT_CONTENT_MASK =0x80 , -HDMI_FC_AVICONF2_IT_CONTENT_NO_DATA =0x00 , -HDMI_FC_AVICONF2_IT_CONTENT_VALID =0x80 , - -HDMI_FC_AVICONF3_IT_CONTENT_TYPE_MASK =0x03 , -HDMI_FC_AVICONF3_IT_CONTENT_TYPE_GRAPHICS =0x00 , -HDMI_FC_AVICONF3_IT_CONTENT_TYPE_PHOTO =0x01 , -HDMI_FC_AVICONF3_IT_CONTENT_TYPE_CINEMA =0x02 , -HDMI_FC_AVICONF3_IT_CONTENT_TYPE_GAME =0x03 , -HDMI_FC_AVICONF3_QUANT_RANGE_MASK =0x0c , -HDMI_FC_AVICONF3_QUANT_RANGE_LIMITED =0x00 , -HDMI_FC_AVICONF3_QUANT_RANGE_FULL =0x04 , - -/* fc_gcp field values*/ -HDMI_FC_GCP_SET_AVMUTE =0x02 , -HDMI_FC_GCP_CLEAR_AVMUTE =0x01 , - -/* phy_conf0 field values */ -HDMI_PHY_CONF0_PDZ_MASK =0x80 , -HDMI_PHY_CONF0_PDZ_OFFSET =7 , -HDMI_PHY_CONF0_ENTMDS_MASK =0x40 , -HDMI_PHY_CONF0_ENTMDS_OFFSET =6 , -HDMI_PHY_CONF0_SPARECTRL_MASK =0x20 , -HDMI_PHY_CONF0_SPARECTRL_OFFSET =5 , -HDMI_PHY_CONF0_GEN2_PDDQ_MASK =0x10 , -HDMI_PHY_CONF0_GEN2_PDDQ_OFFSET =4 , -HDMI_PHY_CONF0_GEN2_TXPWRON_MASK =0x8 , -HDMI_PHY_CONF0_GEN2_TXPWRON_OFFSET =3 , -HDMI_PHY_CONF0_SELDATAENPOL_MASK =0x2 , -HDMI_PHY_CONF0_SELDATAENPOL_OFFSET =1 , -HDMI_PHY_CONF0_SELDIPIF_MASK =0x1 , -HDMI_PHY_CONF0_SELDIPIF_OFFSET =0 , - -/* phy_tst0 field values */ -HDMI_PHY_TST0_TSTCLR_MASK =0x20 , -HDMI_PHY_TST0_TSTCLR_OFFSET =5 , - -/* phy_stat0 field values */ -HDMI_PHY_HPD =0x02 , -HDMI_PHY_TX_PHY_LOCK =0x01 , - -/* phy_i2cm_slave_addr field values */ -HDMI_PHY_I2CM_SLAVE_ADDR_PHY_GEN2 =0x69 , - -/* phy_i2cm_operation_addr field values */ -HDMI_PHY_I2CM_OPERATION_ADDR_WRITE =0x10 , - -/* hdmi_phy_i2cm_int_addr */ -HDMI_PHY_I2CM_INT_ADDR_DONE_POL =0x08 , - -/* hdmi_phy_i2cm_ctlint_addr */ -HDMI_PHY_I2CM_CTLINT_ADDR_NAC_POL =0x80 , -HDMI_PHY_I2CM_CTLINT_ADDR_ARBITRATION_POL =0x08 , - -/* aud_conf0 field values */ -HDMI_AUD_CONF0_SW_AUDIO_FIFO_RST =0x80 , -HDMI_AUD_CONF0_I2S_SELECT =0x20 , -HDMI_AUD_CONF0_I2S_IN_EN_0 =0x01 , -HDMI_AUD_CONF0_I2S_IN_EN_1 =0x02 , -HDMI_AUD_CONF0_I2S_IN_EN_2 =0x04 , -HDMI_AUD_CONF0_I2S_IN_EN_3 =0x08 , - -/* aud_conf0 field values */ -HDMI_AUD_CONF1_I2S_MODE_STANDARD_MODE =0x0 , -HDMI_AUD_CONF1_I2S_WIDTH_16BIT =0x10 , - -/* aud_n3 field values */ -HDMI_AUD_N3_NCTS_ATOMIC_WRITE =0x80 , -HDMI_AUD_N3_AUDN19_16_MASK =0x0f , - -/* aud_cts3 field values */ -HDMI_AUD_CTS3_N_SHIFT_OFFSET =5 , -HDMI_AUD_CTS3_N_SHIFT_MASK =0xe0 , -HDMI_AUD_CTS3_N_SHIFT_1 =0 , -HDMI_AUD_CTS3_N_SHIFT_16 =0x20 , -HDMI_AUD_CTS3_N_SHIFT_32 =0x40 , -HDMI_AUD_CTS3_N_SHIFT_64 =0x60 , -HDMI_AUD_CTS3_N_SHIFT_128 =0x80 , -HDMI_AUD_CTS3_N_SHIFT_256 =0xa0 , -HDMI_AUD_CTS3_CTS_MANUAL =0x10 , -HDMI_AUD_CTS3_AUDCTS19_16_MASK =0x0f , - -/* aud_inputclkfs filed values */ -HDMI_AUD_INPUTCLKFS_128 =0x0 , - -/* mc_clkdis field values */ -HDMI_MC_CLKDIS_AUDCLK_DISABLE =0x8 , -HDMI_MC_CLKDIS_TMDSCLK_DISABLE =0x2 , -HDMI_MC_CLKDIS_PIXELCLK_DISABLE =0x1 , - -/* mc_swrstz field values */ -HDMI_MC_SWRSTZ_II2SSWRST_REQ =0x08 , -HDMI_MC_SWRSTZ_TMDSSWRST_REQ =0x02 , - -/* mc_flowctrl field values */ -HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH =0x1 , -HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_BYPASS =0x0 , - -/* mc_phyrstz field values */ -HDMI_MC_PHYRSTZ_ASSERT =0x0 , -HDMI_MC_PHYRSTZ_DEASSERT =0x1 , - -/* mc_heacphy_rst field values */ -HDMI_MC_HEACPHY_RST_ASSERT =0x1 , - -/* csc_cfg field values */ -HDMI_CSC_CFG_INTMODE_DISABLE =0x00 , - -/* csc_scale field values */ -HDMI_CSC_SCALE_CSC_COLORDE_PTH_MASK =0xf0 , -HDMI_CSC_SCALE_CSC_COLORDE_PTH_24BPP =0x00 , -HDMI_CSC_SCALE_CSC_COLORDE_PTH_30BPP =0x50 , -HDMI_CSC_SCALE_CSC_COLORDE_PTH_36BPP =0x60 , -HDMI_CSC_SCALE_CSC_COLORDE_PTH_48BPP =0x70 , -HDMI_CSC_SCALE_CSCSCALE_MASK =0x03 , - -/* i2cm filed values */ -HDMI_I2CM_SLAVE_DDC_ADDR =0x50 , -HDMI_I2CM_SEGADDR_DDC =0x30 , -HDMI_I2CM_OPT_RD8_EXT =0x8 , -HDMI_I2CM_OPT_RD8 =0x4 , -HDMI_I2CM_DIV_FAST_STD_MODE =0x8 , -HDMI_I2CM_DIV_FAST_MODE =0x8 , -HDMI_I2CM_DIV_STD_MODE =0x0 , -HDMI_I2CM_SOFTRSTZ =0x1 , -}; - -/* -struct display_timing; -struct rk3288_grf; - -int rk_hdmi_init(struct rk3288_grf *grf, u32 vop_id); -int rk_hdmi_enable(const struct display_timing *edid); -int rk_hdmi_get_edid(struct rk3288_grf *grf, struct display_timing *edid); -*/ - -#endif
drivers/video/dw_hdmi.c new file +764 -0
764 lines not on this page · raw message
drivers/video/rockchip/Makefile +1 -1
@@ -5,4 +5,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-y += rk_edp.o rk_hdmi.o rk_vop.o rk_lvds.o +obj-y += rk_edp.o rk_hdmi.o rk_vop.o rk_lvds.o ../dw_hdmi.o
drivers/video/rockchip/rk_hdmi.c +24 -733
815 lines not on this page · raw message
drivers/video/rockchip/rk_vop.c +0 -1
@@ -20,7 +20,6 @@#include <asm/arch/cru_rk3288.h> #include <asm/arch/grf_rk3288.h> #include <asm/arch/edp_rk3288.h> -#include <asm/arch/hdmi_rk3288.h> #include <asm/arch/vop_rk3288.h> #include <dm/device-internal.h> #include <dm/uclass-internal.h>
include/dw_hdmi.h new file +486 -0
486 lines not on this page · raw message
Signature · 1 line
2.12.0
PATCH v2 1/7 rockchip: video: Split out HDMI controller code
Quoted 21 lines · Jernej Skrabec
Designware HDMI controller and phy are used in other SoCs as well. Split out platform independent code.
DW HDMI has 8 bit registers but they can be represented as 32 bit registers as well. Add support to select access mode.
EDID reading code use reading by blocks which is not supported by other SoCs in general. Make it more general using byte by byte approach, which is also used in Linux driver.
Finally, not all DW HDMI controllers are accompanied with DW HDMI phy. Support custom phys by making controller code independent from phy code.
Signed-off-by Jernej Skrabec <[email protected]>Tested-by Nickey Yang <[email protected]>Reviewed-by Simon Glass <[email protected]>---
Changes in v2:
- added tested by tag
- added reviewed by tag
Quoted 10 lines
arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h | 456 -------------- drivers/video/dw_hdmi.c | 764 +++++++++++++++++++++++ drivers/video/rockchip/Makefile | 2 +- drivers/video/rockchip/rk_hdmi.c | 757 +--------------------- drivers/video/rockchip/rk_vop.c | 1 - include/dw_hdmi.h | 486 ++++++++++++++ 6 files changed, 1275 insertions(+), 1191 deletions(-) delete mode 100644 arch/arm/include/asm/arch-rockchip/hdmi_rk3288.h create mode 100644 drivers/video/dw_hdmi.c create mode 100644 include/dw_hdmi.h
Tested on firefly-rk3288:
Applied to u-boot-rockchip, thanks!
PATCH v2 2/7 sunxi: video: Split out TCON code
In reply to Jernej SkrabecTCON unit has similar layout and functionality also on newer SoCs. This commit splits out TCON code for easier reuse later.
---
Changes in v2:
- lcdc conversion to use struct display_timing is done in a new patch
- fix issue with lcdc_enable() calls
arch/arm/include/asm/arch-sunxi/display.h | 103 ---------------
arch/arm/include/asm/arch-sunxi/lcdc.h | 128 ++++++++++++++++++
drivers/video/Makefile | 2 +-
drivers/video/sunxi/Makefile | 8 ++
drivers/video/sunxi/lcdc.c | 207 ++++++++++++++++++++++++++++++
drivers/video/{ => sunxi}/sunxi_display.c | 199 +++-------------------------
6 files changed, 362 insertions(+), 285 deletions(-)
create mode 100644 arch/arm/include/asm/arch-sunxi/lcdc.h
create mode 100644 drivers/video/sunxi/Makefile
create mode 100644 drivers/video/sunxi/lcdc.c
rename drivers/video/{ => sunxi}/sunxi_display.c (86%)arch/arm/include/asm/arch-sunxi/display.h +0 -103
@@ -157,52 +157,6 @@ struct sunxi_de_be_reg {u32 output_color_coef[12 ];/* 0x9d0 */ }; -struct sunxi_lcdc_reg { -u32 ctrl;/* 0x00 */ -u32 int0;/* 0x04 */ -u32 int1;/* 0x08 */ -u8 res0[0x04 ];/* 0x0c */ -u32 tcon0_frm_ctrl;/* 0x10 */ -u32 tcon0_frm_seed[6 ];/* 0x14 */ -u32 tcon0_frm_table[4 ];/* 0x2c */ -u8 res1[4 ];/* 0x3c */ -u32 tcon0_ctrl;/* 0x40 */ -u32 tcon0_dclk;/* 0x44 */ -u32 tcon0_timing_active;/* 0x48 */ -u32 tcon0_timing_h;/* 0x4c */ -u32 tcon0_timing_v;/* 0x50 */ -u32 tcon0_timing_sync;/* 0x54 */ -u32 tcon0_hv_intf;/* 0x58 */ -u8 res2[0x04 ];/* 0x5c */ -u32 tcon0_cpu_intf;/* 0x60 */ -u32 tcon0_cpu_wr_dat;/* 0x64 */ -u32 tcon0_cpu_rd_dat0;/* 0x68 */ -u32 tcon0_cpu_rd_dat1;/* 0x6c */ -u32 tcon0_ttl_timing0;/* 0x70 */ -u32 tcon0_ttl_timing1;/* 0x74 */ -u32 tcon0_ttl_timing2;/* 0x78 */ -u32 tcon0_ttl_timing3;/* 0x7c */ -u32 tcon0_ttl_timing4;/* 0x80 */ -u32 tcon0_lvds_intf;/* 0x84 */ -u32 tcon0_io_polarity;/* 0x88 */ -u32 tcon0_io_tristate;/* 0x8c */ -u32 tcon1_ctrl;/* 0x90 */ -u32 tcon1_timing_source;/* 0x94 */ -u32 tcon1_timing_scale;/* 0x98 */ -u32 tcon1_timing_out;/* 0x9c */ -u32 tcon1_timing_h;/* 0xa0 */ -u32 tcon1_timing_v;/* 0xa4 */ -u32 tcon1_timing_sync;/* 0xa8 */ -u8 res3[0x44 ];/* 0xac */ -u32 tcon1_io_polarity;/* 0xf0 */ -u32 tcon1_io_tristate;/* 0xf4 */ -u8 res4[0x108 ];/* 0xf8 */ -u32 mux_ctrl;/* 0x200 */ -u8 res5[0x1c ];/* 0x204 */ -u32 lvds_ana0;/* 0x220 */ -u32 lvds_ana1;/* 0x224 */ -}; -struct sunxi_hdmi_reg {u32 version_id;/* 0x000 */ u32 ctrl;/* 0x004 */
@@ -347,63 +301,6 @@ struct sunxi_tve_reg {#define SUNXI_DE_BE_OUTPUT_COLOR_CTRL_ENABLE 1/* -* LCDC register constants. -*/ -#define SUNXI_LCDC_X (x) (((x) - 1) << 16) -#define SUNXI_LCDC_Y (y) (((y) - 1) << 0) -#define SUNXI_LCDC_TCON_VSYNC_MASK (1 << 24) -#define SUNXI_LCDC_TCON_HSYNC_MASK (1 << 25) -#define SUNXI_LCDC_CTRL_IO_MAP_MASK (1 << 0) -#define SUNXI_LCDC_CTRL_IO_MAP_TCON0 (0 << 0) -#define SUNXI_LCDC_CTRL_IO_MAP_TCON1 (1 << 0) -#define SUNXI_LCDC_CTRL_TCON_ENABLE (1 << 31) -#define SUNXI_LCDC_TCON0_FRM_CTRL_RGB666 ((1 << 31) | (0 << 4)) -#define SUNXI_LCDC_TCON0_FRM_CTRL_RGB565 ((1 << 31) | (5 << 4)) -#define SUNXI_LCDC_TCON0_FRM_SEED 0x11111111 -#define SUNXI_LCDC_TCON0_FRM_TAB0 0x01010000 -#define SUNXI_LCDC_TCON0_FRM_TAB1 0x15151111 -#define SUNXI_LCDC_TCON0_FRM_TAB2 0x57575555 -#define SUNXI_LCDC_TCON0_FRM_TAB3 0x7f7f7777 -#define SUNXI_LCDC_TCON0_CTRL_CLK_DELAY (n) (((n) & 0x1f) << 4) -#define SUNXI_LCDC_TCON0_CTRL_ENABLE (1 << 31) -#define SUNXI_LCDC_TCON0_DCLK_DIV (n) ((n) << 0) -#define SUNXI_LCDC_TCON0_DCLK_ENABLE (0xf << 28) -#define SUNXI_LCDC_TCON0_TIMING_H_BP (n) (((n) - 1) << 0) -#define SUNXI_LCDC_TCON0_TIMING_H_TOTAL (n) (((n) - 1) << 16) -#define SUNXI_LCDC_TCON0_TIMING_V_BP (n) (((n) - 1) << 0) -#define SUNXI_LCDC_TCON0_TIMING_V_TOTAL (n) (((n) * 2) << 16) -#ifdef CONFIG_SUNXI_GEN_SUN6I -#define SUNXI_LCDC_TCON0_LVDS_CLK_SEL_TCON0 (1 << 20) -#else -#define SUNXI_LCDC_TCON0_LVDS_CLK_SEL_TCON0 0/* NA */ -#endif -#define SUNXI_LCDC_TCON0_LVDS_INTF_BITWIDTH (n) ((n) << 26) -#define SUNXI_LCDC_TCON0_LVDS_INTF_ENABLE (1 << 31) -#define SUNXI_LCDC_TCON0_IO_POL_DCLK_PHASE (x) ((x) << 28) -#define SUNXI_LCDC_TCON1_CTRL_CLK_DELAY (n) (((n) & 0x1f) << 4) -#define SUNXI_LCDC_TCON1_CTRL_INTERLACE_ENABLE (1 << 20) -#define SUNXI_LCDC_TCON1_CTRL_ENABLE (1 << 31) -#define SUNXI_LCDC_TCON1_TIMING_H_BP (n) (((n) - 1) << 0) -#define SUNXI_LCDC_TCON1_TIMING_H_TOTAL (n) (((n) - 1) << 16) -#define SUNXI_LCDC_TCON1_TIMING_V_BP (n) (((n) - 1) << 0) -#define SUNXI_LCDC_TCON1_TIMING_V_TOTAL (n) ((n) << 16) -#define SUNXI_LCDC_MUX_CTRL_SRC0_MASK (0xf << 0) -#define SUNXI_LCDC_MUX_CTRL_SRC0 (x) ((x) << 0) -#define SUNXI_LCDC_MUX_CTRL_SRC1_MASK (0xf << 4) -#define SUNXI_LCDC_MUX_CTRL_SRC1 (x) ((x) << 4) -#ifdef CONFIG_SUNXI_GEN_SUN6I -#define SUNXI_LCDC_LVDS_ANA0 0x40040320 -#define SUNXI_LCDC_LVDS_ANA0_EN_MB (1 << 31) -#define SUNXI_LCDC_LVDS_ANA0_DRVC (1 << 24) -#define SUNXI_LCDC_LVDS_ANA0_DRVD (x) ((x) << 20) -#else -#define SUNXI_LCDC_LVDS_ANA0 0x3f310000 -#define SUNXI_LCDC_LVDS_ANA0_UPDATE (1 << 22) -#endif -#define SUNXI_LCDC_LVDS_ANA1_INIT1 (0x1f << 26 | 0x1f << 10) -#define SUNXI_LCDC_LVDS_ANA1_INIT2 (0x1f << 16 | 0x1f << 00) - -/* * HDMI register constants. */ #define SUNXI_HDMI_X (x) (((x) - 1) << 0)
arch/arm/include/asm/arch-sunxi/lcdc.h new file +128 -0
128 lines not on this page · raw message
drivers/video/Makefile +1 -1
@@ -51,7 +51,6 @@ obj-$(CONFIG_VIDEO_MXS) += mxsfb.o videomodes.o obj-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o obj-$(CONFIG_VIDEO_SANDBOX_SDL) += sandbox_sdl.o obj-$(CONFIG_VIDEO_SM501) += sm501.o -obj-$(CONFIG_VIDEO_SUNXI) += sunxi_display.o videomodes.o obj-$(CONFIG_VIDEO_TEGRA20) += tegra.o obj-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o obj-$(CONFIG_VIDEO_VESA) += vesa.o
@@ -64,3 +63,4 @@ obj-${CONFIG_EXYNOS_FB} += exynos/ obj-${CONFIG_VIDEO_ROCKCHIP} += rockchip/ obj-y += bridge/ +obj-y += sunxi/
drivers/video/sunxi/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# +# (C) Copyright 2000-2007 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-$(CONFIG_VIDEO_SUNXI) += sunxi_display.o lcdc.o ../videomodes.o
drivers/video/sunxi/lcdc.c new file +207 -0
207 lines not on this page · raw message
drivers/video/sunxi/sunxi_display.c renamed from drivers/video/sunxi_display.c +18 -181
282 lines not on this page · raw message
Signature · 1 line
2.12.0
PATCH v2 2/7 sunxi: video: Split out TCON code
Quoted 4 lines · Jernej Skrabec
TCON unit has similar layout and functionality also on newer SoCs. This commit splits out TCON code for easier reuse later.
Signed-off-by Jernej Skrabec <[email protected]>
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/69ac7e93/attachment.sig>
PATCH v2 3/7 sunxi: video: Convert lcdc to use struct display_timing
In reply to Jernej SkrabecVideo driver for older Allwinner SoCs uses cfb console framework which in turn uses struct ctfb_res_modes to hold timing informations. However, DM video framework uses different structure - struct display_timing.
It makes more sense to convert lcdc to use new timing structure because all new drivers should use DM video framework and older drivers might be rewritten to use new framework too.
---
Changes in v2:
- new patch
arch/arm/include/asm/arch-sunxi/lcdc.h | 6 ++-- drivers/video/sunxi/lcdc.c | 64 ++++++++++++++++------------------ drivers/video/sunxi/sunxi_display.c | 35 +++++++++++++++++-- 3 files changed, 67 insertions(+), 38 deletions(-)
arch/arm/include/asm/arch-sunxi/lcdc.h +3 -3
@@ -10,7 +10,7 @@ #ifndef _LCDC_H #define _LCDC_H -struct ctfb_res_modes; +#include <fdtdec.h> struct sunxi_lcdc_reg { u32 ctrl; /* 0x00 */
@@ -118,11 +118,11 @@ struct sunxi_lcdc_reg {void lcdc_init (struct sunxi_lcdc_reg *const lcdc);void lcdc_enable (struct sunxi_lcdc_reg *const lcdc,int depth);void lcdc_tcon0_mode_set (struct sunxi_lcdc_reg *const lcdc, -const struct ctfb_res_modes *mode, +const struct display_timing *mode,int clk_div,bool for_ext_vga_dac,int depth,int dclk_phase);void lcdc_tcon1_mode_set (struct sunxi_lcdc_reg *const lcdc, -const struct ctfb_res_modes *mode, +const struct display_timing *mode,bool ext_hvsync,bool is_composite);#endif /* _LCDC_H */
drivers/video/sunxi/lcdc.c +31 -33
131 lines not on this page · raw message
drivers/video/sunxi/sunxi_display.c +33 -2
@@ -721,12 +721,40 @@ static void sunxi_lcdc_backlight_enable(void)gpio_direction_output (pin,PWM_ON ); } +static void sunxi_ctfb_mode_to_display_timing (const struct ctfb_res_modes *mode, +struct display_timing *timing) +{ + timing->pixelclock.typ = mode->pixclock_khz *1000 ; + + timing->hactive.typ = mode->xres; + timing->hfront_porch.typ = mode->right_margin; + timing->hback_porch.typ = mode->left_margin; + timing->hsync_len.typ = mode->hsync_len; + + timing->vactive.typ = mode->yres; + timing->vfront_porch.typ = mode->lower_margin; + timing->vback_porch.typ = mode->upper_margin; + timing->vsync_len.typ = mode->vsync_len; + +if (mode->sync &FB_SYNC_HOR_HIGH_ACT ) + timing->flags |=DISPLAY_FLAGS_HSYNC_HIGH ; +else + timing->flags |=DISPLAY_FLAGS_HSYNC_LOW ; +if (mode->sync &FB_SYNC_VERT_HIGH_ACT ) + timing->flags |=DISPLAY_FLAGS_VSYNC_HIGH ; +else + timing->flags |=DISPLAY_FLAGS_VSYNC_LOW ; +if (mode->vmode ==FB_VMODE_INTERLACED ) + timing->flags |=DISPLAY_FLAGS_INTERLACED ; +} +static void sunxi_lcdc_tcon0_mode_set (const struct ctfb_res_modes *mode,bool for_ext_vga_dac) {struct sunxi_lcdc_reg *const lcdc = (struct sunxi_lcdc_reg *)SUNXI_LCD0_BASE ;int clk_div, clk_double, pin; +struct display_timing timing;#if definedCONFIG_MACH_SUN8I && definedCONFIG_VIDEO_LCD_IF_LVDS for (pin =SUNXI_GPD (18 ); pin <=SUNXI_GPD (27 ); pin++) {
@@ -746,7 +774,8 @@ static void sunxi_lcdc_tcon0_mode_set(const struct ctfb_res_modes *mode,sunxi_lcdc_pll_set (0 , mode->pixclock_khz, &clk_div, &clk_double); -lcdc_tcon0_mode_set (lcdc, mode, clk_div, for_ext_vga_dac, +sunxi_ctfb_mode_to_display_timing (mode, &timing); +lcdc_tcon0_mode_set (lcdc, &timing, clk_div, for_ext_vga_dac, sunxi_display.depth,CONFIG_VIDEO_LCD_DCLK_PHASE ); }
@@ -757,8 +786,10 @@ static void sunxi_lcdc_tcon1_mode_set(const struct ctfb_res_modes *mode, {struct sunxi_lcdc_reg *const lcdc = (struct sunxi_lcdc_reg *)SUNXI_LCD0_BASE ; +struct display_timing timing; -lcdc_tcon1_mode_set (lcdc, mode, use_portd_hvsync, +sunxi_ctfb_mode_to_display_timing (mode, &timing); +lcdc_tcon1_mode_set (lcdc, &timing, use_portd_hvsync,sunxi_is_composite ());if (use_portd_hvsync) {
Signature · 1 line
2.12.0
PATCH v2 3/7 sunxi: video: Convert lcdc to use struct display_timing
Quoted 9 lines · Jernej Skrabec
Video driver for older Allwinner SoCs uses cfb console framework which in turn uses struct
ctfb_res_modesto hold timing informations. However, DM video framework uses different structure - structdisplay_timing.It makes more sense to convert lcdc to use new timing structure because all new drivers should use DM video framework and older drivers might be rewritten to use new framework too.
Signed-off-by Jernej Skrabec <[email protected]>
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/c7fe77d9/attachment.sig>
PATCH v2 3/7 sunxi: video: Convert lcdc to use struct display_timing
In reply to Jernej SkrabecQuoted 9 lines · Jernej Skrabec
Video driver for older Allwinner SoCs uses cfb console framework which in turn uses struct
ctfb_res_modesto hold timing informations. However, DM video framework uses different structure - structdisplay_timing.It makes more sense to convert lcdc to use new timing structure because all new drivers should use DM video framework and older drivers might be rewritten to use new framework too.
Signed-off-by Jernej Skrabec <[email protected]>
Quoted 8 lines
---
Changes in v2:
- new patcharch/arm/include/asm/arch-sunxi/lcdc.h | 6 ++-- drivers/video/sunxi/lcdc.c | 64 ++++++++++++++++------------------ drivers/video/sunxi/sunxi_display.c | 35 +++++++++++++++++-- 3 files changed, 67 insertions(+), 38 deletions(-)
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
In reply to Jernej SkrabecThis is needed for HDMI, which will be added later.
---
Changes in v2:
- add reviewed by tag
- constant style fix
arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 54 +++++++++++++++++++++++++++ arch/arm/mach-sunxi/clock_sun6i.c | 40 +++++++++++++++++++- drivers/video/sunxi/lcdc.c | 4 ++ include/configs/sun50i.h | 2 + include/configs/sun8i.h | 4 ++ scripts/config_whitelist.txt | 1 + 6 files changed, 104 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-sunxi/clock_sun6i.h +54 -0
@@ -67,13 +67,22 @@ struct sunxi_ccm_reg {u32 dram_pll_cfg;/* 0xf8 PLL_DDR cfg register, A33 only */ u32 mbus_reset;/* 0xfc MBUS reset control, A33 only */ u32 dram_clk_gate;/* 0x100 DRAM module gating */ +#ifdef CONFIG_SUNXI_DE2 +u32 de_clk_cfg;/* 0x104 DE module clock */ +#else u32 be0_clk_cfg;/* 0x104 BE0 module clock */ +#endif u32 be1_clk_cfg;/* 0x108 BE1 module clock */ u32 fe0_clk_cfg;/* 0x10c FE0 module clock */ u32 fe1_clk_cfg;/* 0x110 FE1 module clock */ u32 mp_clk_cfg;/* 0x114 MP module clock */ +#ifdef CONFIG_SUNXI_DE2 +u32 lcd0_clk_cfg;/* 0x118 LCD0 module clock */ +u32 lcd1_clk_cfg;/* 0x11c LCD1 module clock */ +#else u32 lcd0_ch0_clk_cfg;/* 0x118 LCD0 CH0 module clock */ u32 lcd1_ch0_clk_cfg;/* 0x11c LCD1 CH0 module clock */ +#endif u32 reserved14[3 ];u32 lcd0_ch1_clk_cfg;/* 0x12c LCD0 CH1 module clock */ u32 lcd1_ch1_clk_cfg;/* 0x130 LCD1 CH1 module clock */
@@ -85,7 +94,11 @@ struct sunxi_ccm_reg {u32 dmic_clk_cfg;/* 0x148 Digital Mic module clock*/ u32 reserved15;u32 hdmi_clk_cfg;/* 0x150 HDMI module clock */ +#ifdef CONFIG_SUNXI_DE2 +u32 hdmi_slow_clk_cfg;/* 0x154 HDMI slow module clock */ +#else u32 ps_clk_cfg;/* 0x154 PS module clock */ +#endif u32 mtc_clk_cfg;/* 0x158 MTC module clock */ u32 mbus0_clk_cfg;/* 0x15c MBUS0 module clock */ u32 mbus1_clk_cfg;/* 0x160 MBUS1 module clock */
@@ -193,6 +206,7 @@ struct sunxi_ccm_reg {#define CCM_PLL3_CTRL_N_MASK (0x7f << CCM_PLL3_CTRL_N_SHIFT)#define CCM_PLL3_CTRL_N (n) ((((n) - 1) & 0x7f) << 8)#define CCM_PLL3_CTRL_INTEGER_MODE (0x1 << 24) +#define CCM_PLL3_CTRL_LOCK (0x1 << 28)#define CCM_PLL3_CTRL_EN (0x1 << 31)#define CCM_PLL5_CTRL_M (n) ((((n) - 1) & 0x3) << 0)
@@ -222,6 +236,16 @@ struct sunxi_ccm_reg {#define CCM_MIPI_PLL_CTRL_LDO_EN (0x3 << 22)#define CCM_MIPI_PLL_CTRL_EN (0x1 << 31) +#define CCM_PLL10_CTRL_M_SHIFT 0 +#define CCM_PLL10_CTRL_M_MASK (0xf << CCM_PLL10_CTRL_M_SHIFT) +#define CCM_PLL10_CTRL_M (n) ((((n) - 1) & 0xf) << 0) +#define CCM_PLL10_CTRL_N_SHIFT 8 +#define CCM_PLL10_CTRL_N_MASK (0x7f << CCM_PLL10_CTRL_N_SHIFT) +#define CCM_PLL10_CTRL_N (n) ((((n) - 1) & 0x7f) << 8) +#define CCM_PLL10_CTRL_INTEGER_MODE (0x1 << 24) +#define CCM_PLL10_CTRL_LOCK (0x1 << 28) +#define CCM_PLL10_CTRL_EN (0x1 << 31) +#define CCM_PLL11_CTRL_N (n) ((((n) - 1) & 0x3f) << 8)#define CCM_PLL11_CTRL_SIGMA_DELTA_EN (0x1 << 24)#define CCM_PLL11_CTRL_UPD (0x1 << 30)
@@ -273,9 +297,15 @@ struct sunxi_ccm_reg {#define AHB_GATE_OFFSET_DRC0 25#define AHB_GATE_OFFSET_DE_FE0 14#define AHB_GATE_OFFSET_DE_BE0 12 +#define AHB_GATE_OFFSET_DE 12#define AHB_GATE_OFFSET_HDMI 11 +#ifndef CONFIG_SUNXI_DE2 #define AHB_GATE_OFFSET_LCD1 5#define AHB_GATE_OFFSET_LCD0 4 +#else +#define AHB_GATE_OFFSET_LCD1 4 +#define AHB_GATE_OFFSET_LCD0 3 +#endif #define CCM_MMC_CTRL_M (x) ((x) - 1)#define CCM_MMC_CTRL_OCLK_DLY (x) ((x) << 8)
@@ -357,6 +387,12 @@ struct sunxi_ccm_reg {#define CCM_LCD_CH1_CTRL_PLL7_2X (3 << 24)#define CCM_LCD_CH1_CTRL_GATE (0x1 << 31) +#define CCM_LCD0_CTRL_GATE (0x1 << 31) +#define CCM_LCD0_CTRL_M (n) ((((n) - 1) & 0xf) << 0) + +#define CCM_LCD1_CTRL_GATE (0x1 << 31) +#define CCM_LCD1_CTRL_M (n) ((((n) - 1) & 0xf) << 0) +#define CCM_HDMI_CTRL_M (n) ((((n) - 1) & 0xf) << 0)#define CCM_HDMI_CTRL_PLL_MASK (3 << 24)#define CCM_HDMI_CTRL_PLL3 (0 << 24)
@@ -366,6 +402,8 @@ struct sunxi_ccm_reg {#define CCM_HDMI_CTRL_DDC_GATE (0x1 << 30)#define CCM_HDMI_CTRL_GATE (0x1 << 31) +#define CCM_HDMI_SLOW_CTRL_DDC_GATE (1 << 31) +#if defined(CONFIG_MACH_SUN50I )#define MBUS_CLK_DEFAULT 0x81000002/* PLL6x2 / 3 */ #elif defined(CONFIG_MACH_SUN8I )
@@ -393,9 +431,16 @@ struct sunxi_ccm_reg {#define AHB_RESET_OFFSET_DRC0 25#define AHB_RESET_OFFSET_DE_FE0 14#define AHB_RESET_OFFSET_DE_BE0 12 +#define AHB_RESET_OFFSET_DE 12#define AHB_RESET_OFFSET_HDMI 11 +#define AHB_RESET_OFFSET_HDMI2 10 +#ifndef CONFIG_SUNXI_DE2 #define AHB_RESET_OFFSET_LCD1 5#define AHB_RESET_OFFSET_LCD0 4 +#else +#define AHB_RESET_OFFSET_LCD1 4 +#define AHB_RESET_OFFSET_LCD0 3 +#endif /* ahb_reset2 offsets */ #define AHB_RESET_OFFSET_EPHY 2
@@ -418,6 +463,13 @@ struct sunxi_ccm_reg {#define CCM_DE_CTRL_PLL10 (5 << 24)#define CCM_DE_CTRL_GATE (1 << 31) +/* CCM bits common to all Display Engine 2.0 clock ctrl regs */ +#define CCM_DE2_CTRL_M (n) ((((n) - 1) & 0xf) << 0) +#define CCM_DE2_CTRL_PLL_MASK (3 << 24) +#define CCM_DE2_CTRL_PLL6_2X (0 << 24) +#define CCM_DE2_CTRL_PLL10 (1 << 24) +#define CCM_DE2_CTRL_GATE (0x1 << 31) +/* CCU security switch, H3 only */ #define CCM_SEC_SWITCH_MBUS_NONSEC (1 << 2)#define CCM_SEC_SWITCH_BUS_NONSEC (1 << 1)
@@ -426,7 +478,9 @@ struct sunxi_ccm_reg {#ifndef __ASSEMBLY__void clock_set_pll1 (unsigned int hz);void clock_set_pll3 (unsigned int hz); +void clock_set_pll3_factors (int m,int n);void clock_set_pll5 (unsigned int clk,bool sigma_delta_enable); +void clock_set_pll10 (unsigned int hz);void clock_set_pll11 (unsigned int clk,bool sigma_delta_enable);void clock_set_mipi_pll (unsigned int hz);unsigned int clock_get_pll3 (void );
arch/arm/mach-sunxi/clock_sun6i.c +39 -1
@@ -35,7 +35,7 @@ void clock_init_safe(void)clrbits_le32 (&prcm->pll_ctrl1,PRCM_PLL_CTRL_LDO_KEY_MASK );#endif -#ifdef CONFIG_MACH_SUN8I_R40 +#if defined(CONFIG_MACH_SUN8I_R40 ) || defined(CONFIG_MACH_SUN50I )/* Set PLL lock enable bits and switch to old lock mode */ writel (GENMASK (12 ,0 ), &ccm->pll_lock_ctrl);#endif
@@ -150,6 +150,22 @@ void clock_set_pll3(unsigned int clk) &ccm->pll3_cfg); } +#ifdef CONFIG_SUNXI_DE2 +void clock_set_pll3_factors (int m,int n) +{ +struct sunxi_ccm_reg *const ccm = + (struct sunxi_ccm_reg *)SUNXI_CCM_BASE ; + +/* PLL3 rate = 24000000 * n / m */ +writel (CCM_PLL3_CTRL_EN |CCM_PLL3_CTRL_INTEGER_MODE | +CCM_PLL3_CTRL_N (n) |CCM_PLL3_CTRL_M (m), + &ccm->pll3_cfg); + +while (!(readl (&ccm->pll3_cfg) &CCM_PLL3_CTRL_LOCK )) + ; +} +#endif +void clock_set_pll5 (unsigned int clk,bool sigma_delta_enable) { struct sunxi_ccm_reg * const ccm =
@@ -222,6 +238,28 @@ done: }#endif +#ifdef CONFIG_SUNXI_DE2 +void clock_set_pll10 (unsigned int clk) +{ +struct sunxi_ccm_reg *const ccm = + (struct sunxi_ccm_reg *)SUNXI_CCM_BASE ; +const int m =2 ;/* 12 MHz steps */ + +if (clk ==0 ) { +clrbits_le32 (&ccm->pll10_cfg,CCM_PLL10_CTRL_EN ); +return ; + } + +/* PLL10 rate = 24000000 * n / m */ +writel (CCM_PLL10_CTRL_EN |CCM_PLL10_CTRL_INTEGER_MODE | +CCM_PLL10_CTRL_N (clk / (24000000 / m)) |CCM_PLL10_CTRL_M (m), + &ccm->pll10_cfg); + +while (!(readl (&ccm->pll10_cfg) &CCM_PLL10_CTRL_LOCK )) + ; +} +#endif +#if defined(CONFIG_MACH_SUN8I_A33 ) || defined(CONFIG_MACH_SUN50I )void clock_set_pll11 (unsigned int clk,bool sigma_delta_enable) {
drivers/video/sunxi/lcdc.c +4 -0
@@ -74,9 +74,11 @@ void lcdc_tcon0_mode_set(struct sunxi_lcdc_reg * const lcdc, {int bp, clk_delay, total, val; +#ifndef CONFIG_SUNXI_DE2 /* Use tcon0 */ clrsetbits_le32 (&lcdc->ctrl,SUNXI_LCDC_CTRL_IO_MAP_MASK ,SUNXI_LCDC_CTRL_IO_MAP_TCON0 ); +#endif clk_delay =lcdc_get_clk_delay (mode,0 ); writel(SUNXI_LCDC_TCON0_CTRL_ENABLE |
@@ -149,9 +151,11 @@ void lcdc_tcon1_mode_set(struct sunxi_lcdc_reg * const lcdc, {int bp, clk_delay, total, val, yres; +#ifndef CONFIG_SUNXI_DE2 /* Use tcon1 */ clrsetbits_le32 (&lcdc->ctrl,SUNXI_LCDC_CTRL_IO_MAP_MASK ,SUNXI_LCDC_CTRL_IO_MAP_TCON1 ); +#endif clk_delay =lcdc_get_clk_delay (mode,1 ); writel(SUNXI_LCDC_TCON1_CTRL_ENABLE |
include/configs/sun50i.h +2 -0
@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4 -0
@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/* * Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1 -0
@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2 CONFIG_SUNXI_EMAC CONFIG_SUNXI_GMAC CONFIG_SUNXI_GPIO
Signature · 1 line
2.12.0
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Hi,
Quoted 33 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */ include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/* * Include common sunxi configuration where most the settings are */ scripts/config_whitelist.txt +0
-0
scripts/config_whitelist.txt CONFIG_STV0991_HZ_CLOCK · line 3108
Quoted 7 lines
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2 CONFIG_SUNXI_EMAC CONFIG_SUNXI_GMAC CONFIG_SUNXI_GPIO
This should be a Kconfig option.
Looks good otherwise, thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/d7401740/attachment.sig>
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 50 lines
Hi,
Quoted 47 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +0
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI
Quoted 8 lines
Quoted 5 lines
scripts/config_whitelist.txt +1
-0+CONFIG_SUNXI_DE2
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.
So hidden option in board/sunxi/Kconfig will probably be the best then?
VIDEO_DE2 option added in patch 5 should depend on that symbol then.
Regards,
Jernej
Quoted 7 lines
Looks good otherwise, thanks!
Maxime--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Quoted 55 lines · Jernej Å krabec
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 52 lines
Hi,
Quoted 49 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.So hidden option in board/sunxi/Kconfig will probably be the best then?
Yes, I guess, but I'm not entirely sure why you need two different options there?
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170322/1546e3b3/attachment.sig>
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Hi,
Dne sreda, 22. marec 2017 ob 08:45:48 CET je Maxime Ripard napisal(a):
Quoted 63 lines · Jernej Å krabec
Quoted 62 lines
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 58 lines
Hi,
Quoted 50 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2Quoted 3 lines
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.
Quoted 5 lines
Quoted 2 lines
So hidden option in board/sunxi/Kconfig will probably be the best then?
Yes, I guess, but I'm not entirely sure why you need two different options there?
I used define for CONFIG_SUNXI_DE2 here because SoC has or has not DE2 IP block and that is not a choice. Option in patch 5 is configurable and gives opportunity to build video driver or skip it, whithout influencing clock structure.
I could make only one option, but then it would have to be configurable, which doesn't really make sense from patch 4 perspective, because, as I already stated before, this is property of the SoC.
Which solution do you prefer? One option, define and option (as it is now) or two options?
Frankly, none of them is ideal. Best solution would be to convert clocks to use driver model framework.
Regards,
Jernej
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Quoted 81 lines · Jernej Škrabec
Hi,
Dne sreda, 22. marec 2017 ob 08:45:48 CET je Maxime Ripard napisal(a):
Quoted 63 lines · Jernej Škrabec
Quoted 62 lines
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 58 lines
Hi,
Quoted 50 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2Quoted 3 lines
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.Quoted 5 lines
Quoted 2 lines
So hidden option in board/sunxi/Kconfig will probably be the best then?
Yes, I guess, but I'm not entirely sure why you need two different options there?
I used define for
CONFIG_SUNXI_DE2here because SoC has or has not DE2 IP block and that is not a choice. Option in patch 5 is configurable and gives opportunity to build video driver or skip it, whithout influencing clock structure.I could make only one option, but then it would have to be configurable, which doesn't really make sense from patch 4 perspective, because, as I already stated before, this is property of the SoC.
Quoted 5 lines
Which solution do you prefer? One option, define and option (as it is now) or two options?
Frankly, none of them is ideal. Best solution would be to convert clocks to use driver model framework.
I guess you could make a hidden Kconfig option selected by the relevant MACH_ options.
As a general basis, we move away from the old-style config options, so adding any new !Kconfig options isn't really an option.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170324/d98917be/attachment.sig>
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Dne petek, 24. marec 2017 ob 16:53:07 CET je Maxime Ripard napisal(a):
Quoted 89 lines · Jernej Škrabec
Quoted 81 lines
Hi,
Dne sreda, 22. marec 2017 ob 08:45:48 CET je Maxime Ripard napisal(a):
Quoted 63 lines · Jernej Škrabec
Quoted 62 lines
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 58 lines
Hi,
Quoted 50 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2Quoted 3 lines
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.Quoted 5 lines
Quoted 2 lines
So hidden option in board/sunxi/Kconfig will probably be the best then?
Yes, I guess, but I'm not entirely sure why you need two different options there?
I used define for
CONFIG_SUNXI_DE2here because SoC has or has not DE2 IP block and that is not a choice. Option in patch 5 is configurable and gives opportunity to build video driver or skip it, whithout influencing clock structure.I could make only one option, but then it would have to be configurable, which doesn't really make sense from patch 4 perspective, because, as I already stated before, this is property of the SoC.
Quoted 6 lines
Which solution do you prefer? One option, define and option (as it is now) or two options?
Frankly, none of them is ideal. Best solution would be to convert clocks to
use driver model framework.
Quoted 5 lines
I guess you could make a hidden
Kconfigoption selected by the relevantMACH_options.As a general basis, we move away from the old-style config options, so adding any new !Kconfig options isn't really an option.
Ok.
Do you mind if I switch from 16 BPP to 32 BPP in patch 5? efifb linux driver doesn't work well with 16 BPP.
Regards,
Jernej
PATCH v2 4/7 sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
Quoted 93 lines · Jernej Škrabec
Dne petek, 24. marec 2017 ob 16:53:07 CET je Maxime Ripard napisal(a):
Quoted 92 lines · Jernej Škrabec
Quoted 81 lines
Hi,
Dne sreda, 22. marec 2017 ob 08:45:48 CET je Maxime Ripard napisal(a):
Quoted 63 lines · Jernej Škrabec
Quoted 62 lines
Hi,
Dne torek, 21. marec 2017 ob 20:34:33 CET je Maxime Ripard napisal(a):
Quoted 58 lines
Hi,
Quoted 50 lines · Jernej Skrabec
include/configs/sun50i.h +2
-0@@ -21,6 +21,8 @@#define GICD_BASE 0x1c81000#define GICC_BASE 0x1c82000 +#define CONFIG_SUNXI_DE2 +/* * Include common sunxi configuration where most the settings are */
include/configs/sun8i.h +4
-0@@ -25,6 +25,10 @@#define CONFIG_SUNXI_USB_PHYS 2#endif +#ifdef CONFIG_MACH_SUNXI_H3_H5 +#define CONFIG_SUNXI_DE2 +#endif +/*
* Include common sunxi configuration where most the settings are */
scripts/config_whitelist.txt +1
-0@@ -3102,6 +3102,7 @@ CONFIG_STV0991_HZ_CLOCK CONFIG_ST_SMI CONFIG_SUN4 CONFIG_SUNXI_AHCI +CONFIG_SUNXI_DE2Quoted 3 lines
CONFIG_SUNXI_EMAC
CONFIG_SUNXI_GMAC
CONFIG_SUNXI_GPIOThis should be a
Kconfigoption.Quoted 5 lines
Quoted 2 lines
So hidden option in board/sunxi/Kconfig will probably be the best then?
Yes, I guess, but I'm not entirely sure why you need two different options there?
I used define for
CONFIG_SUNXI_DE2here because SoC has or has not DE2 IP block and that is not a choice. Option in patch 5 is configurable and gives opportunity to build video driver or skip it, whithout influencing clock structure.I could make only one option, but then it would have to be configurable, which doesn't really make sense from patch 4 perspective, because, as I already stated before, this is property of the SoC.
Quoted 6 lines
Which solution do you prefer? One option, define and option (as it is now) or two options?
Frankly, none of them is ideal. Best solution would be to convert clocks to
use driver model framework.I guess you could make a hidden
Kconfigoption selected by the relevantMACH_options.
Quoted 7 lines
Quoted 2 lines
As a general basis, we move away from the old-style config options, so adding any new !Kconfig options isn't really an option.
Ok.
Do you mind if I switch from 16 BPP to 32 BPP in patch 5? efifb linux driver doesn't work well with 16 BPP.
Not at all, I think it's also what we use in the previous SoCs.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170327/524df298/attachment.sig>
PATCH v2 5/7 sunxi: video: Add A64/H3/H5 HDMI driver
In reply to Jernej SkrabecThis commit adds support for HDMI output.
---
Changes in v2:
- add reviewed by tag
arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 8 + arch/arm/include/asm/arch-sunxi/display2.h | 124 +++++++++ board/sunxi/Kconfig | 10 + drivers/video/sunxi/Makefile | 1 + drivers/video/sunxi/sunxi_de2.c | 258 ++++++++++++++++++ drivers/video/sunxi/sunxi_dw_hdmi.c | 389 ++++++++++++++++++++++++++++ include/configs/sunxi-common.h | 5 + 7 files changed, 795 insertions(+) create mode 100644 arch/arm/include/asm/arch-sunxi/display2.h create mode 100644 drivers/video/sunxi/sunxi_de2.c create mode 100644 drivers/video/sunxi/sunxi_dw_hdmi.c
arch/arm/include/asm/arch-sunxi/cpu_sun4i.h +8 -0
@@ -18,6 +18,8 @@#define SUNXI_SRAM_D_BASE 0x00010000/* 4 kiB */ #define SUNXI_SRAM_B_BASE 0x00020000/* 64 kiB (secure) */ +#define SUNXI_DE2_BASE 0x01000000 +#ifdef CONFIG_MACH_SUN8I_A83T #define SUNXI_CPUCFG_BASE 0x01700000#endif
@@ -46,7 +48,9 @@#define SUNXI_USB1_BASE 0x01c14000#endif #define SUNXI_SS_BASE 0x01c15000 +#if !defined(CONFIG_MACH_SUNXI_H3_H5 ) && !defined(CONFIG_MACH_SUN50I )#define SUNXI_HDMI_BASE 0x01c16000 +#endif #define SUNXI_SPI2_BASE 0x01c17000#define SUNXI_SATA_BASE 0x01c18000#ifdef CONFIG_SUNXI_GEN_SUN4I
@@ -164,6 +168,10 @@ defined(CONFIG_MACH_SUN50I)#define SUNXI_MP_BASE 0x01e80000#define SUNXI_AVG_BASE 0x01ea0000 +#if defined(CONFIG_MACH_SUNXI_H3_H5 ) || defined(CONFIG_MACH_SUN50I ) +#define SUNXI_HDMI_BASE 0x01ee0000 +#endif +#define SUNXI_RTC_BASE 0x01f00000#define SUNXI_PRCM_BASE 0x01f01400
arch/arm/include/asm/arch-sunxi/display2.h new file +124 -0
124 lines not on this page · raw message
board/sunxi/Kconfig +10 -0
@@ -704,6 +704,16 @@ config VIDEO_LCD_TL059WV5C0 endchoice +config VIDEO_DE2 + bool"Display Engine 2 video driver" + depends on MACH_SUNXI_H3_H5 || MACH_SUN50I + select DM_VIDEO + select DISPLAY + default y + ---help--- + Say y here if you want to build DE2 video driver which is present on + newer SoCs. Currently only HDMI output is supported. + config GMAC_TX_DELAY int "GMAC Transmit Clock Delay Chain"
drivers/video/sunxi/Makefile +1 -0
@@ -6,3 +6,4 @@ # obj-$(CONFIG_VIDEO_SUNXI) += sunxi_display.o lcdc.o ../videomodes.o +obj-$(CONFIG_VIDEO_DE2) += sunxi_de2.o sunxi_dw_hdmi.o lcdc.o ../dw_hdmi.o
drivers/video/sunxi/sunxi_de2.c new file +258 -0
258 lines not on this page · raw message
drivers/video/sunxi/sunxi_dw_hdmi.c new file +389 -0
389 lines not on this page · raw message
include/configs/sunxi-common.h +5 -0
@@ -463,6 +463,11 @@ extern int soft_i2c_gpio_scl;#define CONSOLE_STDOUT_SETTINGS \ "stdout=serial,vga\0" \ "stderr=serial,vga\0" +#elif CONFIG_DM_VIDEO +#define CONFIG_SYS_WHITE_ON_BLACK +#define CONSOLE_STDOUT_SETTINGS \ + "stdout=serial,vidconsole\0" \ + "stderr=serial,vidconsole\0"#else #define CONSOLE_STDOUT_SETTINGS \ "stdout=serial\0" \
Signature · 1 line
2.12.0
PATCH v2 5/7 sunxi: video: Add A64/H3/H5 HDMI driver
Quoted 4 lines · Jernej Skrabec
This commit adds support for HDMI output.
Signed-off-by Jernej Skrabec <[email protected]>Reviewed-by Simon Glass <[email protected]>
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/4090ae11/attachment.sig>
PATCH v2 6/7 sunxi: Disable DE2 video driver where not needed
In reply to Jernej SkrabecBecause DE2 driver is enabled by default, it is nice to disable it on all boards which don't have any video output. List of such boards is also much shorter.
---
Changes in v2:
- invert logic (disable instead of enable)
configs/nanopi_neo_air_defconfig | 1 + configs/nanopi_neo_defconfig | 1 + configs/orangepi_zero_defconfig | 1 + 3 files changed, 3 insertions(+)
configs/nanopi_neo_air_defconfig +1 -0
@@ -15,3 +15,4 @@ CONFIG_SPL=y # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set CONFIG_USB_EHCI_HCD=y +# CONFIG_VIDEO_DE2 is not set
configs/nanopi_neo_defconfig +1 -0
@@ -16,3 +16,4 @@ CONFIG_SPL=y # CONFIG_SPL_EFI_PARTITION is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y +# CONFIG_VIDEO_DE2 is not set
configs/orangepi_zero_defconfig +1 -0
@@ -15,3 +15,4 @@ CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SPL_SPI_SUNXI=y CONFIG_SPL_SPI_FLASH_SUPPORT=y +# CONFIG_VIDEO_DE2 is not set
Signature · 1 line
2.12.0
PATCH v2 6/7 sunxi: Disable DE2 video driver where not needed
Quoted 5 lines · Jernej Skrabec
Because DE2 driver is enabled by default, it is nice to disable it on all boards which don't have any video output. List of such boards is also much shorter.
Signed-off-by Jernej Skrabec <[email protected]>
Thanks,
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/9f84e878/attachment.sig>
PATCH v2 7/7 sunxi: add AXP803 support
In reply to Jernej SkrabecFrom: Icenowy Zheng <[email protected]>
The A64 uses the AXP803 as its PMIC.
---
arch/arm/mach-sunxi/Makefile | 3 + arch/arm/mach-sunxi/pmic_bus.c | 6 +- arch/arm/mach-sunxi/rsb.c | 2 +- board/sunxi/board.c | 31 ++--- drivers/power/Kconfig | 87 ++++++++------ drivers/power/Makefile | 1 + drivers/power/axp803.c | 256 +++++++++++++++++++++++++++++++++++++++++ drivers/power/axp818.c | 2 +- include/axp803.h | 73 ++++++++++++ include/axp_pmic.h | 3 + 10 files changed, 414 insertions(+), 50 deletions(-) create mode 100644 drivers/power/axp803.c create mode 100644 include/axp803.h
arch/arm/mach-sunxi/Makefile +3 -0
@@ -19,9 +19,11 @@ endif obj-$(CONFIG_MACH_SUN6I) += prcm.o obj-$(CONFIG_MACH_SUN8I) += prcm.o obj-$(CONFIG_MACH_SUN9I) += prcm.o +obj-$(CONFIG_MACH_SUN50I) += prcm.o obj-$(CONFIG_MACH_SUN6I) += p2wi.o obj-$(CONFIG_MACH_SUN8I) += rsb.o obj-$(CONFIG_MACH_SUN9I) += rsb.o +obj-$(CONFIG_MACH_SUN50I) += rsb.o obj-$(CONFIG_MACH_SUN4I) += clock_sun4i.o obj-$(CONFIG_MACH_SUN5I) += clock_sun4i.o obj-$(CONFIG_MACH_SUN6I) += clock_sun6i.o
@@ -37,6 +39,7 @@ obj-$(CONFIG_MACH_SUN9I) += clock_sun9i.o gtbus_sun9i.o obj-$(CONFIG_AXP152_POWER) += pmic_bus.o obj-$(CONFIG_AXP209_POWER) += pmic_bus.o obj-$(CONFIG_AXP221_POWER) += pmic_bus.o +obj-$(CONFIG_AXP803_POWER) += pmic_bus.o obj-$(CONFIG_AXP809_POWER) += pmic_bus.o obj-$(CONFIG_AXP818_POWER) += pmic_bus.o
arch/arm/mach-sunxi/pmic_bus.c +3 -3
@@ -36,7 +36,7 @@ int pmic_bus_init(void)if (!needs_init)return 0 ; -#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER +#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER # ifdef CONFIG_MACH_SUN6I p2wi_init (); ret = p2wi_change_to_p2wi_mode(AXP221_CHIP_ADDR, AXP221_CTRL_ADDR,
@@ -62,7 +62,7 @@ int pmic_bus_read(u8 reg, u8 *data)return i2c_read (AXP152_I2C_ADDR , reg,1 , data,1 );#elif definedCONFIG_AXP209_POWER return i2c_read (AXP209_I2C_ADDR , reg,1 , data,1 ); -#elif definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER +#elif definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER # ifdef CONFIG_MACH_SUN6I return p2wi_read (reg, data);# else
@@ -77,7 +77,7 @@ int pmic_bus_write(u8 reg, u8 data)return i2c_write (AXP152_I2C_ADDR , reg,1 , &data,1 );#elif definedCONFIG_AXP209_POWER return i2c_write (AXP209_I2C_ADDR , reg,1 , &data,1 ); -#elif definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER +#elif definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER # ifdef CONFIG_MACH_SUN6I return p2wi_write (reg, data);# else
arch/arm/mach-sunxi/rsb.c +1 -1
@@ -20,7 +20,7 @@ static int rsb_set_device_mode(void);static void rsb_cfg_io (void ) { -#ifdef CONFIG_MACH_SUN8I +#if definedCONFIG_MACH_SUN8I || definedCONFIG_MACH_SUN50I sunxi_gpio_set_cfgpin (SUNXI_GPL (0 ),SUN8I_GPL_R_RSB );sunxi_gpio_set_cfgpin (SUNXI_GPL (1 ),SUN8I_GPL_R_RSB );sunxi_gpio_set_pull (SUNXI_GPL (0 ),1 );
board/sunxi/board.c +18 -13
@@ -487,26 +487,27 @@ void sunxi_board_init(void)#endif #if definedCONFIG_AXP152_POWER || definedCONFIG_AXP209_POWER || \ - definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || \ - definedCONFIG_AXP818_POWER + definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || \ + definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER power_failed =axp_init (); -#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || \ - definedCONFIG_AXP818_POWER +#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || \ + definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER power_failed |=axp_set_dcdc1 (CONFIG_AXP_DCDC1_VOLT );#endif power_failed |=axp_set_dcdc2 (CONFIG_AXP_DCDC2_VOLT ); power_failed |=axp_set_dcdc3 (CONFIG_AXP_DCDC3_VOLT ); -#if !defined(CONFIG_AXP209_POWER ) && !defined(CONFIG_AXP818_POWER ) +#if !defined(CONFIG_AXP209_POWER ) && !defined(CONFIG_AXP803_POWER ) && \ + !defined(CONFIG_AXP818_POWER ) power_failed |=axp_set_dcdc4 (CONFIG_AXP_DCDC4_VOLT );#endif -#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || \ - definedCONFIG_AXP818_POWER +#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || \ + definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER power_failed |=axp_set_dcdc5 (CONFIG_AXP_DCDC5_VOLT );#endif -#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP809_POWER || \ - definedCONFIG_AXP818_POWER +#if definedCONFIG_AXP221_POWER || definedCONFIG_AXP803_POWER || \ + definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER power_failed |=axp_set_aldo1 (CONFIG_AXP_ALDO1_VOLT );#endif power_failed |=axp_set_aldo2 (CONFIG_AXP_ALDO2_VOLT );
@@ -517,8 +518,8 @@ void sunxi_board_init(void) power_failed |=axp_set_aldo4 (CONFIG_AXP_ALDO4_VOLT );#endif -#if defined(CONFIG_AXP221_POWER ) || defined(CONFIG_AXP809_POWER ) || \ - defined(CONFIG_AXP818_POWER ) +#if defined(CONFIG_AXP221_POWER ) || defined(CONFIG_AXP803_POWER ) || \ + defined(CONFIG_AXP809_POWER ) || defined(CONFIG_AXP818_POWER ) power_failed |=axp_set_dldo (1 ,CONFIG_AXP_DLDO1_VOLT ); power_failed |=axp_set_dldo (2 ,CONFIG_AXP_DLDO2_VOLT );#if !definedCONFIG_AXP809_POWER
@@ -530,13 +531,17 @@ void sunxi_board_init(void) power_failed |=axp_set_eldo (3 ,CONFIG_AXP_ELDO3_VOLT );#endif -#ifdef CONFIG_AXP818_POWER +#if definedCONFIG_AXP803_POWER || definedCONFIG_AXP818_POWER power_failed |=axp_set_fldo (1 ,CONFIG_AXP_FLDO1_VOLT ); power_failed |=axp_set_fldo (2 ,CONFIG_AXP_FLDO2_VOLT ); +#endif + +#ifdef CONFIG_AXP818_POWER power_failed |=axp_set_fldo (3 ,CONFIG_AXP_FLDO3_VOLT );#endif -#if definedCONFIG_AXP809_POWER || definedCONFIG_AXP818_POWER +#if definedCONFIG_AXP803_POWER || definedCONFIG_AXP809_POWER || \ + definedCONFIG_AXP818_POWER power_failed |=axp_set_sw (IS_ENABLED (CONFIG_AXP_SW_ON ));#endif #endif
drivers/power/Kconfig +55 -32
258 lines not on this page · raw message
drivers/power/Makefile +1 -0
@@ -9,6 +9,7 @@ obj-$(CONFIG_AS3722_POWER) += as3722.o obj-$(CONFIG_AXP152_POWER) += axp152.o obj-$(CONFIG_AXP209_POWER) += axp209.o obj-$(CONFIG_AXP221_POWER) += axp221.o +obj-$(CONFIG_AXP803_POWER) += axp803.o obj-$(CONFIG_AXP809_POWER) += axp809.o obj-$(CONFIG_AXP818_POWER) += axp818.o obj-$(CONFIG_EXYNOS_TMU) += exynos-tmu.o
drivers/power/axp803.c new file +256 -0
256 lines not on this page · raw message
drivers/power/axp818.c +1 -1
@@ -162,7 +162,7 @@ int axp_set_dldo(int dldo_num, unsigned int mvolt) cfg =axp818_mvolt_to_cfg (mvolt,700 ,3300 ,100 );if (dldo_num ==2 && mvolt >3300 ) cfg +=1 +axp818_mvolt_to_cfg (mvolt,3400 ,4200 ,200 ); - ret =pmic_bus_write (AXP818_ELDO1_CTRL + (dldo_num -1 ), cfg); + ret =pmic_bus_write (AXP818_DLDO1_CTRL + (dldo_num -1 ), cfg);if (ret)return ret;
include/axp803.h new file +73 -0
73 lines not on this page · raw message
include/axp_pmic.h +3 -0
@@ -16,6 +16,9 @@#ifdef CONFIG_AXP221_POWER #include <axp221.h> #endif +#ifdef CONFIG_AXP803_POWER +#include <axp803.h> +#endif #ifdef CONFIG_AXP809_POWER #include <axp809.h> #endif
Signature · 1 line
2.12.0
v2 cover sunxi: video: Add support for HDMI output on A64/H3/H5
In reply to Jernej Skrabec21.03.2017, 06:01, "Jernej Skrabec" <[email protected]>:
Quoted 18 lines
This series implements support for HDMI output. This is done using DM video framework and sharing the HDMI controller code with RK3288.
Patch 1 splits out RK3288 HDMI code in a way that it is appropriate for sharing with Allwinner SoCs.
Patch 2 splits out TCON code which is completely reusable on all Allwinner SoCs.
Patch 3 (new) converts commont TCON code to use DM video compatible timing structure.
Patch 4 adds all necessary clocks which are needed for Display Engine 2, TCON and HDMI.
Patch 5 implement actual DE2 and HDMI driver and patch 6 disables HDMI on all boards which don't have it (default is on).
Quoted 8 lines
Patch 7 is included here only for testing HDMI output on A64 due to missing power regulator support (AXP803). Another option is to use ATF which powers on HDMI. Such ATF can be found on Andre Przywara's github.
Code was tested on OrangePi 2 & OrangePi Plus 2E (both H3), OrangePi PC 2 (H5) and Pine64 (A64). It was also tested on RK3288 Tinker board. However, it was only compile tested for A10 and A20 targets.
I tested the patched U-Boot on A10 with HDMI and A13 with LCD, and it works properly.
Quoted 88 lines
This series was developed on u-boot-sunxi repository with additional, not yet merged, patch: https://patchwork.ozlabs.org/patch/735617/
Because already merged patches are not yet included in u-boot-sunxi repository, they need to be cherry picked from u-boot-rockchip:
a0a2774aebdaa039ce787090c903cf47263f04c9520c174b3564ae183f0e7c118dc8ce3770ae20b0Best regards,
Jernej SkrabecChanges in v2:
- patch 1 & 2 were removed because they were merged
- collect reviewed by and tested by tags
- TCON split out patch is splitted in two patches
- fixedlcdc_enable()calls in video driver for old SoCs
- defconfigs should disable video driver, not enable it
- minor constant style fixIcenowy Zheng (1):
[DO NOT MERGE] sunxi: add AXP803 supportJernej Skrabec (6):
rockchip: video: Split out HDMI controller code
sunxi: video: Split out TCON code
sunxi: video: Convert lcdc to use structdisplay_timing
sunxi: Add clock support for DE2/HDMI/TCON on newer SoCs
sunxi: video: Add A64/H3/H5 HDMI driver
sunxi: Disable DE2 video driver where not neededarch/arm/include/asm/arch-rockchip/hdmi_rk3288.h | 456 --------------
arch/arm/include/asm/arch-sunxi/clock_sun6i.h| 54 ++arch/arm/include/asm/arch-sunxi/cpu_sun4i.h| 8 +arch/arm/include/asm/arch-sunxi/display.h| 103 ---arch/arm/include/asm/arch-sunxi/display2.h| 124 ++++arch/arm/include/asm/arch-sunxi/lcdc.h| 128 ++++arch/arm/mach-sunxi/Makefile| 3 +arch/arm/mach-sunxi/clock_sun6i.c| 40 +-arch/arm/mach-sunxi/pmic_bus.c| 6 +-arch/arm/mach-sunxi/rsb.c| 2 +-
board/sunxi/Kconfig | 10 +
board/sunxi/board.c | 31 +- configs/nanopi_neo_air_defconfig | 1 + configs/nanopi_neo_defconfig | 1 + configs/orangepi_zero_defconfig | 1 +drivers/power/Kconfig| 87 ++-drivers/power/Makefile | 1 + drivers/power/axp803.c | 256 ++++++++ drivers/power/axp818.c | 2 +- drivers/video/Makefile | 2 +-drivers/video/dw_hdmi.c | 764 +++++++++++++++++++++++
drivers/video/rockchip/Makefile| 2 +-drivers/video/rockchip/rk_hdmi.c| 757 +---------------------drivers/video/rockchip/rk_vop.c| 1 -drivers/video/sunxi/Makefile| 9 +drivers/video/sunxi/lcdc.c| 209 +++++++drivers/video/sunxi/sunxi_de2.c| 258 ++++++++drivers/video/{=>sunxi}/sunxi_display.c| 220 ++-----drivers/video/sunxi/sunxi_dw_hdmi.c| 389 ++++++++++++include/axp803.h| 73 +++
include/axp_pmic.h | 3 +
include/configs/sun50i.h | 2 +include/configs/sun8i.h| 4 +include/configs/sunxi-common.h| 5 +include/dw_hdmi.h| 486 ++++++++++++++scripts/config_whitelist.txt| 1 +36 files changed, 2977 insertions(+), 1522 deletions(-)delete mode 100644
arch/arm/include/asm/arch-rockchip/hdmi_rk3288.hcreate mode 100644arch/arm/include/asm/arch-sunxi/display2.hcreate mode 100644arch/arm/include/asm/arch-sunxi/lcdc.hcreate mode 100644drivers/power/axp803.c
create mode 100644drivers/video/dw_hdmi.c
create mode 100644drivers/video/sunxi/Makefile
create mode 100644drivers/video/sunxi/lcdc.c
create mode 100644drivers/video/sunxi/sunxi_de2.crenamedrivers/video/{=>sunxi}/sunxi_display.c(87%) create mode 100644drivers/video/sunxi/sunxi_dw_hdmi.ccreate mode 100644include/axp803.h
create mode 100644include/dw_hdmi.h--
2.12.0--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com. For more options, visit https://groups.google.com/d/optout.
v2 cover sunxi: video: Add support for HDMI output on A64/H3/H5
In reply to Jernej SkrabecHi Jernej,
Quoted 30 lines · Jernej Skrabec
This series implements support for HDMI output. This is done using DM video framework and sharing the HDMI controller code with RK3288.
Patch 1 splits out RK3288 HDMI code in a way that it is appropriate for sharing with Allwinner SoCs.
Patch 2 splits out TCON code which is completely reusable on all Allwinner SoCs.
Patch 3 (new) converts commont TCON code to use DM video compatible timing structure.
Patch 4 adds all necessary clocks which are needed for Display Engine 2, TCON and HDMI.
Patch 5 implement actual DE2 and HDMI driver and patch 6 disables HDMI on all boards which don't have it (default is on).
Patch 7 is included here only for testing HDMI output on A64 due to missing power regulator support (AXP803). Another option is to use ATF which powers on HDMI. Such ATF can be found on Andre Przywara's github.
Code was tested on OrangePi 2 & OrangePi Plus 2E (both H3), OrangePi PC 2 (H5) and Pine64 (A64). It was also tested on RK3288 Tinker board. However, it was only compile tested for A10 and A20 targets.
This series was developed on u-boot-sunxi repository with additional, not yet merged, patch: https://patchwork.ozlabs.org/patch/735617/
Quoted 7 lines
Because already merged patches are not yet included in u-boot-sunxi repository, they need to be cherry picked from u-boot-rockchip:
a0a2774aebdaa039ce787090c903cf47263f04c9520c174b3564ae183f0e7c118dc8ce3770ae20b0Best regards,
Jernej Skrabec
This is a really nice piece of work, thank you!
Regards,
Simon
v2 cover sunxi: video: Add support for HDMI output on A64/H3/H5
Dne sobota, 01. april 2017 ob 06:20:52 CEST je Simon Glass napisal(a):
Quoted 38 lines
Hi Jernej,
Quoted 35 lines · Jernej Skrabec
This series implements support for HDMI output. This is done using DM video framework and sharing the HDMI controller code with RK3288.
Patch 1 splits out RK3288 HDMI code in a way that it is appropriate for sharing with Allwinner SoCs.
Patch 2 splits out TCON code which is completely reusable on all Allwinner SoCs.
Patch 3 (new) converts commont TCON code to use DM video compatible timing structure.
Patch 4 adds all necessary clocks which are needed for Display Engine 2, TCON and HDMI.
Patch 5 implement actual DE2 and HDMI driver and patch 6 disables HDMI on all boards which don't have it (default is on).
Patch 7 is included here only for testing HDMI output on A64 due to missing power regulator support (AXP803). Another option is to use ATF which powers on HDMI. Such ATF can be found on Andre Przywara's github.
Code was tested on OrangePi 2 & OrangePi Plus 2E (both H3), OrangePi PC 2 (H5) and Pine64 (A64). It was also tested on RK3288 Tinker board. However, it was only compile tested for A10 and A20 targets.
This series was developed on u-boot-sunxi repository with additional, not yet merged, patch: https://patchwork.ozlabs.org/patch/735617/
Because already merged patches are not yet included in u-boot-sunxi repository, they need to be cherry picked from u-boot-rockchip:
a0a2774aebdaa039ce787090c903cf47263f04c9520c174b3564ae183f0e7c118dc8ce3770ae20b0
Quoted 4 lines
Quoted 2 lines
Best regards,
Jernej SkrabecThis is a really nice piece of work, thank you!
I'm glad you like it! I will definetly send some follow up patches to improve dw_hdmi driver.
Regards,
Jernej