tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map
PATCH 1/1 tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map
Commit e3b93b3c595 "dmop: add xendevicemodel_modified_memory_bulk()" added the implementation to the library almost 2 years ago, but the function was not included in the map file, essentially making it useless. This patch rectifies the situation.
---
Cc: Ian Jackson <[email protected]>
Cc: Wei Liu <[email protected]>
--- tools/libs/devicemodel/Makefile | 2 +- tools/libs/devicemodel/libxendevicemodel.map | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)
tools/libs/devicemodel/Makefile +1 -1
@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk MAJOR = 1 -MINOR = 2 +MINOR = 3 SHLIB_LDFLAGS += -Wl,--version-script=libxendevicemodel.map CFLAGS += -Werror -Wmissing-prototypes
tools/libs/devicemodel/libxendevicemodel.map +5 -0
@@ -33,3 +33,8 @@ VERS_1.2 { xendevicemodel_relocate_memory; xendevicemodel_pin_memory_cacheattr; } VERS_1.1; + +VERS_1.3 { + global: + xendevicemodel_modified_memory_bulk; +} VERS_1.2;
Signature · 7 lines
2.20.1.2.gb21ebb671 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Cc-ing Juergen, in case this can make 4.12...
Quoted 52 lines
-----Original Message-----
From: Paul Durrant [mailto:[email protected]]
Sent: 15 February 2019 10:02
To: [email protected]
Cc: Paul Durrant <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>
Subject: [PATCH]tools/libxendevicemodel: addxendevicemodel_modified_memory_bulkto mapCommit
e3b93b3c595"dmop: addxendevicemodel_modified_memory_bulk()" added the implementation to the library almost 2 years ago, but the function was not included in the map file, essentially making it useless. This patch rectifies the situation.Signed-off-by Paul Durrant <[email protected]>---
Cc: Ian Jackson <[email protected]>
Cc: Wei Liu <[email protected]>--- tools/libs/devicemodel/Makefile | 2 +- tools/libs/devicemodel/libxendevicemodel.map | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)tools/libs/devicemodel/Makefile +1
-1@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk MAJOR = 1 -MINOR = 2 +MINOR = 3 SHLIB_LDFLAGS += -Wl,--version-script=libxendevicemodel.map CFLAGS += -Werror -Wmissing-prototypestools/libs/devicemodel/libxendevicemodel.map +5
-1@@ -33,3 +33,8 @@ VERS_1.2 { xendevicemodel_relocate_memory; xendevicemodel_pin_memory_cacheattr; } VERS_1.1; + +VERS_1.3 { + global: + xendevicemodel_modified_memory_bulk; +} VERS_1.2; --
Quoted 1 line
2.20.1.2.gb21ebb671
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map"):
Quoted 1 line
Cc-ing Juergen, in case this can make 4.12...
I think this should go into 4.12. It is very low risk.
In another case there would possibly be questions about whether we wanted to add an additional ABI/API stability promise, but in this case this is not an issue.
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 11 lines
-----Original Message-----
From: Ian Jackson [mailto:[email protected]]
Sent: 15 February 2019 11:27
To: Paul Durrant <[email protected]>
Cc: [email protected]; Wei Liu <[email protected]>; [email protected]
Subject: RE: [PATCH]tools/libxendevicemodel: addxendevicemodel_modified_memory_bulkto mapPaul Durrant writes ("RE: [PATCH]
tools/libxendevicemodel: addxendevicemodel_modified_memory_bulkto map"):
Quoted 7 lines
Quoted 1 line
Cc-ing Juergen, in case this can make 4.12...
I think this should go into 4.12. It is very low risk.
In another case there would possibly be questions about whether we wanted to add an additional ABI/API stability promise, but in this case this is not an issue.
No, indeed.
Perhaps it would be possible to build some sort of cross-check that all functions listed in the public header of a library are actually *somewhere* in the map file, so this doesn't happen in future.
Paul
Quoted 2 lines
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map"):
Quoted 1 line
Perhaps it would be possible to build some sort of cross-check that all functions listed in the public header of a library are actually *somewhere* in the map file, so this doesn't happen in future.
I wouldn't stand in the way of that, but presumably functions are usually added because someone wants to call them so it would often be spotted anyway, and the consequences of a mistake here are fairly minor.
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 17 lines · Paul Durrant
Cc-ing Juergen, in case this can make 4.12...
Quoted 15 lines
-----Original Message-----
From: Paul Durrant [mailto:[email protected]]
Sent: 15 February 2019 10:02
To: [email protected]
Cc: Paul Durrant <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>
Subject: [PATCH]tools/libxendevicemodel: addxendevicemodel_modified_memory_bulkto mapCommit
e3b93b3c595"dmop: addxendevicemodel_modified_memory_bulk()" added the implementation to the library almost 2 years ago, but the function was not included in the map file, essentially making it useless. This patch rectifies the situation.Signed-off-by Paul Durrant <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 6 lines · Paul Durrant
Commit
e3b93b3c595"dmop: addxendevicemodel_modified_memory_bulk()" added the implementation to the library almost 2 years ago, but the function was not included in the map file, essentially making it useless. This patch rectifies the situation.Signed-off-by Paul Durrant <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel