Skip to contentSkip to conversation

spmi: Set fwnode for spmi devices

PATCH Applied Saravana Kannan 2 participants 5 messages Nov 15, 2024 – Dec 3, 2024 SPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spmi: Set fwnode for spmi devices

This allows fw_devlink to do proper dependency tracking for SPMI devices. So, better deferred probe handling, async probing, async suspend/resume, etc.

---
 drivers/spmi/spmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spmi/spmi.c +1 -1
index fb0101da1485..3cf8d9bd4566 100644
@@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
 		if (!sdev)
 			continue;
 
-		sdev->dev.of_node = node;
+		device_set_node(&sdev->dev, of_fwnode_handle(node));
 		sdev->usid = (u8)reg[0];
 
 		err = spmi_device_add(sdev);
Signature · 1 line
2.47.0.338.g60cca15819-goog
#1 lore raw
Quoted 6 lines · Saravana Kannan

This allows fw_devlink to do proper dependency tracking for SPMI devices. So, better deferred probe handling, async probing, async suspend/resume, etc.

Stephen,

Gentle nudge. Plan to take this in for 6.13?

-Saravana

Quoted 20 lines
---
 drivers/spmi/spmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spmi/spmi.c +1 -2
index fb0101da1485..3cf8d9bd4566 100644
@@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
                if (!sdev)
                        continue;
 
-               sdev->dev.of_node = node;
+               device_set_node(&sdev->dev, of_fwnode_handle(node));
                sdev->usid = (u8)reg[0];
 
                err = spmi_device_add(sdev);
--

2.47.0.338.g60cca15819-goog

maintainer
#2 lore raw

Quoting Saravana Kannan (2024-11-27 20:23:01)

Quoted 6 lines · Saravana Kannan
Quoted 5 lines

This allows fw_devlink to do proper dependency tracking for SPMI devices. So, better deferred probe handling, async probing, async suspend/resume, etc.

Quoted 6 lines
Quoted 1 line

Stephen,

Gentle nudge. Plan to take this in for 6.13?

It doesn't look like a fix and it was sent too late for 6.13 so I was going to send it over for the next cycle.

#3 lore raw
Quoted 10 lines · Stephen Boyd

Quoting Saravana Kannan (2024-11-27 20:23:01)

Quoted 8 lines · Saravana Kannan
Quoted 6 lines

This allows fw_devlink to do proper dependency tracking for SPMI devices. So, better deferred probe handling, async probing, async suspend/resume, etc.

Quoted 7 lines
Quoted 4 lines

Stephen,

Gentle nudge. Plan to take this in for 6.13?

It doesn't look like a fix and it was sent too late for 6.13 so I was going to send it over for the next cycle.

Sounds good. Can you let me know once you pick it up in one of your git branches?

Thanks,
Saravana