Skip to contentSkip to conversation

configure: fix print syntax for python 3

PATCH In review Wei Liu 2 participants 5 messages Sep 19, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 configure: fix print syntax for python 3

16cc3362a missed one print statement.

---
 m4/python_devel.m4 | 2 +-
 tools/configure    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
m4/python_devel.m4 +1 -1
index 7f26381376..e365cd658e 100644
@@ -6,7 +6,7 @@ AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
 AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +

distutils.sysconfig.get_config_var("INCLUDEPY"))'`"

     CPPFLAGS="$CPPFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print(distutils.sysconfig.get_config_var("CFLAGS"))'`"
     LDFLAGS="$LDFLAGS `$PYTHON -c 'import distutils.sysconfig; \
tools/configure +1 -1
index 1baacea9ac..614d1f5b61 100755
@@ -7441,7 +7441,7 @@ fi
 if test x"$pyconfig" = x"no"; then :
 
         CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +

distutils.sysconfig.get_config_var("INCLUDEPY"))'`"

     CPPFLAGS="$CPPFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print(distutils.sysconfig.get_config_var("CFLAGS"))'`"
     LDFLAGS="$LDFLAGS `$PYTHON -c 'import distutils.sysconfig; \
Signature · 6 lines
2.20.1

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
author
#1 lore raw
Quoted 19 lines · Wei Liu

16cc3362a missed one print statement.

---
 m4/python_devel.m4 | 2 +-
 tools/configure    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
m4/python_devel.m4 +1 -1
index 7f26381376..e365cd658e 100644
@@ -6,7 +6,7 @@ AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
 AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +
Quoted 1 line

distutils.sysconfig.get_config_var("INCLUDEPY"))'`"

Urgh. This has been mangled. Hope you get the idea...

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw

Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python 3"):

Quoted 10 lines · Wei Liu
Quoted 9 lines

16cc3362a missed one print statement.

---
 m4/python_devel.m4 | 2 +-
 tools/configure    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines
Quoted 11 lines
m4/python_devel.m4 +1 -1
index 7f26381376..e365cd658e 100644
@@ -6,7 +6,7 @@ AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
 AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +

distutils.sysconfig.get_config_var("INCLUDEPY"))'`"

Urgh. This has been mangled. Hope you get the idea...

My previous reply bounced due to header mangling in your first mail. Let me try again:

This is good in principle but:

Can you provide as a git branch ? Then I will get the unmangled version and be able to try it out.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#3 lore raw
Quoted 8 lines · Ian Jackson

My previous reply bounced due to header mangling in your first mail. Let me try again:

This is good in principle but:

Can you provide as a git branch ? Then I will get the unmangled version and be able to try it out.

See https://xenbits.xen.org/gitweb/?p=people/liuw/xen.git;a=commitdiff;h=864c7fb715039906762c9638f04ddfd97c1ae54b

Quoted 1 line

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by
#4 lore raw

Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python 3"):

Quoted 10 lines · Ian Jackson
Quoted 7 lines

My previous reply bounced due to header mangling in your first mail. Let me try again:

This is good in principle but:

Can you provide as a git branch ? Then I will get the unmangled version and be able to try it out.

See https://xenbits.xen.org/gitweb/?p=people/liuw/xen.git;a=commitdiff;h=864c7fb715039906762c9638f04ddfd97c1ae54b

Thanks,

and pushed.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel