GFS2: make sure S_NOSEC flag isn't overwritten

At the end of gfs2_set_inode_flags inode->i_flags is set to flags, so we should be mondifying flags instead of inode->i_flags, so it isn't overwritten.

---
 fs/gfs2/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 6e600ab..80d1fd4 100644
@@ -181,7 +181,7 @@ void gfs2_set_inode_flags(struct inode *inode)
 
 	flags &= ~(S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_NOSEC);
 	if ((ip->i_eattr == 0) && !is_sxid(inode->i_mode))
-		inode->i_flags |= S_NOSEC;
+		flags |= S_NOSEC;
 	if (ip->i_diskflags & GFS2_DIF_IMMUTABLE)
 		flags |= S_IMMUTABLE;
 	if (ip->i_diskflags & GFS2_DIF_APPENDONLY)

2.1.0

Hi,

----- Original Message -----

Patch looks good, but "mondifying" looks like a type and should probably be fixed.

Regards,

Bob Peterson
Red Hat File Systems

----- Original Message -----

Hi,

The v2 version of the patch is now in the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=01e64ee40ad741037352d1d6202eaa432f833eb4

Regards,

Bob Peterson
Red Hat File Systems