net: bcmgenet: skip invalid partial checksums
Subsystems (3)
Doug Berger
maintainerPATCH 1/1 net: bcmgenet: skip invalid partial checksums
The RXCHK block will return a partial checksum of 0 if it encounters a problem while receiving a packet. Since a 1's complement sum can only produce this result if no bits are set in the received data stream it is fair to treat it as an invalid partial checksum and not pass it up the stack.
--- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +4 -2
@@ -2287,8 +2287,10 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_rx_ring *ring, dma_length_status = status->length_status;if (dev->features &NETIF_F_RXCSUM ) { rx_csum = (__force __be16)(status->rx_csum &0xffff ); - skb->csum = (__force __wsum )ntohs (rx_csum); - skb->ip_summed =CHECKSUM_COMPLETE ; +if (rx_csum) { + skb->csum = (__force __wsum )ntohs (rx_csum); + skb->ip_summed =CHECKSUM_COMPLETE ; + } }/* DMA flags and length are still valid no matter how
Signature · 1 line
2.25.1
Quoted 8 lines · Doug Berger
The RXCHK block will return a partial checksum of 0 if it encounters a problem while receiving a packet. Since a 1's complement sum can only produce this result if no bits are set in the received data stream it is fair to treat it as an invalid partial checksum and not pass it up the stack.
Fixes 810155397890 ("net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM")Signed-off-by Doug Berger <[email protected]>
Signature · 1 line
Florian
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Wed, 16 Mar 2022 18:28:12 -0700 you wrote:
The RXCHK block will return a partial checksum of 0 if it encounters a problem while receiving a packet. Since a 1's complement sum can only produce this result if no bits are set in the received data stream it is fair to treat it as an invalid partial checksum and not pass it up the stack.
Fixes 810155397890 ("net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM")Signed-off-by Doug Berger <[email protected]>[...]
Here is the summary with links:
- [net] net: bcmgenet: skip invalid partial checksums
https://git.kernel.org/netdev/net/c/0f643c88c8d2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html