Skip to contentSkip to conversation

Revert "net: dsa: b53: Fix valid setting for MDB entries"

PATCH In review Rafał Miłecki 2 participants 2 messages Dec 7, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "net: dsa: b53: Fix valid setting for MDB entries"

From: Rafał Miłecki <[email protected]>

This reverts commit 1fae6eb0fc91d3ecb539e03f9e4dcd1c53ada553.

Upstream commit was a fix for an overlook of setting "ent.is_valid" twice after 5d65b64a3d97 ("net: dsa: b53: Add support for MDB").

Since MDB support was not backported to stable kernels (it's not a bug fix) there is nothing to fix there. Backporting this commit resulted in "env.is_valid" not being set at all.

---
 drivers/net/dsa/b53/b53_common.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dsa/b53/b53_common.c +1 -0
index 825d840cdb8c..1458416f4f91 100644
@@ -1551,6 +1551,7 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,
 
 	memset(&ent, 0, sizeof(ent));
 	ent.port = port;
+	ent.is_valid = is_valid;
 	ent.vid = vid;
 	ent.is_static = true;
 	memcpy(ent.mac, addr, ETH_ALEN);
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This reverts commit 1fae6eb0fc91d3ecb539e03f9e4dcd1c53ada553.

Quoted 8 lines

Upstream commit was a fix for an overlook of setting "ent.is_valid" twice after 5d65b64a3d97 ("net: dsa: b53: Add support for MDB").

Since MDB support was not backported to stable kernels (it's not a bug fix) there is nothing to fix there. Backporting this commit resulted in "env.is_valid" not being set at all.

Thanks for catching this!

Signature · 1 line
Florian