Skip to contentSkip to conversation

drivers/tty: Fix typos in comments

PATCH In review [email protected] 2 participants 3 messages Jul 18, 2023 1 message not in the archive TTY layer and serial drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drivers/tty: Fix typos in comments

Delete duplicate word "the"

---
 drivers/tty/n_gsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/n_gsm.c +1 -1
index b411a26cc092..e8cd1e07eafe 100644
@@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
  *
  *    Add data to the transmit queue and try and get stuff moving
  *    out of the mux tty if not already doing so. Take the
- *    the gsm tx lock and dlci lock.
+ *    gsm tx lock and dlci lock.
  */
 
 static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
#2 lore raw

PATCH 1/1 drivers/tty: Fix typos in comments

Delete duplicate word "the"

---
 drivers/tty/n_gsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/n_gsm.c +1 -1
index b411a26cc092..e8cd1e07eafe 100644
@@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
  *
  *    Add data to the transmit queue and try and get stuff moving
  *    out of the mux tty if not already doing so. Take the
- *    the gsm tx lock and dlci lock.
+ *    gsm tx lock and dlci lock.
  */
 
 static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
maintainer
#3 lore raw
In reply to [email protected]
Quoted 20 lines · On Wed, Jul 19, 2023 at 12:22:25AM +0800, [email protected] wrote:

Delete duplicate word "the"

---
 drivers/tty/n_gsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/n_gsm.c +1 -1
index b411a26cc092..e8cd1e07eafe 100644
@@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci,
 struct gsm_msg *msg)
  *
  *    Add data to the transmit queue and try and get stuff moving
  *    out of the mux tty if not already doing so. Take the
- *    the gsm tx lock and dlci lock.
+ *    gsm tx lock and dlci lock.
  */
 
Quoted 1 line

static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)

Please learn how to get involved in kernel development by working in drivers/staging/* first, as the developers there are used to simple errors like what you did here, and will work to help you out.

Otherwise, patches like this are just going to cause developers to get grumpy when you have obvious errors.

good luck!

greg k-h