Skip to contentSkip to conversation

libxc/migration: Drop unimplemneted domain types

PATCH In review Andrew Cooper 4 participants 9 messages Dec 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxc/migration: Drop unimplemneted domain types

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

---
CC: George Dunlap <[email protected]>
CC: Ian Jackson <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Wei Liu <[email protected]>
CC: Julien Grall <[email protected]>
CC: Marek Marczykowski-Górecki <[email protected]>

---
 docs/specs/libxc-migration-stream.pandoc | 6 +-----
 tools/libxc/xc_sr_common.c               | 2 --
 tools/libxc/xc_sr_stream_format.h        | 2 --
 tools/python/xen/migration/libxc.py      | 4 ----
 4 files changed, 1 insertion(+), 13 deletions(-)
docs/specs/libxc-migration-stream.pandoc +1 -5
index 313be3e80d..a7a8a08936 100644
@@ -160,11 +160,7 @@ type        0x0000: Reserved.
 
             0x0002: x86 HVM.
 
-            0x0003: x86 PVH.
-
-            0x0004: ARM.
-
-            0x0005 - 0xFFFFFFFF: Reserved.
+            0x0003 - 0xFFFFFFFF: Reserved.
 
 page_shift  Size of a guest page as a power of two.
 
tools/libxc/xc_sr_common.c +0 -2
index 370d98d94a..46fd928de2 100644
@@ -8,8 +8,6 @@ static const char *dhdr_types[] =
 {
     [DHDR_TYPE_X86_PV]  = "x86 PV",
     [DHDR_TYPE_X86_HVM] = "x86 HVM",
-    [DHDR_TYPE_X86_PVH] = "x86 PVH",
-    [DHDR_TYPE_ARM]     = "ARM",
 };
 
 const char *dhdr_type_to_str(uint32_t type)
tools/libxc/xc_sr_stream_format.h +0 -2
index 051afa7dcd..37a7da6eab 100644
@@ -43,8 +43,6 @@ struct xc_sr_dhdr
 
 #define DHDR_TYPE_X86_PV  0x00000001U
 #define DHDR_TYPE_X86_HVM 0x00000002U
-#define DHDR_TYPE_X86_PVH 0x00000003U
-#define DHDR_TYPE_ARM     0x00000004U
 
 /*
  * Record Header
tools/python/xen/migration/libxc.py +0 -4
index 70bcb8d15b..432750c9fa 100644
@@ -32,14 +32,10 @@
 
 DHDR_TYPE_x86_pv  = 0x00000001
 DHDR_TYPE_x86_hvm = 0x00000002
-DHDR_TYPE_x86_pvh = 0x00000003
-DHDR_TYPE_arm     = 0x00000004
 
 dhdr_type_to_str = {
     DHDR_TYPE_x86_pv  : "x86 PV",
     DHDR_TYPE_x86_hvm : "x86 HVM",
-    DHDR_TYPE_x86_pvh : "x86 PVH",
-    DHDR_TYPE_arm     : "ARM",
 }
 
 # Records
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw

Hi Andrew,

Quoted 8 lines · Andrew Cooper

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#2 lore raw
In reply to Andrew Cooper
Quoted 8 lines · Andrew Cooper

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
In reply to Andrew Cooper

Andrew Cooper writes ("[PATCH] libxc/migration: Drop unimplemneted domain types"):

Quoted 6 lines

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

...

docs/specs/libxc-migration-stream.pandoc type 0x0000: Reserved. · line 163

Quoted 6 lines
docs/specs/libxc-migration-stream.pandoc +1 -5
-            0x0003: x86 PVH.
-
-            0x0004: ARM.
-
-            0x0005 - 0xFFFFFFFF: Reserved.
+            0x0003 - 0xFFFFFFFF: Reserved.

This is reclaiming those numbers. Could there be any software which uses them ? Eg, maybe someone put the RFC series into production ?

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 7 lines · Ian Jackson

Andrew Cooper writes ("[PATCH] libxc/migration: Drop unimplemneted domain types"):

Quoted 6 lines

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

Quoted 8 lines

...

docs/specs/libxc-migration-stream.pandoc type 0x0000: Reserved. · line 163

Quoted 6 lines
docs/specs/libxc-migration-stream.pandoc +1 -5
-            0x0003: x86 PVH.
-
-            0x0004: ARM.
-
-            0x0005 - 0xFFFFFFFF: Reserved.
+            0x0003 - 0xFFFFFFFF: Reserved.

This is reclaiming those numbers.

Yes

Quoted 1 line

Could there be any software which uses them ?

Not plausibly, no, given...

Quoted 1 line

Eg, maybe someone put the RFC series into production ?

... the rather large set of outstanding TODO items in IanC's RFC series, which included "the hypervisor is unstable when logdirty gets enabled" IIRC.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by
#5 lore raw

Andrew Cooper writes ("Re: [PATCH] libxc/migration: Drop unimplemneted domain types"):

Quoted 9 lines · Ian Jackson
Quoted 1 line

Could there be any software which uses them ?

Not plausibly, no, given...

Quoted 1 line

Eg, maybe someone put the RFC series into production ?

... the rather large set of outstanding TODO items in IanC's RFC series, which included "the hypervisor is unstable when logdirty gets enabled" IIRC.

OK :-).

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
In reply to Andrew Cooper

Hi,

Quoted 19 lines · Andrew Cooper
Quoted 7 lines · Ian Jackson

Andrew Cooper writes ("[PATCH] libxc/migration: Drop unimplemneted domain types"):

Quoted 6 lines

x86 PVH is completely obsolete - it was intended for legacy PVH before that idea was abandoned. There was an RFC series for ARM in 2015, but there is plenty of outstanding work which hasn't been done yet.

No functional change. New types can be (re)introduced with the code which actually implements them.

Quoted 8 lines

...

docs/specs/libxc-migration-stream.pandoc type 0x0000: Reserved. · line 163

Quoted 6 lines
docs/specs/libxc-migration-stream.pandoc +1 -5
-            0x0003: x86 PVH.
-
-            0x0004: ARM.
-
-            0x0005 - 0xFFFFFFFF: Reserved.
+            0x0003 - 0xFFFFFFFF: Reserved.

This is reclaiming those numbers.

Yes

Quoted 8 lines
Quoted 1 line

Could there be any software which uses them ?

Not plausibly, no, given...

Quoted 1 line

Eg, maybe someone put the RFC series into production ?

... the rather large set of outstanding TODO items in IanC's RFC series, which included "the hypervisor is unstable when logdirty gets enabled" IIRC.

Some people after Ian picked up the work (AFAIK Linaro were the last ones), but yes the code was still an RFC even after that.

So I would not worry too much on potential use.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#7 lore raw
In reply to Andrew Cooper

Hi,

I forgot to mention the type in the commit title:

s/unimplemneted/implemented/

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel