Add R8A77980/Condor/V3HSK LVDS/HDMI support
Subsystems (2)
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
Hello!
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support [5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
WBR, Sergei
PATCH v2 1/5 arm64: dts: renesas: r8a77980: add FCPVD support
Describe FCPVD0 in the R8A77980 device tree; it will be used by VSPD0 in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/renesas/r8a77980.dtsi +8 -0
@@ -653,6 +653,14 @@ resets = <&cpg 408>; }; + fcpvd0: fcp at fea27000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea27000 0 0x200>; + clocks = <&cpg CPG_MOD 603>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 603>; + }; + prr: chipid at fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
PATCH v2 1/5 arm64: dts: renesas: r8a77980: add FCPVD support
Quoted 7 lines · Sergei Shtylyov
Describe FCPVD0 in the R8A77980 device tree; it will be used by VSPD0 in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>Signed-off-by Sergei Shtylyov <[email protected]>
Hi,
This looks fine to me but I will wait for the dependencies of this series to land and to see if there are other reviews before applying.
PATCH v2 1/5 arm64: dts: renesas: r8a77980: add FCPVD support
In reply to Sergei ShtylyovHi Sergei,
Thank you for the patch.
Quoted 7 lines · On Thursday, 7 June 2018 23:19:31 EEST Sergei Shtylyov wrote:
Describe FCPVD0 in the R8A77980 device tree; it will be used by VSPD0 in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 23 lines
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)Index:
renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================arch/arm64/boot/dts/renesas/r8a77980.dtsi +8
-0@@ -653,6 +653,14 @@ resets = <&cpg 408>; }; + fcpvd0: fcp at fea27000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea27000 0 0x200>; + clocks = <&cpg CPG_MOD 603>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 603>; + }; + prr: chipid at fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 2/5 arm64: dts: renesas: r8a77980: add VSPD support
In reply to Sergei ShtylyovDescribe VSPD0 in the R8A77980 device tree; it will be used by DU in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/renesas/r8a77980.dtsi +10 -0
@@ -653,6 +653,16 @@ resets = <&cpg 408>; }; + vspd0: vsp at fea20000 { + compatible = "renesas,vsp2"; + reg = <0 0xfea20000 0 0x4000>; + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 623>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 623>; + renesas,fcp = <&fcpvd0>; + }; + fcpvd0: fcp at fea27000 { compatible = "renesas,fcpv"; reg = <0 0xfea27000 0 0x200>;
PATCH v2 2/5 arm64: dts: renesas: r8a77980: add VSPD support
[CC Laurent, Geert]
Quoted 17 lines · Sergei Shtylyov
Describe VSPD0 in the R8A77980 device tree; it will be used by DU in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>Signed-off-by Sergei Shtylyov <[email protected]>--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)Index:
renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
arch/arm64/boot/dts/renesas/r8a77980.dtsi line 658
Quoted 6 lines
arch/arm64/boot/dts/renesas/r8a77980.dtsi +3
-0@@ -653,6 +653,16 @@ resets = <&cpg 408>; }; + vspd0: vsp at fea20000 { + compatible = "renesas,vsp2"; + reg = <0 0xfea20000 0 0x4000>;
As per "[PATCH] arm64: dts: renesas: Fix VSPD registers range" I think the width of the range should be 0x5000.
Quoted 11 lines
arch/arm64/boot/dts/renesas/r8a77980.dtsi +7
-0+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 623>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 623>; + renesas,fcp = <&fcpvd0>; + }; + fcpvd0: fcp at fea27000 { compatible = "renesas,fcpv"; reg = <0 0xfea27000 0 0x200>;
PATCH v2 2/5 arm64: dts: renesas: r8a77980: add VSPD support
Hello Simon,
Quoted 24 lines · On Friday, 8 June 2018 16:54:56 EEST Simon Horman wrote:
[CC Laurent, Geert]
Quoted 21 lines · Sergei Shtylyov
Describe VSPD0 in the R8A77980 device tree; it will be used by DU in the next patch...
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>Signed-off-by Sergei Shtylyov <[email protected]>---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)Index:
renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================arch/arm64/boot/dts/renesas/r8a77980.dtsi +0
-0@@ -653,6 +653,16 @@ resets = <&cpg 408>; };
Quoted 6 lines
arch/arm64/boot/dts/renesas/r8a77980.dtsi line 658
Quoted 3 lines
arch/arm64/boot/dts/renesas/r8a77980.dtsi +3
-0+ vspd0: vsp at fea20000 { + compatible = "renesas,vsp2"; + reg = <0 0xfea20000 0 0x4000>;As per "[PATCH] arm64: dts: renesas: Fix VSPD registers range" I think the width of the range should be
0x5000.
I agree with that.
Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77980.dtsi +7
-0+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 623>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 623>; + renesas,fcp = <&fcpvd0>; + }; + fcpvd0: fcp at fea27000 { compatible = "renesas,fcpv"; reg = <0 0xfea27000 0 0x200>;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 3/5 arm64: dts: renesas: r8a77980: add DU support
In reply to Sergei ShtylyovDefine the generic R8A77980 part of the DU device node.
Based on the original (and large) patch by Vladimir Barinov.
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/renesas/r8a77980.dtsi +30 -0
@@ -671,6 +671,36 @@ resets = <&cpg 603>; }; + du: display at feb00000 { + compatible = "renesas,du-r8a77980", + "renesas,du-r8a77970"; + reg = <0 0xfeb00000 0 0x80000>; + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 724>; + clock-names = "du.0"; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 724>; + vsps = <&vspd0>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port at 0 { + reg = <0>; + du_out_rgb: endpoint { + }; + }; + + port at 1 { + reg = <1>; + du_out_lvds0: endpoint { + }; + }; + }; + }; + prr: chipid at fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
PATCH v2 3/5 arm64: dts: renesas: r8a77980: add DU support
Hi Sergei,
Thank you for the patch.
Quoted 6 lines · On Thursday, 7 June 2018 23:21:38 EEST Sergei Shtylyov wrote:
Define the generic R8A77980 part of the DU device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 45 lines
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)Index:
renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================arch/arm64/boot/dts/renesas/r8a77980.dtsi +30
-0@@ -671,6 +671,36 @@ resets = <&cpg 603>; }; + du: display@feb00000 { + compatible = "renesas,du-r8a77980", + "renesas,du-r8a77970"; + reg = <0 0xfeb00000 0 0x80000>; + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 724>; + clock-names = "du.0"; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 724>; + vsps = <&vspd0>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + du_out_rgb: endpoint { + }; + }; + + port@1 { + reg = <1>; + du_out_lvds0: endpoint { + }; + }; + }; + }; + prr: chipid@fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 4/5 arm64: dts: renesas: r8a77980: add LVDS support
In reply to Sergei ShtylyovDefine the generic R8A77980 part of the LVDS device node.
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
arch/arm64/boot/dts/renesas/r8a77980.dtsi +29 -0
@@ -696,6 +696,35 @@ port at 1 { reg = <1>; du_out_lvds0: endpoint { + remote-endpoint = <&lvds0_in>; + }; + }; + }; + }; + + lvds0: lvds-encoder at feb90000 { + compatible = "renesas,r8a77980-lvds"; + reg = <0 0xfeb90000 0 0x14>; + clocks = <&cpg CPG_MOD 727>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 727>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port at 0 { + reg = <0>; + lvds0_in: endpoint { + remote-endpoint = + <&du_out_lvds0>; + }; + }; + + port at 1 { + reg = <1>; + lvds0_out: endpoint { }; }; };
PATCH v2 4/5 arm64: dts: renesas: r8a77980: add LVDS support
Hi Sergei,
Thank you for the patch.
Quoted 3 lines · On Thursday, 7 June 2018 23:23:06 EEST Sergei Shtylyov wrote:
Define the generic R8A77980 part of the LVDS device node.
Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 44 lines
--- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 29 ++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)Index:
renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================arch/arm64/boot/dts/renesas/r8a77980.dtsi +29
-0@@ -696,6 +696,35 @@ port@1 { reg = <1>; du_out_lvds0: endpoint { + remote-endpoint = <&lvds0_in>; + }; + }; + }; + }; + + lvds0: lvds-encoder@feb90000 { + compatible = "renesas,r8a77980-lvds"; + reg = <0 0xfeb90000 0 0x14>; + clocks = <&cpg CPG_MOD 727>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + resets = <&cpg 727>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + lvds0_in: endpoint { + remote-endpoint = + <&du_out_lvds0>; + }; + }; + + port@1 { + reg = <1>; + lvds0_out: endpoint { }; }; };
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 5/5 arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
In reply to Sergei ShtylyovDefine the Condor/V3HSK board dependent parts of the DU and LVDS device nodes. Also add the device nodes for Thine THC63LVD1024 LVDS decoder and Analog Devices ADV7511W HDMI transmitter...
Based on the original (and large) patch by Vladimir Barinov.
---
Changes in version 2:
- added the V3HSK DT update, reworded the description, renamed the patch;
- added a space between the HDMI node name and a brace.
arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 106 +++++++++++++++++++++ arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 120 ++++++++++++++++++++++++ 2 files changed, 226 insertions(+)
arch/arm64/boot/dts/renesas/r8a77980-condor.dts +106 -0
@@ -45,6 +45,56 @@ regulator-boot-on; regulator-always-on; }; + + d1_8v: regulator-2 { + compatible = "regulator-fixed"; + regulator-name = "D1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + hdmi-out { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con: endpoint { + remote-endpoint = <&adv7511_out>; + }; + }; + }; + + lvds-decoder { + compatible = "thine,thc63lvd1024"; + vcc-supply = <&d3_3v>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port at 0 { + reg = <0>; + thc63lvd1024_in: endpoint { + remote-endpoint = <&lvds0_out>; + }; + }; + + port at 2 { + reg = <2>; + thc63lvd1024_out: endpoint { + remote-endpoint = <&adv7511_in>; + }; + }; + }; + }; + + x1_clk: x1-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <148500000>; + }; }; &avb {
@@ -74,6 +124,13 @@ }; }; +&du { + clocks = <&cpg CPG_MOD 724>, + <&x1_clk>; + clock-names = "du.0", "dclkin.0"; + status = "okay"; +}; + &extal_clk { clock-frequency = <16666666>; };
@@ -102,6 +159,55 @@ gpio-controller; #gpio-cells = <2>; }; + + hdmi at 39 { + compatible = "adi,adv7511w"; + reg = <0x39>; + interrupt-parent = <&gpio1>; + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; + avdd-supply = <&d1_8v>; + dvdd-supply = <&d1_8v>; + pvdd-supply = <&d1_8v>; + bgvdd-supply = <&d1_8v>; + dvdd-3v-supply = <&d3_3v>; + + adi,input-depth = <8>; + adi,input-colorspace = "rgb"; + adi,input-clock = "1x"; + adi,input-style = <1>; + adi,input-justification = "evenly"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port at 0 { + reg = <0>; + adv7511_in: endpoint { + remote-endpoint = <&thc63lvd1024_out>; + }; + }; + + port at 1 { + reg = <1>; + adv7511_out: endpoint { + remote-endpoint = <&hdmi_con>; + }; + }; + }; + }; +}; + +&lvds0 { + status = "okay"; + + ports { + port at 1 { + lvds0_out: endpoint { + remote-endpoint = <&thc63lvd1024_in>; + }; + }; + }; }; &mmc0 {
arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts +120 -0
138 lines not on this page · raw message
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
In reply to Sergei ShtylyovQuoted 9 lines · Sergei Shtylyov
Hello!
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
Quoted 5 lines
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support [5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
Sergei,
what are the changes in this series between v1 and v2?
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
Quoted 13 lines · Simon Horman
Quoted 7 lines
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
Quoted 5 lines
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support [5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
Quoted 3 lines
Sergei,
what are the changes in this series between v1 and v2?
See patch #5. I've added the V3HSK DT update there...
MBR, Sergei
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
In reply to Sergei ShtylyovHi Sergei,
Quoted 9 lines · On Thursday, 7 June 2018 23:17:03 EEST Sergei Shtylyov wrote:
Hello!
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
Quoted 4 lines
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support
Based on the recent request of the ARM SoC maintainers to avoid a plethora of small patches, I think you can squash 1/5 to 4/5 all together.
Quoted 1 line
[5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
Signature · 3 lines
Regards, Laurent Pinchart
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
Quoted 12 lines · Laurent Pinchart
Hi Sergei,
Quoted 9 lines · On Thursday, 7 June 2018 23:17:03 EEST Sergei Shtylyov wrote:
Hello!
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
Quoted 7 lines
Quoted 4 lines
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support
Based on the recent request of the ARM SoC maintainers to avoid a plethora of small patches, I think you can squash 1/5 to 4/5 all together.
Agreed.
Seregi could you please post a v2 with patches 1 - 4 squashed and the register range for VSPD0 reduced to 0x5000? Thanks!
Quoted 1 line
Quoted 1 line
[5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
v2 cover Add R8A77980/Condor/V3HSK LVDS/HDMI support
Quoted 12 lines · Simon Horman
Quoted 12 lines
Quoted 11 lines
Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine THC63LVD1024 driver and the R8A77980 LVDS support patch in order to work, and R8A77980 GPIO DT patches in order to apply/compile...
[1/5] arm64: dts: renesas: r8a77980: add FCPVD support [2/5] arm64: dts: renesas: r8a77980: add VSPD support [3/5] arm64: dts: renesas: r8a77980: add DU support [4/5] arm64: dts: renesas: r8a77980: add LVDS support
Quoted 6 lines
Quoted 2 lines
Based on the recent request of the ARM SoC maintainers to avoid a plethora of small patches, I think you can squash 1/5 to 4/5 all together.
Agreed.
Seregi could you please post a v2 with patches 1 - 4 squashed and the
It's going to be v3 already. :-)
Quoted 1 line
register range for VSPD0 reduced to
0x5000? Thanks!
More like increased. :-)
Working on it...
Quoted 1 line
Quoted 1 line
Quoted 1 line
[5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support
MBR, Sergei