nubus: Kill nubus_proc_detach_device()
PATCH 1/1 nubus: Kill nubus_proc_detach_device()
Commit 59d8053f1e16904d54ed7469d4b36801ea6b8f2c ("proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h") broke Apple NuBus support:
drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’:drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete type drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type
Fortunately nubus_proc_detach_device() is unused, and appears to have never been used, so just remove it.
--- drivers/nubus/proc.c | 15 --------------- include/linux/nubus.h | 1 - 2 files changed, 0 insertions(+), 16 deletions(-)
drivers/nubus/proc.c +0 -15
@@ -147,21 +147,6 @@ int nubus_proc_attach_device(struct nubus_dev *dev) }EXPORT_SYMBOL (nubus_proc_attach_device); -/* FIXME: this is certainly broken! */ -int nubus_proc_detach_device (struct nubus_dev *dev) -{ -struct proc_dir_entry *e; - -if ((e = dev->procdir)) { -if (atomic_read (&e->count)) -return -EBUSY ; -remove_proc_entry (e->name, proc_bus_nubus_dir); - dev->procdir =NULL ; - } -return 0 ; -} -EXPORT_SYMBOL (nubus_proc_detach_device); -/* * /proc/nubus stuff */
include/linux/nubus.h +0 -1
@@ -87,7 +87,6 @@ static inline void nubus_proc_init(void) {}#endif int get_nubus_list (char *buf);int nubus_proc_attach_device (struct nubus_dev *dev); -int nubus_proc_detach_device (struct nubus_dev *dev);/* If we need more precision we can add some more of these */ struct nubus_dev* nubus_find_device(unsigned short category, unsigned short type,
Signature · 1 line
1.7.0.4
Quoted 4 lines · Geert Uytterhoeven
Commit
59d8053f1e16904d54ed7469d4b36801ea6b8f2c("proc: Move non-public stuff fromlinux/proc_fs.htofs/proc/internal.h") broke Apple NuBus support:
Quoted 8 lines
drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’:drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete typedrivers/nubus/proc.c:158: error: dereferencing pointer to incomplete typeFortunately
nubus_proc_detach_device()is unused, and appears to have never been used, so just remove it.Signed-off-by Geert Uytterhoeven <[email protected]>
Fine by me.