ARM: dts: imx8mq-kontron-pitx-imx8m: Remove off-on-delay-us property
Subsystems (2)
PATCH 1/1 ARM: dts: imx8mq-kontron-pitx-imx8m: Remove off-on-delay-us property
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
---
The same change is done in the linux dts file.
arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)
arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0 -1
@@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
Signature · 1 line
2.30.2
Hi Heiko,
Quoted 8 lines · Heiko Thiery
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.
I saw your equivalent patch to the Linux devicetree. When I saw it, it was unclear whether it fixed a bug.
Reading the commit log of this patch, it becomes clear.
I suggest you improve the commit log to the other patch to state that it fixes a real bug.
Hi,
Am Mo., 24. Okt. 2022 um 13:31 Uhr schrieb Fabio Estevam <[email protected]>:
Quoted 13 lines
Hi Heiko,
Quoted 8 lines · Heiko Thiery
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.
Quoted 7 lines
I saw your equivalent patch to the Linux devicetree. When I saw it, it was unclear whether it fixed a bug.
Reading the commit log of this patch, it becomes clear.
I suggest you improve the commit log to the other patch to state that it fixes a real bug.
Will do, thanks!
Quoted 2 lines
Reviewed-by Fabio Estevam <[email protected]>
Quoted 3 lines · Heiko Thiery
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
off-on-delay-us here would cause store env failure? Would you please share more info?
Thanks,
Peng.
Quoted 20 lines
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0
-1@@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
Hi Peng,
Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <[email protected]>:
Quoted 10 lines · Heiko Thiery
Quoted 3 lines
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
off-on-delay-us here would cause store env failure? Would you please share more info?
I saw that the environment could not be loaded/stored since the synchroinzation of the device tree from linux 181d1684cae07f111 (imx8mq: synchronise device tree with linux) and then without doing a bisect I found this commit 5d42ea553534 (ARM: dts: imx8mq-evk: Remove u-boot,off-on-delay-us property). After removing the delay loading/storing worked again.
Signature · 1 line
Heiko
Quoted 24 lines
Thanks,
Peng.Quoted 20 lines
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0
-1@@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
Hi Heiko
Quoted 15 lines · Heiko Thiery
Hi Peng,
Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <[email protected]>:
Quoted 10 lines · Heiko Thiery
Quoted 3 lines
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
off-on-delay-us here would cause store env failure? Would you please share more info?
Quoted 7 lines
I saw that the environment could not be loaded/stored since the synchroinzation of the device tree from linux
181d1684cae07f111(imx8mq: synchronise device tree with linux) and then without doing a bisect I found this commit5d42ea553534(ARM: dts: imx8mq-evk: Remove u-boot,off-on-delay-us property). After removing the delay loading/storing worked again.
What is not clear apart the environment store if the sdcard is working or not
Michael
Quoted 29 lines
--
HeikoQuoted 24 lines
Thanks,
Peng.Quoted 20 lines
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0
-1@@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Hi Michael,
Am Di., 25. Okt. 2022 um 08:46 Uhr schrieb Michael Nazzareno Trimarchi <[email protected]>:
Quoted 27 lines
Hi Heiko
Quoted 15 lines · Heiko Thiery
Hi Peng,
Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <[email protected]>:
Quoted 10 lines · Heiko Thiery
Quoted 3 lines
U-Boot is not able to store the environment variables in the SD card.
Remove the off-on-delay-us property to fix the regression.
off-on-delay-us here would cause store env failure? Would you please share more info?
Quoted 7 lines
I saw that the environment could not be loaded/stored since the synchroinzation of the device tree from linux
181d1684cae07f111(imx8mq: synchronise device tree with linux) and then without doing a bisect I found this commit5d42ea553534(ARM: dts: imx8mq-evk: Remove u-boot,off-on-delay-us property). After removing the delay loading/storing worked again.
Quoted 1 line
What is not clear apart the environment store if the sdcard is working or not
Ok, Accessing the SD card at all is not working. I only noticed it first because the environment could not be loaded.
Signature · 1 line
Heiko
Quoted 47 lines
Michael
Quoted 17 lines
--
HeikoQuoted 12 lines
Thanks,
Peng.Quoted 8 lines
Signed-off-by Heiko Thiery <[email protected]>---
The same change is done in the linux dts file.arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0
-0Quoted 8 lines
arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts line 56
Quoted 8 lines
arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +0
-1@@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com