Skip to contentSkip to conversation

media: docs: Modify the section of User xattr

PATCH In review Deming Wang 3 participants 3 messages Jun 24, 2022 – Jun 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: docs: Modify the section of User xattr

Delete duplicate words of "the".

---
 Documentation/filesystems/overlayfs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/overlayfs.rst +1 -1
index 7da6c30ed596..4c76fda07645 100644
@@ -607,7 +607,7 @@ can be removed.
 User xattr
 ----------
 
-The the "-o userxattr" mount option forces overlayfs to use the
+The "-o userxattr" mount option forces overlayfs to use the
 "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
 useful for unprivileged mounting of overlayfs.
 
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 12 lines · Deming Wang

Delete duplicate words of "the".

---
 Documentation/filesystems/overlayfs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/overlayfs.rst +0 -0
index 7da6c30ed596..4c76fda07645 100644

Documentation/filesystems/overlayfs.rst can be removed. · line 612

Quoted 7 lines
Documentation/filesystems/overlayfs.rst +1 -1
@@ -607,7 +607,7 @@ can be removed.
 User xattr
 ----------
 
-The the "-o userxattr" mount option forces overlayfs to use the
+The "-o userxattr" mount option forces overlayfs to use the
 "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
 useful for unprivileged mounting of overlayfs.

I've applied this but changed the patch title. This is not a media patch, and "modify" tells the reader nothing; it's now "docs: Remove duplicate word".

Thanks,

jon

#2 lore raw
In reply to Deming Wang
Quoted 2 lines · Deming Wang

Delete duplicate words of "the".

I think "Modify something" isn't clear subject, because reviewers don't know at glance the logical change this patch is doing other than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message same as the subject, if the message can't be described more concise but clearer.

Documentation/filesystems/overlayfs.rst can be removed. · line 613

Quoted 9 lines
Documentation/filesystems/overlayfs.rst +1 -1
@@ -607,7 +607,7 @@ can be removed.
 User xattr
 ----------
 
-The the "-o userxattr" mount option forces overlayfs to use the
+The "-o userxattr" mount option forces overlayfs to use the
 "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
 useful for unprivileged mounting of overlayfs.
 

The diff looks OK.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara