tests/9p: prevent potential error in do_local_xattr_limit()
PATCH 1/1 tests/9p: prevent potential error in do_local_xattr_limit()
The local fs backend driver tests require that a dummy file is created on the host side before running the xattr limit tests, otherwise the test will fail because the file is expected to exist.
The original call of g_file_set_contents() didn't check its return value, which might cause subsequent test checks to fail, making it harder to identify the root cause.
Fix this by simply wrapping the call into a g_assert().
CID: 1660926
--- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/virtio-9p-test.c +1 -1
@@ -402,7 +402,7 @@ static void do_local_xattr_limit(QVirtio9P *v9p, int max_xattr)/* * this file must be created for the test to work with the 'local' fs driver */ -g_file_set_contents (test_file,"" ,0 ,NULL ); +g_assert (g_file_set_contents (test_file,"" ,0 ,NULL ));/* the actual test code shared with the 'synth' fs driver tests */ do_xattr_limit (v9p, max_xattr, false);
Signature · 1 line
2.47.3
Quoted 8 lines · Christian Schoenebeck
The local fs backend driver tests require that a dummy file is created on the host side before running the xattr limit tests, otherwise the test will fail because the file is expected to exist.
The original call of
g_file_set_contents()didn't check its return value, which might cause subsequent test checks to fail, making it harder to identify the root cause.
Quoted 8 lines
Fix this by simply wrapping the call into a
g_assert().Fixes 04a62cdfe873 ("tests/9p: add 3 xattr FID limit test cases (local fs driver)")CID: 1660926
Signed-off-by Christian Schoenebeck <[email protected]>--- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines · Christian Schoenebeck
The local fs backend driver tests require that a dummy file is created on the host side before running the xattr limit tests, otherwise the test will fail because the file is expected to exist.
The original call of
g_file_set_contents()didn't check its return value, which might cause subsequent test checks to fail, making it harder to identify the root cause.
Quoted 9 lines
Fix this by simply wrapping the call into a
g_assert().Fixes 04a62cdfe873 ("tests/9p: add 3 xattr FID limit test cases (local fs driver)")CID: 1660926
Signed-off-by Christian Schoenebeck <[email protected]>--- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines · Christian Schoenebeck
The local fs backend driver tests require that a dummy file is created on the host side before running the xattr limit tests, otherwise the test will fail because the file is expected to exist.
The original call of
g_file_set_contents()didn't check its return value, which might cause subsequent test checks to fail, making it harder to identify the root cause.
Quoted 8 lines
Fix this by simply wrapping the call into a
g_assert().Fixes 04a62cdfe873 ("tests/9p: add 3 xattr FID limit test cases (local fs driver)")CID: 1660926
Signed-off-by Christian Schoenebeck <[email protected]>--- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines · On Friday, 3 July 2026 17:38:10 CEST Christian Schoenebeck wrote:
The local fs backend driver tests require that a dummy file is created on the host side before running the xattr limit tests, otherwise the test will fail because the file is expected to exist.
The original call of
g_file_set_contents()didn't check its return value, which might cause subsequent test checks to fail, making it harder to identify the root cause.
Quoted 8 lines
Fix this by simply wrapping the call into a
g_assert().Fixes 04a62cdfe873 ("tests/9p: add 3 xattr FID limit test cases (local fsdriver)") CID: 1660926
Signed-off-by Christian Schoenebeck <[email protected]>--- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
/Christian