app/test: fix missing header
PATCH 1/1 app/test: fix missing header
Build of test_compressdev.c fails on FreeBSD due to the missing include of unistd.h, to provide the function usleep.
---
I sent this previously, but I don't think it made the public list, so resending. Apologies to anyone who gets this twice!
--- app/test/test_compressdev.c | 1 + 1 file changed, 1 insertion(+)
app/test/test_compressdev.c +1 -0
@@ -5,6 +5,7 @@#include <zlib.h> #include <math.h> #include <stdlib.h> +#include <unistd.h> #include <rte_cycles.h> #include <rte_malloc.h>
Signature · 1 line
2.20.1
nit: "test/compress:" for the title prefix ?
Quoted 29 lines · Bruce Richardson
Build of
test_compressdev.cfails on FreeBSD due to the missing include ofunistd.h, to provide the function usleep.Fixes b06aa643cac4 ("test/compress: add initial unit tests")Signed-off-by Bruce Richardson <[email protected]>---
I sent this previously, but I don't think it made the public list, so resending.
Apologies to anyone who gets this twice!--- app/test/test_compressdev.c | 1 + 1 file changed, 1 insertion(+)app/test/test_compressdev.c +1
-1@@ -5,6 +5,7 @@#include <zlib.h> #include <math.h> #include <stdlib.h> +#include <unistd.h> #include <rte_cycles.h> #include <rte_malloc.h> --
Quoted 3 lines
2.20.1
Tested on FreeBSD 10.4.
Signature · 1 line
David Marchand
Quoted 1 line · David Marchand
nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like this with! :-) Thomas, please fix on apply, if possible.
Quoted 27 lines
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <[1][email protected]> wrote: Build of test_compressdev.c fails on FreeBSD due to the missing include of unistd.h, to provide the function usleep. Fixes: b06aa643cac4 ("test/compress: add initial unit tests") Cc: [2][email protected] Cc: [3][email protected] Signed-off-by: Bruce Richardson <[4][email protected]> --- I sent this previously, but I don't think it made the public list, so resending. Apologies to anyone who gets this twice! --- app/test/test_compressdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index 404b98f60..121514af5 100644 --- a/app/test/test_compressdev.c +++ b/app/test/test_compressdev.c @@ -5,6 +5,7 @@ #include <zlib.h> #include <math.h> #include <stdlib.h> +#include <unistd.h> #include <rte_cycles.h>
Quoted 9 lines
#include <rte_malloc.h>
--
2.20.1
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand <[5][email protected]>
--
David MarchandThanks,
/Bruce
Thomas Monjalon
Applied19/04/2019 14:12, Bruce Richardson:
Quoted 5 lines · David Marchand
Quoted 1 line
nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like this with! :-) Thomas, please fix on apply, if possible.
In this case, you can just copy the prefix from the "Fixes:" line :)
Quoted 10 lines
Quoted 10 lines
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <[1][email protected]> wrote:
Build of
test_compressdev.cfails on FreeBSD due to the missing include ofunistd.h, to provide the function usleep.Fixes b06aa643cac4 ("test/compress: add initial unit tests")Cc [2][email protected]Cc [3][email protected]Signed-off-by Bruce Richardson <[4][email protected]>
Quoted 2 lines
Quoted 2 lines
Tested on FreeBSD 10.4.
Reviewed-by David Marchand <[5][email protected]>
Applied, thanks