misc: Fix irq leak in max8997_muic_probe error path
함명주
Acked-byQuoted 4 lines
Current code does not properly free allocated irqs if
request_threaded_irqreturns error, fix it.Signed-off-by Axel Lin <[email protected]>
Thanks for pointing that out.
Acked-by MyungJoo Ham <[email protected]>
Quoted 30 lines
--- drivers/misc/max8997-muic.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)drivers/misc/max8997-muic.c +2
-4@@ -566,10 +566,6 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)"failed: irq request (IRQ: %d," " error :%d)\n" , muic_irq->irq, ret); - -for (i = i -1 ; i >=0 ; i--) -free_irq (muic_irq->irq, info); - goto err_irq; } }@@ -583,6 +579,8 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)return ret; err_irq: +while (--i >=0 ) +free_irq (pdata->irq_base + muic_irqs[i].irq, info);sysfs_remove_group (&pdev->dev.kobj, &max8997_muic_group); err_sysfs: err_pdata:Signature · 1 line
1.7.5.4
�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m����띠�◀?뻀�