OSSTEST: Install libtirpc-dev for libvirt builds
PATCH 1/1 OSSTEST: Install libtirpc-dev for libvirt builds
The check for XDR support was changed in libvirt commit d7147b3797 to use libtirpc pkg-config instead of complicated AC_CHECK_LIB, AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been failing since this change hit libvirt.git master. Fix it by adding libtirpc-dev to the list of 'extra_packages' installed for libvirt builds.
---
I *think* this change will work for older libvirt branches too. The old, hand-coded m4 logic should work with libtirpc-dev installed.
Osstest/Toolstack/libvirt.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Osstest/Toolstack/libvirt.pm +1 -1
@@ -26,7 +26,7 @@ use XML::LibXML; sub new { my ($class, $ho, $methname,$asset) = @_; - my @extra_packages = qw(libavahi-client3); + my @extra_packages = qw(libavahi-client3 libtirpc-dev); my $nl_lib = "libnl-3-200"; my $libgnutls = "libgnutls30";
Signature · 1 line
2.26.2
Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"):
Quoted 8 lines
The check for XDR support was changed in libvirt commit
d7147b3797to use libtirpc pkg-config instead of complicatedAC_CHECK_LIB,AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been failing since this change hit libvirt.git master. Fix it by adding libtirpc-dev to the list of 'extra_packages' installed for libvirt builds.Signed-off-by Jim Fehlig <[email protected]>
Thanks! I will push this to osstest pretest shortly.
Ian.
Quoted 8 lines · Ian Jackson
Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"):
Quoted 7 lines
The check for XDR support was changed in libvirt commit
d7147b3797to use libtirpc pkg-config instead of complicatedAC_CHECK_LIB,AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been failing since this change hit libvirt.git master. Fix it by adding libtirpc-dev to the list of 'extra_packages' installed for libvirt builds.
Quoted 5 lines
Quoted 1 line
Signed-off-by Jim Fehlig <[email protected]>Reviewed-by Ian Jackson <[email protected]>Thanks! I will push this to osstest pretest shortly.
Thanks Ian! Perhaps you've noticed libvirt has now moved to the meson build system. My weak perl skills have discouraged me from investigating ways to accommodate that.
Regards,
Jim