Skip to contentSkip to conversation

build: detect backtrace availability

PATCH In review Thomas Monjalon 2 participants 3 messages Jan 8, 2023 – Feb 2, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: detect backtrace availability

Backtrace dump is available:
- always on Windows
- on Linux/BSD if execinfo.h is available (not anymore on Alpine)

The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h. It is now set only if the feature is available.

Note: Alpine Linux has decided to remove libexecinfo support, so this change will allow to compile DPDK on recent Alpine Linux.

---
 config/meson.build                | 3 ++-
 config/rte_config.h               | 1 -
 doc/guides/linux_gsg/sys_reqs.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
config/meson.build +2 -1
index 80564eec52..0c4d1f06e5 100644
@@ -200,10 +200,11 @@ if fdt_dep.found() and cc.has_header('fdt.h')
 endif
 
 libexecinfo = cc.find_library('libexecinfo', required: false)
-if libexecinfo.found() and cc.has_header('execinfo.h')
+if libexecinfo.found()
     add_project_link_arguments('-lexecinfo', language: 'c')
     dpdk_extra_ldflags += '-lexecinfo'
 endif
+dpdk_conf.set('RTE_BACKTRACE', cc.has_header('execinfo.h') or is_windows)
 
 libarchive = dependency('libarchive', required: false, method: 'pkg-config')
 if libarchive.found()
config/rte_config.h +0 -1
index 3c4876d434..7b8c85e948 100644
@@ -37,7 +37,6 @@
 #define RTE_MAX_MEMZONE 2560
 #define RTE_MAX_TAILQ 32
 #define RTE_LOG_DP_LEVEL RTE_LOG_INFO
-#define RTE_BACKTRACE 1
 #define RTE_MAX_VFIO_CONTAINERS 64
 
 /* bsd module defines */
doc/guides/linux_gsg/sys_reqs.rst +1 -1
index e4f9b41251..2a7988cf46 100644
@@ -32,7 +32,7 @@ Compilation of the DPDK
 
     * For RHEL/Fedora systems these can be installed using ``dnf groupinstall "Development Tools"``
     * For Ubuntu/Debian systems these can be installed using ``apt install build-essential``
-    * For Alpine Linux, ``apk add alpine-sdk bsd-compat-headers libexecinfo-dev``
+    * For Alpine Linux, ``apk add alpine-sdk bsd-compat-headers``
 
 .. note::
 
Signature · 1 line
2.39.0
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Thomas Monjalon

Backtrace dump is available:
- always on Windows
- on Linux/BSD if execinfo.h is available (not anymore on Alpine)

Quoted 8 lines

The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h. It is now set only if the feature is available.

Note: Alpine Linux has decided to remove libexecinfo support, so this change will allow to compile DPDK on recent Alpine Linux.

---

author Applied
#2 lore raw

09/01/2023 10:08, Bruce Richardson:

Quoted 8 lines · Thomas Monjalon
Quoted 7 lines

Backtrace dump is available:
- always on Windows
- on Linux/BSD if execinfo.h is available (not anymore on Alpine)

The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h. It is now set only if the feature is available.

Quoted 6 lines
Quoted 4 lines

Note: Alpine Linux has decided to remove libexecinfo support, so this change will allow to compile DPDK on recent Alpine Linux.

Applied