Skip to contentSkip to conversation

RDMA/uverbs: remove the unnecessary assignment

PATCH Applied [email protected] 3 participants 4 messages Dec 6, 2021 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/uverbs: remove the unnecessary assignment

From: Zhu Yanjun <[email protected]>

The struct member variable create_flags are assigned twice. Remove the unnecessary assignment.

Fixes ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
---
 drivers/infiniband/core/uverbs_cmd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/core/uverbs_cmd.c +0 -1
index d1345d76d9b1..6b6393176b3c 100644
@@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
 	attr.sq_sig_type   = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
 					      IB_SIGNAL_REQ_WR;
 	attr.qp_type       = cmd->qp_type;
-	attr.create_flags  = 0;
 
 	attr.cap.max_send_wr     = cmd->max_send_wr;
 	attr.cap.max_recv_wr     = cmd->max_recv_wr;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · On 7 Dec 2021, at 07:46, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

The struct member variable create_flags are assigned twice.

may be "... is assigned twice." ?

Quoted 4 lines

Remove the unnecessary assignment.

Fixes ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")

LGTM, so

Thxs, Håkon

Quoted 19 lines

---
drivers/infiniband/core/uverbs_cmd.c | 1 -

1 file changed, 1 deletion(-)
drivers/infiniband/core/uverbs_cmd.c +0 -1
index d1345d76d9b1..6b6393176b3c 100644
@@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
 	attr.sq_sig_type   = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
 					      IB_SIGNAL_REQ_WR;
 	attr.qp_type       = cmd->qp_type;
-	attr.create_flags  = 0;
 
 	attr.cap.max_send_wr     = cmd->max_send_wr;
 	attr.cap.max_recv_wr     = cmd->max_recv_wr;
Signature · 1 line
2.27.0
author
#2 lore raw
Quoted 9 lines · Haakon Bugge
Quoted 7 lines · On 7 Dec 2021, at 07:46, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

The struct member variable create_flags are assigned twice.

may be "... is assigned twice." ?

My bad. Thanks.

Zhu Yanjun

Quoted 34 lines
Quoted 5 lines

Remove the unnecessary assignment.

Fixes ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")

LGTM, so

Thxs, Håkon

Quoted 19 lines

---
drivers/infiniband/core/uverbs_cmd.c | 1 -

1 file changed, 1 deletion(-)
drivers/infiniband/core/uverbs_cmd.c +0 -1
index d1345d76d9b1..6b6393176b3c 100644
@@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
 	attr.sq_sig_type   = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
 					      IB_SIGNAL_REQ_WR;
 	attr.qp_type       = cmd->qp_type;
-	attr.create_flags  = 0;
 
 	attr.cap.max_send_wr     = cmd->max_send_wr;
 	attr.cap.max_recv_wr     = cmd->max_recv_wr;
Signature · 1 line
2.27.0
maintainer Applied
#3 lore raw
In reply to [email protected]
Quoted 11 lines · On Tue, Dec 07, 2021 at 01:46:07AM -0500, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

The struct member variable create_flags are assigned twice. Remove the unnecessary assignment.

Fixes ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
---
 drivers/infiniband/core/uverbs_cmd.c | 1 -
 1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason