ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')
PATCH 1/1 ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ else
--- sound/hda/codecs/realtek/alc269.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/hda/codecs/realtek/alc269.c +2 -2
@@ -2296,9 +2296,9 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,struct alc_spec *spec = codec->spec; spec->parse_flags |=HDA_PINCFG_HEADSET_MIC ;alc255_set_default_jack_type (codec); - } -else + }else {alc_fixup_headset_mode (codec, fix, action); + } } static void alc288_update_headset_jack_cb(struct hda_codec *codec,
Signature · 1 line
2.25.1
Takashi Iwai
AppliedQuoted 5 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
Quoted 7 lines
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ elseFixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>
Thanks, applied to for-next branch.
Takashi
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ else
Quoted 4 lines
Quoted 2 lines
Fixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>Thanks, applied to for-next branch.
I hope you dropped the fake Fixes tag. Or at least give people chance to review it.
Best regards,
Krzysztof
Quoted 13 lines · Krzysztof Kozlowski
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ else
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Fixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>Thanks, applied to for-next branch.
I hope you dropped the fake Fixes tag. Or at least give people chance to review it.
I see you entirely ignored all the comments about fake bug being fixed here.
Best regards,
Krzysztof
Quoted 18 lines · Krzysztof Kozlowski
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Takashi Iwai
Quoted 12 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ elseFixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Thanks, applied to for-next branch.
I hope you dropped the fake Fixes tag. Or at least give people chance to review it.
I see you entirely ignored all the comments about fake bug being fixed here.
I saw your comments, but I have a different opinion.
In the case of HD-audio code where the code change happens very actively and quite often backported to stable trees, a change like this would block the further backports if missing. With a hint of Fixes tag, the change of the code change can be tracked more easily, hence it's still worth to have.
thanks,
Takashi
Quoted 25 lines · Takashi Iwai
Quoted 23 lines · Krzysztof Kozlowski
Quoted 20 lines · Krzysztof Kozlowski
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ elseQuoted 4 lines
Quoted 2 lines
Fixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>Thanks, applied to for-next branch.
I hope you dropped the fake Fixes tag. Or at least give people chance to review it.
Quoted 6 lines
Quoted 1 line
I see you entirely ignored all the comments about fake bug being fixed here.
I saw your comments, but I have a different opinion.
In the case of HD-audio code where the code change happens very actively and quite often backported to stable trees, a change like this would block the further backports if missing. With a hint of
No, it would not. Commits marked for backports can even mention dependencies.
Quoted 2 lines
Fixes tag, the change of the code change can be tracked more easily, hence it's still worth to have.
Fake fixes tag is not the solution for that. It adds effort on stable team for no gain, it adds work on people evaluating backported commits for no gain.
BTW, since I was looking at your tree - you have contributions from [email protected] which does not follow requirements for a *known identity*. IOW, it does not pass DCO requirements and should not be accepted.
Best regards,
Krzysztof
Quoted 37 lines · Krzysztof Kozlowski
Quoted 25 lines · Takashi Iwai
Quoted 23 lines · Krzysztof Kozlowski
Quoted 20 lines · Krzysztof Kozlowski
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ elseQuoted 4 lines
Quoted 2 lines
Fixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")Signed-off-by Lei Huang <[email protected]>Thanks, applied to for-next branch.
I hope you dropped the fake Fixes tag. Or at least give people chance to review it.
Quoted 6 lines
Quoted 1 line
I see you entirely ignored all the comments about fake bug being fixed here.
I saw your comments, but I have a different opinion.
In the case of HD-audio code where the code change happens very actively and quite often backported to stable trees, a change like this would block the further backports if missing. With a hint ofNo, it would not. Commits marked for backports can even mention dependencies.
Quoted 6 lines
Quoted 2 lines
Fixes tag, the change of the code change can be tracked more easily, hence it's still worth to have.
Fake fixes tag is not the solution for that. It adds effort on stable team for no gain, it adds work on people evaluating backported commits for no gain.
It actually helps a lot on distro side, judging from my long experience of backporting (literally) million of patches for openSUSE / SUSE kernels.
Quoted 4 lines
BTW, since I was looking at your tree - you have contributions from [email protected] which does not follow requirements for a *known identity*. IOW, it does not pass DCO requirements and should not be accepted.
Do you mean the form
?
The name spelling without space is pretty normal in Chinese.
thanks,
Takashi
Quoted 10 lines · Takashi Iwai
It actually helps a lot on distro side, judging from my long experience of backporting (literally) million of patches for openSUSE / SUSE kernels.
Quoted 4 lines
BTW, since I was looking at your tree - you have contributions from [email protected] which does not follow requirements for a *known identity*. IOW, it does not pass DCO requirements and should not be accepted.
Quoted 5 lines
Do you mean the form
Signed-off-by songxiebing <[email protected]>?
The name spelling without space is pretty normal in Chinese.
It is a copy of email username. I am no expert, but usually Latin transliterations have differences from usernames (and Google confirms that space is expected for transliteration, although Google is no expert either), so this looks like semi-configured Git.
Best regards,
Krzysztof
Quoted 12 lines · Krzysztof Kozlowski
Quoted 10 lines · Takashi Iwai
It actually helps a lot on distro side, judging from my long experience of backporting (literally) million of patches for openSUSE / SUSE kernels.
Quoted 4 lines
BTW, since I was looking at your tree - you have contributions from [email protected] which does not follow requirements for a *known identity*. IOW, it does not pass DCO requirements and should not be accepted.
Quoted 7 lines
Quoted 5 lines
Do you mean the form
Signed-off-by songxiebing <[email protected]>?
The name spelling without space is pretty normal in Chinese.
It is a copy of email username.
... and the username shows the real name in this case :)
Quoted 4 lines
I am no expert, but usually Latin
transliterations have differences from usernames (and Google confirms that space is expected for transliteration, although Google is no expert either), so this looks like semi-configured Git.
Yeah, it's possible, but also it's a common pattern, too.
Strictly speaking, it's rather a mistake, and I'm no fan of that style, too. OTOH, since it's relatively broadly used and can serve for denoting the known identity, at least, I took as is.
thanks,
Takashi
Quoted 10 lines · Lei Huang
From: Lei Huang <[email protected]>
Fix checkpatch code style errors:
ERROR: else should follow close brace '}' #2300: FILE:
sound/hda/codecs/realtek/alc269.c:2300:
+ }
+ elseFixes 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
There is no bug to be fixed here. Don't add fake bug indications, it unnecessarily gives stable team some work.
Drop the tag.
Best regards,
Krzysztof