afs: Fix afs_atcell_get_link() to check if ws_cell is unset first
Subsystems (2)
David Howells
maintainerPATCH 1/1 afs: Fix afs_atcell_get_link() to check if ws_cell is unset first
Fix afs_atcell_get_link() to check if the workstation cell is unset before doing the RCU pathwalk bit where we dereference that.
--- fs/afs/dynroot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
fs/afs/dynroot.c +3 -3
@@ -210,6 +210,9 @@ static const char *afs_atcell_get_link(struct dentry *dentry, struct inode *inodconst char *name;bool dotted = vnode->fid.vnode ==3 ; +if (!rcu_access_pointer (net->ws_cell)) +return ERR_PTR (-ENOENT ); +if (!dentry) {/* We're in RCU-pathwalk. */ cell =rcu_dereference (net->ws_cell);
@@ -221,9 +224,6 @@ static const char *afs_atcell_get_link(struct dentry *dentry, struct inode *inodreturn name; } -if (!rcu_access_pointer (net->ws_cell)) -return ERR_PTR (-ENOENT ); -down_read (&net->cells_lock); cell =rcu_dereference_protected (net->ws_cell,lockdep_is_held (&net->cells_lock));
Quoted 10 lines · David Howells
Fix
afs_atcell_get_link()to check if the workstation cell is unset before doing the RCU pathwalk bit where we dereference that.Fixes 823869e1e616 ("afs: Fix afs_atcell_get_link() to handle RCU pathwalk")Reported-by [email protected]Signed-off-by David Howells <[email protected]>Tested-by [email protected]cc Marc Dionne <[email protected]>
My fix already sent, it is much earlier than your patch.
https://lore.kernel.org/all/[email protected]/
BR,
Edward
Quoted 4 lines · David Howells
Fix
afs_atcell_get_link()to check if the workstation cell is unset before doing the RCU pathwalk bit where we dereference that.
Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes
[1/1] afs: Fix afs_atcell_get_link() to check if ws_cell is unset first
https://git.kernel.org/vfs/vfs/c/0307d16f3610