Skip to contentSkip to conversation

Reduce default children in dio_read test

PATCH In review Andrea Cervesato 3 participants 3 messages Jan 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Reduce default children in dio_read test

We reduce default children from 100 to 8 in order to reduce time execution and memory footprint consuption when using default values.

---
 testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/io/ltp-aiodio/dio_read.c +2 -2
index 2c2ec4bce..b0bbb25d5 100644
@@ -26,7 +26,7 @@ static char *str_readsize;
 static char *str_filesize;
 
 static char *filename = "file.bin";
-static int numchildren = 100;
+static int numchildren = 8;
 static long long writesize = 32 * 1024 * 1024;
 static long long readsize = 32 * 1024 * 1024;
 static long long filesize = 128 * 1024 * 1024;
@@ -171,7 +171,7 @@ static struct tst_test test = {
 	.needs_tmpdir = 1,
 	.forks_child = 1,
 	.options = (struct tst_option[]) {
-		{"n:", &str_numchildren, "Number of threads (default 100)"},
+		{"n:", &str_numchildren, "Number of threads (default 8)"},
 		{"w:", &str_writesize, "Size of writing blocks (default 32M)"},
 		{"r:", &str_readsize, "Size of reading blocks (default 32M)"},
 		{"s:", &str_filesize, "File size (default 128M)"},
Signature · 5 lines
2.34.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v2 1/1
#1 lore raw

Hi Andrea,

So we don't have to use .timeout for it.
Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Acked-by on v2 1/1
#2 lore raw
In reply to Andrea Cervesato

Hi,

Quoted 31 lines · Andrea Cervesato

We reduce default children from 100 to 8 in order to reduce time execution and memory footprint consuption when using default values.

---
 testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/io/ltp-aiodio/dio_read.c +2 -2
index 2c2ec4bce..b0bbb25d5 100644
@@ -26,7 +26,7 @@ static char *str_readsize;
 static char *str_filesize;
 
 static char *filename = "file.bin";
-static int numchildren = 100;
+static int numchildren = 8;
 static long long writesize = 32 * 1024 * 1024;
 static long long readsize = 32 * 1024 * 1024;
 static long long filesize = 128 * 1024 * 1024;
@@ -171,7 +171,7 @@ static struct tst_test test = {
 	.needs_tmpdir = 1,
 	.forks_child = 1,
 	.options = (struct tst_option[]) {
-		{"n:", &str_numchildren, "Number of threads (default 100)"},
+		{"n:", &str_numchildren, "Number of threads (default 8)"},
 		{"w:", &str_writesize, "Size of writing blocks (default 32M)"},
 		{"r:", &str_readsize, "Size of reading blocks (default 32M)"},
 		{"s:", &str_filesize, "File size (default 128M)"},
Signature · 10 lines
Martin Doucha   [email protected]
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp