Skip to contentSkip to conversation

arm64: dts: qcom: sdm845: Add SCM DT node

PATCH In review Sibi Sankar 3 participants 4 messages Oct 26, 2018 – Oct 29, 2018

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Sibi Sankar

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sdm845: Add SCM DT node

Add SCM DT node to enable SCM functionality on SDM845.

Signed-off-by Sibi Sankar <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +6 -0
index b72bdb0a31a5..fad22acfda4d 100644
@@ -221,6 +221,12 @@
 		};
 	};
 
+	firmware {
+		scm {
+			compatible = "qcom,scm-sdm845", "qcom,scm";
+		};
+	};
+
 	tcsr_mutex: hwlock {
 		compatible = "qcom,tcsr-mutex";
 		syscon = <&tcsr_mutex_regs 0 0x1000>;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Sibi Sankar

Add SCM DT node to enable SCM functionality on SDM845.

Signed-off-by Sibi Sankar <[email protected]>
Reviewed-by Bjorn Andersson <[email protected]>

Regards,
Bjorn

Quoted 25 lines
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +6 -0
index b72bdb0a31a5..fad22acfda4d 100644
@@ -221,6 +221,12 @@
 		};
 	};
 
+	firmware {
+		scm {
+			compatible = "qcom,scm-sdm845", "qcom,scm";
+		};
+	};
+
 	tcsr_mutex: hwlock {
 		compatible = "qcom,tcsr-mutex";
 		syscon = <&tcsr_mutex_regs 0 0x1000>;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw
In reply to Sibi Sankar

Hi Sibi,

Quoted 12 lines · Sibi Sankar

Add SCM DT node to enable SCM functionality on SDM845.

Signed-off-by Sibi Sankar <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +0 -0
index b72bdb0a31a5..fad22acfda4d 100644

arch/arm64/boot/dts/qcom/sdm845.dtsi line 228

Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +5 -0
@@ -221,6 +221,12 @@
 		};
 	};
 
+	firmware {
+		scm {
+			compatible = "qcom,scm-sdm845", "qcom,scm";
+		};
+	};

What will happen if the platform is without tz firmware? I'd move this DT node in sdm845-mtp.dts or at least make it status = disabled.

Signature · 2 lines
regards,
Stan
author
#3 lore raw

Hi Stan,
Thanks for the review!

Quoted 18 lines · Stanimir Varbanov

Hi Sibi,

Quoted 15 lines · Sibi Sankar

Add SCM DT node to enable SCM functionality on SDM845.

Signed-off-by Sibi Sankar <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +0 -0
index b72bdb0a31a5..fad22acfda4d 100644
@@ -221,6 +221,12 @@
 		};
 	};
Quoted 8 lines

arch/arm64/boot/dts/qcom/sdm845.dtsi line 228

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +5 -0
+	firmware {
+		scm {
+			compatible = "qcom,scm-sdm845", "qcom,scm";
+		};
+	};

What will happen if the platform is without tz firmware? I'd move this DT node in sdm845-mtp.dts or at least make it status = disabled.

Even in the absence of tz firmware, ATF is expected to implement the necessary handlers for the SMC calls so I don't think it is necessary to keep it disabled.

Signature · 3 lines
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.