ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Subsystems (3)
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.
--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3 -0
@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a {
Signature · 1 line
2.28.0
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Hi Marek,
Quoted 7 lines
From: Marek Vasut <[email protected]>
Sent: lundi 19 octobre 2020 23:38The cd-gpios with (
GPIO_ACTIVE_LOW|GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.
It is strange if it is not working... I will check why the configuration is not managed correctly in stm32 gpio/pincontrol driver.
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3
-1@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a { --
Quoted 1 line
2.28.0
But I will be try to fix the issue before to accept this patch.
I will merge it only if I can't found the root cause for v2020.01-rc2....
Thanks
Patrick
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Quoted 1 line · Patrick DELAUNAY
Hi Marek,
Hi,
Quoted 38 lines
Quoted 7 lines
From: Marek Vasut <[email protected]>
Sent: lundi 19 octobre 2020 23:38The cd-gpios with (
GPIO_ACTIVE_LOW|GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.It is strange if it is not working... I will check why the configuration is not managed correctly in stm32 gpio/pincontrol driver.
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3
-1@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a { --Quoted 1 line
2.28.0
Reviewed-by Patrick Delaunay <[email protected]>
Quoted 3 lines
But I will be try to fix the issue before to accept this patch.
I will merge it only if I can't found the root cause for v2020.01-rc2....
Do you not see the same behavior on EV/DK ?
btw it is bugged in SPL.
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Hi,
Quoted 51 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 22 octobre 2020 20:19
To: Patrick DELAUNAY <[email protected]>; u-boot at lists.denx.de
Cc: Patrice CHOTARD <[email protected]>
Subject: Re: [PATCH] ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Importance: HighQuoted 1 line · Patrick DELAUNAY
Hi Marek,
Hi,
Quoted 38 lines
Quoted 7 lines
From: Marek Vasut <[email protected]>
Sent: lundi 19 octobre 2020 23:38The cd-gpios with (
GPIO_ACTIVE_LOW|GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.It is strange if it is not working... I will check why the configuration is not managed correctly in stm32 gpio/pincontrol driver.
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3
-1@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a { --Quoted 1 line
2.28.0
Reviewed-by Patrick Delaunay <[email protected]>
Quoted 5 lines
Quoted 3 lines
But I will be try to fix the issue before to accept this patch.
I will merge it only if I can't found the root cause for v2020.01-rc2....
Do you not see the same behavior on EV/DK ?
No but I think we have pull-up on board.
But after investigation the internall pull-up is not configurated in stm32 pinctrol (cheked with pinmux command) even it is requested in device-tree of EV1/DK2.
It is clearly a bug (I isolate the issue) and I am working on a patch (it should be sent to u-boot mailing liste next week).
Quoted 1 line
btw it is bugged in SPL.
Ah, what is the issue.
In the stm32 driver or in the framework ?
I will cross-check it also on EV1/DK2.
Patrick
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
On 10/23/20 4:39 PM, Patrick DELAUNAY wrote:
Hi,
[...]
Quoted 52 lines
Quoted 38 lines
Quoted 38 lines
Quoted 7 lines
From: Marek Vasut <[email protected]>
Sent: lundi 19 octobre 2020 23:38The cd-gpios with (
GPIO_ACTIVE_LOW|GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.It is strange if it is not working... I will check why the configuration is not managed correctly in stm32 gpio/pincontrol driver.
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3
-1@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a { --Quoted 1 line
2.28.0
Reviewed-by Patrick Delaunay <[email protected]>Quoted 5 lines
Quoted 3 lines
But I will be try to fix the issue before to accept this patch.
I will merge it only if I can't found the root cause for v2020.01-rc2....
Do you not see the same behavior on EV/DK ?
No but I think we have pull-up on board.
But after investigation the internall pull-up is not configurated in stm32 pinctrol (cheked with pinmux command) even it is requested in device-tree of EV1/DK2.
It is clearly a bug (I isolate the issue) and I am working on a patch (it should be sent to u-boot mailing liste next week).
Quoted 7 lines
Quoted 1 line
btw it is bugged in SPL.
Ah, what is the issue.
In the stm32 driver or in the framework ?
I will cross-check it also on EV1/DK2.
The card is not detected in SPL again, same fail mode as before. Now that I think about it, note to self, I should check whether the CD GPIO controller node is u-boot,dm-spl .
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Hi Marek,
Quoted 66 lines
From: Marek Vasut <[email protected]>
Sent: vendredi 23 octobre 2020 17:04On 10/23/20 4:39 PM, Patrick DELAUNAY wrote:
Hi,
[...]
Quoted 40 lines
Quoted 40 lines
Quoted 40 lines
Quoted 7 lines
From: Marek Vasut <[email protected]>
Sent: lundi 19 octobre 2020 23:38The cd-gpios with (
GPIO_ACTIVE_LOW|GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.It is strange if it is not working... I will check why the configuration is not managed correctly in stm32 gpio/pincontrol driver.
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3
-1@@ -265,6 +265,9 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; + /delete-property/ disable-wp; }; &sdmmc1_b4_pins_a { --Quoted 1 line
2.28.0
Reviewed-by Patrick Delaunay <[email protected]>But I will be try to fix the issue before to accept this patch.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
I will merge it only if I can't found the root cause for v2020.01-rc2....
Do you not see the same behavior on EV/DK ?
No but I think we have pull-up on board.
But after investigation the internall pull-up is not configurated in stm32 pinctrol (cheked with pinmux command) even it is requested in device-
tree of EV1/DK2.
Quoted 8 lines
It is clearly a bug (I isolate the issue) and I am working on a patch (it should be sent to u-boot mailing liste next week).
Quoted 1 line
btw it is bugged in SPL.
Ah, what is the issue.
Quoted 7 lines
Quoted 3 lines
In the stm32 driver or in the framework ?
I will cross-check it also on EV1/DK2.
The card is not detected in SPL again, same fail mode as before. Now that I think about it, note to self, I should check whether the CD GPIO controller node is u-boot,dm-spl
I found a big issue in stm32 pincontrol: the bias configuration was only managed for ouput pin.
With this serie [1], I checked the pull-up configuration (including in SPL by adding a debug trace).
With [2], the bias configuration is now correct in DK2 / EV1 boards (even if the pull-up configuration is not mandatory, because I don't see cart detection issue on ST board).
I expect this patch correct the DHSOM issue.
[1]: http://patchwork.ozlabs.org/project/uboot/list/?series=210501
[2]: patch [2/2] gpio: stm32: correct the bias management
http://patchwork.ozlabs.org/project/uboot/patch/20201028094908.11031-2-patrick.delaunay at st.com/
Regards,
Patrick
PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Quoted 1 line · Patrick DELAUNAY
Hi Marek,
Hello Patrick,
[...]
Quoted 19 lines
Quoted 11 lines
Quoted 2 lines
But after investigation the internall pull-up is not configurated in stm32 pinctrol (cheked with pinmux command) even it is requested in device-
tree of EV1/DK2.
Quoted 8 lines
It is clearly a bug (I isolate the issue) and I am working on a patch (it should be sent to u-boot mailing liste next week).
Quoted 1 line
btw it is bugged in SPL.
Ah, what is the issue.
Quoted 7 lines
Quoted 3 lines
In the stm32 driver or in the framework ?
I will cross-check it also on EV1/DK2.
The card is not detected in SPL again, same fail mode as before. Now that I think about it, note to self, I should check whether the CD GPIO controller node is u-boot,dm-spl
Quoted 8 lines
I found a big issue in stm32 pincontrol: the bias configuration was only managed for ouput pin.
With this serie [1], I checked the pull-up configuration (including in SPL by adding a debug trace).
With [2], the bias configuration is now correct in DK2 / EV1 boards (even if the pull-up configuration is not mandatory, because I don't see cart detection issue on ST board).
I expect this patch correct the DHSOM issue.
It does not, but the following does:
[PATCH] ARM: dts: stm32: Fix uSD card-detect GPIO on DHCOM
So it's a bug on both ends, good thing we found them.
Thanks!