drm/amdgpu: add printing to indicate rpm completeness
Subsystems (2)
PATCH 3/3 drm/amdgpu: add printing to indicate rpm completeness
Add an explicit printing to tell when finishing rpm execution in amdgpu.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -0
@@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)amdgpu_device_baco_enter (drm_dev); } +dev_info (&pdev->dev,"amdgpu finishes runtime suspend\n" ); +return 0 ; }
Signature · 1 line
2.25.1
Quoted 13 lines · Guchun Chen
Add an explicit printing to tell when finishing rpm execution in amdgpu.
Signed-off-by Guchun Chen <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c static int amdgpu_pmops_runtime_suspend(struct device *dev) · line 2576
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2
-0@@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)amdgpu_device_baco_enter (drm_dev); } +dev_info (&pdev->dev,"amdgpu finishes runtime suspend\n" ); +
This may be an annoyance. Maybe dev_dbg?
Series is:
Thanks,
Lijo
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0return 0 ; }
Chen, Guchun
Reviewed-by Lijo LazarHi Lijo,
Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences.
Regards,
Guchun
-----Original Message-----
From: Lazar, Lijo <[email protected]>
Sent: Wednesday, November 23, 2022 1:58 PM
To: Chen, Guchun <[email protected]>; [email protected]; Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Quan, Evan <[email protected]>
Subject: Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness
Quoted 14 lines · Guchun Chen
Add an explicit printing to tell when finishing rpm execution in amdgpu.
Signed-off-by Guchun Chen <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c static int amdgpu_pmops_runtime_suspend(struct device *dev) · line 2576
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2
-0@@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)amdgpu_device_baco_enter (drm_dev); } +dev_info (&pdev->dev,"amdgpu finishes runtime suspend\n" ); +
This may be an annoyance. Maybe dev_dbg?
Series is:
Thanks,
Lijo
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0return 0 ; }
Quoted 3 lines · Guchun
Hi Lijo,
Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences.
How about making those messages not printed by default then, instead of adding more?
Signature · 2 lines
Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer
Quoted 7 lines · Michel Dänzer
Quoted 3 lines · Guchun
Hi Lijo,
Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences.
How about making those messages not printed by default then, instead of adding more?
Yeah, I agree. No need to add more. Runtime PM can happen pretty frequently.
Alex
Quoted 6 lines
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
Thanks for your comments, Alex and Michel.
So like Lijo suggested, Does dev_dbg instead of dev_info for those message printings make sense to you as well?
Regards,
Guchun
-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Wednesday, November 23, 2022 11:41 PM
To: Michel Dänzer <[email protected]>
Cc: Chen, Guchun <[email protected]>; Lazar, Lijo <[email protected]>; [email protected]; Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Quan, Evan <[email protected]>
Subject: Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness
Quoted 7 lines · Michel Dänzer
Quoted 3 lines · Guchun
Hi Lijo,
Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences.
How about making those messages not printed by default then, instead of adding more?
Yeah, I agree. No need to add more. Runtime PM can happen pretty frequently.
Alex
Quoted 6 lines
--
Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.com%2F&data=05%7C01%7CGuchun.Chen%40amd.com%7C4669eec9570e4afc1e3d08dacd692ad7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638048148815933075%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vu7ZbIwuFX3PFIjvQgoQAqoVqCO02Moxzk%2Br8ubK23U%3D&reserved=0
Libre software enthusiast | Mesa and Xwayland developer
[AMD Official Use Only - General]
Quoted 24 lines
-----Original Message-----
From: Chen, Guchun <[email protected]>
Sent: Wednesday, November 23, 2022 9:44 AM
To: [email protected]; Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Lazar, Lijo <[email protected]>; Quan, Evan <[email protected]>
Cc: Chen, Guchun <[email protected]>
Subject: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completenessAdd an explicit printing to tell when finishing rpm execution in amdgpu.
Signed-off-by Guchun Chen <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c static int amdgpu_pmops_runtime_suspend(struct · line 2576
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-0@@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)amdgpu_device_baco_enter (drm_dev ); } +dev_info (&pdev->dev,"amdgpu finishes runtime suspend\n" );
[Quan, Evan] Maybe better with something like "asic/device is runtime suspended". Anyway, the series is Reviewed-by: Evan Quan <[email protected]>
Evan
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-1+return 0 ; } --2.25.1
Re: [Quan, Evan] Maybe better with something like "asic/device is runtime suspended".
Sure, will update it like this when pushing.
Regards,
Guchun
-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Wednesday, November 23, 2022 3:37 PM
To: Chen, Guchun <[email protected]>; [email protected]; Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Lazar, Lijo <[email protected]>
Subject: RE: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness
[AMD Official Use Only - General]
Quoted 23 lines
-----Original Message-----
From: Chen, Guchun <[email protected]>
Sent: Wednesday, November 23, 2022 9:44 AM
To: [email protected]; Deucher, Alexander <[email protected]>; Zhang, Hawking <[email protected]>; Lazar, Lijo <[email protected]>; Quan, Evan <[email protected]>
Cc: Chen, Guchun <[email protected]>
Subject: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completenessAdd an explicit printing to tell when finishing rpm execution in amdgpu.
Signed-off-by Guchun Chen <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c static int amdgpu_pmops_runtime_suspend(struct · line 2576
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-0@@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)amdgpu_device_baco_enter (drm_dev ); } +dev_info (&pdev->dev,"amdgpu finishes runtime suspend\n" );
[Quan, Evan] Maybe better with something like "asic/device is runtime suspended". Anyway, the series is Reviewed-by: Evan Quan <[email protected]>
Evan
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-1+return 0 ; } --2.25.1