allow building a kernel without buffer_heads
Subsystems (30)
Hi all,
This series allows to build a kernel without buffer_heads, which I think is useful to show where the dependencies are, and maybe also for some very much limited environments, where people just needs xfs and/or btrfs and some of the read-only block based file systems.
It first switches buffered writes (but not writeback) for block devices to use iomap unconditionally, but still using buffer_heads, and then adds a CONFIG_BUFFER_HEAD selected by all file systems that need it (which is most block based file systems), makes the buffer_head support in iomap optional, and adds an alternative implementation of the block device address_operations using iomap. This latter implementation will also be useful to support block size > PAGE_SIZE for block device nodes as buffer_heads won't work very well for that.
Note that for now the md software raid drivers is also disabled as it has some (rather questionable) buffer_head usage in the unconditionally built bitmap code. I have a series pending to make the bitmap code conditional and deprecated it, but it hasn't been merged yet.
Changes since v1:
- drop the already merged prep patches
- depend on FS_IOMAP not IOMAP
- pick a better new name for block_page_mkwrite_return
PATCH 1/6 fs: remove emergency_thaw_bdev
Fold emergency_thaw_bdev into it's only caller, to prepare for buffer.c to be built only when buffer_head support is enabled.
--- fs/buffer.c | 6 ------ fs/internal.h | 6 ------ fs/super.c | 4 +++- 3 files changed, 3 insertions(+), 13 deletions(-)
fs/buffer.c +0 -6
@@ -562,12 +562,6 @@ static int osync_buffers_list(spinlock_t *lock, struct list_head *list)return err; } -void emergency_thaw_bdev (struct super_block *sb) -{ -while (sb->s_bdev && !thaw_bdev (sb->s_bdev)) -printk (KERN_WARNING "Emergency Thaw on %pg\n" , sb->s_bdev); -} -/** * sync_mapping_buffers - write out & wait upon a mapping's "associated" buffers * @mapping: the mapping which wants those buffers written
fs/internal.h +0 -6
@@ -23,16 +23,10 @@ struct mnt_idmap;*/ #ifdef CONFIG_BLOCK extern void __init bdev_cache_init (void ); - -void emergency_thaw_bdev (struct super_block *sb);#else static inline void bdev_cache_init (void ) { } -static inline int emergency_thaw_bdev (struct super_block *sb) -{ -return 0 ; -}#endif /* CONFIG_BLOCK */ /*
fs/super.c +3 -1
@@ -1029,7 +1029,9 @@ static void do_thaw_all_callback(struct super_block *sb) {down_write (&sb->s_umount);if (sb->s_root && sb->s_flags &SB_BORN ) { -emergency_thaw_bdev (sb); +if (IS_ENABLED (CONFIG_BLOCK )) +while (sb->s_bdev && !thaw_bdev (sb->s_bdev)) +pr_warn ("Emergency Thaw on %pg\n" , sb->s_bdev);thaw_super_locked (sb); }else {up_write (&sb->s_umount);
Signature · 1 line
2.39.2
Re: [PATCH 1/6] fs: remove emergency_thaw_bdev
Looks good,
Re: [PATCH 1/6] fs: remove emergency_thaw_bdev
In reply to Christoph HellwigQuoted 10 lines · Christoph Hellwig
Fold
emergency_thaw_bdevinto it's only caller, to prepare forbuffer.cto be built only whenbuffer_headsupport is enabled.Signed-off-by Christoph Hellwig <[email protected]>--- fs/buffer.c | 6 ------ fs/internal.h | 6 ------ fs/super.c | 4 +++- 3 files changed, 3 insertions(+), 13 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 1/6] fs: remove emergency_thaw_bdev
In reply to Christoph HellwigQuoted 4 lines · Christoph Hellwig
Fold
emergency_thaw_bdevinto it's only caller, to prepare forbuffer.cto be built only whenbuffer_headsupport is enabled.Signed-off-by Christoph Hellwig <[email protected]>
Luis
PATCH 2/6 fs: rename and move block_page_mkwrite_return
In reply to Christoph Hellwigblock_page_mkwrite_return is neither block nor mkwrite specific, and should not be under CONFIG_BLOCK. Move it to mm.h and rename it to vmf_fs_error.
--- fs/ext4/inode.c | 2 +- fs/f2fs/file.c | 2 +- fs/gfs2/file.c | 16 ++++++++-------- fs/iomap/buffered-io.c | 2 +- fs/nilfs2/file.c | 2 +- fs/udf/file.c | 2 +- include/linux/buffer_head.h | 12 ------------ include/linux/mm.h | 18 ++++++++++++++++++ 8 files changed, 31 insertions(+), 25 deletions(-)
fs/ext4/inode.c +1 -1
@@ -6140,7 +6140,7 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)if (err == -ENOSPC &&ext4_should_retry_alloc (inode->i_sb, &retries)) goto retry_alloc; out_ret: - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); out:filemap_invalidate_unlock_shared (mapping);sb_end_pagefault (inode->i_sb);
fs/f2fs/file.c +1 -1
@@ -159,7 +159,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)sb_end_pagefault (inode->i_sb); err: -return block_page_mkwrite_return (err); +return vmf_fs_error (err); }static const struct vm_operations_struct f2fs_file_vm_ops = {
fs/gfs2/file.c +8 -8
@@ -432,7 +432,7 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)gfs2_holder_init (ip->i_gl,LM_ST_EXCLUSIVE ,0 , &gh); err =gfs2_glock_nq (&gh);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_uninit; }
@@ -474,7 +474,7 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf) err =gfs2_rindex_update (sdp);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_unlock; }
@@ -482,12 +482,12 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf) ap.target = data_blocks + ind_blocks; err =gfs2_quota_lock_check (ip, &ap);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_unlock; } err =gfs2_inplace_reserve (ip, &ap);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_quota_unlock; }
@@ -500,7 +500,7 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf) } err =gfs2_trans_begin (sdp, rblocks,0 );if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_trans_fail; }
@@ -508,7 +508,7 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)if (gfs2_is_stuffed (ip)) { err =gfs2_unstuff_dinode (ip);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_trans_end; } }
@@ -524,7 +524,7 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf) err =gfs2_allocate_page_backing (page, length);if (err) - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); out_page_locked:if (ret !=VM_FAULT_LOCKED )
@@ -558,7 +558,7 @@ static vm_fault_t gfs2_fault(struct vm_fault *vmf)gfs2_holder_init (ip->i_gl,LM_ST_SHARED ,0 , &gh); err =gfs2_glock_nq (&gh);if (err) { - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_uninit; } ret =filemap_fault (vmf);
fs/iomap/buffered-io.c +1 -1
@@ -1286,7 +1286,7 @@ vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops)return VM_FAULT_LOCKED ; out_unlock:folio_unlock (folio); -return block_page_mkwrite_return (ret); +return vmf_fs_error (ret); }EXPORT_SYMBOL_GPL (iomap_page_mkwrite);
fs/nilfs2/file.c +1 -1
@@ -108,7 +108,7 @@ static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)wait_for_stable_page (page); out:sb_end_pagefault (inode->i_sb); -return block_page_mkwrite_return (ret); +return vmf_fs_error (ret); }static const struct vm_operations_struct nilfs_file_vm_ops = {
fs/udf/file.c +1 -1
@@ -67,7 +67,7 @@ static vm_fault_t udf_page_mkwrite(struct vm_fault *vmf) err =block_commit_write (page,0 , end);if (err <0 ) {unlock_page (page); - ret =block_page_mkwrite_return (err); + ret =vmf_fs_error (err); goto out_unlock; } out_dirty:
include/linux/buffer_head.h +0 -12
@@ -291,18 +291,6 @@ int generic_cont_expand_simple(struct inode *inode, loff_t size);int block_commit_write (struct page *page,unsigned from,unsigned to);int block_page_mkwrite (struct vm_area_struct *vma,struct vm_fault *vmf,get_block_t get_block); -/* Convert errno to return value from ->page_mkwrite() call */ -static inline vm_fault_t block_page_mkwrite_return (int err) -{ -if (err ==0 ) -return VM_FAULT_LOCKED ; -if (err == -EFAULT || err == -EAGAIN ) -return VM_FAULT_NOPAGE ; -if (err == -ENOMEM ) -return VM_FAULT_OOM ; -/* -ENOSPC, -EDQUOT, -EIO ... */ -return VM_FAULT_SIGBUS ; -}sector_t generic_block_bmap (struct address_space *,sector_t ,get_block_t *);int block_truncate_page (struct address_space *,loff_t ,get_block_t *);
include/linux/mm.h +18 -0
@@ -3386,6 +3386,24 @@ static inline vm_fault_t vmf_error(int err)return VM_FAULT_SIGBUS ; } +/* +* Convert errno to return value for ->page_mkwrite() calls. +* +* This should eventually be merged with vmf_error() above, but will need a +* careful audit of all vmf_error() callers. +*/ +static inline vm_fault_t vmf_fs_error (int err) +{ +if (err ==0 ) +return VM_FAULT_LOCKED ; +if (err == -EFAULT || err == -EAGAIN ) +return VM_FAULT_NOPAGE ; +if (err == -ENOMEM ) +return VM_FAULT_OOM ; +/* -ENOSPC, -EDQUOT, -EIO ... */ +return VM_FAULT_SIGBUS ; +} +struct page *follow_page (struct vm_area_struct *vma,unsigned long address,unsigned int foll_flags);
Signature · 1 line
2.39.2
Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return
Looks good,
Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return
In reply to Christoph HellwigQuoted 5 lines · Christoph Hellwig
block_page_mkwrite_returnis neither block nor mkwrite specific, and should not be underCONFIG_BLOCK. Move it tomm.hand rename it tovmf_fs_error.Signed-off-by Christoph Hellwig <[email protected]>
Quoted 11 lines
--- fs/ext4/inode.c | 2 +- fs/f2fs/file.c | 2 +- fs/gfs2/file.c | 16 ++++++++-------- fs/iomap/buffered-io.c | 2 +- fs/nilfs2/file.c | 2 +- fs/udf/file.c | 2 +- include/linux/buffer_head.h | 12 ------------ include/linux/mm.h | 18 ++++++++++++++++++ 8 files changed, 31 insertions(+), 25 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return
In reply to Christoph HellwigQuoted 5 lines · Christoph Hellwig
block_page_mkwrite_returnis neither block nor mkwrite specific, and should not be underCONFIG_BLOCK. Move it tomm.hand rename it tovmf_fs_error.Signed-off-by Christoph Hellwig <[email protected]>
Luis
PATCH 3/6 block: open code __generic_file_write_iter for blkdev writes
In reply to Christoph HellwigOpen code __generic_file_write_iter to remove the indirect call into ->direct_IO and to prepare using the iomap based write code.
--- block/fops.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-)
block/fops.c +42 -2
@@ -533,6 +533,29 @@ static int blkdev_release(struct inode *inode, struct file *filp)return 0 ; } +static ssize_t +blkdev_direct_write (struct kiocb *iocb,struct iov_iter *from) +{ +size_t count =iov_iter_count (from); +ssize_t written; + + written =kiocb_invalidate_pages (iocb, count); +if (written) { +if (written == -EBUSY ) +return 0 ; +return written; + } + + written =blkdev_direct_IO (iocb, from); +if (written >0 ) { +kiocb_invalidate_post_direct_write (iocb, count); + iocb->ki_pos += written; + } +if (written != -EIOCBQUEUED ) +iov_iter_revert (from, count - written -iov_iter_count (from)); +return written; +} +/* * Write data to the block device. Only intended for the block device itself * and the raw driver which basically is a fake block device.
@@ -542,7 +565,8 @@ static int blkdev_release(struct inode *inode, struct file *filp)*/ static ssize_t blkdev_write_iter (struct kiocb *iocb,struct iov_iter *from) { -struct block_device *bdev =I_BDEV (iocb->ki_filp->f_mapping->host); +struct file *file = iocb->ki_filp; +struct block_device *bdev =I_BDEV (file->f_mapping->host);struct inode *bd_inode = bdev->bd_inode;loff_t size =bdev_nr_bytes (bdev);size_t shorted =0 ;
@@ -569,7 +593,23 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)iov_iter_truncate (from, size); } - ret =__generic_file_write_iter (iocb, from); + ret =file_remove_privs (file); +if (ret) +return ret; + + ret =file_update_time (file); +if (ret) +return ret; + +if (iocb->ki_flags &IOCB_DIRECT ) { + ret =blkdev_direct_write (iocb, from); +if (ret >=0 &&iov_iter_count (from)) + ret =direct_write_fallback (iocb, from, ret, +generic_perform_write (iocb, from)); + }else { + ret =generic_perform_write (iocb, from); + } +if (ret >0 ) ret =generic_write_sync (iocb, ret);iov_iter_reexpand (from,iov_iter_count (from) + shorted);
Signature · 1 line
2.39.2
Re: [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes
Looks good,
Re: [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes
In reply to Christoph HellwigQuoted 8 lines · Christoph Hellwig
Open code
__generic_file_write_iterto remove the indirect call into ->direct_IO and to prepare using the iomap based write code.Signed-off-by Christoph Hellwig <[email protected]>--- block/fops.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes
In reply to Christoph HellwigQuoted 24 lines · Christoph Hellwig
Open code
__generic_file_write_iterto remove the indirect call into ->direct_IO and to prepare using the iomap based write code.Signed-off-by Christoph Hellwig <[email protected]>--- block/fops.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-)block/fops.c +8
-0@@ -533,6 +533,29 @@ static int blkdev_release(struct inode *inode, struct file *filp)return 0 ; } +static ssize_t +blkdev_direct_write (struct kiocb *iocb,struct iov_iter *from) +{ +size_t count =iov_iter_count (from); +ssize_t written; + + written =kiocb_invalidate_pages (iocb, count); +if (written) {
block/fops.c static int blkdev_release(struct inode *inode, struct file *filp) · line 553
Quoted 10 lines
block/fops.c +10
-0+if (written == -EBUSY ) +return 0 ; +return written; + } + + written =blkdev_direct_IO (iocb, from); +if (written >0 ) { +kiocb_invalidate_post_direct_write (iocb, count); + iocb->ki_pos += written; + }
I noted in the last series how this could be negative and then crash:
https://lkml.kernel.org/r/[email protected]
This can be fixed as follows:
block/fops.c +4 -0
@@ -536,9 +536,13 @@ static int blkdev_release(struct inode *inode, struct file *filp)static ssize_t blkdev_direct_write (struct kiocb *iocb,struct iov_iter *from) { +struct block_device *bdev =I_BDEV (iocb->ki_filp->f_mapping->host);size_t count =iov_iter_count (from);ssize_t written; +if (blkdev_dio_unaligned (bdev, iocb->ki_pos, from)) +return -EINVAL ; + written =kiocb_invalidate_pages (iocb, count);if (written) {if (written == -EBUSY )
With that:
Luis
PATCH 4/6 block: stop setting ->direct_IO
In reply to Christoph HellwigDirect I/O on block devices now nevers goes through aops->direct_IO. Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead.
--- block/fops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
block/fops.c +1 -2
@@ -428,7 +428,6 @@ const struct address_space_operations def_blk_aops = { .writepage = blkdev_writepage, .write_begin = blkdev_write_begin, .write_end = blkdev_write_end, - .direct_IO = blkdev_direct_IO, .migrate_folio = buffer_migrate_folio_norefs, .is_dirty_writeback = buffer_check_dirty_writeback, };
@@ -505,7 +504,7 @@ static int blkdev_open(struct inode *inode, struct file *filp)* during an unstable branch. */ filp->f_flags |=O_LARGEFILE ; - filp->f_mode |=FMODE_BUF_RASYNC ; + filp->f_mode |=FMODE_BUF_RASYNC |FMODE_CAN_ODIRECT ;/* * Use the file private data to store the holder for exclusive openes.
Signature · 1 line
2.39.2
Re: [PATCH 4/6] block: stop setting ->direct_IO
Looks good,
Re: [PATCH 4/6] block: stop setting ->direct_IO
In reply to Christoph HellwigQuoted 8 lines · Christoph Hellwig
Direct I/O on block devices now nevers goes through
aops->direct_IO. Stop setting it and set theFMODE_CAN_ODIRECTin ->open instead.Signed-off-by Christoph Hellwig <[email protected]>--- block/fops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 4/6] block: stop setting ->direct_IO
In reply to Christoph HellwigQuoted 4 lines · Christoph Hellwig
Direct I/O on block devices now nevers goes through
aops->direct_IO. Stop setting it and set theFMODE_CAN_ODIRECTin ->open instead.Signed-off-by Christoph Hellwig <[email protected]>
Luis
PATCH 5/6 block: use iomap for writes to block devices
In reply to Christoph HellwigUse iomap in buffer_head compat mode to write to block devices.
--- block/Kconfig | 1 + block/fops.c | 31 +++++++++++++++++++++++++++++-- 2 files changed, 30 insertions(+), 2 deletions(-)
block/Kconfig +1 -0
@@ -5,6 +5,7 @@ menuconfig BLOCK bool "Enable the block layer" if EXPERT default y + select FS_IOMAP select SBITMAP help Provide block layer support for the kernel.
block/fops.c +29 -2
@@ -15,6 +15,7 @@#include <linux/falloc.h> #include <linux/suspend.h> #include <linux/fs.h> +#include <linux/iomap.h> #include <linux/module.h> #include "blk.h"
@@ -386,6 +387,27 @@ static ssize_t blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter)return __blkdev_direct_IO (iocb, iter,bio_max_segs (nr_pages)); } +static int blkdev_iomap_begin (struct inode *inode,loff_t offset,loff_t length, +unsigned int flags,struct iomap *iomap,struct iomap *srcmap) +{ +struct block_device *bdev =I_BDEV (inode); +loff_t isize =i_size_read (inode); + + iomap->bdev = bdev; + iomap->offset =ALIGN_DOWN (offset,bdev_logical_block_size (bdev)); +if (WARN_ON_ONCE (iomap->offset >= isize)) +return -EIO ; + iomap->type =IOMAP_MAPPED ; + iomap->addr = iomap->offset; + iomap->length = isize - iomap->offset; + iomap->flags |=IOMAP_F_BUFFER_HEAD ; +return 0 ; +} + +static const struct iomap_ops blkdev_iomap_ops = { + .iomap_begin = blkdev_iomap_begin, +}; +static int blkdev_writepage (struct page *page,struct writeback_control *wbc) {return block_write_full_page (page, blkdev_get_block, wbc);
@@ -555,6 +577,11 @@ blkdev_direct_write(struct kiocb *iocb, struct iov_iter *from)return written; } +static ssize_t blkdev_buffered_write (struct kiocb *iocb,struct iov_iter *from) +{ +return iomap_file_buffered_write (iocb, from, &blkdev_iomap_ops); +} +/* * Write data to the block device. Only intended for the block device itself * and the raw driver which basically is a fake block device.
@@ -604,9 +631,9 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from) ret =blkdev_direct_write (iocb, from);if (ret >=0 &&iov_iter_count (from)) ret =direct_write_fallback (iocb, from, ret, -generic_perform_write (iocb, from)); +blkdev_buffered_write (iocb, from)); }else { - ret =generic_perform_write (iocb, from); + ret =blkdev_buffered_write (iocb, from); }if (ret >0 )
Signature · 1 line
2.39.2
Re: [PATCH 5/6] block: use iomap for writes to block devices
Quoted 8 lines · Christoph Hellwig
Use iomap in
buffer_headcompat mode to write to block devices.Signed-off-by Christoph Hellwig <[email protected]>--- block/Kconfig | 1 + block/fops.c | 31 +++++++++++++++++++++++++++++-- 2 files changed, 30 insertions(+), 2 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 5/6] block: use iomap for writes to block devices
In reply to Christoph HellwigQuoted 3 lines · Christoph Hellwig
Use iomap in
buffer_headcompat mode to write to block devices.Signed-off-by Christoph Hellwig <[email protected]>
Luis
Re: [PATCH 5/6] block: use iomap for writes to block devices
In reply to Christoph HellwigQuoted 3 lines · Christoph Hellwig
Use iomap in
buffer_headcompat mode to write to block devices.Signed-off-by Christoph Hellwig <[email protected]>
Looks good,
PATCH 6/6 fs: add CONFIG_BUFFER_HEAD
In reply to Christoph HellwigAdd a new config option that controls building the buffer_head code, and select it from all file systems and stacking drivers that need it.
For the block device nodes and alternative iomap based buffered I/O path is provided when buffer_head support is not enabled, and iomap needs a little tweak to be able to compile out the buffer_head based code path.
Otherwise this is just Kconfig and ifdef changes.
--- block/fops.c | 71 +++++++++++++++++++++++++++++++----- drivers/md/Kconfig | 1 + fs/Kconfig | 4 ++ fs/Makefile | 2 +- fs/adfs/Kconfig | 1 + fs/affs/Kconfig | 1 + fs/befs/Kconfig | 1 + fs/bfs/Kconfig | 1 + fs/efs/Kconfig | 1 + fs/exfat/Kconfig | 1 + fs/ext2/Kconfig | 1 + fs/ext4/Kconfig | 1 + fs/f2fs/Kconfig | 1 + fs/fat/Kconfig | 1 + fs/freevxfs/Kconfig | 1 + fs/gfs2/Kconfig | 1 + fs/hfs/Kconfig | 1 + fs/hfsplus/Kconfig | 1 + fs/hpfs/Kconfig | 1 + fs/iomap/buffered-io.c | 12 ++++-- fs/isofs/Kconfig | 1 + fs/jfs/Kconfig | 1 + fs/minix/Kconfig | 1 + fs/nilfs2/Kconfig | 1 + fs/ntfs/Kconfig | 1 + fs/ntfs3/Kconfig | 1 + fs/ocfs2/Kconfig | 1 + fs/omfs/Kconfig | 1 + fs/qnx4/Kconfig | 1 + fs/qnx6/Kconfig | 1 + fs/reiserfs/Kconfig | 1 + fs/sysv/Kconfig | 1 + fs/udf/Kconfig | 1 + fs/ufs/Kconfig | 1 + include/linux/buffer_head.h | 32 ++++++++-------- include/trace/events/block.h | 2 + mm/migrate.c | 4 +- 37 files changed, 125 insertions(+), 32 deletions(-)
block/fops.c +61 -10
@@ -24,15 +24,6 @@ static inline struct inode *bdev_file_inode(struct file *file)return file->f_mapping->host; } -static int blkdev_get_block (struct inode *inode,sector_t iblock, -struct buffer_head *bh,int create) -{ - bh->b_bdev =I_BDEV (inode); - bh->b_blocknr = iblock; -set_buffer_mapped (bh); -return 0 ; -} -static blk_opf_t dio_bio_write_op (struct kiocb *iocb) {blk_opf_t opf =REQ_OP_WRITE |REQ_SYNC |REQ_IDLE ;
@@ -400,7 +391,8 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, iomap->type =IOMAP_MAPPED ; iomap->addr = iomap->offset; iomap->length = isize - iomap->offset; - iomap->flags |=IOMAP_F_BUFFER_HEAD ; +if (IS_ENABLED (CONFIG_BUFFER_HEAD )) + iomap->flags |=IOMAP_F_BUFFER_HEAD ;return 0 ; }
@@ -408,6 +400,16 @@ static const struct iomap_ops blkdev_iomap_ops = { .iomap_begin = blkdev_iomap_begin, }; +#ifdef CONFIG_BUFFER_HEAD +static int blkdev_get_block (struct inode *inode,sector_t iblock, +struct buffer_head *bh,int create) +{ + bh->b_bdev =I_BDEV (inode); + bh->b_blocknr = iblock; +set_buffer_mapped (bh); +return 0 ; +} +static int blkdev_writepage (struct page *page,struct writeback_control *wbc) {return block_write_full_page (page, blkdev_get_block, wbc);
@@ -453,6 +455,55 @@ const struct address_space_operations def_blk_aops = { .migrate_folio = buffer_migrate_folio_norefs, .is_dirty_writeback = buffer_check_dirty_writeback, }; +#else /* CONFIG_BUFFER_HEAD */ +static int blkdev_read_folio (struct file *file,struct folio *folio) +{ +return iomap_read_folio (folio, &blkdev_iomap_ops); +} + +static void blkdev_readahead (struct readahead_control *rac) +{ +iomap_readahead (rac, &blkdev_iomap_ops); +} + +static int blkdev_map_blocks (struct iomap_writepage_ctx *wpc, +struct inode *inode,loff_t offset) +{ +loff_t isize =i_size_read (inode); + +if (WARN_ON_ONCE (offset >= isize)) +return -EIO ; +if (offset >= wpc->iomap.offset && + offset < wpc->iomap.offset + wpc->iomap.length) +return 0 ; +return blkdev_iomap_begin (inode, offset, isize - offset, +IOMAP_WRITE , &wpc->iomap,NULL ); +} + +static const struct iomap_writeback_ops blkdev_writeback_ops = { + .map_blocks = blkdev_map_blocks, +}; + +static int blkdev_writepages (struct address_space *mapping, +struct writeback_control *wbc) +{ +struct iomap_writepage_ctx wpc = { }; + +return iomap_writepages (mapping, wbc, &wpc, &blkdev_writeback_ops); +} + +const struct address_space_operations def_blk_aops = { + .dirty_folio = filemap_dirty_folio, + .release_folio = iomap_release_folio, + .invalidate_folio = iomap_invalidate_folio, + .read_folio = blkdev_read_folio, + .readahead = blkdev_readahead, + .writepages = blkdev_writepages, + .is_partially_uptodate = iomap_is_partially_uptodate, + .error_remove_page = generic_error_remove_page, + .migrate_folio = filemap_migrate_folio, +}; +#endif /* CONFIG_BUFFER_HEAD */ /* * for a block special file file_inode(file)->i_size is zero
drivers/md/Kconfig +1 -0
@@ -15,6 +15,7 @@ if MD config BLK_DEV_MD tristate "RAID support" select BLOCK_HOLDER_DEPRECATED if SYSFS + select BUFFER_HEAD # BLOCK_LEGACY_AUTOLOAD requirement should be removed # after relevant mdadm enhancements - to make "names=yes" # the default - are widely available.
fs/Kconfig +4 -0
@@ -18,8 +18,12 @@ config VALIDATE_FS_PARSER config FS_IOMAP bool +config BUFFER_HEAD + bool + # old blockdev_direct_IO implementation. Use iomap for new code instead config LEGACY_DIRECT_IO + depends on BUFFER_HEAD bool if BLOCK
fs/Makefile +1 -1
@@ -17,7 +17,7 @@ obj-y := open.o read_write.o file_table.o super.o \ fs_types.o fs_context.o fs_parser.o fsopen.o init.o \ kernel_read_file.o mnt_idmapping.o remap_range.o -obj-$(CONFIG_BLOCK) += buffer.o mpage.o +obj-$(CONFIG_BUFFER_HEAD) += buffer.o mpage.o obj-$(CONFIG_PROC_FS) += proc_namespace.o obj-$(CONFIG_LEGACY_DIRECT_IO) += direct-io.o obj-y += notify/
fs/adfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config ADFS_FS tristate "ADFS file system support" depends on BLOCK + select BUFFER_HEAD help The Acorn Disc Filing System is the standard file system of the RiscOS operating system which runs on Acorn's ARM-based Risc PC
fs/affs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config AFFS_FS tristate "Amiga FFS file system support" depends on BLOCK + select BUFFER_HEAD select LEGACY_DIRECT_IO help The Fast File System (FFS) is the common file system used on hard
fs/befs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config BEFS_FS tristate "BeOS file system (BeFS) support (read only)" depends on BLOCK + select BUFFER_HEAD select NLS help The BeOS File System (BeFS) is the native file system of Be, Inc's
fs/bfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config BFS_FS tristate "BFS file system support" depends on BLOCK + select BUFFER_HEAD help Boot File System (BFS) is a file system used under SCO UnixWare to allow the bootloader access to the kernel image and other important
fs/efs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config EFS_FS tristate "EFS file system support (read only)" depends on BLOCK + select BUFFER_HEAD help EFS is an older file system used for non-ISO9660 CD-ROMs and hard disk partitions by SGI's IRIX operating system (IRIX 6.0 and newer
fs/exfat/Kconfig +1 -0
@@ -2,6 +2,7 @@ config EXFAT_FS tristate "exFAT filesystem support" + select BUFFER_HEAD select NLS select LEGACY_DIRECT_IO help
fs/ext2/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config EXT2_FS tristate "Second extended fs support" + select BUFFER_HEAD select FS_IOMAP select LEGACY_DIRECT_IO help
fs/ext4/Kconfig +1 -0
@@ -28,6 +28,7 @@ config EXT3_FS_SECURITY config EXT4_FS tristate "The Extended 4 (ext4) filesystem" + select BUFFER_HEAD select JBD2 select CRC16 select CRYPTO
fs/f2fs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config F2FS_FS tristate "F2FS filesystem support" depends on BLOCK + select BUFFER_HEAD select NLS select CRYPTO select CRYPTO_CRC32
fs/fat/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config FAT_FS tristate + select BUFFER_HEAD select NLS select LEGACY_DIRECT_IO help
fs/freevxfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config VXFS_FS tristate "FreeVxFS file system support (VERITAS VxFS(TM) compatible)" depends on BLOCK + select BUFFER_HEAD help FreeVxFS is a file system driver that support the VERITAS VxFS(TM) file system format. VERITAS VxFS(TM) is the standard file system
fs/gfs2/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config GFS2_FS tristate "GFS2 file system support" + select BUFFER_HEAD select FS_POSIX_ACL select CRC32 select LIBCRC32C
fs/hfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config HFS_FS tristate "Apple Macintosh file system support" depends on BLOCK + select BUFFER_HEAD select NLS select LEGACY_DIRECT_IO help
fs/hfsplus/Kconfig +1 -0
@@ -2,6 +2,7 @@ config HFSPLUS_FS tristate "Apple Extended HFS file system support" depends on BLOCK + select BUFFER_HEAD select NLS select NLS_UTF8 select LEGACY_DIRECT_IO
fs/hpfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config HPFS_FS tristate "OS/2 HPFS file system support" depends on BLOCK + select BUFFER_HEAD select FS_IOMAP help OS/2 is IBM's operating system for PC's, the same as Warp, and HPFS
fs/iomap/buffered-io.c +9 -3
@@ -41,6 +41,12 @@ static inline struct iomap_page *to_iomap_page(struct folio *folio)return NULL ; } +static inline bool iomap_use_buffer_heads (const struct iomap *iomap) +{ +return IS_ENABLED (CONFIG_BUFFER_HEAD ) && + (iomap->flags &IOMAP_F_BUFFER_HEAD ); +} +static struct bio_set iomap_ioend_bioset; static struct iomap_page *
@@ -675,7 +681,7 @@ static int iomap_write_begin(struct iomap_iter *iter, loff_t pos,if (srcmap->type ==IOMAP_INLINE ) status =iomap_write_begin_inline (iter, folio); -else if (srcmap->flags &IOMAP_F_BUFFER_HEAD ) +else if (iomap_use_buffer_heads (srcmap)) status =__block_write_begin_int (folio, pos, len,NULL , srcmap);else status =__iomap_write_begin (iter, pos, len, folio);
@@ -745,7 +751,7 @@ static size_t iomap_write_end(struct iomap_iter *iter, loff_t pos, size_t len,if (srcmap->type ==IOMAP_INLINE ) { ret =iomap_write_end_inline (iter, folio, pos, copied); - }else if (srcmap->flags &IOMAP_F_BUFFER_HEAD ) { + }else if (iomap_use_buffer_heads (srcmap)) { ret =block_write_end (NULL , iter->inode->i_mapping, pos, len, copied, &folio->page,NULL ); }else {
@@ -1248,7 +1254,7 @@ static loff_t iomap_folio_mkwrite_iter(struct iomap_iter *iter,loff_t length =iomap_length (iter);int ret; -if (iter->iomap.flags &IOMAP_F_BUFFER_HEAD ) { +if (iomap_use_buffer_heads (&iter->iomap)) { ret =__block_write_begin_int (folio, iter->pos, length,NULL , &iter->iomap);if (ret)
fs/isofs/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config ISO9660_FS tristate "ISO 9660 CDROM file system support" + select BUFFER_HEAD help This is the standard file system used on CD-ROMs. It was previously known as "High Sierra File System" and is called "hsfs" on other
fs/jfs/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config JFS_FS tristate "JFS filesystem support" + select BUFFER_HEAD select NLS select CRC32 select LEGACY_DIRECT_IO
fs/minix/Kconfig +1 -0
@@ -2,6 +2,7 @@ config MINIX_FS tristate "Minix file system support" depends on BLOCK + select BUFFER_HEAD help Minix is a simple operating system used in many classes about OS's. The minix file system (method to organize files on a hard disk
fs/nilfs2/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config NILFS2_FS tristate "NILFS2 file system support" + select BUFFER_HEAD select CRC32 select LEGACY_DIRECT_IO help
fs/ntfs/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config NTFS_FS tristate "NTFS file system support" + select BUFFER_HEAD select NLS help NTFS is the file system of Microsoft Windows NT, 2000, XP and 2003.
fs/ntfs3/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config NTFS3_FS tristate "NTFS Read-Write file system support" + select BUFFER_HEAD select NLS select LEGACY_DIRECT_IO help
fs/ocfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config OCFS2_FS tristate "OCFS2 file system support" depends on INET && SYSFS && CONFIGFS_FS + select BUFFER_HEAD select JBD2 select CRC32 select QUOTA
fs/omfs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config OMFS_FS tristate "SonicBlue Optimized MPEG File System support" depends on BLOCK + select BUFFER_HEAD select CRC_ITU_T help This is the proprietary file system used by the Rio Karma music
fs/qnx4/Kconfig +1 -0
@@ -2,6 +2,7 @@ config QNX4FS_FS tristate "QNX4 file system support (read only)" depends on BLOCK + select BUFFER_HEAD help This is the file system used by the real-time operating systems QNX 4 and QNX 6 (the latter is also called QNX RTP).
fs/qnx6/Kconfig +1 -0
@@ -2,6 +2,7 @@ config QNX6FS_FS tristate "QNX6 file system support (read only)" depends on BLOCK && CRC32 + select BUFFER_HEAD help This is the file system used by the real-time operating systems QNX 6 (also called QNX RTP).
fs/reiserfs/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config REISERFS_FS tristate "Reiserfs support (deprecated)" + select BUFFER_HEAD select CRC32 select LEGACY_DIRECT_IO help
fs/sysv/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SYSV_FS tristate "System V/Xenix/V7/Coherent file system support" depends on BLOCK + select BUFFER_HEAD help SCO, Xenix and Coherent are commercial Unix systems for Intel machines, and Version 7 was used on the DEC PDP-11. Saying Y
fs/udf/Kconfig +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config UDF_FS tristate "UDF file system support" + select BUFFER_HEAD select CRC_ITU_T select NLS select LEGACY_DIRECT_IO
fs/ufs/Kconfig +1 -0
@@ -2,6 +2,7 @@ config UFS_FS tristate "UFS file system support (read only)" depends on BLOCK + select BUFFER_HEAD help BSD and derivate versions of Unix (such as SunOS, FreeBSD, NetBSD, OpenBSD and NeXTstep) use a file system called UFS. Some System V
include/linux/buffer_head.h +16 -16
@@ -16,8 +16,6 @@#include <linux/wait.h> #include <linux/atomic.h> -#ifdef CONFIG_BLOCK -enum bh_state_bits { BH_Uptodate,/* Contains valid data */ BH_Dirty,/* Is dirty */
@@ -198,7 +196,6 @@ void set_bh_page(struct buffer_head *bh, struct page *page, unsigned long offset);void folio_set_bh (struct buffer_head *bh,struct folio *folio,unsigned long offset); -bool try_to_free_buffers (struct folio *);struct buffer_head *folio_alloc_buffers (struct folio *folio,unsigned long size,bool retry); struct buffer_head *alloc_page_buffers(struct page *page, unsigned long size,
@@ -213,10 +210,6 @@ void end_buffer_async_write(struct buffer_head *bh, int uptodate);/* Things to do with buffers at mapping->private_list */ void mark_buffer_dirty_inode (struct buffer_head *bh,struct inode *inode); -int inode_has_buffers (struct inode *); -void invalidate_inode_buffers (struct inode *); -int remove_inode_buffers (struct inode *inode); -int sync_mapping_buffers (struct address_space *mapping);int generic_buffers_fsync_noflush (struct file *file,loff_t start,loff_t end,bool datasync); int generic_buffers_fsync(struct file *file, loff_t start, loff_t end,
@@ -240,9 +233,6 @@ void __bforget(struct buffer_head *);void __breadahead (struct block_device *,sector_t block,unsigned int size);struct buffer_head *__bread_gfp (struct block_device *,sector_t block,unsigned size,gfp_t gfp); -void invalidate_bh_lrus (void ); -void invalidate_bh_lrus_cpu (void ); -bool has_bh_in_lru (int cpu,void *dummy);struct buffer_head *alloc_buffer_head (gfp_t gfp_flags);void free_buffer_head (struct buffer_head * bh);void unlock_buffer (struct buffer_head *bh);
@@ -258,8 +248,6 @@ int __bh_read(struct buffer_head *bh, blk_opf_t op_flags, bool wait);void __bh_read_batch (int nr,struct buffer_head *bhs[],blk_opf_t op_flags,bool force_lock); -extern int buffer_heads_over_limit; -/* * Generic address_space_operations implementations for buffer_head-backed * address_spaces.
@@ -304,8 +292,6 @@ extern int buffer_migrate_folio_norefs(struct address_space *,#define buffer_migrate_folio_norefs NULL#endif -void buffer_init (void ); -/* * inline definitions */
@@ -465,7 +451,20 @@ __bread(struct block_device *bdev, sector_t block, unsigned size)bool block_dirty_folio (struct address_space *mapping,struct folio *folio); -#else /* CONFIG_BLOCK */ +#ifdef CONFIG_BUFFER_HEAD + +void buffer_init (void ); +bool try_to_free_buffers (struct folio *folio); +int inode_has_buffers (struct inode *inode); +void invalidate_inode_buffers (struct inode *inode); +int remove_inode_buffers (struct inode *inode); +int sync_mapping_buffers (struct address_space *mapping); +void invalidate_bh_lrus (void ); +void invalidate_bh_lrus_cpu (void ); +bool has_bh_in_lru (int cpu,void *dummy); +extern int buffer_heads_over_limit; + +#else /* CONFIG_BUFFER_HEAD */ static inline void buffer_init (void ) {}static inline bool try_to_free_buffers (struct folio *folio) {return true; }
@@ -473,9 +472,10 @@ static inline int inode_has_buffers(struct inode *inode) { return 0; }static inline void invalidate_inode_buffers (struct inode *inode) {}static inline int remove_inode_buffers (struct inode *inode) {return 1 ; }static inline int sync_mapping_buffers (struct address_space *mapping) {return 0 ; } +static inline void invalidate_bh_lrus (void ) {}static inline void invalidate_bh_lrus_cpu (void ) {}static inline bool has_bh_in_lru (int cpu,void *dummy) {return false; }#define buffer_heads_over_limit 0 -#endif /* CONFIG_BLOCK */ +#endif /* CONFIG_BUFFER_HEAD */ #endif /* _LINUX_BUFFER_HEAD_H */
include/trace/events/block.h +2 -0
@@ -12,6 +12,7 @@#define RWBS_LEN 8 +#ifdef CONFIG_BUFFER_HEAD DECLARE_EVENT_CLASS(block_buffer, TP_PROTO(struct buffer_head *bh),
@@ -61,6 +62,7 @@ DEFINE_EVENT(block_buffer, block_dirty_buffer,TP_ARGS (bh) ); +#endif /* CONFIG_BUFFER_HEAD */ /** * block_rq_requeue - place block IO request back on a queue
mm/migrate.c +2 -2
@@ -684,7 +684,7 @@ int migrate_folio(struct address_space *mapping, struct folio *dst, }EXPORT_SYMBOL (migrate_folio); -#ifdef CONFIG_BLOCK +#ifdef CONFIG_BUFFER_HEAD /* Returns true if all buffers are successfully locked */ static bool buffer_migrate_lock_buffers (struct buffer_head *head,enum migrate_mode mode)
@@ -837,7 +837,7 @@ int buffer_migrate_folio_norefs(struct address_space *mapping, return __buffer_migrate_folio(mapping, dst, src, mode, true); }EXPORT_SYMBOL_GPL (buffer_migrate_folio_norefs); -#endif +#endif /* CONFIG_BUFFER_HEAD */ int filemap_migrate_folio (struct address_space *mapping,struct folio *dst,struct folio *src,enum migrate_mode mode)
Signature · 1 line
2.39.2
Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD
block/fops.c static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, · line 395
Quoted 7 lines · Christoph Hellwig
block/fops.c +2
-1@@ -400,7 +391,8 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, iomap->type =IOMAP_MAPPED ; iomap->addr = iomap->offset; iomap->length = isize - iomap->offset; - iomap->flags |=IOMAP_F_BUFFER_HEAD ; +if (IS_ENABLED (CONFIG_BUFFER_HEAD )) + iomap->flags |=IOMAP_F_BUFFER_HEAD ;
Wouldn't it be simpler to do ...
+#ifdef CONFIG_BUFFER_HEAD
#define IOMAP_F_BUFFER_HEAD (1U << 4)
+#else
+#define IOMAP_F_BUFFER_HEAD 0
+#endif
in include/linux/iomap.h ?
fs/iomap/buffered-io.c static inline struct iomap_page *to_iomap_page(struct folio *folio) · line 48
Quoted 13 lines
fs/iomap/buffered-io.c +5
-0@@ -41,6 +41,12 @@ static inline struct iomap_page *to_iomap_page(struct folio *folio)return NULL ; } +static inline bool iomap_use_buffer_heads (const struct iomap *iomap) +{ +return IS_ENABLED (CONFIG_BUFFER_HEAD ) && + (iomap->flags &IOMAP_F_BUFFER_HEAD ); +}
... because this function then goes away.
fs/iomap/buffered-io.c static int iomap_write_begin(struct iomap_iter *iter, loff_t pos, · line 684
Quoted 6 lines
fs/iomap/buffered-io.c +1
-1@@ -675,7 +681,7 @@ static int iomap_write_begin(struct iomap_iter *iter, loff_t pos,if (srcmap->type ==IOMAP_INLINE ) status =iomap_write_begin_inline (iter, folio); -else if (srcmap->flags &IOMAP_F_BUFFER_HEAD ) +else if (iomap_use_buffer_heads (srcmap))
... as this will be optimised away.
Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD
Quoted 17 lines · Matthew Wilcox
block/fops.c static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, · line 395
Quoted 7 lines · Christoph Hellwig
block/fops.c +2
-1@@ -400,7 +391,8 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, iomap->type =IOMAP_MAPPED ; iomap->addr = iomap->offset; iomap->length = isize - iomap->offset; - iomap->flags |=IOMAP_F_BUFFER_HEAD ; +if (IS_ENABLED (CONFIG_BUFFER_HEAD )) + iomap->flags |=IOMAP_F_BUFFER_HEAD ;Wouldn't it be simpler to do ...
(quoted diff) +4
-0+#ifdef CONFIG_BUFFER_HEAD #define IOMAP_F_BUFFER_HEAD (1U << 4) +#else +#define IOMAP_F_BUFFER_HEAD 0 +#endif
Quoted 3 lines
in
include/linux/iomap.h?... because this function then goes away.
I guess we could do that. It is less intrusive, but I have to say I find flags that get defined away to 0 fairly confusing for the reader.
Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD
In reply to Christoph HellwigQuoted 41 lines · Christoph Hellwig
Add a new config option that controls building the
buffer_headcode, and select it from all file systems and stacking drivers that need it.For the block device nodes and alternative iomap based buffered I/O path is provided when
buffer_headsupport is not enabled, and iomap needs a little tweak to be able to compile out thebuffer_headbased code path.Otherwise this is just
Kconfigand ifdef changes.Signed-off-by Christoph Hellwig <[email protected]>--- block/fops.c | 71 +++++++++++++++++++++++++++++++----- drivers/md/Kconfig | 1 + fs/Kconfig | 4 ++ fs/Makefile | 2 +- fs/adfs/Kconfig | 1 + fs/affs/Kconfig | 1 + fs/befs/Kconfig | 1 + fs/bfs/Kconfig | 1 + fs/efs/Kconfig | 1 + fs/exfat/Kconfig | 1 + fs/ext2/Kconfig | 1 + fs/ext4/Kconfig | 1 + fs/f2fs/Kconfig | 1 + fs/fat/Kconfig | 1 + fs/freevxfs/Kconfig | 1 + fs/gfs2/Kconfig | 1 + fs/hfs/Kconfig | 1 + fs/hfsplus/Kconfig | 1 + fs/hpfs/Kconfig | 1 + fs/iomap/buffered-io.c | 12 ++++-- fs/isofs/Kconfig | 1 + fs/jfs/Kconfig | 1 + fs/minix/Kconfig | 1 + fs/nilfs2/Kconfig | 1 + fs/ntfs/Kconfig | 1 + fs/ntfs3/Kconfig | 1 + fs/ocfs2/Kconfig | 1 + fs/omfs/Kconfig | 1 + fs/qnx4/Kconfig | 1 + fs/qnx6/Kconfig | 1 +
Quoted 9 lines
fs/reiserfs/Kconfig | 1 + fs/sysv/Kconfig | 1 + fs/udf/Kconfig | 1 + fs/ufs/Kconfig | 1 + include/linux/buffer_head.h | 32 ++++++++-------- include/trace/events/block.h | 2 + mm/migrate.c | 4 +- 37 files changed, 125 insertions(+), 32 deletions(-)
Hmm.
I actually have a patchset which _does_ allow for large I/O blocksizes with buffer_heads. (And even ltp/fsx is happy on xfs...)
Can we modify this to not have a compile-time option but rather a setting somewhere? EG kernel option or flag in struct address_space?
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD
Quoted 2 lines · Hannes Reinecke
Can we modify this to not have a compile-time option but rather a setting somewhere? EG kernel option or flag in struct
address_space?
Modify what? The current code diables buffer_head suport on the block devices when the kernel does not support buffer_heads. There is no good way to make that a run time decision :)
Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD
In reply to Christoph HellwigQuoted 10 lines · Christoph Hellwig
Add a new config option that controls building the
buffer_headcode, and select it from all file systems and stacking drivers that need it.For the block device nodes and alternative iomap based buffered I/O path is provided when
buffer_headsupport is not enabled, and iomap needs a little tweak to be able to compile out thebuffer_headbased code path.Otherwise this is just
Kconfigand ifdef changes.Signed-off-by Christoph Hellwig <[email protected]>
Luis
Quoted 21 lines · Christoph Hellwig
Hi all,
This series allows to build a kernel without
buffer_heads, which I think is useful to show where the dependencies are, and maybe also for some very much limited environments, where people just needs xfs and/or btrfs and some of the read-only block based file systems.It first switches buffered writes (but not writeback) for block devices to use iomap unconditionally, but still using
buffer_heads, and then adds aCONFIG_BUFFER_HEADselected by all file systems that need it (which is most block based file systems), makes thebuffer_headsupport in iomap optional, and adds an alternative implementation of the block deviceaddress_operationsusing iomap. This latter implementation will also be useful to support block size >PAGE_SIZEfor block device nodes asbuffer_headswon't work very well for that.Note that for now the md software raid drivers is also disabled as it has some (rather questionable)
buffer_headusage in the unconditionally built bitmap code. I have a series pending to make the bitmap code conditional and deprecated it, but it hasn't been merged yet.
Quoted 5 lines
Changes since v1:
- drop the already merged prep patches
- depend onFS_IOMAPnot IOMAP
- pick a better new name forblock_page_mkwrite_return
Hi Christoph,
Gfs2 still uses buffer_heads to manage the metadata being pushed through its journals. We've been reducing our dependency on them but eliminating them altogether is a large and daunting task. We can still work toward that goal, but it will take time.
Bob Peterson
Quoted 4 lines · Bob Peterson
Gfs2 still uses
buffer_headsto manage the metadata being pushed through its journals. We've been reducing our dependency on them but eliminating them altogether is a large and daunting task. We can still work toward that goal, but it will take time.
That's fine - gfs2 selects CONFIG_BUFFER_HEAD after this series and will be perfectly fine.