Skip to contentSkip to conversation

centralize some nls helpers

PATCH Petr Vandrovec 1 participant 1 message Sep 1, 2004 VFS

lore
Share & tools
lore
#0 lore raw
Quoted 7 lines · Christoph Hellwig

This patch adds common nls_tolower, nls_toupper and nls_strnicmp helpers to nls.h and uses them in various filesystems instead of local duplicates.

The situation for ncpfs isn't as nice as it allows to compile without nls support even if the kernel has CONFIG_NLS set, so we need wrappers there.

I have no problem with setting CONFIG_NCPFS_NLS == CONFIG_NLS. As all ncpfs features except NCPFS_SMALLDOS can be set at mount time, there is no reason for not hardwiring all CONFIG_NCPFS_* options (except SMALLDOS) to 'y', except that it will consume some additional memory (and I doubt that embedded people use ncpfs). Only question is whether retain CONFIG_NCP_FS selecting NLS (currently CONFIG_NCPFS_NLS selects NLS), or whether CONFIG_NCP_FS should depend on NLS (I've thought that CONFIG_NCPFS_NLS depends on NLS and only just now I found that CONFIG_NCPFS_NLS selects NLS now...).
Petr Vandrovec [email protected]