misc: fastrpc: Use memdup_user() rather than duplicating its implementation
Subsystems (4)
PATCH 1/1 misc: fastrpc: Use memdup_user() rather than duplicating its implementation
From: Markus Elfring <[email protected]>
Date: Sun, 28 Jan 2024 15:17:03 +0100
Reuse existing functionality from memdup_user() instead of keeping duplicate source code.
Generated by: scripts/coccinelle/api/memdup_user.cocci
--- drivers/misc/fastrpc.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/misc/fastrpc.c +3 -8
@@ -1260,17 +1260,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, goto err; } - name =kzalloc (init.namelen,GFP_KERNEL ); -if (!name) { - err = -ENOMEM ; + name =memdup_user (init.name, init.namelen); + if (IS_ERR(name) { + err =PTR_ERR (name); goto err; } -if (copy_from_user (name, (void __user *)(uintptr_t )init.name, init.namelen)) { - err = -EFAULT ; - goto err_name; - } -if (!fl->cctx->remote_heap) { err =fastrpc_remote_heap_alloc (fl, fl->sctx->dev, init.memlen, &fl->cctx->remote_heap);
--
2.43.0
PATCH v2 1/1 misc: fastrpc: Use memdup_user() rather than duplicating its implementation
From: Markus Elfring <[email protected]>
Date: Mon, 29 Jan 2024 15:33:41 +0100
* Reuse existing functionality from memdup_user() instead of keeping duplicate source code.
Generated by: scripts/coccinelle/api/memdup_user.cocci
* Adjust a data type conversion for a function call parameter.
---
v2:
A data type conversion should still be applied for one function call parameter.
drivers/misc/fastrpc.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/misc/fastrpc.c +3 -8
@@ -1260,17 +1260,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, goto err; } - name =kzalloc (init.namelen,GFP_KERNEL ); -if (!name) { - err = -ENOMEM ; + name =memdup_user (u64_to_user_ptr (init.name), init.namelen); + if (IS_ERR(name) { + err =PTR_ERR (name); goto err; } -if (copy_from_user (name, (void __user *)(uintptr_t )init.name, init.namelen)) { - err = -EFAULT ; - goto err_name; - } -if (!fl->cctx->remote_heap) { err =fastrpc_remote_heap_alloc (fl, fl->sctx->dev, init.memlen, &fl->cctx->remote_heap);
--
2.43.0