Skip to contentSkip to conversation

python3-setuptools: upgrade 57.0.0 -> 57.1.0

PATCH In review wangmy 5 participants 8 messages Jul 12, 2021 – Jul 16, 2021

lore
Share & tools
lore

wangmy

author
#0 lore raw

PATCH v4 1/1 python3-setuptools: upgrade 57.0.0 -> 57.1.0

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

Documentation changes
^^^^^^^^^^^^^^^^^^^^^
* #2604: Revamped the backward/cross tool compatibility section to remove some confusion.
Add some examples and the version since when ``entry_points`` are supported in declarative configuration.
Tried to make the reading flow a bit leaner, gather some informations that were a bit dispersed.

---
 .../python3-setuptools/reproducibility.patch  | 40 -------------------
 ...57.0.0.bb => python3-setuptools_57.1.0.bb} |  5 +--
 2 files changed, 2 insertions(+), 43 deletions(-)
 delete mode 100644 meta/recipes-devtools/python/python3-setuptools/reproducibility.patch
 rename meta/recipes-devtools/python/{python3-setuptools_57.0.0.bb => python3-setuptools_57.1.0.bb} (88%)
meta/recipes-devtools/python/python3-setuptools/reproducibility.patch deleted +0 -40
deleted file mode 100644
index 149d8ad5ce..0000000000
@@ -1,40 +0,0 @@
-The License-File lines in PKG-INFO change ordering depending on the order on disk, 
-for example for python-packaging, one build shows:
-
-License-File: LICENSE
-License-File: LICENSE.APACHE
-License-File: LICENSE.BSD
-
-and the other shows:
-
-License-File: LICENSE
-License-File: LICENSE.BSD
-License-File: LICENSE.APACHE
-
-This is because glob uses os.listdir() which is unsorted. Sort the result to avoid this.
-
-Upstream-Status: Submitted [https://github.com/pypa/setuptools/issues/2691]
-Signed-off-by: Richard Purdie <[email protected]>
-
-Index: setuptools-57.0.0/setuptools/dist.py
-===================================================================
---- setuptools-57.0.0.orig/setuptools/dist.py
-+++ setuptools-57.0.0/setuptools/dist.py
-@@ -15,7 +15,7 @@ import distutils.command
- from distutils.util import strtobool
- from distutils.debug import DEBUG
- from distutils.fancy_getopt import translate_longopt
--from glob import iglob
-+from glob import glob
- import itertools
- import textwrap
- from typing import List, Optional, TYPE_CHECKING
-@@ -603,7 +603,7 @@ class Distribution(_Distribution):
-         return (
-             path
-             for pattern in patterns
--            for path in iglob(pattern)
-+            for path in sorted(glob(pattern))
-             if not path.endswith('~')
-             and os.path.isfile(path)
-         )
meta/recipes-devtools/python/python3-setuptools_57.1.0.bb renamed from meta/recipes-devtools/python/python3-setuptools_57.0.0.bb +2 -3
similarity index 88%
rename from meta/recipes-devtools/python/python3-setuptools_57.0.0.bb
rename to meta/recipes-devtools/python/python3-setuptools_57.1.0.bb
index a15b51e31c..c066d8209f 100644
@@ -8,10 +8,9 @@ inherit pypi setuptools3
 
 SRC_URI_append_class-native = " file://0001-conditionally-do-not-fetch-code-by-easy_install.patch"
 
-SRC_URI += "file://0001-change-shebang-to-python3.patch \
-            file://reproducibility.patch"
+SRC_URI += "file://0001-change-shebang-to-python3.patch"
 
-SRC_URI[sha256sum] = "401cbf33a7bf817d08014d51560fc003b895c4cdc1a5b521ad2969e928a07535"
+SRC_URI[sha256sum] = "cfca9c97e7eebbc8abe18d5e5e962a08dcad55bb63afddd82d681de4d22a597b"
 
 DEPENDS += "${PYTHON_PN}"
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · wangmy

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Quoted 8 lines

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change
breaks meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:
do_install:

+ people who might be interested in python3-cassandra-driver.

| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/
| Download error on https://pypi.org/simple/geomet/: [SSL:
CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local
issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/
| Download error on https://pypi.org/simple/: [SSL:

CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found! | No local packages or working download links found for geomet<0.3,>=0.1 | error: Could not find suitable distribution for Requirement.parse('geomet<0.3,>=0.1')

#2 lore raw
Quoted 22 lines · Martin Jansa

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change breaks  meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:do_install:

+ people who might be interested in python3-cassandra-driver.

Quoted 13 lines
| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/ <https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/ <https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/ <https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for geomet<0.3,>=0.1
| error: Could not find suitable distribution for Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 4 lines
#3 lore raw
Quoted 28 lines · Khem Raj
Quoted 25 lines · Martin Jansa

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

    reproducibility.patch
    deleted since it's been merged upstream.

    v57.1.0
    -------

    Changes
    ^^^^^^^
    * #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
    * #2714: Update to distutils at pypa/distutils@e2627b7.
    * #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change breaks  meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:do_install:

+ people who might be interested in python3-cassandra-driver.

| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

Quoted 9 lines
Quoted 9 lines
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/ <https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/ <https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/ <https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for geomet<0.3,>=0.1

But that not directly an issue of the setuptools upgrade, but a not well written recipe here.
I'm more than lucky that this update revealed the issue, because otherwise no one would have really noticed that the original recipe of cassandra-driver is pulling sources while installing. So just in case I would rather pull in this upgrade than to mind the broken recipe from meta-python here (just my 2c)

Quoted 15 lines
Quoted 3 lines

| error: Could not find suitable distribution for Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 4 lines
#4 lore raw
Quoted 52 lines · Konrad Weihmann

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 32 lines · Khem Raj
Quoted 29 lines · Martin Jansa

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

    reproducibility.patch
    deleted since it's been merged upstream.

    v57.1.0
    -------

    Changes
    ^^^^^^^
    * #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
    * #2714: Update to distutils at pypa/distutils@e2627b7.
    * #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change
breaks meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:do_install:

+ people who might be interested in python3-cassandra-driver.

| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

Quoted 16 lines
Quoted 8 lines
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/

<https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/
<https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!

Quoted 8 lines
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/

<https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for geomet<0.3,>=0.1

Quoted 7 lines

But that not directly an issue of the setuptools upgrade, but a not well written recipe here.
I'm more than lucky that this update revealed the issue, because otherwise no one would have really noticed that the original recipe of cassandra-driver is pulling sources while installing.
So just in case I would rather pull in this upgrade than to mind the broken recipe from meta-python here (just my 2c)

FYI, I am working on a recipe for python3-geomat to make this work better in the future.

- Trevor

Quoted 17 lines
Quoted 17 lines
Quoted 5 lines

| error: Could not find suitable distribution for
Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 4 lines
#5 lore raw
In reply to Konrad Weihmann
Quoted 50 lines · Konrad Weihmann
Quoted 31 lines · Khem Raj
Quoted 28 lines · Martin Jansa

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change
breaks meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:do_install:

+ people who might be interested in python3-cassandra-driver.

| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

Quoted 16 lines
Quoted 8 lines
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/

<https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/
<https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!

Quoted 8 lines
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/

<https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for geomet<0.3,>=0.1

Quoted 8 lines

But that not directly an issue of the setuptools upgrade, but a not well written recipe here.
I'm more than lucky that this update revealed the issue, because otherwise no one would have really noticed that the original recipe of cassandra-driver is pulling sources while installing.
So just in case I would rather pull in this upgrade than to mind the broken recipe from meta-python here (just my 2c)

i am fine with whatever the right fix is. Its normal that some base infra component dependency
drives a change in another recipe if thats inline with expected design then change the component
to work with new update.

Quoted 16 lines
Quoted 16 lines
Quoted 4 lines

| error: Could not find suitable distribution for
Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 4 lines
#6 lore raw
Quoted 58 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 47 lines · Konrad Weihmann
Quoted 30 lines · Khem Raj
Quoted 28 lines · Martin Jansa

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

FWIW: this change
breaks meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:do_install:

+ people who might be interested in python3-cassandra-driver.

| Installed /jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

Quoted 16 lines
Quoted 8 lines
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/

<https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/
<https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!

Quoted 8 lines
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/

<https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for geomet<0.3,>=0.1

Quoted 8 lines

But that not directly an issue of the setuptools upgrade, but a not well written recipe here.
I'm more than lucky that this update revealed the issue, because otherwise no one would have really noticed that the original recipe of cassandra-driver is pulling sources while installing.
So just in case I would rather pull in this upgrade than to mind the broken recipe from meta-python here (just my 2c)

Quoted 5 lines

i am fine with whatever the right fix is. Its normal that some base infra component dependency
drives a change in another recipe if thats inline with expected design then change the component
to work with new update.

I've sent a patch to the openembedded-devel mailing list that removes the --no-libev flags and adds python3-geomet (which I also sent a patch to add to the layer) to the RDEPENDS, allowing python3-cassandra-driver to build/import OK in an image without trying to pull stuff during do_install.

- Trevor

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 5 lines

| error: Could not find suitable distribution for
Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 3 lines
#7 lore raw

Thanks Trevor! my next world build will be green again (maybe) :).

Quoted 97 lines · Trevor Gamblin
Quoted 3 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

On Thu, Jul 15, 2021 at 10:57 AM Konrad Weihmann <[email protected]>

Quoted 22 lines · wrote:
Quoted 22 lines · Khem Raj
Quoted 21 lines · Martin Jansa
Quoted 19 lines

On Mon, Jul 12, 2021 at 9:57 AM wangmy <[email protected] <mailto:[email protected]>> wrote:

reproducibility.patch
deleted since it's been merged upstream.

v57.1.0
-------

Changes
^^^^^^^
* #2692: Globs are now sorted in 'license_files' restoring reproducibility by eliminating variance from disk order.
* #2714: Update to distutils at pypa/distutils@e2627b7.
* #2715: Removed reliance on deprecated ssl.match_hostname by removing the ssl support. Now any index operations rely on the native SSL implementation.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

FWIW: this change
breaks

meta-openembedded/meta-python/recipes-devtools/python/python3-cassandra-driver_3.25.0.bb:
do_install:

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

+ people who might be interested in python3-cassandra-driver.

| Installed

/jenkins/mjansa/build/ros/ros2-rolling-honister/tmp-glibc/work/core2-64-oe-linux/python3-cassandra-driver/3.25.0-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/cassandra_driver-3.25.0-py3.9-linux-x86_64.egg

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 9 lines
| Processing dependencies for cassandra-driver==3.25.0
| Searching for geomet<0.3,>=0.1
| Reading https://pypi.org/simple/geomet/

<https://pypi.org/simple/geomet/>
| Download error on https://pypi.org/simple/geomet/
<https://pypi.org/simple/geomet/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!

Quoted 8 lines
| Couldn't find index page for 'geomet' (maybe misspelled?)
| Scanning index of all packages (this may take a while)
| Reading https://pypi.org/simple/ <https://pypi.org/simple/>
| Download error on https://pypi.org/simple/

<https://pypi.org/simple/>: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129) -- Some packages may not be found!
| No local packages or working download links found for

geomet<0.3,>=0.1

Quoted 8 lines
Quoted 8 lines

But that not directly an issue of the setuptools upgrade, but a not well written recipe here.
I'm more than lucky that this update revealed the issue, because otherwise no one would have really noticed that the original recipe of cassandra-driver is pulling sources while installing.
So just in case I would rather pull in this upgrade than to mind the broken recipe from meta-python here (just my 2c)

Quoted 5 lines

i am fine with whatever the right fix is. Its normal that some base infra component dependency
drives a change in another recipe if thats inline with expected design then change the component
to work with new update.

I've sent a patch to the openembedded-devel mailing list that removes the --no-libev flags and adds python3-geomet (which I also sent a patch to add to the layer) to the RDEPENDS, allowing python3-cassandra-driver to build/import OK in an image without trying to pull stuff during do_install.

- Trevor

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 5 lines

| error: Could not find suitable distribution for
Requirement.parse('geomet<0.3,>=0.1')

yes its reproduced on AB as well.
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1397

Quoted 3 lines