Skip to contentSkip to conversation

seccomp: add additional asynchronous I/O syscalls

PATCH Applied Paul Moore 3 participants 5 messages Jul 15, 2013 – Aug 2, 2013

lore
Share & tools
lore

Paul Moore

author
#0 lore raw

PATCH 1/1 seccomp: add additional asynchronous I/O syscalls

A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls.

Signed-off-by Paul Moore <[email protected]>
---
 qemu-seccomp.c |    2 ++
 1 file changed, 2 insertions(+)
qemu-seccomp.c +2 -0
index ca123bf..173d185 100644
@@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(socketcall), 250 },
 #endif
     { SCMP_SYS(read), 249 },
+    { SCMP_SYS(io_submit), 249 },
     { SCMP_SYS(brk), 248 },
     { SCMP_SYS(clone), 247 },
     { SCMP_SYS(mmap), 247 },

@@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(recvmmsg), 241 },
     { SCMP_SYS(prlimit64), 241 },
     { SCMP_SYS(waitid), 241 },
+    { SCMP_SYS(io_cancel), 241 },
     { SCMP_SYS(io_setup), 241 },
     { SCMP_SYS(io_destroy), 241 }
 };
author
#1 lore raw
Quoted 6 lines · Paul Moore

A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls.

Signed-off-by Paul Moore <[email protected]>

A gentle nudge so this fix doesn't get forgotten.

Quoted 24 lines
---
 qemu-seccomp.c |    2 ++
 1 file changed, 2 insertions(+)
qemu-seccomp.c +2 -0
index ca123bf..173d185 100644
@@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
 = { { SCMP_SYS(socketcall), 250 },
 #endif
     { SCMP_SYS(read), 249 },
+    { SCMP_SYS(io_submit), 249 },
     { SCMP_SYS(brk), 248 },
     { SCMP_SYS(clone), 247 },
     { SCMP_SYS(mmap), 247 },

@@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall
 seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 },
     { SCMP_SYS(prlimit64), 241 },
     { SCMP_SYS(waitid), 241 },
+    { SCMP_SYS(io_cancel), 241 },
     { SCMP_SYS(io_setup), 241 },
     { SCMP_SYS(io_destroy), 241 }
 };
Signature · 2 lines
paul moore
security and virtualization @ redhat
Reviewed-by
#2 lore raw
Quoted 9 lines · Paul Moore
Quoted 6 lines · Paul Moore

A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls.

Signed-off-by Paul Moore <[email protected]>

A gentle nudge so this fix doesn't get forgotten.

Reviewed and tested.

Reviewed-by Eduardo Otubo <[email protected]>
Quoted 25 lines
Quoted 25 lines
---
  qemu-seccomp.c |    2 ++
  1 file changed, 2 insertions(+)
qemu-seccomp.c +2 -0
index ca123bf..173d185 100644
@@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
 = { { SCMP_SYS(socketcall), 250 },
  #endif
      { SCMP_SYS(read), 249 },
+    { SCMP_SYS(io_submit), 249 },
      { SCMP_SYS(brk), 248 },
      { SCMP_SYS(clone), 247 },
      { SCMP_SYS(mmap), 247 },

@@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall
 seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 },
      { SCMP_SYS(prlimit64), 241 },
      { SCMP_SYS(waitid), 241 },
+    { SCMP_SYS(io_cancel), 241 },
      { SCMP_SYS(io_setup), 241 },
      { SCMP_SYS(io_destroy), 241 }
  };
Signature · 2 lines
Eduardo Otubo
IBM Linux Technology Center
author
#3 lore raw
Quoted 7 lines · Eduardo Otubo
Quoted 6 lines · Paul Moore
Quoted 5 lines · Paul Moore

A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Paul Moore <[email protected]>

A gentle nudge so this fix doesn't get forgotten.

Reviewed and tested.

Reviewed-by Eduardo Otubo <[email protected]>

Any chance of merging this patch?

Quoted 34 lines
Quoted 34 lines
Quoted 34 lines

---

  qemu-seccomp.c |    2 ++
  1 file changed, 2 insertions(+)
qemu-seccomp.c +1 -0
index ca123bf..173d185 100644
@@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall
 seccomp_whitelist[] = { { SCMP_SYS(socketcall), 250 },
 
  #endif
 
      { SCMP_SYS(read), 249 },
 
+    { SCMP_SYS(io_submit), 249 },

      { SCMP_SYS(brk), 248 },
      { SCMP_SYS(clone), 247 },
      { SCMP_SYS(mmap), 247 },
qemu-seccomp.c +1 -0
@@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall
 seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 },
 
      { SCMP_SYS(prlimit64), 241 },
      { SCMP_SYS(waitid), 241 },
 
+    { SCMP_SYS(io_cancel), 241 },
 

      { SCMP_SYS(io_setup), 241 },
      { SCMP_SYS(io_destroy), 241 }
  };
Signature · 2 lines
paul moore
security and virtualization @ redhat