Skip to contentSkip to conversation

Use of BBPATH in a layer.conf file.

DISCUSSION Scott Garman 4 participants 8 messages Dec 2, 2012 – Dec 3, 2012

lore
Share & tools
lore
#0 lore raw

Hey folks,

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center
#1 lore raw
Quoted 7 lines · On Sunday 02 December 2012 14:51:28 Scott Garman wrote:

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

Quoted 7 lines

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
Quoted 12 lines · Paul Eggleton
Quoted 11 lines · On Sunday 02 December 2012 14:51:28 Scott Garman wrote:

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Quoted 7 lines
Quoted 3 lines

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Oh? Would this apply just to meta-yocto or all layer.conf files?

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center
#3 lore raw
Quoted 17 lines · On Sunday 02 December 2012 15:35:54 you wrote:
Quoted 16 lines · Paul Eggleton
Quoted 14 lines · On Sunday 02 December 2012 14:51:28 Scott Garman wrote:

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

Quoted 5 lines
Quoted 3 lines

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Oh? Would this apply just to meta-yocto or all layer.conf files?

All, really. Functionally it makes no real difference, but I think it's preferred stylistically based on previous discussions.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw
Quoted 18 lines · Paul Eggleton
Quoted 17 lines · On Sunday 02 December 2012 15:35:54 you wrote:
Quoted 16 lines · Paul Eggleton
Quoted 14 lines · On Sunday 02 December 2012 14:51:28 Scott Garman wrote:

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Oh? Would this apply just to meta-yocto or all layer.conf files?

All, really. Functionally it makes no real difference, but I think it's preferred stylistically based on previous discussions.

hang on ... i thought the ordering of BBPATH would affect the
processing of "include" directives. no?

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#5 lore raw
Quoted 25 lines · On Monday 03 December 2012 03:16:10 Robert P. J. Day wrote:
Quoted 24 lines · Paul Eggleton
Quoted 23 lines · On Sunday 02 December 2012 15:35:54 you wrote:
Quoted 21 lines · Paul Eggleton
Quoted 9 lines · On Sunday 02 December 2012 14:51:28 Scott Garman wrote:

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

but in meta-yocto, we do:

Quoted 7 lines

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different
ordering in meta-yocto's layer.conf, I will submit a patch to make this
more consistent.

I think it actually ought to be:

BBPATH .= ":${LAYERDIR}"

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Oh? Would this apply just to meta-yocto or all layer.conf files?

All, really. Functionally it makes no real difference, but I think it's preferred stylistically based on previous discussions.

hang on ... i thought the ordering of BBPATH would affect the
processing of "include" directives. no?

Yes, it does. What I mean is, functionally _within layer.conf_ the following two are equivalent:

BBPATH := "${BBPATH}:${LAYERDIR}"

BBPATH .= ":${LAYERDIR}"

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#6 lore raw
In reply to Scott Garman
Quoted 7 lines · Scott Garman

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

Quoted 7 lines

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

This meta-yocto setup is intentional (there was thread about that a while back). meta-yocto is a distro layer, and for any distro layer it is reasonable to enforce its own precedence over any other layers is may use, and meta-yocto chooses to do this. Non-distro layers, including all bsp layers, are expected to always use an append operation so that they can be stacked together.

Tomas

Signature · 1 line
http://sleepfive.com
#7 lore raw
Quoted 16 lines · Tomas Frydrych
Quoted 7 lines · Scott Garman

Robert Day has brought up an inconsistency in the way we append to BBPATH within a couple of our layer.conf files.

In meta-hob, meta-yocto-bsp, and meta-intel, we do:

BBPATH := "${BBPATH}:${LAYERDIR}"

Quoted 7 lines

but in meta-yocto, we do:

BBPATH := "${LAYERDIR}:${BBPATH}"

Unless someone explains to me that it's necessary to use this different ordering in meta-yocto's layer.conf, I will submit a patch to make this more consistent.

Quoted 6 lines

This meta-yocto setup is intentional (there was thread about that a while back). meta-yocto is a distro layer, and for any distro layer it is reasonable to enforce its own precedence over any other layers is may use, and meta-yocto chooses to do this. Non-distro layers, including all bsp layers, are expected to always use an append operation so that they can be stacked together.

Thanks for the concise explanation.

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center