Skip to contentSkip to conversation

mm, memory-failure: clarify error message

PATCH In review Jane Chu 4 participants 4 messages May 21, 2019

Subsystems (3)
lore
Share & tools
lore

Jane Chu

author
#0 lore raw

PATCH v2 1/1 mm, memory-failure: clarify error message

Some user who install SIGBUS handler that does longjmp out therefore keeping the process alive is confused by the error message
"[188988.765862] Memory failure: 0x1840200: Killing
cellsrv:33395 due to hardware memory corruption"
Slightly modify the error message to improve clarity.

---
 mm/memory-failure.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory-failure.c +1 -1
index fc8b517..c4f4bcd 100644
@@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags)
 	short addr_lsb = tk->size_shift;
 	int ret;
 
-	pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory corruption\n",
+	pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n",
 		pfn, t->comm, t->pid);
 
 	if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
Signature · 6 lines
1.8.3.1

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Jane Chu

Some user who install SIGBUS handler that does longjmp out therefore keeping the process alive is confused by the error message
"[188988.765862] Memory failure: 0x1840200: Killing
cellsrv:33395 due to hardware memory corruption"
Slightly modify the error message to improve clarity.

Thanks!

Reviewed-by on v2 1/1
#2 lore raw
In reply to Jane Chu
Quoted 8 lines · Jane Chu

Some user who install SIGBUS handler that does longjmp out therefore keeping the process alive is confused by the error message
"[188988.765862] Memory failure: 0x1840200: Killing
cellsrv:33395 due to hardware memory corruption"
Slightly modify the error message to improve clarity.

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Acked-by on v2 1/1
#3 lore raw
In reply to Jane Chu
Quoted 29 lines

Some user who install SIGBUS handler that does longjmp out therefore keeping the process alive is confused by the error message
"[188988.765862] Memory failure: 0x1840200: Killing
cellsrv:33395 due to hardware memory corruption"
Slightly modify the error message to improve clarity.

---
 mm/memory-failure.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory-failure.c +1 -1
index fc8b517..c4f4bcd 100644
@@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long
 pfn, int flags)
         short addr_lsb = tk->size_shift;
         int ret;
 
-        pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory
 corruption\n",
+        pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware
 memory corruption\n",
                 pfn, t->comm, t->pid);
 
         if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
Quoted 2 lines

--
1.8.3.1

This error message is helpful.

Quoted 6 lines

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm