Skip to contentSkip to conversation

mn10300: Select CONFIG_HAVE_UID16 to fix build failure

PATCH In review Guenter Roeck 3 participants 5 messages Nov 28, 2015 – Nov 30, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mn10300: Select CONFIG_HAVE_UID16 to fix build failure

mn10300 builds fail with

fs/stat.c: In function 'cp_old_stat':
fs/stat.c:163:2: error: 'old_uid_t' undeclared

ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
ipc/util.c:540:2: error: 'old_uid_t' undeclared

Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16 to fix the problem.

Fixes fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
Cc Arnd Bergmann <[email protected]>
---
 arch/mn10300/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/mn10300/Kconfig +1 -3
index 4434b54e1d87..78ae5552fdb8 100644
@@ -1,6 +1,7 @@
 config MN10300
 	def_bool y
 	select HAVE_OPROFILE
+	select HAVE_UID16
 	select GENERIC_IRQ_SHOW
 	select ARCH_WANT_IPC_PARSE_VERSION
 	select HAVE_ARCH_TRACEHOOK
@@ -37,9 +38,6 @@ config HIGHMEM
 config NUMA
 	def_bool n
 
-config UID16
-	def_bool y
-
 config RWSEM_GENERIC_SPINLOCK
 	def_bool y
 
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Saturday 28 November 2015 08:57:57 Guenter Roeck wrote:

mn10300 builds fail with

fs/stat.c: In function 'cp_old_stat':
fs/stat.c:163:2: error: 'old_uid_t' undeclared

ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
ipc/util.c:540:2: error: 'old_uid_t' undeclared

Quoted 7 lines

Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16 to fix the problem.

Fixes fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
Cc Arnd Bergmann <[email protected]>

sorry about causing this.

Acked-by on v1 1/1
#2 lore raw
In reply to Guenter Roeck
Quoted 8 lines · Guenter Roeck

mn10300 builds fail with

fs/stat.c: In function 'cp_old_stat':
fs/stat.c:163:2: error: 'old_uid_t' undeclared

ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
ipc/util.c:540:2: error: 'old_uid_t' undeclared

Quoted 6 lines

Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16 to fix the problem.

Fixes fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
Cc Arnd Bergmann <[email protected]>
#3 lore raw
Quoted 10 lines · David Howells
Quoted 8 lines · Guenter Roeck

mn10300 builds fail with

fs/stat.c: In function 'cp_old_stat':
fs/stat.c:163:2: error: 'old_uid_t' undeclared

ipc/util.c: In function 'ipc64_perm_to_ipc_perm':
ipc/util.c:540:2: error: 'old_uid_t' undeclared

Quoted 9 lines
Quoted 6 lines

Select CONFIG_HAVE_UID16 and remove local definition of CONFIG_UID16 to fix the problem.

Fixes fbc416ff8618 ("arm64: fix building without CONFIG_UID16")
Cc Arnd Bergmann <[email protected]>

David,

your Acked-by: seems to suggest that you don't plan to send this patch to Linus. At the same time, it looks like Koichi Yasutake's e-mail address is no longer valid.

Do you want me to send it directly ?

Thanks,
Guenter

#4 lore raw
Quoted 5 lines · Guenter Roeck

your Acked-by: seems to suggest that you don't plan to send this patch to Linus. At the same time, it looks like Koichi Yasutake's e-mail address is no longer valid.

Do you want me to send it directly ?

Please do.

Thanks,
David