Skip to contentSkip to conversation

crypto: DH - limit key size to 2048 in FIPS mode

PATCH In review Stephan Müller 2 participants 2 messages Nov 21, 2021 – Nov 26, 2021 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: DH - limit key size to 2048 in FIPS mode

FIPS disallows DH with keys < 2048 bits. Thus, the kernel should consider the enforcement of this limit.

---
 crypto/dh.c | 4 ++++
 1 file changed, 4 insertions(+)
crypto/dh.c +4 -0
index cd4f32092e5c..38557e64b4b3 100644
@@ -5,6 +5,7 @@
  * Authors: Salvatore Benedetto <[email protected]>
  */
 
+#include <linux/fips.h>
 #include <linux/module.h>
 #include <crypto/internal/kpp.h>
 #include <crypto/kpp.h>
@@ -47,6 +48,9 @@ static inline struct dh_ctx *dh_get_ctx(struct crypto_kpp *tfm)
 
 static int dh_check_params_length(unsigned int p_len)
 {
+	if (fips_enabled)
+		return (p_len < 2048) ? -EINVAL : 0;
+
 	return (p_len < 1536) ? -EINVAL : 0;
 }
 
Signature · 1 line
2.33.1
maintainer
#1 lore raw
Quoted 7 lines · Stephan Müller

FIPS disallows DH with keys < 2048 bits. Thus, the kernel should consider the enforcement of this limit.

---
 crypto/dh.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt