ARM: multi_v7_defconfig: Make drm support modular

PATCH New Geert Uytterhoeven 4 participants 7 messages May 29, 2015 – Jun 8, 2015

Subsystems (3)

Arm (32-bit) Arm Qualcomm mailing list Tegra architecture support

lore

Share & tools

lore

Geert Uytterhoeven

author

2015-05-29 13:25 UTC #0 lore raw

PATCH 1/2 ARM: multi_v7_defconfig: Make drm support modular

From: Geert Uytterhoeven <[email protected]>

Make drm support modular to reduce kernel size (-620 KiB):

       text    data     bss     dec     hex   filename
    12211122 1392076  338520 13941718  d4bbd6 vmlinux.before
    11581470 1387196  338264 13306930  cb0c32 vmlinux.after

Signed-off-by Geert Uytterhoeven <[email protected]>

---
Slightly controversial:
- Does anyone need drm for boot testing?

 arch/arm/configs/multi_v7_defconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

arch/arm/configs/multi_v7_defconfig +5 -3

index 40ca1ab29a2e350f..9b4e33d5b15e340f 100644
@@ -426,15 +426,17 @@ CONFIG_VIDEO_RENESAS_VSP1=m
 # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
 CONFIG_VIDEO_ADV7180=m
 CONFIG_VIDEO_ML86V7667=m
-CONFIG_DRM=y
+CONFIG_TEGRA_HOST1X=y
+CONFIG_DRM=m
 CONFIG_DRM_PTN3460=m
 CONFIG_DRM_PS8622=m
 CONFIG_DRM_EXYNOS=m
 CONFIG_DRM_EXYNOS_FIMD=y
 CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_RCAR_DU=m
-CONFIG_DRM_TEGRA=y
-CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_TEGRA=m
+CONFIG_DRM_PANEL_SIMPLE=m
+CONFIG_FB=y
 CONFIG_FB_ARMCLCD=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y

Signature · 1 line

1.9.1

Geert Uytterhoeven

author

2015-05-29 13:25 UTC #1 lore raw

PATCH 2/2 ARM: multi_v7_defconfig: Make fbdev support modular

From: Geert Uytterhoeven <[email protected]>

Make fbdev support modular to reduce kernel size (-158 KiB):

       text    data     bss     dec     hex   filename
    11581470 1387196  338264 13306930  cb0c32 vmlinux.before
    11430531 1384340  330584 13145455  c8956f vmlinux.after

Signed-off-by Geert Uytterhoeven <[email protected]>

---
This one is more controversial:
- Does anyone need fbdev for boot-testing?
- This disables two drivers that cannot be modular (FB_WM8505 and FB_SIMPLE), and the PLAT_VERSATILE_CLCD helper support.

 arch/arm/configs/multi_v7_defconfig | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

arch/arm/configs/multi_v7_defconfig +3 -6

index 9b4e33d5b15e340f..af94ade61b1400d6 100644
@@ -436,18 +436,15 @@ CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_SIMPLE=m
-CONFIG_FB=y
-CONFIG_FB_ARMCLCD=y
-CONFIG_FB_WM8505=y
-CONFIG_FB_SH_MOBILE_LCDC=y
-CONFIG_FB_SIMPLE=y
+CONFIG_FB_ARMCLCD=m
+CONFIG_FB_SH_MOBILE_LCDC=m
 CONFIG_FB_SH_MOBILE_MERAM=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
 CONFIG_LCD_PLATFORM=m
 CONFIG_BACKLIGHT_PWM=y
 CONFIG_BACKLIGHT_AS3711=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_FRAMEBUFFER_CONSOLE=m
 CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 CONFIG_SOUND=m
 CONFIG_SND=m

Signature · 1 line

1.9.1

Arnd Bergmann

2015-05-29 14:31 UTC #2 lore raw

PATCH 2/2 ARM: multi_v7_defconfig: Make fbdev support modular

Quoted 8 lines · On Friday 29 May 2015 15:25:26 Geert Uytterhoeven wrote:

From: Geert Uytterhoeven <[email protected]>
Make fbdev support modular to reduce kernel size (-158 KiB):
       text    data     bss     dec     hex   filename
    11581470 1387196  338264 13306930  cb0c32 vmlinux.before
    11430531 1384340  330584 13145455  c8956f vmlinux.after

Quoted 6 lines

Signed-off-by Geert Uytterhoeven <[email protected]>
---
This one is more controversial:
- Does anyone need fbdev for boot-testing?
- This disables two drivers that cannot be modular (FB_WM8505 and FB_SIMPLE), and the PLAT_VERSATILE_CLCD helper support.

My guess is that FB_WM8505 would be useful, as the chip is primarily used in tablets that don't come with an easily accessible UART.

OTOH, those machines are very rare, and we may decided that we just include them for build testing as well as the odd developers that do have a UART.

Arnd

Quoted 30 lines

 arch/arm/configs/multi_v7_defconfig | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

arch/arm/configs/multi_v7_defconfig +3 -6

index 9b4e33d5b15e340f..af94ade61b1400d6 100644
@@ -436,18 +436,15 @@ CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_SIMPLE=m
-CONFIG_FB=y
-CONFIG_FB_ARMCLCD=y
-CONFIG_FB_WM8505=y
-CONFIG_FB_SH_MOBILE_LCDC=y
-CONFIG_FB_SIMPLE=y
+CONFIG_FB_ARMCLCD=m
+CONFIG_FB_SH_MOBILE_LCDC=m
 CONFIG_FB_SH_MOBILE_MERAM=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
 CONFIG_LCD_PLATFORM=m
 CONFIG_BACKLIGHT_PWM=y
 CONFIG_BACKLIGHT_AS3711=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_FRAMEBUFFER_CONSOLE=m
 CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 CONFIG_SOUND=m
 CONFIG_SND=m

Arnd Bergmann

2015-05-29 15:41 UTC #3 lore raw

PATCH 1/2 ARM: multi_v7_defconfig: Make drm support modular

In reply to Geert Uytterhoeven

Quoted 4 lines · On Friday 29 May 2015 15:25:25 Geert Uytterhoeven wrote:

From: Geert Uytterhoeven <[email protected]>
Make drm support modular to reduce kernel size (-620 KiB):

Quoted 8 lines

       text    data     bss     dec     hex   filename
    12211122 1392076  338520 13941718  d4bbd6 vmlinux.before
    11581470 1387196  338264 13306930  cb0c32 vmlinux.after
Signed-off-by Geert Uytterhoeven <[email protected]>
---
Slightly controversial:
- Does anyone need drm for boot testing?

Only the tegra driver is affected, so let's ask the tegra maintainers.

Arnd

Quoted 30 lines

 arch/arm/configs/multi_v7_defconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

arch/arm/configs/multi_v7_defconfig +5 -3

index 40ca1ab29a2e350f..9b4e33d5b15e340f 100644
@@ -426,15 +426,17 @@ CONFIG_VIDEO_RENESAS_VSP1=m
 # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
 CONFIG_VIDEO_ADV7180=m
 CONFIG_VIDEO_ML86V7667=m
-CONFIG_DRM=y
+CONFIG_TEGRA_HOST1X=y
+CONFIG_DRM=m
 CONFIG_DRM_PTN3460=m
 CONFIG_DRM_PS8622=m
 CONFIG_DRM_EXYNOS=m
 CONFIG_DRM_EXYNOS_FIMD=y
 CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_RCAR_DU=m
-CONFIG_DRM_TEGRA=y
-CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_TEGRA=m
+CONFIG_DRM_PANEL_SIMPLE=m
+CONFIG_FB=y
 CONFIG_FB_ARMCLCD=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y

Geert Uytterhoeven

author

2015-05-29 16:33 UTC #4 lore raw

PATCH 1/2 ARM: multi_v7_defconfig: Make drm support modular

Quoted 9 lines · Arnd Bergmann

Quoted 8 lines · On Friday 29 May 2015 15:25:25 Geert Uytterhoeven wrote:
From: Geert Uytterhoeven <[email protected]>
Make drm support modular to reduce kernel size (-620 KiB):
       text    data     bss     dec     hex   filename
    12211122 1392076  338520 13941718  d4bbd6 vmlinux.before
    11581470 1387196  338264 13306930  cb0c32 vmlinux.after

Quoted 7 lines

Quoted 4 lines
Signed-off-by Geert Uytterhoeven <[email protected]>
---
Slightly controversial:
- Does anyone need drm for boot testing?
Only the tegra driver is affected, so let's ask the tegra maintainers.

And the qcom maintainers.

CONFIG_DRM_MSM also changes from m to y, but this is not visible in multi_v7_defconfig due to CONFIG_DRM_MSM_FBDEV=y and defconfig reduction...

Quoted 20 lines

 arch/arm/configs/multi_v7_defconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

arch/arm/configs/multi_v7_defconfig +2 -1

index 40ca1ab29a2e350f..9b4e33d5b15e340f 100644
@@ -426,15 +426,17 @@ CONFIG_VIDEO_RENESAS_VSP1=m
 # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
 CONFIG_VIDEO_ADV7180=m
 CONFIG_VIDEO_ML86V7667=m
-CONFIG_DRM=y
+CONFIG_TEGRA_HOST1X=y
+CONFIG_DRM=m
 CONFIG_DRM_PTN3460=m
 CONFIG_DRM_PS8622=m
 CONFIG_DRM_EXYNOS=m
 CONFIG_DRM_EXYNOS_FIMD=y
 CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_RCAR_DU=m

Quoted 8 lines

arch/arm/configs/multi_v7_defconfig CONFIG_VIDEO_RENESAS_VSP1=m · line 442
Quoted 8 lines
arch/arm/configs/multi_v7_defconfig +3 -2
-CONFIG_DRM_TEGRA=y
-CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_TEGRA=m
+CONFIG_DRM_PANEL_SIMPLE=m
+CONFIG_FB=y
 CONFIG_FB_ARMCLCD=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Thierry Reding

2015-06-05 11:39 UTC #5 lore raw

PATCH 1/2 ARM: multi_v7_defconfig: Make drm support modular

In reply to Arnd Bergmann

Quoted 9 lines · Arnd Bergmann

Quoted 8 lines · On Friday 29 May 2015 15:25:25 Geert Uytterhoeven wrote:
From: Geert Uytterhoeven <[email protected]>
Make drm support modular to reduce kernel size (-620 KiB):
       text    data     bss     dec     hex   filename
    12211122 1392076  338520 13941718  d4bbd6 vmlinux.before
    11581470 1387196  338264 13306930  cb0c32 vmlinux.after

Quoted 7 lines

Quoted 4 lines
Signed-off-by Geert Uytterhoeven <[email protected]>
---
Slightly controversial:
- Does anyone need drm for boot testing?
Only the tegra driver is affected, so let's ask the tegra maintainers.

As a matter of fact I do most of the DRM testing on boot using the built-in driver. However I can do that easily using tegra_defconfig so I'm fine with this change.

Acked-by Thierry Reding <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150605/adbb4a75/attachment.sig>

Alexandre Courbot

2015-06-08 02:09 UTC #6 lore raw

PATCH 1/2 ARM: multi_v7_defconfig: Make drm support modular

Quoted 15 lines · Thierry Reding

Quoted 14 lines · Arnd Bergmann
Quoted 12 lines · On Friday 29 May 2015 15:25:25 Geert Uytterhoeven wrote:
From: Geert Uytterhoeven <[email protected]>
Make drm support modular to reduce kernel size (-620 KiB):
       text    data     bss     dec     hex   filename
    12211122 1392076  338520 13941718  d4bbd6 vmlinux.before
    11581470 1387196  338264 13306930  cb0c32 vmlinux.after
Signed-off-by Geert Uytterhoeven <[email protected]>
---
Slightly controversial:
- Does anyone need drm for boot testing?

Quoted 8 lines

Quoted 2 lines
Only the tegra driver is affected, so let's ask the tegra maintainers.
As a matter of fact I do most of the DRM testing on boot using the built-in driver. However I can do that easily using tegra_defconfig so I'm fine with this change.
Acked-by Thierry Reding <[email protected]>

Looks good to me to, Nouveau works better as a module anyway. :)

Acked-by Alexandre Courbot <[email protected]>