FB: Add some members for CPU Interface.
PATCH 1/3 FB: Add some members for CPU Interface.
Ok, I understood.
I think this issue incompatible with existing users is because userspace API didn't consider cpu mode before. anyway, I will correct my patch as your comments and send it again.
Perhaps, cpu timing variables would be moved to platform file.
thank you.
------- Original Message -------
Sender : Russell King - ARM Linux<[email protected]>
Date : 2010-07-02 16:30 (GMT+09:00)
Title : Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Quoted 6 lines · Jaya Kumar
Quoted 6 lines
include/linux/fb.h +0
-0@@ -269,6 +269,12 @@ struct fb_var_screeninfo {__u32 vmode;/* see FB_VMODE_* */
Quoted 8 lines
include/linux/fb.h struct fb_var_screeninfo { · line 277
Quoted 8 lines
include/linux/fb.h +6
-0__u32 rotate;/* angle we rotate counter clockwise */ __u32 reserved[5 ];/* Reserved for future compatibility */ + +/* For cpu interface timing. */ +__u32 cs_setup; +__u32 wr_setup; +__u32 wr_act; +__u32 wr_hold;
This changes the framebuffer userspace API, making it incompatible with existing users. What this means is that stuff using the framebuffer API in userspace has to be upgraded/downgraded in lock-step with this change
- which is not a good idea.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/3 FB: Add some members for CPU Interface.
Quoted 5 lines
I think this issue incompatible with existing users is because userspace API didn't consider cpu mode before. anyway, I will correct my patch as your comments and send it again.
Perhaps, cpu timing variables would be moved to platform file.
I would suggest using sysfs for those extra variables.
Quoted 34 lines
thank you.
------- Original Message -------
Sender : Russell King - ARM Linux<[email protected]>
Date : 2010-07-02 16:30 (GMT+09:00)
Title : Re: [PATCH 1/3] FB: Add some members for CPU Interface.Quoted 6 lines · Jaya Kumar
Quoted 6 lines
include/linux/fb.h +0
-0@@ -269,6 +269,12 @@ struct fb_var_screeninfo {__u32 vmode;/* see FB_VMODE_* */ Quoted 8 lines
include/linux/fb.h struct fb_var_screeninfo { · line 277
Quoted 8 lines
include/linux/fb.h +6
-0__u32 rotate;/* angle we rotate counter clockwise */ __u32 reserved[5 ];/* Reserved for future compatibility */ + +/* For cpu interface timing. */ +__u32 cs_setup; +__u32 wr_setup; +__u32 wr_act; +__u32 wr_hold;This changes the framebuffer userspace API, making it incompatible with existing users. What this means is that stuff using the framebuffer API in userspace has to be upgraded/downgraded in lock-step with this change
- which is not a good idea.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line
N?????r??y????b?X????v?^?)??{.n?+????{?}?^?)????w* jg???
???????j/?????z?????2???????&?)???a????
?G?????h??j:+v???w????