Skip to contentSkip to conversation

ath11k: fix compiler warnings for unused variables

PATCH In review John Crispin 3 participants 3 messages Apr 10, 2019 – Apr 15, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: fix compiler warnings for unused variables

CC [M] drivers/net/wireless/ath/ath11k/core.o
drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused variable 'rproc_phandle' [-Wunused-variable] phandle rproc_phandle;
^
drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused variable 'prproc' [-Wunused-variable] struct rproc *prproc;
^
drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused variable 'dev' [-Wunused-variable] struct device *dev = sc->dev;
^

---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/core.c +1 -1
index 48a42cad4e14..af4aa8eabd81 100644
@@ -747,11 +747,11 @@ static void ath11k_core_restart(struct work_struct *work)
 int ath11k_core_init(struct ath11k_base *sc)
 {
 	struct device *dev = sc->dev;
+#ifndef CONFIG_IPQ_SUBSYSTEM_RESTART
 	struct rproc *prproc;
 	phandle rproc_phandle;
 	int ret;
 
-#ifndef CONFIG_IPQ_SUBSYSTEM_RESTART
 	if (of_property_read_u32(dev->of_node, "q6_rproc", &rproc_phandle)) {
 		ath11k_err(sc, "failed to get q6_rproc handle\n");
 		return -ENOENT;
Signature · 7 lines
2.11.0


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 11 lines · On Wednesday, 10 April 2019 07:58:40 CEST John Crispin wrote:

CC [M] drivers/net/wireless/ath/ath11k/core.o
drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused variable 'rproc_phandle' [-Wunused-variable] phandle rproc_phandle;
^
drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused variable 'prproc' [-Wunused-variable] struct rproc *prproc;
^
drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused variable 'dev' [-Wunused-variable] struct device *dev = sc->dev;
^

This patch doesn't apply because they just dropped the CONFIG_IPQ_SUBSYSTEM_RESTART support (which is their only way to get the Q6 up in their 4.4 Hawkeye kernel) using a off-the-list patch [1] submission.

Kind regards,
Sven

[1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath11k-bringup&id=426598fdbef82ace7b4a728445f61ecf034f233c

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k

#2 lore raw
Quoted 16 lines · Sven Eckelmann
Quoted 6 lines · On Wednesday, 10 April 2019 07:58:40 CEST John Crispin wrote:

CC [M] drivers/net/wireless/ath/ath11k/core.o
drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused variable 'rproc_phandle' [-Wunused-variable]
phandle rproc_phandle;
^

Quoted 8 lines

drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused variable 'prproc' [-Wunused-variable]
struct rproc *prproc;
^
drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused variable 'dev' [-Wunused-variable]
struct device *dev = sc->dev;
^

Quoted 3 lines

This patch doesn't apply because they just dropped the CONFIG_IPQ_SUBSYSTEM_RESTART support (which is their only way to get the Q6 up in their 4.4 Hawkeye kernel) using a off-the-list patch [1] submission.

BTW, now as the ath11k mailing list is up and running, I won't apply patches directly to ath11k-bringup branch anymore. I only take them from this list after review, I was thinking to wait minimum two days for comments.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k