Skip to contentSkip to conversation

staging: nvec: replace led_classdev_register

PATCH In review Gujulan Elango, Hari Prasath (H.) 2 participants 2 messages Jan 21, 2016 – Jan 25, 2016

Subsystems (3)
Staging Tegra architecture support Staging - NVIDIA compliant embedded controller interface (nvec)
lore
Share & tools
lore

Gujulan Elango, Hari Prasath (H.)

author
#0 lore raw

PATCH 1/1 staging: nvec: replace led_classdev_register

From: Hari Prasath Gujulan Elango <[email protected]>

Replace the led_classdev_register() with the platform managed version devm_led_classdev_register() & henceforth remove the redundant nvec_paz00_remove() function.

Signed-off-by Hari Prasath Gujulan Elango <[email protected]>
---
 drivers/staging/nvec/nvec_paz00.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/staging/nvec/nvec_paz00.c +1 -11
index 68146bf..cddbfd2 100644
@@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, led);
 
-	ret = led_classdev_register(&pdev->dev, &led->cdev);
+	ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
 	if (ret < 0)
 		return ret;
 

@@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int nvec_paz00_remove(struct platform_device *pdev)
-{
-	struct nvec_led *led = platform_get_drvdata(pdev);
-
-	led_classdev_unregister(&led->cdev);
-
-	return 0;
-}
-
 static struct platform_driver nvec_paz00_driver = {
 	.probe  = nvec_paz00_probe,
-	.remove = nvec_paz00_remove,
 	.driver = {
 		.name  = "nvec-paz00",
 	},
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw

Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath:

Quoted 7 lines

From: Hari Prasath Gujulan Elango <[email protected]>

Replace the led_classdev_register() with the platform managed version devm_led_classdev_register() & henceforth remove the redundant nvec_paz00_remove() function.

Signed-off-by Hari Prasath Gujulan Elango <[email protected]>

Thanks!

Acked-by Marc Dietrich <[email protected]>
Quoted 36 lines
---
 drivers/staging/nvec/nvec_paz00.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/nvec/nvec_paz00.c index 68146bf..cddbfd2 100644

drivers/staging/nvec/nvec_paz00.c +1 -11
@@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, led);
 
-	ret = led_classdev_register(&pdev->dev, &led->cdev);
+	ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
 	if (ret < 0)
 		return ret;
 

@@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 return 0;
 }
 
-static int nvec_paz00_remove(struct platform_device *pdev)
-{
-	struct nvec_led *led = platform_get_drvdata(pdev);
-
-	led_classdev_unregister(&led->cdev);
-
-	return 0;
-}
-
 static struct platform_driver nvec_paz00_driver = {
 	.probe  = nvec_paz00_probe,
-	.remove = nvec_paz00_remove,
 	.driver = {
 		.name  = "nvec-paz00",
 	},