Skip to contentSkip to conversation

S390: Bail out whithout KVM

PATCH In review Alexander Graf 2 participants 4 messages Dec 18, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 S390: Bail out whithout KVM

Currently only the S390 KVM target works. To keep users from accidently not using KVM, let's not even initialize the machine when KVM is not used.

---
 hw/s390-virtio.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
hw/s390-virtio.c +7 -0
index b57fa9c..a33076a 100644
@@ -142,6 +142,13 @@ static void s390_init(ram_addr_t ram_size,
     ram_addr_t initrd_size = 0;
     int i;
 
+    /* XXX we only work on KVM for now */
+
+    if (!kvm_enabled()) {
+        fprintf(stderr, "The S390 target only works with KVM enabled\n");
+        exit(1);
+    }
+
     /* get a BUS */
     s390_bus = s390_virtio_bus_init(&ram_size);
 
Signature · 1 line
1.6.0.2
#1 lore raw

Hi,

Am 18.12.2009 um 16:29 schrieb Alexander Graf:

Quoted 2 lines

Currently only the S390 KVM target works. To keep users from accidently not using KVM, let's not even initialize the machine when KVM is not used.

How does this fit together with your "S390 TCG target" patch? Aren't they mutually exclusive? Is this one for stable?

Andreas

Quoted 29 lines

---
hw/s390-virtio.c | 7 +++++++

1 files changed, 7 insertions(+), 0 deletions(-)
hw/s390-virtio.c +7 -0
index b57fa9c..a33076a 100644
@@ -142,6 +142,13 @@ static void s390_init(ram_addr_t ram_size,
    ram_addr_t initrd_size = 0;
    int i;
 
+    /* XXX we only work on KVM for now */
+
+    if (!kvm_enabled()) {
+        fprintf(stderr, "The S390 target only works with KVM enabled 
 \n");
+        exit(1);
+    }
+
    /* get a BUS */
    s390_bus = s390_virtio_bus_init(&ram_size);
Signature · 2 lines
-- 
1.6.0.2
#2 lore raw
Quoted 10 lines · Andreas Färber

Hi,

Am 18.12.2009 um 16:29 schrieb Alexander Graf:

Quoted 3 lines

Currently only the S390 KVM target works. To keep users from accidently not
using KVM, let's not even initialize the machine when KVM is not used.

How does this fit together with your "S390 TCG target" patch? Aren't they mutually exclusive? Is this one for stable?

They go hand in hand.

The TCG patch is to enable S390x hosts, so you can run qemu-system-x86_64 on S390.
This patch is for S390x guests, so qemu-system-s390x refuses to start without -enable-kvm.

Alex

#3 lore raw

Am 18.12.2009 um 22:07 schrieb Alexander Graf:

Quoted 12 lines
Quoted 10 lines · Andreas Färber

Hi,

Am 18.12.2009 um 16:29 schrieb Alexander Graf:

Quoted 3 lines

Currently only the S390 KVM target works. To keep users from accidently not
using KVM, let's not even initialize the machine when KVM is not used.

How does this fit together with your "S390 TCG target" patch? Aren't they mutually exclusive? Is this one for stable?

Quoted 6 lines

They go hand in hand.

The TCG patch is to enable S390x hosts, so you can run qemu-system-x86_64 on S390.
This patch is for S390x guests, so qemu-system-s390x refuses to start without -enable-kvm.

Ouch! Thanks for clarifying.

Andreas