bpf: task_group_seq_get_next: use __next_thread()
Subsystems (2)
cover bpf: task_group_seq_get_next: use __next_thread()
Compile tested, 1-5 need the review from bpf maintainers, quite possibly I did some silly mistakes. I tried to cleanup this code because I could not look at it, but it has other problems and imo should be rewritten.
6/6 obviously depends on
[PATCH 1/2] introduce __next_thread(), fix next_tid() vs exec() race https://lore.kernel.org/all/[email protected]/
which was not merged yet.
To simplify the review, this is the code after 6/6:
static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_common *common,
u32 *tid,
bool skip_if_dup_files)
{
struct task_struct *task;
struct pid *pid;
u32 next_tid;
if (!*tid) {
/* The first time, the iterator calls this function. */
pid = find_pid_ns(common->pid, common->ns);
task = get_pid_task(pid, PIDTYPE_TGID);
if (!task)
return NULL;
*tid = common->pid;
common->pid_visiting = common->pid;
return task;
}
/* If the control returns to user space and comes back to the
* kernel again, *tid and common->pid_visiting should be the
* same for task_seq_start() to pick up the correct task.
*/
if (*tid == common->pid_visiting) {
pid = find_pid_ns(common->pid_visiting, common->ns);
task = get_pid_task(pid, PIDTYPE_PID);
return task;
}
task = find_task_by_pid_ns(common->pid_visiting, common->ns);
if (!task)
return NULL;
retry:
task = __next_thread(task);
if (!task)
return NULL;
next_tid = __task_pid_nr_ns(task, PIDTYPE_PID, common->ns);
if (!next_tid)
goto retry;
if (skip_if_dup_files && task->files == task->group_leader->files)
goto retry;
*tid = common->pid_visiting = next_tid;
get_task_struct(task);
return task;
}Oleg.
PATCH 1/6 bpf: task_group_seq_get_next: cleanup the usage of next_thread()
1. find_pid_ns() + get_pid_task() under rcu_read_lock() guarantees that we can safely iterate the task->thread_group list. Even if this task exits right after get_pid_task() (or goto retry) and pid_alive() returns 0.
Kill the unnecessary pid_alive() check.
2. next_thread() simply can't return NULL, kill the bogus "if (!next_task)" check.
--- kernel/bpf/task_iter.c | 7 ------- 1 file changed, 7 deletions(-)
kernel/bpf/task_iter.c +0 -7
@@ -75,15 +75,8 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn NULL ; retry: -if (!pid_alive (task)) { -put_task_struct (task); -return NULL ; - } - next_task =next_thread (task);put_task_struct (task); -if (!next_task) -return NULL ; saved_tid = *tid; *tid =__task_pid_nr_ns (next_task,PIDTYPE_PID , common->ns);
Signature · 1 line
2.25.1.362.g51ebf55
Re: [PATCH 1/6] bpf: task_group_seq_get_next: cleanup the usage of next_thread()
Quoted 10 lines · Oleg Nesterov
1.
find_pid_ns()+get_pid_task()underrcu_read_lock()guarantees that we can safely iterate thetask->thread_grouplist. Even if this task exits right afterget_pid_task()(or goto retry) andpid_alive()returns 0.Kill the unnecessary
pid_alive()check.2.
next_thread()simply can't return NULL, kill the bogus "if (!next_task)" check.Signed-off-by Oleg Nesterov <[email protected]>
__unhash_process() tries to detach_pid() (pid_alive() may become false) and ist_del_rcu(&p->thread_group). So yes, next_thread() should be safe to grab next_task since &task->thread_group is rcu protected. So
Quoted 24 lines
--- kernel/bpf/task_iter.c | 7 ------- 1 file changed, 7 deletions(-)kernel/bpf/task_iter.c +0
-7@@ -75,15 +75,8 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn NULL ; retry: -if (!pid_alive (task)) { -put_task_struct (task); -return NULL ; - } - next_task =next_thread (task);put_task_struct (task); -if (!next_task) -return NULL ; saved_tid = *tid; *tid =__task_pid_nr_ns (next_task,PIDTYPE_PID , common->ns);
PATCH 2/6 bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct
In reply to Oleg Nesterovget_pid_task() makes no sense, the code does put_task_struct() soon after. Use find_task_by_pid_ns() instead of find_pid_ns + get_pid_task and kill put_task_struct(), this allows to do get_task_struct() only once before return.
While at it, kill the unnecessary "if (!pid)" check in the "if (!*tid)" block, this matches the next usage of find_pid_ns() + get_pid_task() in this function.
--- kernel/bpf/task_iter.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
kernel/bpf/task_iter.c +2 -10
@@ -42,9 +42,6 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commif (!*tid) {/* The first time, the iterator calls this function. */ pid =find_pid_ns (common->pid, common->ns); -if (!pid) -return NULL ; - task =get_pid_task (pid,PIDTYPE_TGID );if (!task)return NULL ;
@@ -66,17 +63,12 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn task; } - pid =find_pid_ns (common->pid_visiting, common->ns); -if (!pid) -return NULL ; - - task =get_pid_task (pid,PIDTYPE_PID ); + task =find_task_by_pid_ns (common->pid_visiting, common->ns);if (!task)return NULL ; retry: next_task =next_thread (task); -put_task_struct (task); saved_tid = *tid; *tid =__task_pid_nr_ns (next_task,PIDTYPE_PID , common->ns);
@@ -88,7 +80,6 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn NULL ; } -get_task_struct (next_task); common->pid_visiting = *tid;if (skip_if_dup_files && task->files == task->group_leader->files) {
@@ -96,6 +87,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm goto retry; } +get_task_struct (next_task);return next_task; }
Signature · 1 line
2.25.1.362.g51ebf55
PATCH 3/6 bpf: task_group_seq_get_next: fix the skip_if_dup_files check
In reply to Oleg NesterovUnless I am notally confused it is wrong. We are going to return or skip next_task so we need to check next_task-files, not task->files.
--- kernel/bpf/task_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/bpf/task_iter.c +1 -1
@@ -82,7 +82,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm common->pid_visiting = *tid; -if (skip_if_dup_files && task->files == task->group_leader->files) { +if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { task = next_task; goto retry; }
Signature · 1 line
2.25.1.362.g51ebf55
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Forgot to mention in the changelog...
In any case this doesn't look right. ->group_leader can exit before other threads, call exit_files(), and in this case task_group_seq_get_next() will check task->files == NULL.
Quoted 24 lines · Oleg Nesterov
Unless I am notally confused it is wrong. We are going to return or skip
next_taskso we need to check next_task-files, nottask->files.Signed-off-by Oleg Nesterov <[email protected]>--- kernel/bpf/task_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/bpf/task_iter.c +1
-2@@ -82,7 +82,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm common->pid_visiting = *tid; -if (skip_if_dup_files && task->files == task->group_leader->files) { +if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { task = next_task; goto retry; } --2.25.1.362.g51ebf55
Yonghong Song
maintainerRe: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 5 lines · Oleg Nesterov
Forgot to mention in the changelog...
In any case this doesn't look right. ->group_leader can exit before other threads, call
exit_files(), and in this casetask_group_seq_get_next()will checktask->files== NULL.
It is okay. This won't be affecting correctness. We will end with calling bpf program for 'next_task'.
Quoted 28 lines · Oleg Nesterov
Quoted 24 lines
Unless I am notally confused it is wrong. We are going to return or skip
next_taskso we need to check next_task-files, nottask->files.Signed-off-by Oleg Nesterov <[email protected]>--- kernel/bpf/task_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/bpf/task_iter.c +1
-2@@ -82,7 +82,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm common->pid_visiting = *tid; -if (skip_if_dup_files && task->files == task->group_leader->files) { +if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { task = next_task; goto retry; } --2.25.1.362.g51ebf55
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 10 lines · Yonghong Song
Quoted 5 lines · Oleg Nesterov
Forgot to mention in the changelog...
In any case this doesn't look right. ->group_leader can exit before other threads, call
exit_files(), and in this casetask_group_seq_get_next()will checktask->files== NULL.It is okay. This won't be affecting correctness. We will end with calling bpf program for '
next_task'.
Well, I didn't mean it is necessarily wrong, I simply do not know.
But let's suppose that we have a thread group with the main thread M + 1000 sub-threads. In the likely case they all have the same ->files, CLONE_THREAD without CLONE_FILES is not that common.
Let's assume the BPF_TASK_ITER_TGID case for simplicity.
Now lets look at task_file_seq_get_next() which passes skip_if_dup_files == 1 to task_seq_get_next() and thus to task_group_seq_get_next().
Now, in this case task_seq_get_next() will return non-NULL only once (OK, unless task_file_seq_ops.stop() was called), it will return the group leader M first, then after task_file_seq_get_next() "reports" all the fd's of M and increments info->tid, the next task_seq_get_next(&info->tid, true) should return NULL because of the skip_if_dup_files check in task_group_seq_get_next().
Right?
But. if the group leader M exits then M->files == NULL. And in this case task_seq_get_next() will need to "inspect" all the sub-threads even if they all have the same ->files pointer.
No?
Again, I am not saying this is a bug and quite possibly I misread this code, but in any case the skip_if_dup_files logic looks sub-optimal and confusing to me.
Nevermind, please forget. This is minor even if I am right.
Thanks for rewiev!
Oleg.
Yonghong Song
maintainerRe: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 29 lines · Oleg Nesterov
Quoted 10 lines · Yonghong Song
Quoted 5 lines · Oleg Nesterov
Forgot to mention in the changelog...
In any case this doesn't look right. ->group_leader can exit before other threads, call
exit_files(), and in this casetask_group_seq_get_next()will checktask->files== NULL.It is okay. This won't be affecting correctness. We will end with calling bpf program for '
next_task'.Well, I didn't mean it is necessarily wrong, I simply do not know.
But let's suppose that we have a thread group with the main thread M + 1000 sub-threads. In the likely case they all have the same ->files,
CLONE_THREADwithoutCLONE_FILESis not that common.Let's assume the
BPF_TASK_ITER_TGIDcase for simplicity.Now lets look at
task_file_seq_get_next()which passesskip_if_dup_files== 1 totask_seq_get_next()and thus totask_group_seq_get_next().Now, in this case
task_seq_get_next()will return non-NULL only once (OK, unlesstask_file_seq_ops.stop()was called), it will return the group leader M first, then aftertask_file_seq_get_next()"reports" all the fd's of M and incrementsinfo->tid, the nexttask_seq_get_next(&info->tid, true)should return NULL because of theskip_if_dup_filescheck intask_group_seq_get_next().
Quoted 5 lines
Right?
But. if the group leader M exits then
M->files== NULL. And in this casetask_seq_get_next()will need to "inspect" all the sub-threads even if they all have the same ->files pointer.
That is correct. I do not have practical experience on how much possibility this scenario may happen. I assume it should be very low. If this is not the case, we might need to revisit.
Quoted 12 lines
No?
Again, I am not saying this is a bug and quite possibly I misread this code, but in any case the
skip_if_dup_fileslogic looks sub-optimal and confusing to me.Nevermind, please forget. This is minor even if I am right.
Thanks for rewiev!
Oleg.
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 9 lines · Yonghong Song
Quoted 4 lines · Oleg Nesterov
But. if the group leader M exits then
M->files== NULL. And in this casetask_seq_get_next()will need to "inspect" all the sub-threads even if they all have the same ->files pointer.That is correct. I do not have practical experience on how much possibility this scenario may happen. I assume it should be very low.
Yes. I just tried to explain why the ->files check looks confusing to me. Nevermind.
Could you review 6/6 as well?
Should I fold 1-5 into a single patch? I tried to document every change and simplify the review, but I do not want to blow the git history.
Oleg.
Yonghong Song
maintainerRe: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 8 lines · Oleg Nesterov
Quoted 7 lines · Yonghong Song
Quoted 4 lines · Oleg Nesterov
But. if the group leader M exits then
M->files== NULL. And in this casetask_seq_get_next()will need to "inspect" all the sub-threads even if they all have the same ->files pointer.
Quoted 7 lines
Quoted 2 lines
That is correct. I do not have practical experience on how much possibility this scenario may happen. I assume it should be very low.
Yes. I just tried to explain why the ->files check looks confusing to me. Nevermind.
Could you review 6/6 as well?
I think we can wait patch 6/6 after
https://lore.kernel.org/all/[email protected]/
is merged.
Quoted 3 lines
Should I fold 1-5 into a single patch? I tried to document every change and simplify the review, but I do not want to blow the git history.
Currently, because patch 6, the whole patch set cannot be tested by bpf CI since it has a build failure:
https://github.com/kernel-patches/bpf/pull/5580
I suggest you get patch 1-5 and resubmit with tag like
"bpf-next v2"
[Patch bpf-next v2 x/5] ...
so CI can build with different architectures and compilers to ensure everything builds and runs fine.
Quoted 3 lines
Oleg.
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 8 lines · Yonghong Song
Quoted 2 lines · Oleg Nesterov
Could you review 6/6 as well?
I think we can wait patch 6/6 after
https://lore.kernel.org/all/[email protected]/
is merged.
OK.
Quoted 6 lines
Quoted 2 lines
Should I fold 1-5 into a single patch? I tried to document every change and simplify the review, but I do not want to blow the git history.
Currently, because patch 6, the whole patch set cannot be tested by bpf CI since it has a build failure:
https://github.com/kernel-patches/bpf/pull/5580
Heh. I thought this is obvious. I thought you can test 1-5 without 6/6 and _review_ 6/6.
I simply can't understand how can this pull/5580 come when I specially mentioned
> 6/6 obviously depends on > > [PATCH 1/2] introduce __next_thread(), fix next_tid() vs exec() race > https://lore.kernel.org/all/[email protected]/ > > which was not merged yet.
in 0/6.
Quoted 5 lines
I suggest you get patch 1-5 and resubmit with tag like
"bpf-next v2"
[Patch bpf-next v2 x/5] ...
so CI can build with different architectures and compilers to ensure everything builds and runs fine.
I think we can wait for
https://lore.kernel.org/all/[email protected]/
as you suggest above, then I'll send the s/next_thread/__next_thread/ oneliner without 1-5. I no longer think it makes sense to try to cleanup the poor task_group_seq_get_next() when IMHO the whole task_iter logic needs the complete rewrite. Yes, yes, I know, it is very easy to blame someone else's code, sorry can't resist ;)
The only "fix" in this series is 3/6, but this code has more serious bugs, so I guess we can forget it.
Oleg.
Yonghong Song
maintainerRe: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 25 lines · Oleg Nesterov
Quoted 8 lines · Yonghong Song
Quoted 2 lines · Oleg Nesterov
Could you review 6/6 as well?
I think we can wait patch 6/6 after
https://lore.kernel.org/all/[email protected]/is merged.
OK.
Quoted 6 lines
Quoted 2 lines
Should I fold 1-5 into a single patch? I tried to document every change and simplify the review, but I do not want to blow the git history.
Currently, because patch 6, the whole patch set cannot be tested by bpf CI since it has a build failure:
https://github.com/kernel-patches/bpf/pull/5580Heh. I thought this is obvious. I thought you can test 1-5 without 6/6 and _review_ 6/6.
I simply can't understand how can this pull/5580 come when I specially mentioned
Quoted 8 lines
> 6/6 obviously depends on > > [PATCH 1/2] introduce __next_thread(), fix next_tid() vs exec() race > https://lore.kernel.org/all/[email protected]/ > > which was not merged yet.in 0/6.
The process in CI for testing is fully automated, and it does not look at commit message. That is why it takes the whole series. This is true for all other patch set.
Quoted 22 lines
Quoted 6 lines
I suggest you get patch 1-5 and resubmit with tag like
"bpf-next v2"
[Patch bpf-next v2 x/5] ...
so CI can build with different architectures and compilers to ensure everything builds and runs fine.I think we can wait for
https://lore.kernel.org/all/[email protected]/as you suggest above, then I'll send the s/next_thread/__next_thread/ oneliner without 1-5. I no longer think it makes sense to try to cleanup the poor
task_group_seq_get_next()when IMHO the wholetask_iterlogic needs the complete rewrite. Yes, yes, I know, it is very easy to blame someone else's code, sorry can't resist ;)The only "fix" in this series is 3/6, but this code has more serious bugs, so I guess we can forget it.
Oleg.
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Quoted 13 lines · Yonghong Song
Quoted 11 lines · Oleg Nesterov
I simply can't understand how can this pull/5580 come when I specially mentioned
> 6/6 obviously depends on > > [PATCH 1/2] introduce __next_thread(), fix next_tid() vs exec() race > https://lore.kernel.org/all/[email protected]/ > > which was not merged yet.
Quoted 3 lines
Quoted 1 line
in 0/6.
The process in CI for testing is fully automated,
Ah, OK, sorry then.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
I suggest you get patch 1-5 and resubmit with tag like
"bpf-next v2"
[Patch bpf-next v2 x/5] ...
so CI can build with different architectures and compilers to ensure everything builds and runs fine.
OK, will do when I have time.
Thanks,
Oleg.
Re: [PATCH 3/6] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
In reply to Oleg NesterovQuoted 2 lines · Oleg Nesterov
Unless I am notally confused it is wrong. We are going to return or skip
next_taskso we need to check next_task-files, nottask->files.
Thanks for capturing this. This is indeed an oversight.
Quoted 19 lines
Signed-off-by Oleg Nesterov <[email protected]>--- kernel/bpf/task_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/bpf/task_iter.c +1
-1@@ -82,7 +82,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm common->pid_visiting = *tid; -if (skip_if_dup_files && task->files == task->group_leader->files) { +if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { task = next_task; goto retry; }
PATCH 4/6 bpf: task_group_seq_get_next: kill next_task
In reply to Oleg NesterovIt only adds the unnecessary confusion and compicates the "retry" code.
--- kernel/bpf/task_iter.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
kernel/bpf/task_iter.c +6 -8
@@ -35,7 +35,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm u32 *tid, bool skip_if_dup_files) { -struct task_struct *task, *next_task; +struct task_struct *task;struct pid *pid;u32 saved_tid;
@@ -68,10 +68,10 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn NULL ; retry: - next_task =next_thread (task); + task =next_thread (task); saved_tid = *tid; - *tid =__task_pid_nr_ns (next_task,PIDTYPE_PID , common->ns); + *tid =__task_pid_nr_ns (task,PIDTYPE_PID , common->ns);if (!*tid || *tid == common->pid) {/* Run out of tasks of a process. The tasks of a * thread_group are linked as circular linked list.
@@ -82,13 +82,11 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm common->pid_visiting = *tid; -if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { - task = next_task; +if (skip_if_dup_files && task->files == task->group_leader->files) goto retry; - } -get_task_struct (next_task); -return next_task; +get_task_struct (task); +return task; } static struct task_struct *task_seq_get_next(struct bpf_iter_seq_task_common *common,
Signature · 1 line
2.25.1.362.g51ebf55
Re: [PATCH 4/6] bpf: task_group_seq_get_next: kill next_task
Quoted 3 lines · Oleg Nesterov
It only adds the unnecessary confusion and compicates the "retry" code.
Signed-off-by Oleg Nesterov <[email protected]>
PATCH 5/6 bpf: task_group_seq_get_next: simplify the "next tid" logic
In reply to Oleg NesterovKill saved_tid. It looks ugly to update *tid and then restore the previous value if __task_pid_nr_ns() returns 0. Change this code to update *tid and common->pid_visiting once before return.
--- kernel/bpf/task_iter.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
kernel/bpf/task_iter.c +4 -7
@@ -37,7 +37,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm {struct task_struct *task;struct pid *pid; -u32 saved_tid; +u32 next_tid;if (!*tid) {/* The first time, the iterator calls this function. */
@@ -70,21 +70,18 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm retry: task =next_thread (task); - saved_tid = *tid; - *tid =__task_pid_nr_ns (task,PIDTYPE_PID , common->ns); -if (!*tid || *tid == common->pid) { + next_tid =__task_pid_nr_ns (task,PIDTYPE_PID , common->ns); +if (!next_tid || next_tid == common->pid) {/* Run out of tasks of a process. The tasks of a * thread_group are linked as circular linked list. */ - *tid = saved_tid;return NULL ; } - common->pid_visiting = *tid; -if (skip_if_dup_files && task->files == task->group_leader->files) goto retry; + *tid = common->pid_visiting = next_tid;get_task_struct (task);return task; }
Signature · 1 line
2.25.1.362.g51ebf55
Re: [PATCH 5/6] bpf: task_group_seq_get_next: simplify the "next tid" logic
Quoted 5 lines · Oleg Nesterov
Kill
saved_tid. It looks ugly to update *tid and then restore the previous value if__task_pid_nr_ns()returns 0. Change this code to update *tid andcommon->pid_visitingonce before return.Signed-off-by Oleg Nesterov <[email protected]>
PATCH 6/6 bpf: task_group_seq_get_next: use __next_thread() rather than next_thread()
In reply to Oleg NesterovLockless use of next_thread() should be avoided, task_group_seq_get_next() is the last user, it too can return the group leader twice if it races with mt-thread exec which changes the group->leader's pid.
Change the main loop to use __next_thread(), kill "next_tid == common->pid" check.
__next_thread() can't loop forever, so we can also change this code to retry if next_tid == 0.
--- kernel/bpf/task_iter.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
kernel/bpf/task_iter.c +5 -7
@@ -68,15 +68,13 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_commreturn NULL ; retry: - task =next_thread (task); + task =__next_thread (task); +if (!task) +return NULL ; next_tid =__task_pid_nr_ns (task,PIDTYPE_PID , common->ns); -if (!next_tid || next_tid == common->pid) { -/* Run out of tasks of a process. The tasks of a -* thread_group are linked as circular linked list. -*/ -return NULL ; - } +if (!next_tid) + goto retry;if (skip_if_dup_files && task->files == task->group_leader->files) goto retry;
Signature · 1 line
2.25.1.362.g51ebf55