Skip to contentSkip to conversation

drivers: extcon: space required after that ','

PATCH In review [email protected] 3 participants 3 messages Jul 17, 2023 – Jul 23, 2023 1 message not in the archive External connector subsystem (extcon)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drivers: extcon: space required after that ','

This patch fixes the checkpatch.pl error:

./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)

---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -1
index 6f7a60d..4ef4422 100644
@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
 }
 
 static int is_extcon_property_capability(struct extcon_dev *edev,
-                unsigned int id, int index,unsigned int prop)
+                unsigned int id, int index, unsigned int prop)
 {
     struct extcon_cable *cable;
     int type, ret;
maintainer Acked-by on v1 1/1
#2 lore raw
Quoted 6 lines

This patch fixes the checkpatch.pl error:

./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)

@Chanwoo, it looks like that's from a 7 years old commit of yours :).

Quoted 18 lines
---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -1
index 6f7a60d..4ef4422 100644
@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned 
 int id, unsigned int prop)
 }
 
 static int is_extcon_property_capability(struct extcon_dev *edev,
-                unsigned int id, int index,unsigned int prop)
+                unsigned int id, int index, unsigned int prop)
 {
     struct extcon_cable *cable;
     int type, ret;
#3 lore raw
In reply to [email protected]

Hi,

Quoted 5 lines · On 23. 7. 17. 18:03, [email protected] wrote:

This patch fixes the checkpatch.pl error:

./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)

'maqimei' is your name?

I recommend that you can check the guide of 'submitting-patches'[1].
[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Please update your name.

Quoted 17 lines

---
 drivers/extcon/extcon.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -1
index 6f7a60d..4ef4422 100644
@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
  }
 
  static int is_extcon_property_capability(struct extcon_dev *edev,
-                unsigned int id, int index,unsigned int prop)
+                unsigned int id, int index, unsigned int prop)
  {
      struct extcon_cable *cable;
      int type, ret;
Signature · 3 lines
Best Regards,
Samsung Electronics
Chanwoo Choi